René's URL Explorer Experiment


Title: crypto: remove default encoding from pbkdf2 by tniessen · Pull Request #47869 · nodejs/node · GitHub

Open Graph Title: crypto: remove default encoding from pbkdf2 by tniessen · Pull Request #47869 · nodejs/node

X Title: crypto: remove default encoding from pbkdf2 by tniessen · Pull Request #47869 · nodejs/node

Description: This partially addresses: node/lib/internal/crypto/util.js Lines 77 to 80 in af9b48a // TODO(tniessen): ...

Open Graph Description: This partially addresses: node/lib/internal/crypto/util.js Lines 77 to 80 in af9b48a // TODO(tniessen): ...

X Description: This partially addresses: node/lib/internal/crypto/util.js Lines 77 to 80 in af9b48a // TODO(tniessen): ...

Opengraph URL: https://github.com/nodejs/node/pull/47869

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0cfd38dc-4b0a-c744-774a-9f85c1a93eee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA168:281585:C42CAB:1129A3C:696A367E
html-safe-nonce5111c26cbf200dfa83ae0bfda37a4821b0f1883a4b343a8415fe4aedaa068548
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTY4OjI4MTU4NTpDNDJDQUI6MTEyOUEzQzo2OTZBMzY3RSIsInZpc2l0b3JfaWQiOiIzMDE1NzQ2OTkyNzE4MTAwMDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac30f1e4b4dffc445db48443dcff135f058a1a14046f788a6d3cc2aa288e6c2bd4
hovercard-subject-tagpull_request:1339208785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47869/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/924a7ed29c24a179db0dbeb8c1ac1c3f63064e2efff191244b375117c036bee8/nodejs/node/pull/47869
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/924a7ed29c24a179db0dbeb8c1ac1c3f63064e2efff191244b375117c036bee8/nodejs/node/pull/47869
og:image:altThis partially addresses: node/lib/internal/crypto/util.js Lines 77 to 80 in af9b48a // TODO(tniessen): ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47869#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47869
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47869
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47869
Reloadhttps://github.com/nodejs/node/pull/47869
Reloadhttps://github.com/nodejs/node/pull/47869
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47869
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47869
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47869#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-pbkdf2-default-encodinghttps://github.com/tniessen/node/tree/crypto-pbkdf2-default-encoding
crypto: remove default encoding from pbkdf2 https://github.com/nodejs/node/pull/47869#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-pbkdf2-default-encodinghttps://github.com/tniessen/node/tree/crypto-pbkdf2-default-encoding
Conversation 5 https://github.com/nodejs/node/pull/47869
Commits 1 https://github.com/nodejs/node/pull/47869/commits
Checks 0 https://github.com/nodejs/node/pull/47869/checks
Files changed https://github.com/nodejs/node/pull/47869/files
Please reload this pagehttps://github.com/nodejs/node/pull/47869
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 5, 2023https://github.com/nodejs/node/pull/47869#issue-1696857114
node/lib/internal/crypto/util.jshttps://github.com/nodejs/node/blob/af9b48a2f17b11b66a8b81beeaba3c408b863795/lib/internal/crypto/util.js#L77-L80
af9b48ahttps://github.com/nodejs/node/commit/af9b48a2f17b11b66a8b81beeaba3c408b863795
#47182https://github.com/nodejs/node/pull/47182
Please reload this pagehttps://github.com/nodejs/node/pull/47869
https://github.com/tniessen
crypto: remove default encoding from pbkdf2https://github.com/nodejs/node/pull/47869/commits/948f94de68479deada6f17511aa7f5c1e70deb6b
948f94dhttps://github.com/nodejs/node/pull/47869/commits/948f94de68479deada6f17511aa7f5c1e70deb6b
nodejs#47182https://github.com/nodejs/node/pull/47182
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2023https://github.com/nodejs/node/pull/47869#issuecomment-1535557316
Please reload this pagehttps://github.com/nodejs/node/pull/47869
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 5, 2023https://github.com/nodejs/node/pull/47869#event-9172634006
https://github.com/tniessen
tniessenhttps://github.com/tniessen
dont-land-on-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v16.x
May 5, 2023https://github.com/nodejs/node/pull/47869#event-9172693089
https://github.com/panva
panvahttps://github.com/panva
May 5, 2023 https://github.com/nodejs/node/pull/47869#pullrequestreview-1414228435
View reviewed changes https://github.com/nodejs/node/pull/47869/files/948f94de68479deada6f17511aa7f5c1e70deb6b
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2023https://github.com/nodejs/node/pull/47869#event-9173774106
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2023https://github.com/nodejs/node/pull/47869#event-9173814589
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47869
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47869
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2023https://github.com/nodejs/node/pull/47869#issuecomment-1536449073
https://ci.nodejs.org/job/node-test-pull-request/51666/https://ci.nodejs.org/job/node-test-pull-request/51666/
Please reload this pagehttps://github.com/nodejs/node/pull/47869
https://github.com/lpinca
lpincahttps://github.com/lpinca
May 5, 2023 https://github.com/nodejs/node/pull/47869#pullrequestreview-1415143178
View reviewed changes https://github.com/nodejs/node/pull/47869/files/948f94de68479deada6f17511aa7f5c1e70deb6b
https://github.com/tniessen
tniessenhttps://github.com/tniessen
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 5, 2023https://github.com/nodejs/node/pull/47869#event-9179164803
CI Reliability 2023-05-06 nodejs/reliability#557 https://github.com/nodejs/reliability/issues/557
CI Reliability 2023-05-07 nodejs/reliability#558 https://github.com/nodejs/reliability/issues/558
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 7, 2023https://github.com/nodejs/node/pull/47869#event-9183424645
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
6fb10cahttps://github.com/nodejs/node/commit/6fb10cad308ad7e0d9a8a78f91d41165eb830065
May 7, 2023https://github.com/nodejs/node/pull/47869#event-9183424698
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 7, 2023https://github.com/nodejs/node/pull/47869#issuecomment-1537255868
6fb10cahttps://github.com/nodejs/node/commit/6fb10cad308ad7e0d9a8a78f91d41165eb830065
Please reload this pagehttps://github.com/nodejs/node/pull/47869
CI Reliability 2023-05-08 nodejs/reliability#559 https://github.com/nodejs/reliability/issues/559
CI Reliability 2023-05-09 nodejs/reliability#560 https://github.com/nodejs/reliability/issues/560
CI Reliability 2023-05-10 nodejs/reliability#561 https://github.com/nodejs/reliability/issues/561
targoshttps://github.com/targos
May 12, 2023 https://github.com/nodejs/node/pull/47869#ref-commit-e9c6ee7
https://github.com/tniessen
https://github.com/targos
crypto: remove default encoding from pbkdf2https://github.com/nodejs/node/commit/e9c6ee74f3b23a03e302df5177dc8ee7025f0a24
e9c6ee7https://github.com/nodejs/node/commit/e9c6ee74f3b23a03e302df5177dc8ee7025f0a24
#47182https://github.com/nodejs/node/pull/47182
#47869https://github.com/nodejs/node/pull/47869
https://github.com/targos
targoshttps://github.com/targos
May 15, 2023 https://github.com/nodejs/node/pull/47869#ref-pullrequest-1710289834
v20.2.0 release proposal #48020 https://github.com/nodejs/node/pull/48020
tniessenhttps://github.com/tniessen
Aug 14, 2023 https://github.com/nodejs/node/pull/47869#ref-commit-d66373c
https://github.com/tniessen
crypto: remove getDefaultEncoding()https://github.com/tniessen/node/commit/d66373ce0e825be0fe31aa91d247622d06c36baa
d66373chttps://github.com/tniessen/node/commit/d66373ce0e825be0fe31aa91d247622d06c36baa
nodejs#47182https://github.com/nodejs/node/pull/47182
nodejs#47869https://github.com/nodejs/node/pull/47869
nodejs#47943https://github.com/nodejs/node/pull/47943
nodejs#47998https://github.com/nodejs/node/pull/47998
nodejs#49140https://github.com/nodejs/node/pull/49140
nodejs#49145https://github.com/nodejs/node/pull/49145
nodejs#49167https://github.com/nodejs/node/pull/49167
nodejs#49169https://github.com/nodejs/node/pull/49169
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Aug 14, 2023 https://github.com/nodejs/node/pull/47869#ref-pullrequest-1850030440
crypto: remove getDefaultEncoding() #49170 https://github.com/nodejs/node/pull/49170
tniessenhttps://github.com/tniessen
Aug 16, 2023 https://github.com/nodejs/node/pull/47869#ref-commit-d4a91a8
https://github.com/tniessen
crypto: remove getDefaultEncoding()https://github.com/tniessen/node/commit/d4a91a8fcc67b8edaf3d3e17acdcddaad66f54cd
d4a91a8https://github.com/tniessen/node/commit/d4a91a8fcc67b8edaf3d3e17acdcddaad66f54cd
nodejs#47182https://github.com/nodejs/node/pull/47182
nodejs#47869https://github.com/nodejs/node/pull/47869
nodejs#47943https://github.com/nodejs/node/pull/47943
nodejs#47998https://github.com/nodejs/node/pull/47998
nodejs#49140https://github.com/nodejs/node/pull/49140
nodejs#49145https://github.com/nodejs/node/pull/49145
nodejs#49167https://github.com/nodejs/node/pull/49167
nodejs#49169https://github.com/nodejs/node/pull/49169
debadree25https://github.com/debadree25
Aug 19, 2023 https://github.com/nodejs/node/pull/47869#ref-commit-78842cf
https://github.com/tniessen
https://github.com/debadree25
crypto: remove getDefaultEncoding()https://github.com/nodejs/node/commit/78842cf213aea95a64119b18b036d0255507438c
78842cfhttps://github.com/nodejs/node/commit/78842cf213aea95a64119b18b036d0255507438c
#47182https://github.com/nodejs/node/pull/47182
#47869https://github.com/nodejs/node/pull/47869
#47943https://github.com/nodejs/node/pull/47943
#47998https://github.com/nodejs/node/pull/47998
#49140https://github.com/nodejs/node/pull/49140
#49145https://github.com/nodejs/node/pull/49145
#49167https://github.com/nodejs/node/pull/49167
#49169https://github.com/nodejs/node/pull/49169
#49170https://github.com/nodejs/node/pull/49170
UlisesGasconhttps://github.com/UlisesGascon
Sep 10, 2023 https://github.com/nodejs/node/pull/47869#ref-commit-7eb10a3
https://github.com/tniessen
https://github.com/UlisesGascon
crypto: remove getDefaultEncoding()https://github.com/nodejs/node/commit/7eb10a38ea3d8c0f132ab0817fa184a76961559f
7eb10a3https://github.com/nodejs/node/commit/7eb10a38ea3d8c0f132ab0817fa184a76961559f
#47182https://github.com/nodejs/node/pull/47182
#47869https://github.com/nodejs/node/pull/47869
#47943https://github.com/nodejs/node/pull/47943
#47998https://github.com/nodejs/node/pull/47998
#49140https://github.com/nodejs/node/pull/49140
#49145https://github.com/nodejs/node/pull/49145
#49167https://github.com/nodejs/node/pull/49167
#49169https://github.com/nodejs/node/pull/49169
#49170https://github.com/nodejs/node/pull/49170
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47869
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/47869/files/948f94de68479deada6f17511aa7f5c1e70deb6b
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/47869/files/948f94de68479deada6f17511aa7f5c1e70deb6b
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/47869
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.