| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:3e59b913-9136-4fdd-2bc5-78909ff64d20 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DBEE:2C9A2F:6A93F3:8F9951:6969CCD2 |
| html-safe-nonce | b2da70f76f40ed7de79ad7dc436aba13a7839959925ba0c16b67ea4fe7134d57 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkVFOjJDOUEyRjo2QTkzRjM6OEY5OTUxOjY5NjlDQ0QyIiwidmlzaXRvcl9pZCI6IjU5MDg5NTgwOTg1NjEyODk0MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 37b4f292946ad9890761feea7570a40e13c5b5202da0af56ee9e03bdd78900c5 |
| hovercard-subject-tag | pull_request:1321263681 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/47637 |
| twitter:image | https://opengraph.githubassets.com/12d738e09dd252cd20ae992c557ac1a49fd469a8a7775a9a4f0df72451802a61/nodejs/node/pull/47637 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12d738e09dd252cd20ae992c557ac1a49fd469a8a7775a9a4f0df72451802a61/nodejs/node/pull/47637 |
| og:image:alt | As per discussion in nodejs/TSC#1353, this PR adds GN build files into Node's repo.
I have provided 2 ways to test the build:
Build with a standalone version of GN.
Build with depot_tools from... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zcbenz |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/47637#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47637 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47637 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/47637 |
| Reload | https://github.com/nodejs/node/pull/47637 |
| Reload | https://github.com/nodejs/node/pull/47637 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/47637#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| zcbenz:patch-gn | https://github.com/zcbenz/node/tree/patch-gn |
|
build: add GN build files
| https://github.com/nodejs/node/pull/47637#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| zcbenz:patch-gn | https://github.com/zcbenz/node/tree/patch-gn |
|
Conversation
40
| https://github.com/nodejs/node/pull/47637 |
|
Commits
1
| https://github.com/nodejs/node/pull/47637/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/47637/checks |
|
Files changed
| https://github.com/nodejs/node/pull/47637/files |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issue-1676447802 |
| nodejs/TSC#1353 | https://github.com/nodejs/TSC/issues/1353 |
| standalone version of GN | https://github.com/photoionization/node_with_gn/tree/gn-in-node |
| depot_tools from Chromium | https://github.com/photoionization/node-ci |
| https://github.com/photoionization/node-ci | https://github.com/photoionization/node-ci |
| https://chromium.googlesource.com/v8/node-ci/ | https://chromium.googlesource.com/v8/node-ci/ |
| https://github.com/photoionization/node_with_gn | https://github.com/photoionization/node_with_gn |
| @codebytere | https://github.com/codebytere |
| @victorgomes | https://github.com/victorgomes |
| @joyeecheung | https://github.com/joyeecheung |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1516089775 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#event-9055763711 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1393707753 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47637/files |
| tools/search_files.py | https://github.com/nodejs/node/pull/47637/files#diff-d4c4670a71620f842f7eb16a2f7bf331c9ee3f6a267a502571674c91945b2d95 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1393756293 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47637/files |
| deps/ada/BUILD.gn | https://github.com/nodejs/node/pull/47637/files#diff-48d4c9a835446f596abfc4bc0cfafdc475ff34daa3fb1caa5e5f037b225b4661 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1516185495 |
| https://github.com/nodejs/node/blob/main/.gitpod.yml | https://github.com/nodejs/node/blob/main/.gitpod.yml |
| source.chromium.org/chromium/chromium/src/+/main:build/config/sanitizers/sanitizers.gni | https://source.chromium.org/chromium/chromium/src/+/main:build/config/sanitizers/sanitizers.gni |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1516228314 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1516230429 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1516237454 |
| https://github.com/nodejs/node/blob/main/.gitpod.yml | https://github.com/nodejs/node/blob/main/.gitpod.yml |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1516252364 |
| github action file | https://github.com/photoionization/node-ci/blob/main/.github/workflows/main.yml |
| https://github.com/photoionization/node-ci | https://github.com/photoionization/node-ci |
| https://chromium.googlesource.com/v8/node-ci/ | https://chromium.googlesource.com/v8/node-ci/ |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1394646835 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47637/files |
| BUILD.gn | https://github.com/nodejs/node/pull/47637/files#diff-d7acea6210a7cc323c71038bc347fc751c62b8f13566c9dcdbc212328c8efa44 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Apr 24, 2023 | https://github.com/nodejs/node/pull/47637#event-9077790686 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/ff7e8495b1c336c3c23a9cfc9ed64b4057d93717..b0a0174c364f6182a20ad50635fcadb49bf61eb4 |
| ff7e849 | https://github.com/nodejs/node/commit/ff7e8495b1c336c3c23a9cfc9ed64b4057d93717 |
| b0a0174 | https://github.com/nodejs/node/commit/b0a0174c364f6182a20ad50635fcadb49bf61eb4 |
|
Compare
| https://github.com/nodejs/node/compare/ff7e8495b1c336c3c23a9cfc9ed64b4057d93717..b0a0174c364f6182a20ad50635fcadb49bf61eb4 |
| April 26, 2023 10:56 | https://github.com/nodejs/node/pull/47637#event-9102142556 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 27, 2023
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1403943119 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47637/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1403943119 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| BUILD.gn | https://github.com/nodejs/node/pull/47637/files#diff-d7acea6210a7cc323c71038bc347fc751c62b8f13566c9dcdbc212328c8efa44 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| deps/ada/BUILD.gn | https://github.com/nodejs/node/pull/47637/files#diff-48d4c9a835446f596abfc4bc0cfafdc475ff34daa3fb1caa5e5f037b225b4661 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| unofficial.gni | https://github.com/nodejs/node/pull/47637/files#diff-e8cf5a456ebf7f553134f4de566885ea786ab0cc428ba6bd143a3b6fa4c4324f |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Apr 28, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1527077834 |
| main/.gitpod.yml | https://github.com/nodejs/node/blob/main/.gitpod.yml?rgh-link-date=2023-04-20T12%3A24%3A59Z |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/b0a0174c364f6182a20ad50635fcadb49bf61eb4..81d43b29a0380e7ca39d101dbbbc41d2abe7e96d |
| b0a0174 | https://github.com/nodejs/node/commit/b0a0174c364f6182a20ad50635fcadb49bf61eb4 |
| 81d43b2 | https://github.com/nodejs/node/commit/81d43b29a0380e7ca39d101dbbbc41d2abe7e96d |
|
Compare
| https://github.com/nodejs/node/compare/b0a0174c364f6182a20ad50635fcadb49bf61eb4..81d43b29a0380e7ca39d101dbbbc41d2abe7e96d |
| May 8, 2023 06:25 | https://github.com/nodejs/node/pull/47637#event-9186798762 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| May 8, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1537823189 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 8, 2023
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1568010069 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47637/files |
| unofficial.gni | https://github.com/nodejs/node/pull/47637/files#diff-e8cf5a456ebf7f553134f4de566885ea786ab0cc428ba6bd143a3b6fa4c4324f |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
|
tools: allow passing absolute path of config.gypi in js2c
#49162
| https://github.com/nodejs/node/pull/49162 |
|
gyp: put cctest filenames in variables
#49178
| https://github.com/nodejs/node/pull/49178 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/47637#pullrequestreview-1578951395 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47637/files |
| deps/ada/unofficial.gni | https://github.com/nodejs/node/pull/47637/files#diff-57ae6b7a8a5fc5350e13c2fab5e8e20fa85f53278ccf8fdfa4ce4dbb43b5880b |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Aug 21, 2023
| https://github.com/nodejs/node/pull/47637#ref-pullrequest-1858720096 |
|
chore: move node headers generation to electron
electron/electron#39589
| https://github.com/electron/electron/pull/39589 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/81d43b29a0380e7ca39d101dbbbc41d2abe7e96d..b587910f6c69e1a03b82eff6fb2e086f9e1a79a3 |
| 81d43b2 | https://github.com/nodejs/node/commit/81d43b29a0380e7ca39d101dbbbc41d2abe7e96d |
| b587910 | https://github.com/nodejs/node/commit/b587910f6c69e1a03b82eff6fb2e086f9e1a79a3 |
|
Compare
| https://github.com/nodejs/node/compare/81d43b29a0380e7ca39d101dbbbc41d2abe7e96d..b587910f6c69e1a03b82eff6fb2e086f9e1a79a3 |
| September 8, 2023 10:48 | https://github.com/nodejs/node/pull/47637#event-10316645092 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Sep 8, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1711469620 |
| #49178 | https://github.com/nodejs/node/pull/49178 |
| #49279 | https://github.com/nodejs/node/pull/49279 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/b587910f6c69e1a03b82eff6fb2e086f9e1a79a3..dc09591a2113f34808474d9d4b668c21a21a0973 |
| b587910 | https://github.com/nodejs/node/commit/b587910f6c69e1a03b82eff6fb2e086f9e1a79a3 |
| dc09591 | https://github.com/nodejs/node/commit/dc09591a2113f34808474d9d4b668c21a21a0973 |
|
Compare
| https://github.com/nodejs/node/compare/b587910f6c69e1a03b82eff6fb2e086f9e1a79a3..dc09591a2113f34808474d9d4b668c21a21a0973 |
| September 8, 2023 10:52 | https://github.com/nodejs/node/pull/47637#event-10316678401 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Sep 11, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1713455005 |
| #49279 | https://github.com/nodejs/node/pull/49279 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| force-pushed | https://github.com/nodejs/node/compare/dc09591a2113f34808474d9d4b668c21a21a0973..f4a37fe112f6bfbc124a07027b2be281ae61112a |
| dc09591 | https://github.com/nodejs/node/commit/dc09591a2113f34808474d9d4b668c21a21a0973 |
| f4a37fe | https://github.com/nodejs/node/commit/f4a37fe112f6bfbc124a07027b2be281ae61112a |
|
Compare
| https://github.com/nodejs/node/compare/dc09591a2113f34808474d9d4b668c21a21a0973..f4a37fe112f6bfbc124a07027b2be281ae61112a |
| September 11, 2023 09:08 | https://github.com/nodejs/node/pull/47637#event-10331349837 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Oct 2, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1743070132 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/47637#ref-commit-ec6ff88 |
|
| https://github.com/zcbenz |
|
| https://github.com/targos |
| build: add GN build files | https://github.com/nodejs/node/commit/ec6ff883f288f74e4e1428576860d193c46de340 |
| ec6ff88 | https://github.com/nodejs/node/commit/ec6ff883f288f74e4e1428576860d193c46de340 |
| #47637 | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| Nov 12, 2023 | https://github.com/nodejs/node/pull/47637#issuecomment-1806951510 |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| Chromium's license | https://source.chromium.org/chromium/chromium/src/+/main:LICENSE |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 12, 2023
| https://github.com/nodejs/node/pull/47637#ref-pullrequest-1989278421 |
|
v21.2.0 release proposal
#50681
| https://github.com/nodejs/node/pull/50681 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Nov 13, 2023
| https://github.com/nodejs/node/pull/47637#ref-pullrequest-1989963415 |
|
doc: the GN files should use Node's license
#50694
| https://github.com/nodejs/node/pull/50694 |
| targos | https://github.com/targos |
|
Nov 14, 2023
| https://github.com/nodejs/node/pull/47637#ref-commit-b9f3613 |
|
| https://github.com/zcbenz |
|
| https://github.com/targos |
| build: add GN build files | https://github.com/nodejs/node/commit/b9f3613908dcfef091f3895a8f184e032a56e08c |
| b9f3613 | https://github.com/nodejs/node/commit/b9f3613908dcfef091f3895a8f184e032a56e08c |
| #47637 | https://github.com/nodejs/node/pull/47637 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/47637#ref-issue-1991709228 |
|
Things blocking a full-featured GN build of upstream Node.js
photoionization/node_with_gn#1
| https://github.com/photoionization/node_with_gn/issues/1 |
| https://github.com/zcbenz |
| zcbenz | https://github.com/zcbenz |
| November 28, 2023 01:57 | https://github.com/nodejs/node/pull/47637#event-11077876955 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 11, 2023
| https://github.com/nodejs/node/pull/47637#ref-commit-8705058 |
|
| https://github.com/zcbenz |
|
| https://github.com/UlisesGascon |
| build: add GN build files | https://github.com/nodejs/node/commit/8705058b09a785eebfd73df1fc2c512c3db88fd5 |
| 8705058 | https://github.com/nodejs/node/commit/8705058b09a785eebfd73df1fc2c512c3db88fd5 |
| #47637 | https://github.com/nodejs/node/pull/47637 |
| https://github.com/UlisesGascon |
| UlisesGascon | https://github.com/UlisesGascon |
|
Dec 12, 2023
| https://github.com/nodejs/node/pull/47637#ref-pullrequest-2036750657 |
|
v20.11.0 proposal
#51124
| https://github.com/nodejs/node/pull/51124 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-12e06ae |
|
| https://github.com/codebytere |
| build: remove deps/ada BUILD.gn | https://github.com/electron/electron/commit/12e06aef9d46e4835e9e8e0d9a28ba5f790793fb |
| 12e06ae | https://github.com/electron/electron/commit/12e06aef9d46e4835e9e8e0d9a28ba5f790793fb |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-e476680 |
|
| https://github.com/codebytere |
| build: remove deps/base64 BUILD.gn | https://github.com/electron/electron/commit/e476680af0004c7d5a10ba2ac263e8f41ecb119e |
| e476680 | https://github.com/electron/electron/commit/e476680af0004c7d5a10ba2ac263e8f41ecb119e |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-3898639 |
|
| https://github.com/codebytere |
| build: remove deps/cares BUILD.gn | https://github.com/electron/electron/commit/3898639245a71b1c60b837dfb87cb7870a813209 |
| 3898639 | https://github.com/electron/electron/commit/3898639245a71b1c60b837dfb87cb7870a813209 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-fd49d95 |
|
| https://github.com/codebytere |
| build: remove deps/googletest BUILD.gn | https://github.com/electron/electron/commit/fd49d9583e00260f9a6d653d699e200b799fd0a0 |
| fd49d95 | https://github.com/electron/electron/commit/fd49d9583e00260f9a6d653d699e200b799fd0a0 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-1720174 |
|
| https://github.com/codebytere |
| build: remove deps/histogram BUILD.gn | https://github.com/electron/electron/commit/1720174d40f85791eb37b51066b1fa25aedd9159 |
| 1720174 | https://github.com/electron/electron/commit/1720174d40f85791eb37b51066b1fa25aedd9159 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-2476ce6 |
|
| https://github.com/codebytere |
| build: remove deps/nghttp2 BUILD.gn | https://github.com/electron/electron/commit/2476ce6a86b0719cffd49c8d3f494d4689d2b5c1 |
| 2476ce6 | https://github.com/electron/electron/commit/2476ce6a86b0719cffd49c8d3f494d4689d2b5c1 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-1a603e3 |
|
| https://github.com/codebytere |
| build: remove deps/simdutf BUILD.gn | https://github.com/electron/electron/commit/1a603e3bb5089383f7139cc36e95ebf649d33be3 |
| 1a603e3 | https://github.com/electron/electron/commit/1a603e3bb5089383f7139cc36e95ebf649d33be3 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-7bb9eb3 |
|
| https://github.com/codebytere |
| build: remove deps/uv BUILD.gn | https://github.com/electron/electron/commit/7bb9eb31ddded3f8390506c676d07804c4ceeb44 |
| 7bb9eb3 | https://github.com/electron/electron/commit/7bb9eb31ddded3f8390506c676d07804c4ceeb44 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-131d904 |
|
| https://github.com/codebytere |
| build: remove deps/uvwasi BUILD.gn | https://github.com/electron/electron/commit/131d904a013b7e1dd71a9647ffe73eb33551f1d9 |
| 131d904 | https://github.com/electron/electron/commit/131d904a013b7e1dd71a9647ffe73eb33551f1d9 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-942fb3c |
|
| https://github.com/codebytere |
| build: remove src/inspector BUILD.gn | https://github.com/electron/electron/commit/942fb3cfbed58c4bcbfc1983e35bd4e92d364ab8 |
| 942fb3c | https://github.com/electron/electron/commit/942fb3cfbed58c4bcbfc1983e35bd4e92d364ab8 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-20ae6ad |
|
| https://github.com/codebytere |
| build: remove node.gni | https://github.com/electron/electron/commit/20ae6ad56fde23bdee72c629b5b9772df21b94b1 |
| 20ae6ad | https://github.com/electron/electron/commit/20ae6ad56fde23bdee72c629b5b9772df21b94b1 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-235bac6 |
|
| https://github.com/codebytere |
| build: remove Node.js BUILD.gn | https://github.com/electron/electron/commit/235bac6627f308b14aaf1de3c83dce353e252624 |
| 235bac6 | https://github.com/electron/electron/commit/235bac6627f308b14aaf1de3c83dce353e252624 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Jan 10, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-0269b1d |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/0269b1dcb4c4960f47e89dad5b4071941118bbb4 |
| 0269b1d | https://github.com/electron/electron/commit/0269b1dcb4c4960f47e89dad5b4071941118bbb4 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 16, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-3b1902f |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/3b1902fbdc1f6b17ed3ead30e551e804fdb11c73 |
| 3b1902f | https://github.com/electron/electron/commit/3b1902fbdc1f6b17ed3ead30e551e804fdb11c73 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-156787e |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/156787e5b9d795656a35da36f4515b15718b8ea2 |
| 156787e | https://github.com/electron/electron/commit/156787e5b9d795656a35da36f4515b15718b8ea2 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 21, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-735e16d |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/735e16dc4af751c1851360ed28b12c2300c8c3bf |
| 735e16d | https://github.com/electron/electron/commit/735e16dc4af751c1851360ed28b12c2300c8c3bf |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 22, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-f7b7738 |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/f7b7738bd5bf71acf9e911934140511198fe79b8 |
| f7b7738 | https://github.com/electron/electron/commit/f7b7738bd5bf71acf9e911934140511198fe79b8 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 28, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-eddfe2d |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/eddfe2da73fd601bed2b26e677501b369b02e827 |
| eddfe2d | https://github.com/electron/electron/commit/eddfe2da73fd601bed2b26e677501b369b02e827 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 29, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-974943f |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/974943fb2500c6ad38b98c1fbffa42f2544982fe |
| 974943f | https://github.com/electron/electron/commit/974943fb2500c6ad38b98c1fbffa42f2544982fe |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| codebytere | https://github.com/codebytere |
|
Oct 31, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-3c8479d |
|
| https://github.com/codebytere |
| build: add GN build files | https://github.com/electron/electron/commit/3c8479d2655f1157df81b32cd3689d998b00f8ac |
| 3c8479d | https://github.com/electron/electron/commit/3c8479d2655f1157df81b32cd3689d998b00f8ac |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| jkleinsc | https://github.com/jkleinsc |
|
Nov 4, 2024
| https://github.com/nodejs/node/pull/47637#ref-commit-c63d0d6 |
|
| https://github.com/codebytere |
| chore: bump Node.js to v22.9.0 ( | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| #44281 | https://github.com/electron/electron/pull/44281 |
| ) | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| c63d0d6 | https://github.com/electron/electron/commit/c63d0d61e71f12d29efb1df885a0883ae76bb164 |
| nodejs/node#52856 | https://github.com/nodejs/node/pull/52856 |
| nodejs/node#50737 | https://github.com/nodejs/node/pull/50737 |
| nodejs/node#51344 | https://github.com/nodejs/node/pull/51344 |
| nodejs/node#50322 | https://github.com/nodejs/node/pull/50322 |
| nodejs-private/node-private#525 | https://github.com/nodejs-private/node-private/pull/525 |
| nodejs/node#54320 | https://github.com/nodejs/node/pull/54320 |
| nodejs/node#50234 | https://github.com/nodejs/node/pull/50234 |
| nodejs/node#54028 | https://github.com/nodejs/node/pull/54028 |
| nodejs/node#54775 | https://github.com/nodejs/node/pull/54775 |
| nodejs/node#47182 | https://github.com/nodejs/node/pull/47182 |
| nodejs/node#50650 | https://github.com/nodejs/node/pull/50650 |
| nodejs/node#53605 | https://github.com/nodejs/node/pull/53605 |
| nodejs/node#53822 | https://github.com/nodejs/node/pull/53822 |
| nodejs/node#49152 | https://github.com/nodejs/node/pull/49152 |
| nodejs/node#53656 | https://github.com/nodejs/node/pull/53656 |
| nodejs/node#52413 | https://github.com/nodejs/node/pull/52413 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#49639 | https://github.com/nodejs/node/pull/49639 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#50650 | https://github.com/nodejs/node/pull/50650 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#52996 | https://github.com/nodejs/node/pull/52996 |
| nodejs/node#53084 | https://github.com/nodejs/node/pull/53084 |
| nodejs/node#53084 | https://github.com/nodejs/node/pull/53084 |
| nodejs/node#53174 | https://github.com/nodejs/node/pull/53174 |
| nodejs/node#52745 | https://github.com/nodejs/node/pull/52745 |
| nodejs/node#51362 | https://github.com/nodejs/node/pull/51362 |
| nodejs/node#51999 | https://github.com/nodejs/node/pull/51999 |
| nodejs/node#54375 | https://github.com/nodejs/node/pull/54375 |
| nodejs/node#52177 | https://github.com/nodejs/node/pull/52177 |
| nodejs/node#53540 | https://github.com/nodejs/node/pull/53540 |
| nodejs/node#50115 | https://github.com/nodejs/node/pull/50115 |
| nodejs/node#52870 | https://github.com/nodejs/node/pull/52870 |
| nodejs/node#54890 | https://github.com/nodejs/node/pull/54890 |
| nodejs/node#52838 | https://github.com/nodejs/node/pull/52838 |
| nodejs/node#52966 | https://github.com/nodejs/node/pull/52966 |
| nodejs/node#51783 | https://github.com/nodejs/node/pull/51783 |
| nodejs/node#47637 | https://github.com/nodejs/node/pull/47637 |
| nodejs/node#52435 | https://github.com/nodejs/node/pull/52435 |
| nodejs/node#52609 | https://github.com/nodejs/node/pull/52609 |
| nodejs/node#54077 | https://github.com/nodejs/node/pull/54077 |
| nodejs/node#48325 | https://github.com/nodejs/node/pull/48325 |
| nodejs/node#54459 | https://github.com/nodejs/node/pull/54459 |
| nodejs/node#54320 | https://github.com/nodejs/node/pull/54320 |
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047 | https://chromium-review.googlesource.com/c/v8/v8/+/5507047 |
| nodejs/node#54459 | https://github.com/nodejs/node/pull/54459 |
| nodejs/node#53656 | https://github.com/nodejs/node/pull/53656 |
| nodejs/node#54553 | https://github.com/nodejs/node/pull/54553 |
| nodejs/node#48528 | https://github.com/nodejs/node/pull/48528 |
| nodejs/node#52213 | https://github.com/nodejs/node/pull/52213 |
| nodejs/node#53592 | https://github.com/nodejs/node/pull/53592 |
| nodejs/node#50322 | https://github.com/nodejs/node/pull/50322 |
| nodejs/node#55584 | https://github.com/nodejs/node/issues/55584 |
| libuv/libuv#4341 | https://github.com/libuv/libuv/pull/4341 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47637 |
|
| https://github.com/Qard |
|
Qard
| https://github.com/Qard |
|
| https://github.com/nodejs/node/pull/47637/files/e5e85792edab55f71d6e6d91d6abbc23963b6c92 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/47637/files/05799e19c4f56a15dfaf6459e8b37fc9a061c464 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/47637/files/90e1b2fec3148d1e0995e2b259d247318c21240b |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/47637/files/4d6bf56933f1333d2b11b000475897087cc5e2ef |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/47637/files/05799e19c4f56a15dfaf6459e8b37fc9a061c464 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/47637/files/eb8624291d48be80ae6c7970ee072ed342a92801 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/47637 |
|
| https://github.com/zcbenz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/gengjiawen |
|
| https://github.com/targos |
|
| https://github.com/joyeecheung |
|
| https://github.com/Qard |
|
| https://github.com/anonrig |
|
| https://github.com/jasnell |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |