| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5b837491-6799-0f56-db9f-ed77a83fd923 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9480:2D4000:6AA71C:928A9D:696A1E3F |
| html-safe-nonce | d9a4829457f87fc848cfd3a5be2c482ad02128b6ea5b4e7274cbb685056d1856 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDgwOjJENDAwMDo2QUE3MUM6OTI4QTlEOjY5NkExRTNGIiwidmlzaXRvcl9pZCI6Ijc2NDAzODc4NTY1NzU4OTcxNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a9902a040663c119824f46102850c92abca069a477b5467adf3fad8b5a351981 |
| hovercard-subject-tag | pull_request:1319801820 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47620/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0b1c4c875b45ca62be8a525d14d7cad920553a09476530814399611a8c96afbe/nodejs/node/pull/47620 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0b1c4c875b45ca62be8a525d14d7cad920553a09476530814399611a8c96afbe/nodejs/node/pull/47620 |
| og:image:alt | Use the default loader as the cascaded loader in the loader worker. Otherwise we spawn loader workers in the loader workers indefinitely.
Fixes: #47566 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/47620#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47620 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47620 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/47620 |
| Reload | https://github.com/nodejs/node/pull/47620 |
| Reload | https://github.com/nodejs/node/pull/47620 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/47620#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| joyeecheung:fix-loader-worker | https://github.com/joyeecheung/node/tree/fix-loader-worker |
|
loader: use default loader as cascaded loader in the in loader worker
| https://github.com/nodejs/node/pull/47620#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| joyeecheung:fix-loader-worker | https://github.com/joyeecheung/node/tree/fix-loader-worker |
|
Conversation
47
| https://github.com/nodejs/node/pull/47620 |
|
Commits
7
| https://github.com/nodejs/node/pull/47620/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/47620/checks |
|
Files changed
| https://github.com/nodejs/node/pull/47620/files |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issue-1674790182 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| #47566 | https://github.com/nodejs/node/issues/47566 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
|
| https://github.com/joyeecheung |
| loader: use default loader as cascaded loader in the in loader worker | https://github.com/nodejs/node/pull/47620/commits/3707d0051fbba829cadb2fccac2a7929eae04bad |
| 3707d00 | https://github.com/nodejs/node/pull/47620/commits/3707d0051fbba829cadb2fccac2a7929eae04bad |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1514636540 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#event-9045956157 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#ref-pullrequest-1671767425 |
|
esm: do not lazy instantiate loaders to avoid infinite loop
#47599
| https://github.com/nodejs/node/pull/47599 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1391947324 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
| test/es-module/test-loader-worker.js | https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad#diff-161f9a48c1de1dbe934e477ee01cc08eeed659469a2631b1e8487191ec580c4a |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1392002823 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1392245313 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1392245313 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1514975388 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#event-9049320275 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1392697660 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#event-9050852381 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#event-9050933654 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1392871310 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1392871310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| lib/internal/modules/esm/utils.js | https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad#diff-1831d1a1c94734d1167c7283fc5bedcce59011985d583a956e7abc16e1fb00c2 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171848037 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| aduh95 | https://github.com/aduh95 |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171858487 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171863581 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| node/lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/blob/3707d0051fbba829cadb2fccac2a7929eae04bad/lib/internal/modules/esm/hooks.js#L498 |
| 3707d00 | https://github.com/nodejs/node/commit/3707d0051fbba829cadb2fccac2a7929eae04bad |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| aduh95 | https://github.com/aduh95 |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171875153 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171971913 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1172231943 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| lib/internal/modules/esm/utils.js | https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad#diff-1831d1a1c94734d1167c7283fc5bedcce59011985d583a956e7abc16e1fb00c2 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171848939 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#discussion_r1171972110 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1515379754 |
| https://ci.nodejs.org/job/node-test-pull-request/51361/ | https://ci.nodejs.org/job/node-test-pull-request/51361/ |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#event-9051636999 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1515499933 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1515511569 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1515513262 |
| https://ci.nodejs.org/job/node-test-pull-request/51366/ | https://ci.nodejs.org/job/node-test-pull-request/51366/ |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 19, 2023 | https://github.com/nodejs/node/pull/47620#event-9051759224 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 19, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1393027640 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
| lib/internal/main/worker_thread.js | https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad#diff-63a0126eeb7dca524e9cedab9d7f2d216dcef95b70d74e4b89625d1a9855e427 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| April 19, 2023 17:28 | https://github.com/nodejs/node/pull/47620#commits-pushed-4c0fbfd |
|
| https://github.com/GeoffreyBooth |
| Add tests, reimplement new test in current loaders tests style | https://github.com/nodejs/node/pull/47620/commits/4c0fbfda3baffda9ac4581bc0d20622a316f351c |
| 4c0fbfd | https://github.com/nodejs/node/pull/47620/commits/4c0fbfda3baffda9ac4581bc0d20622a316f351c |
|
| https://github.com/GeoffreyBooth |
| Add comment | https://github.com/nodejs/node/pull/47620/commits/bb939a5cdd7f3457c014d246436dfe32b589039a |
| bb939a5 | https://github.com/nodejs/node/pull/47620/commits/bb939a5cdd7f3457c014d246436dfe32b589039a |
|
| https://github.com/GeoffreyBooth |
| Clarity | https://github.com/nodejs/node/pull/47620/commits/954e02e07ea87bdd9c9a058766992cedcbe0127c |
| 954e02e | https://github.com/nodejs/node/pull/47620/commits/954e02e07ea87bdd9c9a058766992cedcbe0127c |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1515558695 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#event-9052005564 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1515559143 |
| https://ci.nodejs.org/job/node-test-pull-request/51367/ | https://ci.nodejs.org/job/node-test-pull-request/51367/ |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1516488537 |
| https://ci.nodejs.org/job/node-test-pull-request/51384/ | https://ci.nodejs.org/job/node-test-pull-request/51384/ |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1394226368 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595 |
| test/es-module/test-loaders-workers-spawned.mjs | https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595#diff-ceb3da861095f1eebbaf2e8caa79b87de553cc7773e037c8917a2b74865333f1 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1394248343 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595 |
| test/es-module/test-loaders-workers-spawned.mjs | https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595#diff-ceb3da861095f1eebbaf2e8caa79b87de553cc7773e037c8917a2b74865333f1 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1394248993 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595 |
| test/es-module/test-loaders-workers-spawned.mjs | https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595#diff-ceb3da861095f1eebbaf2e8caa79b87de553cc7773e037c8917a2b74865333f1 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
|
| https://github.com/aduh95 |
| Apply suggestions from code review | https://github.com/nodejs/node/pull/47620/commits/3db9ee13cc0ac74f96deb76ccdba45636468d193 |
| 3db9ee1 | https://github.com/nodejs/node/pull/47620/commits/3db9ee13cc0ac74f96deb76ccdba45636468d193 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1516531130 |
| https://ci.nodejs.org/job/node-test-pull-request/51385/ | https://ci.nodejs.org/job/node-test-pull-request/51385/ |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Apr 20, 2023
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1394519658 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47620/files/3db9ee13cc0ac74f96deb76ccdba45636468d193 |
| benjamingr | https://github.com/benjamingr |
| https://github.com/nodejs/node/pull/47620#pullrequestreview-1394519658 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1516899586 |
| https://ci.nodejs.org/job/node-test-pull-request/51387/ | https://ci.nodejs.org/job/node-test-pull-request/51387/ |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Apr 20, 2023 | https://github.com/nodejs/node/pull/47620#event-9061673210 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 21, 2023 | https://github.com/nodejs/node/pull/47620#event-9067230849 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| f14d2e5 | https://github.com/nodejs/node/commit/f14d2e5a0c33996ecbcff1a61a60d787380345c0 |
| Apr 21, 2023 | https://github.com/nodejs/node/pull/47620#event-9067231628 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 21, 2023 | https://github.com/nodejs/node/pull/47620#issuecomment-1517760512 |
| f14d2e5 | https://github.com/nodejs/node/commit/f14d2e5a0c33996ecbcff1a61a60d787380345c0 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
|
CI Reliability 2023-04-24
nodejs/reliability#545
| https://github.com/nodejs/reliability/issues/545 |
|
CI Reliability 2023-04-25
nodejs/reliability#546
| https://github.com/nodejs/reliability/issues/546 |
|
CI Reliability 2023-04-26
nodejs/reliability#547
| https://github.com/nodejs/reliability/issues/547 |
| https://github.com/gtm-nayan |
| gtm-nayan | https://github.com/gtm-nayan |
|
Apr 26, 2023
| https://github.com/nodejs/node/pull/47620#ref-issue-1684285736 |
|
[BUG] Node 20: Test timeouts do not exit gracefully
microsoft/playwright#22641
| https://github.com/microsoft/playwright/issues/22641 |
| targos | https://github.com/targos |
|
May 2, 2023
| https://github.com/nodejs/node/pull/47620#ref-commit-91e4a7c |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| loader: use default loader as cascaded loader in the in loader worker | https://github.com/nodejs/node/commit/91e4a7cdeefa59a36df0d0c9594e10f92b56eee5 |
| 91e4a7c | https://github.com/nodejs/node/commit/91e4a7cdeefa59a36df0d0c9594e10f92b56eee5 |
| #47620 | https://github.com/nodejs/node/pull/47620 |
| #47566 | https://github.com/nodejs/node/issues/47566 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 2, 2023
| https://github.com/nodejs/node/pull/47620#ref-pullrequest-1692366695 |
|
v20.1.0 release proposal
#47820
| https://github.com/nodejs/node/pull/47820 |
|
Release plan - v20.x Maintenance LTS
nodejs/Release#855
| https://github.com/nodejs/Release/issues/855 |
|
Using custom loaders results in a load loop / OOM
#47566
| https://github.com/nodejs/node/issues/47566 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Jun 27, 2023 | https://github.com/nodejs/node/pull/47620#event-9645819284 |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/47620#ref-commit-ee9cef2 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| loader: use default loader as cascaded loader in the in loader worker | https://github.com/targos/node/commit/ee9cef2b847fc7889e147393a8a80a8a484cecbb |
| ee9cef2 | https://github.com/targos/node/commit/ee9cef2b847fc7889e147393a8a80a8a484cecbb |
| nodejs#47620 | https://github.com/nodejs/node/pull/47620 |
| nodejs#47566 | https://github.com/nodejs/node/issues/47566 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/47620#ref-pullrequest-1989043303 |
|
[v18.x] Backport most ESM and customization hook changes
#50669
| https://github.com/nodejs/node/pull/50669 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Nov 23, 2023 | https://github.com/nodejs/node/pull/47620#event-11045037967 |
| targos | https://github.com/targos |
|
Nov 23, 2023
| https://github.com/nodejs/node/pull/47620#ref-commit-b77a6b2 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| loader: use default loader as cascaded loader in the in loader worker | https://github.com/nodejs/node/commit/b77a6b237631df9c1fff0bebe21feacc3c9cdb94 |
| b77a6b2 | https://github.com/nodejs/node/commit/b77a6b237631df9c1fff0bebe21feacc3c9cdb94 |
| #47620 | https://github.com/nodejs/node/pull/47620 |
| #50669 | https://github.com/nodejs/node/pull/50669 |
| #47566 | https://github.com/nodejs/node/issues/47566 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/47620#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/47620#ref-commit-cb8981f |
|
| https://github.com/sercher |
| loader: use default loader as cascaded loader in the in | https://github.com/sercher/graaljs/commit/cb8981f7b7437efb7d4ca47b7ae0a09b19af2010 |
| cb8981f | https://github.com/sercher/graaljs/commit/cb8981f7b7437efb7d4ca47b7ae0a09b19af2010 |
| nodejs/node#47620 | https://github.com/nodejs/node/pull/47620 |
| nodejs/node#50669 | https://github.com/nodejs/node/pull/50669 |
| nodejs/node#47566 | https://github.com/nodejs/node/issues/47566 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/47620#ref-commit-c07d36d |
|
| https://github.com/sercher |
| loader: use default loader as cascaded loader in the in | https://github.com/sercher/graaljs/commit/c07d36d5c2229987996ba7a514e10750b8112971 |
| c07d36d | https://github.com/sercher/graaljs/commit/c07d36d5c2229987996ba7a514e10750b8112971 |
| nodejs/node#47620 | https://github.com/nodejs/node/pull/47620 |
| nodejs/node#50669 | https://github.com/nodejs/node/pull/50669 |
| nodejs/node#47566 | https://github.com/nodejs/node/issues/47566 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47620 |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/47620/files/954e02e07ea87bdd9c9a058766992cedcbe0127c |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/47620/files/36f9c62d92b9043cf25268026df781750f039595 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/47620/files/3db9ee13cc0ac74f96deb76ccdba45636468d193 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/47620/files/b691d1447ae1bd47a3cc96ac705d1edcbc3b72de |
|
| https://github.com/JakobJingleheimer |
|
JakobJingleheimer
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs/node/pull/47620/files/954e02e07ea87bdd9c9a058766992cedcbe0127c |
|
| https://github.com/merceyz |
|
merceyz
| https://github.com/merceyz |
|
| https://github.com/nodejs/node/pull/47620/files/3707d0051fbba829cadb2fccac2a7929eae04bad |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
|
Using custom loaders results in a load loop / OOM
| https://github.com/nodejs/node/issues/47566 |
| Please reload this page | https://github.com/nodejs/node/pull/47620 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/aduh95 |
|
| https://github.com/benjamingr |
|
| https://github.com/targos |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/merceyz |
|
| https://github.com/danielleadams |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |