René's URL Explorer Experiment


Title: fix: harden check for non-module in vm.modules linker by MikeRalphson · Pull Request #47583 · nodejs/node · GitHub

Open Graph Title: fix: harden check for non-module in vm.modules linker by MikeRalphson · Pull Request #47583 · nodejs/node

X Title: fix: harden check for non-module in vm.modules linker by MikeRalphson · Pull Request #47583 · nodejs/node

Description: (node:528088) ExperimentalWarning: VM Modules is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) node:internal/vm/module...

Open Graph Description: (node:528088) ExperimentalWarning: VM Modules is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) node:internal/vm/module...

X Description: (node:528088) ExperimentalWarning: VM Modules is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) node:internal/vm/module...

Opengraph URL: https://github.com/nodejs/node/pull/47583

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2df6997c-3b8f-f4f6-d65d-208e92dda671
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB59C:320F8E:C997B0:1158206:696A8CC3
html-safe-noncedd79968e32e23be36830afdea0e2158a8317ae2ce155dd02ee7447d88dbec559
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTlDOjMyMEY4RTpDOTk3QjA6MTE1ODIwNjo2OTZBOENDMyIsInZpc2l0b3JfaWQiOiIzNTUwNDY4NTUyNzU5MzQ4NDE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3e85afdab0cf1ad8f5b01bb04934fc5afaab51b1ea61b30e538fdd93730654c3
hovercard-subject-tagpull_request:1315635111
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47583/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4a0340334d34c784cfa9eedf65da1ffa7a21a862cff3b9fd9179bc911b023541/nodejs/node/pull/47583
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4a0340334d34c784cfa9eedf65da1ffa7a21a862cff3b9fd9179bc911b023541/nodejs/node/pull/47583
og:image:alt(node:528088) ExperimentalWarning: VM Modules is an experimental feature and might change at any time (Use `node --trace-warnings ...` to show where the warning was created) node:internal/vm/module...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMikeRalphson
hostnamegithub.com
expected-hostnamegithub.com
Noned2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1dbca8981c5e3d6a69bce2f1d289e732b86241d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47583#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47583
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47583
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47583
Reloadhttps://github.com/nodejs/node/pull/47583
Reloadhttps://github.com/nodejs/node/pull/47583
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47583
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47583
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47583#issue-comment-box
MikeRalphsonhttps://github.com/MikeRalphson
nodejs:mainhttps://github.com/nodejs/node/tree/main
MikeRalphson:patch-3https://github.com/MikeRalphson/node/tree/patch-3
fix: harden check for non-module in vm.modules linker https://github.com/nodejs/node/pull/47583#top
MikeRalphsonhttps://github.com/MikeRalphson
nodejs:mainhttps://github.com/nodejs/node/tree/main
MikeRalphson:patch-3https://github.com/MikeRalphson/node/tree/patch-3
Conversation 11 https://github.com/nodejs/node/pull/47583
Commits 2 https://github.com/nodejs/node/pull/47583/commits
Checks 0 https://github.com/nodejs/node/pull/47583/checks
Files changed https://github.com/nodejs/node/pull/47583/files
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/MikeRalphson
MikeRalphsonhttps://github.com/MikeRalphson
Apr 16, 2023https://github.com/nodejs/node/pull/47583#issue-1670033929
Please reload this pagehttps://github.com/nodejs/node/pull/47583
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Apr 16, 2023https://github.com/nodejs/node/pull/47583#event-9017798847
https://github.com/MikeRalphson
vm: harden check for non-module in vm.modules linkerhttps://github.com/nodejs/node/pull/47583/commits/1586f9393579562c8a138fbbc4e5a23cef3b3154
1586f93https://github.com/nodejs/node/pull/47583/commits/1586f9393579562c8a138fbbc4e5a23cef3b3154
https://github.com/MikeRalphson
MikeRalphsonhttps://github.com/MikeRalphson
force-pushedhttps://github.com/nodejs/node/compare/bccbb288fa679c03961a790db1be4c0cfbc30f8b..1586f9393579562c8a138fbbc4e5a23cef3b3154
bccbb28https://github.com/nodejs/node/commit/bccbb288fa679c03961a790db1be4c0cfbc30f8b
1586f93https://github.com/nodejs/node/commit/1586f9393579562c8a138fbbc4e5a23cef3b3154
Compare https://github.com/nodejs/node/compare/bccbb288fa679c03961a790db1be4c0cfbc30f8b..1586f9393579562c8a138fbbc4e5a23cef3b3154
April 16, 2023 16:29https://github.com/nodejs/node/pull/47583#event-9017812789
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 17, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1510732477
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/MikeRalphson
MikeRalphsonhttps://github.com/MikeRalphson
Apr 17, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1510771235
@RaisinTenhttps://github.com/RaisinTen
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 17, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1510775799
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/aduh95
aduh95https://github.com/aduh95
Apr 17, 2023 https://github.com/nodejs/node/pull/47583#pullrequestreview-1388430503
View reviewed changes https://github.com/nodejs/node/pull/47583/files/1586f9393579562c8a138fbbc4e5a23cef3b3154
lib/internal/vm/module.jshttps://github.com/nodejs/node/pull/47583/files/1586f9393579562c8a138fbbc4e5a23cef3b3154#diff-e3a178523fbae05afc4bd5da8e3ba29be9a02d5b244bfcd31c3fd507b10a89e3
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/MikeRalphson
https://github.com/aduh95
vm: use more idiomatic test for undefinedhttps://github.com/nodejs/node/pull/47583/commits/ac3d903008d5ab3c42e0e4b2c4568c332543aca4
ac3d903https://github.com/nodejs/node/pull/47583/commits/ac3d903008d5ab3c42e0e4b2c4568c332543aca4
https://github.com/MikeRalphson
MikeRalphsonhttps://github.com/MikeRalphson
Apr 18, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1513690845
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/MikeRalphson
MikeRalphsonhttps://github.com/MikeRalphson
Apr 19, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1514261913
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 19, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1514265112
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/MikeRalphson
MikeRalphsonhttps://github.com/MikeRalphson
Apr 19, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1514826188
@RaisinTenhttps://github.com/RaisinTen
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/aduh95
aduh95https://github.com/aduh95
Apr 19, 2023https://github.com/nodejs/node/pull/47583#issuecomment-1514851885
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 21, 2023 https://github.com/nodejs/node/pull/47583#pullrequestreview-1394928797
View reviewed changes https://github.com/nodejs/node/pull/47583/files/ac3d903008d5ab3c42e0e4b2c4568c332543aca4
https://github.com/fhinkel
fhinkelhttps://github.com/fhinkel
Feb 3, 2024https://github.com/nodejs/node/pull/47583#issuecomment-1925283436
@MikeRalphsonhttps://github.com/MikeRalphson
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 20, 2024 https://github.com/nodejs/node/pull/47583#ref-pullrequest-2197068752
vm: harden module type checks #52162 https://github.com/nodejs/node/pull/52162
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 22, 2024https://github.com/nodejs/node/pull/47583#issuecomment-2014725597
d1d5da2https://github.com/nodejs/node/commit/d1d5da22e4e699a8e32f3fa2a28f53a296eaec40
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/legendecas
legendecashttps://github.com/legendecas
Mar 22, 2024https://github.com/nodejs/node/pull/47583#event-12213377397
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47583
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/47583/files/1586f9393579562c8a138fbbc4e5a23cef3b3154
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/47583/files/ac3d903008d5ab3c42e0e4b2c4568c332543aca4
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
vm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Avm
Please reload this pagehttps://github.com/nodejs/node/pull/47583
https://github.com/MikeRalphson
https://github.com/RaisinTen
https://github.com/aduh95
https://github.com/fhinkel
https://github.com/legendecas
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.