| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a9a46dee-15f0-3bed-9fdb-9ee81e7cd4ca |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DDC4:2786B7:345A80:4607B2:6969CEE0 |
| html-safe-nonce | 130d0e086ad8e98f1cd0c786fba461d7a5dce60745f189f4dcf288e3578fb629 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREM0OjI3ODZCNzozNDVBODA6NDYwN0IyOjY5NjlDRUUwIiwidmlzaXRvcl9pZCI6IjUxMTA0NjQxNTQyODMxMzQ2ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d28dbaf3cc204f5b5ee65e740c7b007342f5d2740e1ab2785e6c600d90b8b430 |
| hovercard-subject-tag | pull_request:1312633754 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47541/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/88fdbe9c9409ff1610240de04ee5a6307e8c9c9949bd1c81b551c24be2502c43/nodejs/node/pull/47541 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/88fdbe9c9409ff1610240de04ee5a6307e8c9c9949bd1c81b551c24be2502c43/nodejs/node/pull/47541 |
| og:image:alt | Due to URL.canParse, we can avoid try/catch block and have faster validation. The previous implementation was not performant due to:
Unnecessary string serialization - We don't need href, orig... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/47541#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47541 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47541 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/47541 |
| Reload | https://github.com/nodejs/node/pull/47541 |
| Reload | https://github.com/nodejs/node/pull/47541 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/47541#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:improve-esm-performance | https://github.com/anonrig/node/tree/improve-esm-performance |
|
esm: avoid try/catch when validating urls
| https://github.com/nodejs/node/pull/47541#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:improve-esm-performance | https://github.com/anonrig/node/tree/improve-esm-performance |
|
Conversation
21
| https://github.com/nodejs/node/pull/47541 |
|
Commits
1
| https://github.com/nodejs/node/pull/47541/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/47541/checks |
|
Files changed
2
| https://github.com/nodejs/node/pull/47541/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issue-1666557793 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507088484 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#event-8997808648 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 13, 2023
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1383598471 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47541/files |
| aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1383598471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507104811 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507176629 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/5375959554691ca078a567ff2b62e94a1ea780e4..3a5776203fd7c7e2d323655d5edb1e54ff867ee0 |
| 5375959 | https://github.com/nodejs/node/commit/5375959554691ca078a567ff2b62e94a1ea780e4 |
| 3a57762 | https://github.com/nodejs/node/commit/3a5776203fd7c7e2d323655d5edb1e54ff867ee0 |
|
Compare
| https://github.com/nodejs/node/compare/5375959554691ca078a567ff2b62e94a1ea780e4..3a5776203fd7c7e2d323655d5edb1e54ff867ee0 |
| April 13, 2023 15:52 | https://github.com/nodejs/node/pull/47541#event-8998660445 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| aduh95 | https://github.com/aduh95 |
| April 13, 2023 15:53 | https://github.com/nodejs/node/pull/47541#event-8998663842 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 13, 2023
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1383753504 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47541/files |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#event-8998757669 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#event-8998783850 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507223738 |
| https://ci.nodejs.org/job/node-test-pull-request/51204/ | https://ci.nodejs.org/job/node-test-pull-request/51204/ |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Apr 13, 2023
| https://github.com/nodejs/node/pull/47541#ref-pullrequest-1666773112 |
|
url: handle URL.canParse without base parameter
#47547
| https://github.com/nodejs/node/pull/47547 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507348275 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507372272 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507374285 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507399068 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Apr 13, 2023
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1384012491 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47541/files |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1384012491 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Apr 13, 2023
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1384030179 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47541/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507572743 |
| #47179 | https://github.com/nodejs/node/pull/47179 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507594459 |
| node/src/node_url.cc | https://github.com/nodejs/node/blob/4afb25ccfd8a03a7f6c5bf5f4ad77d6bb9261c09/src/node_url.cc#L116-L117 |
| 4afb25c | https://github.com/nodejs/node/commit/4afb25ccfd8a03a7f6c5bf5f4ad77d6bb9261c09 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507613025 |
| @KhafraDev | https://github.com/KhafraDev |
| #47552 | https://github.com/nodejs/node/pull/47552 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Apr 13, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1507623846 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
|
| https://github.com/anonrig |
| esm: avoid try/catch when validating urls | https://github.com/nodejs/node/pull/47541/commits/05742e92687050e8fc60353cb11c313d824e62cc |
| 05742e9 | https://github.com/nodejs/node/pull/47541/commits/05742e92687050e8fc60353cb11c313d824e62cc |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/3a5776203fd7c7e2d323655d5edb1e54ff867ee0..05742e92687050e8fc60353cb11c313d824e62cc |
| 3a57762 | https://github.com/nodejs/node/commit/3a5776203fd7c7e2d323655d5edb1e54ff867ee0 |
| 05742e9 | https://github.com/nodejs/node/commit/05742e92687050e8fc60353cb11c313d824e62cc |
|
Compare
| https://github.com/nodejs/node/compare/3a5776203fd7c7e2d323655d5edb1e54ff867ee0..05742e92687050e8fc60353cb11c313d824e62cc |
| April 14, 2023 13:45 | https://github.com/nodejs/node/pull/47541#event-9008095415 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 14, 2023 | https://github.com/nodejs/node/pull/47541#event-9008796422 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 14, 2023 | https://github.com/nodejs/node/pull/47541#event-9008826708 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 14, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1508733068 |
| https://ci.nodejs.org/job/node-test-pull-request/51262/ | https://ci.nodejs.org/job/node-test-pull-request/51262/ |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 14, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1509213391 |
| https://ci.nodejs.org/job/node-test-pull-request/51268/ | https://ci.nodejs.org/job/node-test-pull-request/51268/ |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| aduh95 | https://github.com/aduh95 |
| lpinca | https://github.com/lpinca |
| April 14, 2023 22:24 | https://github.com/nodejs/node/pull/47541#event-9012123998 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Apr 14, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1509354922 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
|
Apr 14, 2023
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1386247301 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47541/files/05742e92687050e8fc60353cb11c313d824e62cc |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 14, 2023 | https://github.com/nodejs/node/pull/47541#event-9012288263 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Apr 15, 2023
| https://github.com/nodejs/node/pull/47541#ref-issue-1669068455 |
|
CI Reliability 2023-04-15
nodejs/reliability#543
| https://github.com/nodejs/reliability/issues/543 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Apr 15, 2023
| https://github.com/nodejs/node/pull/47541#pullrequestreview-1386432969 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/47541/files/05742e92687050e8fc60353cb11c313d824e62cc |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/47541/files/05742e92687050e8fc60353cb11c313d824e62cc#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Apr 15, 2023 | https://github.com/nodejs/node/pull/47541#discussion_r1167474538 |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| aduh95 | https://github.com/aduh95 |
| Apr 15, 2023 | https://github.com/nodejs/node/pull/47541#discussion_r1167543301 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| anonrig | https://github.com/anonrig |
| Apr 15, 2023 | https://github.com/nodejs/node/pull/47541#discussion_r1167543897 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 15, 2023 | https://github.com/nodejs/node/pull/47541#event-9014483925 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 17570c0 | https://github.com/nodejs/node/commit/17570c0a85bbe3ecf82876d78b98a637a01cd2ba |
| Apr 15, 2023 | https://github.com/nodejs/node/pull/47541#event-9014484323 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 15, 2023 | https://github.com/nodejs/node/pull/47541#issuecomment-1509859440 |
| 17570c0 | https://github.com/nodejs/node/commit/17570c0a85bbe3ecf82876d78b98a637a01cd2ba |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/47541#ref-issue-1672146770 |
|
CI Reliability 2023-04-18
nodejs/reliability#544
| https://github.com/nodejs/reliability/issues/544 |
| targos | https://github.com/targos |
|
May 2, 2023
| https://github.com/nodejs/node/pull/47541#ref-commit-889add6 |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
| esm: avoid try/catch when validating urls | https://github.com/nodejs/node/commit/889add68e50fbd2b1aa06735609ddb55f3a92889 |
| 889add6 | https://github.com/nodejs/node/commit/889add68e50fbd2b1aa06735609ddb55f3a92889 |
| #47541 | https://github.com/nodejs/node/pull/47541 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
May 2, 2023
| https://github.com/nodejs/node/pull/47541#ref-pullrequest-1692366695 |
|
v20.1.0 release proposal
#47820
| https://github.com/nodejs/node/pull/47820 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Jul 3, 2023 | https://github.com/nodejs/node/pull/47541#event-9713401711 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Jul 3, 2023
| https://github.com/nodejs/node/pull/47541#ref-pullrequest-1679466289 |
|
esm: rename URLCanParse to be consistent
#47668
| https://github.com/nodejs/node/pull/47668 |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/47541#ref-commit-7c878ef |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
| esm: avoid try/catch when validating urls | https://github.com/targos/node/commit/7c878ef60e35483787d8a9b391a084558718d957 |
| 7c878ef | https://github.com/targos/node/commit/7c878ef60e35483787d8a9b391a084558718d957 |
| nodejs#47541 | https://github.com/nodejs/node/pull/47541 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 11, 2023
| https://github.com/nodejs/node/pull/47541#ref-pullrequest-1989043303 |
|
[v18.x] Backport most ESM and customization hook changes
#50669
| https://github.com/nodejs/node/pull/50669 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Nov 23, 2023 | https://github.com/nodejs/node/pull/47541#event-11045013759 |
| targos | https://github.com/targos |
|
Nov 23, 2023
| https://github.com/nodejs/node/pull/47541#ref-commit-2a528b7 |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
| esm: avoid try/catch when validating urls | https://github.com/nodejs/node/commit/2a528b76e6e3a27f8e715edc54aa1dcbd2fe7040 |
| 2a528b7 | https://github.com/nodejs/node/commit/2a528b76e6e3a27f8e715edc54aa1dcbd2fe7040 |
| #47541 | https://github.com/nodejs/node/pull/47541 |
| #50669 | https://github.com/nodejs/node/pull/50669 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/47541#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/47541#ref-commit-dbd86ae |
|
| https://github.com/sercher |
| esm: avoid try/catch when validating urls | https://github.com/sercher/graaljs/commit/dbd86ae40c1a7e79ee9271dacd39435fe3260042 |
| dbd86ae | https://github.com/sercher/graaljs/commit/dbd86ae40c1a7e79ee9271dacd39435fe3260042 |
| nodejs/node#47541 | https://github.com/nodejs/node/pull/47541 |
| nodejs/node#50669 | https://github.com/nodejs/node/pull/50669 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/47541#ref-commit-9c2429d |
|
| https://github.com/sercher |
| esm: avoid try/catch when validating urls | https://github.com/sercher/graaljs/commit/9c2429de69a088d254b2893ed0fcbb083785476a |
| 9c2429d | https://github.com/sercher/graaljs/commit/9c2429de69a088d254b2893ed0fcbb083785476a |
| nodejs/node#47541 | https://github.com/nodejs/node/pull/47541 |
| nodejs/node#50669 | https://github.com/nodejs/node/pull/50669 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47541 |
|
| https://github.com/Qard |
|
Qard
| https://github.com/Qard |
|
| https://github.com/nodejs/node/pull/47541/files/05742e92687050e8fc60353cb11c313d824e62cc |
|
| https://github.com/JakobJingleheimer |
|
JakobJingleheimer
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs/node/pull/47541/files/05742e92687050e8fc60353cb11c313d824e62cc |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/47541 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/aduh95 |
|
| https://github.com/ljharb |
|
| https://github.com/mscdex |
|
| https://github.com/Qard |
|
| https://github.com/lpinca |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/targos |
|
| https://github.com/danielleadams |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |