René's URL Explorer Experiment


Title: crypto: replace THROW with CHECK for scrypt keylen by tniessen · Pull Request #47407 · nodejs/node · GitHub

Open Graph Title: crypto: replace THROW with CHECK for scrypt keylen by tniessen · Pull Request #47407 · nodejs/node

X Title: crypto: replace THROW with CHECK for scrypt keylen by tniessen · Pull Request #47407 · nodejs/node

Description: The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure that the keylen argument fits into a signed 32-bit integer, thus, the THROW statement in C++ is unreachable (unless the bindin...

Open Graph Description: The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure that the keylen argument fits into a signed 32-bit integer, thus, the THROW statement in C++ is unreachable (unless th...

X Description: The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure that the keylen argument fits into a signed 32-bit integer, thus, the THROW statement in C++ is unreachable (u...

Opengraph URL: https://github.com/nodejs/node/pull/47407

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e42fe8ae-7c6c-99eb-65ab-6e4711ec327b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8FF4:1ED5B9:E18AC2:1350732:6969F05A
html-safe-nonceab6905fd37445e91e393cf64e67bd5bdbcf38484faf402b778f3f9f680eb309d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkY0OjFFRDVCOTpFMThBQzI6MTM1MDczMjo2OTY5RjA1QSIsInZpc2l0b3JfaWQiOiIyNzk0NzI2NDEyMjk3ODI2Mzk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac01f15f80f974ce64a60391a9ea952b00973108fa8e250d7d754d824fb70f5126
hovercard-subject-tagpull_request:1301917150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47407/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97619677b42e97caa48fa36da36d65bc3b37d530e8bf09e6d6e36152a826a0a1/nodejs/node/pull/47407
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97619677b42e97caa48fa36da36d65bc3b37d530e8bf09e6d6e36152a826a0a1/nodejs/node/pull/47407
og:image:altThe JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure that the keylen argument fits into a signed 32-bit integer, thus, the THROW statement in C++ is unreachable (unless th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47407#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47407
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47407
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47407
Reloadhttps://github.com/nodejs/node/pull/47407
Reloadhttps://github.com/nodejs/node/pull/47407
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47407
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47407
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47407#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-scrypt-keylen-checkhttps://github.com/tniessen/node/tree/crypto-scrypt-keylen-check
crypto: replace THROW with CHECK for scrypt keylen https://github.com/nodejs/node/pull/47407#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:crypto-scrypt-keylen-checkhttps://github.com/tniessen/node/tree/crypto-scrypt-keylen-check
Conversation 6 https://github.com/nodejs/node/pull/47407
Commits 1 https://github.com/nodejs/node/pull/47407/commits
Checks 0 https://github.com/nodejs/node/pull/47407/checks
Files changed https://github.com/nodejs/node/pull/47407/files
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 4, 2023https://github.com/nodejs/node/pull/47407#issue-1654165187
node/lib/internal/crypto/scrypt.jshttps://github.com/nodejs/node/blob/af8ed0206732319c63a86ecb54d2588b953d45f2/lib/internal/crypto/scrypt.js#L85-L91
af8ed02https://github.com/nodejs/node/commit/af8ed0206732319c63a86ecb54d2588b953d45f2
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/tniessen
crypto: replace THROW with CHECK for scrypt keylenhttps://github.com/nodejs/node/pull/47407/commits/46631b5ae575c3dd93f301f9d9a1e65526ca564c
46631b5https://github.com/nodejs/node/pull/47407/commits/46631b5ae575c3dd93f301f9d9a1e65526ca564c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 4, 2023https://github.com/nodejs/node/pull/47407#issuecomment-1496232448
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 4, 2023https://github.com/nodejs/node/pull/47407#event-8926273397
https://github.com/anonrig
anonrighttps://github.com/anonrig
Apr 4, 2023 https://github.com/nodejs/node/pull/47407#pullrequestreview-1371320786
View reviewed changes https://github.com/nodejs/node/pull/47407/files/46631b5ae575c3dd93f301f9d9a1e65526ca564c
https://github.com/panva
panvahttps://github.com/panva
Apr 4, 2023 https://github.com/nodejs/node/pull/47407#pullrequestreview-1371320851
View reviewed changes https://github.com/nodejs/node/pull/47407/files/46631b5ae575c3dd93f301f9d9a1e65526ca564c
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Apr 4, 2023https://github.com/nodejs/node/pull/47407#event-8926303038
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 4, 2023https://github.com/nodejs/node/pull/47407#event-8926303201
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Apr 4, 2023https://github.com/nodejs/node/pull/47407#event-8926319579
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47407
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 4, 2023 https://github.com/nodejs/node/pull/47407#pullrequestreview-1371759460
View reviewed changes https://github.com/nodejs/node/pull/47407/files/46631b5ae575c3dd93f301f9d9a1e65526ca564c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 4, 2023https://github.com/nodejs/node/pull/47407#issuecomment-1496715972
https://ci.nodejs.org/job/node-test-pull-request/50943/https://ci.nodejs.org/job/node-test-pull-request/50943/
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 5, 2023 https://github.com/nodejs/node/pull/47407#ref-issue-1654737608
CI Reliability 2023-04-05 nodejs/reliability#540 https://github.com/nodejs/reliability/issues/540
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 8, 2023https://github.com/nodejs/node/pull/47407#issuecomment-1500855573
https://ci.nodejs.org/job/node-test-pull-request/51066/https://ci.nodejs.org/job/node-test-pull-request/51066/
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 8, 2023https://github.com/nodejs/node/pull/47407#issuecomment-1500905477
https://ci.nodejs.org/job/node-test-pull-request/51070/https://ci.nodejs.org/job/node-test-pull-request/51070/
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/panva
panvahttps://github.com/panva
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Apr 9, 2023https://github.com/nodejs/node/pull/47407#event-8958838613
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Apr 9, 2023https://github.com/nodejs/node/pull/47407#event-8958847013
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
1cda3f3https://github.com/nodejs/node/commit/1cda3f36d0b2d9df655bb4a51fa24f4187601f11
Apr 9, 2023https://github.com/nodejs/node/pull/47407#event-8958847163
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 9, 2023https://github.com/nodejs/node/pull/47407#issuecomment-1501084787
1cda3f3https://github.com/nodejs/node/commit/1cda3f36d0b2d9df655bb4a51fa24f4187601f11
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 11, 2023 https://github.com/nodejs/node/pull/47407#ref-pullrequest-1651807011
2023-04-18, Version 20.0.0 (Current) #47381 https://github.com/nodejs/node/pull/47381
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 12, 2023 https://github.com/nodejs/node/pull/47407#ref-issue-1663419643
CI Reliability 2023-04-12 nodejs/reliability#541 https://github.com/nodejs/reliability/issues/541
RafaelGSShttps://github.com/RafaelGSS
Apr 13, 2023 https://github.com/nodejs/node/pull/47407#ref-commit-48c0148
https://github.com/tniessen
https://github.com/RafaelGSS
crypto: replace THROW with CHECK for scrypt keylenhttps://github.com/nodejs/node/commit/48c01485cde60d8565056195bf0aa76573d5a558
48c0148https://github.com/nodejs/node/commit/48c01485cde60d8565056195bf0aa76573d5a558
#47407https://github.com/nodejs/node/pull/47407
danielleadamshttps://github.com/danielleadams
Jul 6, 2023 https://github.com/nodejs/node/pull/47407#ref-commit-ac3a4d9
https://github.com/tniessen
https://github.com/danielleadams
crypto: replace THROW with CHECK for scrypt keylenhttps://github.com/nodejs/node/commit/ac3a4d96b0db3a53cde82d725b62145d29cb4bb1
ac3a4d9https://github.com/nodejs/node/commit/ac3a4d96b0db3a53cde82d725b62145d29cb4bb1
#47407https://github.com/nodejs/node/pull/47407
MoLowhttps://github.com/MoLow
Jul 6, 2023 https://github.com/nodejs/node/pull/47407#ref-commit-a5f214c
https://github.com/tniessen
https://github.com/MoLow
crypto: replace THROW with CHECK for scrypt keylenhttps://github.com/MoLow/node/commit/a5f214c00c5c124804a433c4acf84a9640ab938b
a5f214chttps://github.com/MoLow/node/commit/a5f214c00c5c124804a433c4acf84a9640ab938b
nodejs#47407https://github.com/nodejs/node/pull/47407
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jul 10, 2023 https://github.com/nodejs/node/pull/47407#ref-pullrequest-1793607989
v18.17.0 release proposal #48694 https://github.com/nodejs/node/pull/48694
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47407
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/47407/files/46631b5ae575c3dd93f301f9d9a1e65526ca564c
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/47407/files/46631b5ae575c3dd93f301f9d9a1e65526ca564c
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/47407/files/46631b5ae575c3dd93f301f9d9a1e65526ca564c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/47407
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/lpinca
https://github.com/anonrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.