René's URL Explorer Experiment


Title: Revert "util: reduce javascript call for ToUSVString" by anonrig · Pull Request #47340 · nodejs/node · GitHub

Open Graph Title: Revert "util: reduce javascript call for ToUSVString" by anonrig · Pull Request #47340 · nodejs/node

X Title: Revert "util: reduce javascript call for ToUSVString" by anonrig · Pull Request #47340 · nodejs/node

Description: This PR reverts #47192 due to #47328. This change causes huge performance regression. Even though we have dont-land label on the PR, it is meddling with our benchmark results. Fixes #47328 cc @mscd...

Open Graph Description: This PR reverts #47192 due to #47328. This change causes huge performance regression. Even though we have dont-land label on the PR, it is meddling with our benchmark results. Fixes #47328 cc @mscd...

X Description: This PR reverts #47192 due to #47328. This change causes huge performance regression. Even though we have dont-land label on the PR, it is meddling with our benchmark results. Fixes #47328 cc @mscd...

Opengraph URL: https://github.com/nodejs/node/pull/47340

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:02b2bf90-7a7d-4cba-5ad5-d18a247a5e58
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8056:9CC2A:2186F2B:2E3DD98:696ABA49
html-safe-nonce6086fcd8c19381f53bce97903f64ad71df3de4378a4646b8710f2ca6b831ae5d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDU2OjlDQzJBOjIxODZGMkI6MkUzREQ5ODo2OTZBQkE0OSIsInZpc2l0b3JfaWQiOiI0MjcxMTY2NTM0NjM0MzU1Mjc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca5e06d12f65cd6651ab3664af449a228ba54c0954f00e2d6f8fb96b0c0471bd6
hovercard-subject-tagpull_request:1297750666
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47340/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8dce578d3ad2b52acf3fbd8bb29090e55deea07350a1cb5dbd625e75065cea9b/nodejs/node/pull/47340
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8dce578d3ad2b52acf3fbd8bb29090e55deea07350a1cb5dbd625e75065cea9b/nodejs/node/pull/47340
og:image:altThis PR reverts #47192 due to #47328. This change causes huge performance regression. Even though we have dont-land label on the PR, it is meddling with our benchmark results. Fixes #47328 cc @mscd...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47340#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47340
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47340
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47340
Reloadhttps://github.com/nodejs/node/pull/47340
Reloadhttps://github.com/nodejs/node/pull/47340
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47340
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47340
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47340#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:revert-tousv-stringhttps://github.com/anonrig/node/tree/revert-tousv-string
Revert "util: reduce javascript call for ToUSVString" https://github.com/nodejs/node/pull/47340#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:revert-tousv-stringhttps://github.com/anonrig/node/tree/revert-tousv-string
Conversation 7 https://github.com/nodejs/node/pull/47340
Commits 1 https://github.com/nodejs/node/pull/47340/commits
Checks 0 https://github.com/nodejs/node/pull/47340/checks
Files changed https://github.com/nodejs/node/pull/47340/files
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 31, 2023https://github.com/nodejs/node/pull/47340#issue-1649352203
Please reload this pagehttps://github.com/nodejs/node/pull/47340
#47192https://github.com/nodejs/node/pull/47192
#47328https://github.com/nodejs/node/issues/47328
#47328https://github.com/nodejs/node/issues/47328
@mscdexhttps://github.com/mscdex
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/anonrig
Revert "util: reduce javascript call for ToUSVString"https://github.com/nodejs/node/pull/47340/commits/8a591f89df6388ba8297acf248a859225d3e1952
8a591f8https://github.com/nodejs/node/pull/47340/commits/8a591f89df6388ba8297acf248a859225d3e1952
f51c152https://github.com/anonrig/node/commit/f51c152f6016fdf9ad9ec6ee246f83a7b4793043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8898050568
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8898052968
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8898125898
https://github.com/anonrig
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47340
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8901271496
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 31, 2023https://github.com/nodejs/node/pull/47340#issuecomment-1492506619
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8901305907
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 31, 2023https://github.com/nodejs/node/pull/47340#issuecomment-1492511214
https://ci.nodejs.org/job/node-test-pull-request/50764/https://ci.nodejs.org/job/node-test-pull-request/50764/
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/anonrig
anonrighttps://github.com/anonrig
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8901325233
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 31, 2023https://github.com/nodejs/node/pull/47340#issuecomment-1492513661
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/Qard
Qardhttps://github.com/Qard
Mar 31, 2023 https://github.com/nodejs/node/pull/47340#pullrequestreview-1367512135
View reviewed changes https://github.com/nodejs/node/pull/47340/files/8a591f89df6388ba8297acf248a859225d3e1952
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Mar 31, 2023 https://github.com/nodejs/node/pull/47340#pullrequestreview-1367514879
View reviewed changes https://github.com/nodejs/node/pull/47340/files/8a591f89df6388ba8297acf248a859225d3e1952
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8901361405
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
Mar 31, 2023https://github.com/nodejs/node/pull/47340#event-8901370281
Performance regression after updating to V8 11.3 #47350 https://github.com/nodejs/node/issues/47350
lib,src: replace toUSVString with toWellFormed() #47342 https://github.com/nodejs/node/pull/47342
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 31, 2023 https://github.com/nodejs/node/pull/47340#pullrequestreview-1367568212
View reviewed changes https://github.com/nodejs/node/pull/47340/files/8a591f89df6388ba8297acf248a859225d3e1952
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2023https://github.com/nodejs/node/pull/47340#issuecomment-1492762571
https://ci.nodejs.org/job/node-test-pull-request/50777/https://ci.nodejs.org/job/node-test-pull-request/50777/
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/anonrig
anonrighttps://github.com/anonrig
Apr 1, 2023https://github.com/nodejs/node/pull/47340#issuecomment-1492801193
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/targos
targoshttps://github.com/targos
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Apr 1, 2023https://github.com/nodejs/node/pull/47340#event-8903760453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Apr 1, 2023https://github.com/nodejs/node/pull/47340#event-8903774442
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
4c9ec98https://github.com/nodejs/node/commit/4c9ec9866e3de3255856507d82ddc4b27df9784a
Apr 1, 2023https://github.com/nodejs/node/pull/47340#event-8903774508
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 1, 2023https://github.com/nodejs/node/pull/47340#issuecomment-1492918548
4c9ec98https://github.com/nodejs/node/commit/4c9ec9866e3de3255856507d82ddc4b27df9784a
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 2, 2023 https://github.com/nodejs/node/pull/47340#ref-issue-1650746021
CI Reliability 2023-04-02 nodejs/reliability#537 https://github.com/nodejs/reliability/issues/537
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 3, 2023 https://github.com/nodejs/node/pull/47340#ref-issue-1651148526
CI Reliability 2023-04-03 nodejs/reliability#538 https://github.com/nodejs/reliability/issues/538
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 3, 2023 https://github.com/nodejs/node/pull/47340#ref-pullrequest-1651807011
2023-04-18, Version 20.0.0 (Current) #47381 https://github.com/nodejs/node/pull/47381
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47340
https://github.com/Qard
Qard https://github.com/Qard
https://github.com/nodejs/node/pull/47340/files/8a591f89df6388ba8297acf248a859225d3e1952
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/47340/files/8a591f89df6388ba8297acf248a859225d3e1952
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/47340/files/8a591f89df6388ba8297acf248a859225d3e1952
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
large performance regressions since f51c152 https://github.com/nodejs/node/issues/47328
Please reload this pagehttps://github.com/nodejs/node/pull/47340
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/Qard
https://github.com/jasnell
https://github.com/BridgeAR
https://github.com/targos
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.