René's URL Explorer Experiment


Title: quic: do not dereference shared_ptr after move by tniessen · Pull Request #47294 · nodejs/node · GitHub

Open Graph Title: quic: do not dereference shared_ptr after move by tniessen · Pull Request #47294 · nodejs/node

X Title: quic: do not dereference shared_ptr after move by tniessen · Pull Request #47294 · nodejs/node

Description: The stored pointer is assumed to be nullptr after std::move.

Open Graph Description: The stored pointer is assumed to be nullptr after std::move.

X Description: The stored pointer is assumed to be nullptr after std::move.

Opengraph URL: https://github.com/nodejs/node/pull/47294

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:daf80261-defc-2afb-a21a-ebd5fc24ef3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA0C:1B40D2:7D2742:AC2D9C:6969E6E8
html-safe-nonce431cc336b72d2f3795b750ebc25dafa2bff8e228fa1df87194d31bdf24a8eb53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTBDOjFCNDBEMjo3RDI3NDI6QUMyRDlDOjY5NjlFNkU4IiwidmlzaXRvcl9pZCI6Ijg4MDQyMzIxMzE3Njg0MTk2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3e6438c6e386de7079d925d0683be530323f5edb3f1ea2ab52beb42bdd1eb325
hovercard-subject-tagpull_request:1294521804
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47294/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a9576f9ccb1c1efcfda690ed8f5702deeb025a0db176cab9a21af571b2380112/nodejs/node/pull/47294
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a9576f9ccb1c1efcfda690ed8f5702deeb025a0db176cab9a21af571b2380112/nodejs/node/pull/47294
og:image:altThe stored pointer is assumed to be nullptr after std::move.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47294#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47294
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47294
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47294
Reloadhttps://github.com/nodejs/node/pull/47294
Reloadhttps://github.com/nodejs/node/pull/47294
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47294
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47294
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47294#issue-comment-box
tniessenhttps://github.com/tniessen
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:src-quic-store-movehttps://github.com/tniessen/node/tree/src-quic-store-move
quic: do not dereference shared_ptr after move https://github.com/nodejs/node/pull/47294#top
tniessenhttps://github.com/tniessen
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:src-quic-store-movehttps://github.com/tniessen/node/tree/src-quic-store-move
Conversation 5 https://github.com/nodejs/node/pull/47294
Commits 1 https://github.com/nodejs/node/pull/47294/commits
Checks 0 https://github.com/nodejs/node/pull/47294/checks
Files changed https://github.com/nodejs/node/pull/47294/files
Please reload this pagehttps://github.com/nodejs/node/pull/47294
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 29, 2023https://github.com/nodejs/node/pull/47294#issue-1645674601
Please reload this pagehttps://github.com/nodejs/node/pull/47294
https://github.com/tniessen
quic: do not dereference shared_ptr after movehttps://github.com/nodejs/node/pull/47294/commits/c1e875849140770e5006a2aedccca7b02922ca7a
c1e8758https://github.com/nodejs/node/pull/47294/commits/c1e875849140770e5006a2aedccca7b02922ca7a
https://github.com/tniessen
tniessenhttps://github.com/tniessen
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
quic https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquic
Mar 29, 2023https://github.com/nodejs/node/pull/47294#event-8875755434
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
March 29, 2023 12:08https://github.com/nodejs/node/pull/47294#event-8875755466
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Mar 29, 2023https://github.com/nodejs/node/pull/47294#event-8875758431
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 29, 2023 https://github.com/nodejs/node/pull/47294#pullrequestreview-1363101363
View reviewed changes https://github.com/nodejs/node/pull/47294/files/c1e875849140770e5006a2aedccca7b02922ca7a
src/quic/data.cchttps://github.com/nodejs/node/pull/47294/files/c1e875849140770e5006a2aedccca7b02922ca7a#diff-83cc416334e253684edee27e599a4affadcafb7874ab33c743461e77e49cfa8f
jasnellhttps://github.com/jasnell
Mar 29, 2023https://github.com/nodejs/node/pull/47294#discussion_r1151940939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/47294
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 29, 2023 https://github.com/nodejs/node/pull/47294#pullrequestreview-1363101530
View reviewed changes https://github.com/nodejs/node/pull/47294/files/c1e875849140770e5006a2aedccca7b02922ca7a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Mar 29, 2023https://github.com/nodejs/node/pull/47294#event-8876641992
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 29, 2023https://github.com/nodejs/node/pull/47294#issuecomment-1488612652
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/47294
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Qardhttps://github.com/Qard
anonrighttps://github.com/anonrig
March 29, 2023 13:27https://github.com/nodejs/node/pull/47294#event-8876644546
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 29, 2023 https://github.com/nodejs/node/pull/47294#pullrequestreview-1363107434
View reviewed changes https://github.com/nodejs/node/pull/47294/files/c1e875849140770e5006a2aedccca7b02922ca7a
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 29, 2023https://github.com/nodejs/node/pull/47294#event-8876654747
https://github.com/jasnell
jasnellhttps://github.com/jasnell
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 29, 2023https://github.com/nodejs/node/pull/47294#event-8876698515
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 29, 2023https://github.com/nodejs/node/pull/47294#issuecomment-1488620358
https://ci.nodejs.org/job/node-test-pull-request/50664/https://ci.nodejs.org/job/node-test-pull-request/50664/
Please reload this pagehttps://github.com/nodejs/node/pull/47294
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 29, 2023https://github.com/nodejs/node/pull/47294#issuecomment-1488980040
9b104behttps://github.com/nodejs/node/commit/9b104be502a497a20748b106ad01b2fbf22a6e4e
Please reload this pagehttps://github.com/nodejs/node/pull/47294
jasnellhttps://github.com/jasnell
Mar 29, 2023 https://github.com/nodejs/node/pull/47294#ref-commit-9b104be
https://github.com/tniessen
https://github.com/jasnell
quic: do not dereference shared_ptr after movehttps://github.com/nodejs/node/commit/9b104be502a497a20748b106ad01b2fbf22a6e4e
9b104behttps://github.com/nodejs/node/commit/9b104be502a497a20748b106ad01b2fbf22a6e4e
#47294https://github.com/nodejs/node/pull/47294
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 29, 2023https://github.com/nodejs/node/pull/47294#event-8878846748
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 3, 2023 https://github.com/nodejs/node/pull/47294#ref-pullrequest-1651807011
2023-04-18, Version 20.0.0 (Current) #47381 https://github.com/nodejs/node/pull/47381
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
dont-land-on-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v16.x
Apr 5, 2023https://github.com/nodejs/node/pull/47294#event-8938551927
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 5, 2023https://github.com/nodejs/node/pull/47294#issuecomment-1497993573
#47263https://github.com/nodejs/node/pull/47263
Please reload this pagehttps://github.com/nodejs/node/pull/47294
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47294
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/47294/files/c1e875849140770e5006a2aedccca7b02922ca7a
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/47294/files/c1e875849140770e5006a2aedccca7b02922ca7a
https://github.com/Qard
Qard https://github.com/Qard
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
quic https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquic
Please reload this pagehttps://github.com/nodejs/node/pull/47294
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/RafaelGSS
https://github.com/anonrig
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.