René's URL Explorer Experiment


Title: buffer: use private properties for brand checks in File by KhafraDev · Pull Request #47154 · nodejs/node · GitHub

Open Graph Title: buffer: use private properties for brand checks in File by KhafraDev · Pull Request #47154 · nodejs/node

X Title: buffer: use private properties for brand checks in File by KhafraDev · Pull Request #47154 · nodejs/node

Description: The current checks wouldn't work for certain values, and other places in the code have moved to this behavior as well. import { File } from 'node:buffer' const pd = Object.getOwnPropertyDescriptor...

Open Graph Description: The current checks wouldn't work for certain values, and other places in the code have moved to this behavior as well. import { File } from 'node:buffer' const pd = Object.getOwnProper...

X Description: The current checks wouldn't work for certain values, and other places in the code have moved to this behavior as well. import { File } from 'node:buffer' const pd = Object....

Opengraph URL: https://github.com/nodejs/node/pull/47154

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b0c25f2f-b50d-f253-0aa0-650b6b182b28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAF2:36099A:FE3F1F:163D126:696A3687
html-safe-nonceabcf32fa897a985008ea9946c34bbf78dad289ed58f06234f722ecd11a54535d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUYyOjM2MDk5QTpGRTNGMUY6MTYzRDEyNjo2OTZBMzY4NyIsInZpc2l0b3JfaWQiOiIzOTQ0NTAyNTM0OTk3NDE4MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac044ecb7046cae96673a66f4dcce8cda2fcd539240e141ec8fb02ed5f35582dbd
hovercard-subject-tagpull_request:1281349580
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47154/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e176cc00dab7b7b9f130b5aae7281b52523005fcc55aa3f42288f6e6dd1e5d5a/nodejs/node/pull/47154
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e176cc00dab7b7b9f130b5aae7281b52523005fcc55aa3f42288f6e6dd1e5d5a/nodejs/node/pull/47154
og:image:altThe current checks wouldn't work for certain values, and other places in the code have moved to this behavior as well. import { File } from 'node:buffer' const pd = Object.getOwnProper...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKhafraDev
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47154#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47154
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47154
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47154
Reloadhttps://github.com/nodejs/node/pull/47154
Reloadhttps://github.com/nodejs/node/pull/47154
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47154
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47154
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47154#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
KhafraDev:file-brand-checkshttps://github.com/KhafraDev/node/tree/file-brand-checks
buffer: use private properties for brand checks in File https://github.com/nodejs/node/pull/47154#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
KhafraDev:file-brand-checkshttps://github.com/KhafraDev/node/tree/file-brand-checks
Conversation 4 https://github.com/nodejs/node/pull/47154
Commits 1 https://github.com/nodejs/node/pull/47154/commits
Checks 0 https://github.com/nodejs/node/pull/47154/checks
Files changed https://github.com/nodejs/node/pull/47154/files
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/KhafraDev
KhafraDevhttps://github.com/KhafraDev
Mar 18, 2023https://github.com/nodejs/node/pull/47154#issue-1630627853
#46904https://github.com/nodejs/node/pull/46904
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.com/KhafraDev
buffer: use private properties for brand checks in Filehttps://github.com/nodejs/node/pull/47154/commits/393e443e2cd1ad6be0b8e487f494788ca4ed0cbd
393e443https://github.com/nodejs/node/pull/47154/commits/393e443e2cd1ad6be0b8e487f494788ca4ed0cbd
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Mar 18, 2023https://github.com/nodejs/node/pull/47154#event-8786137280
https://github.com/anonrig
anonrighttps://github.com/anonrig
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 18, 2023https://github.com/nodejs/node/pull/47154#event-8786415669
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 18, 2023 https://github.com/nodejs/node/pull/47154#pullrequestreview-1347307818
View reviewed changes https://github.com/nodejs/node/pull/47154/files/393e443e2cd1ad6be0b8e487f494788ca4ed0cbd
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 18, 2023https://github.com/nodejs/node/pull/47154#event-8786425378
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 18, 2023https://github.com/nodejs/node/pull/47154#issuecomment-1475029327
https://ci.nodejs.org/job/node-test-pull-request/50451/https://ci.nodejs.org/job/node-test-pull-request/50451/
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 19, 2023https://github.com/nodejs/node/pull/47154#issuecomment-1475086290
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.com/anonrig
anonrighttps://github.com/anonrig
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Mar 19, 2023https://github.com/nodejs/node/pull/47154#event-8786819310
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 19, 2023https://github.com/nodejs/node/pull/47154#issuecomment-1475086595
https://ci.nodejs.org/job/node-test-pull-request/50455/https://ci.nodejs.org/job/node-test-pull-request/50455/
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 19, 2023 https://github.com/nodejs/node/pull/47154#pullrequestreview-1347375562
View reviewed changes https://github.com/nodejs/node/pull/47154/files/393e443e2cd1ad6be0b8e487f494788ca4ed0cbd
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 20, 2023 https://github.com/nodejs/node/pull/47154#ref-issue-1631177453
CI Reliability 2023-03-20 nodejs/reliability#530 https://github.com/nodejs/reliability/issues/530
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 20, 2023https://github.com/nodejs/node/pull/47154#event-8797924655
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 20, 2023https://github.com/nodejs/node/pull/47154#event-8799627048
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
252a069https://github.com/nodejs/node/commit/252a06900728e11d6052f9e9812328d69b794c90
Mar 20, 2023https://github.com/nodejs/node/pull/47154#event-8799627518
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 20, 2023https://github.com/nodejs/node/pull/47154#issuecomment-1476993295
252a069https://github.com/nodejs/node/commit/252a06900728e11d6052f9e9812328d69b794c90
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.com/KhafraDev
KhafraDevhttps://github.com/KhafraDev
March 20, 2023 22:22https://github.com/nodejs/node/pull/47154#event-8799768494
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 21, 2023 https://github.com/nodejs/node/pull/47154#ref-issue-1633048431
CI Reliability 2023-03-21 nodejs/reliability#531 https://github.com/nodejs/reliability/issues/531
https://github.com/debadree25
debadree25https://github.com/debadree25
Mar 21, 2023 https://github.com/nodejs/node/pull/47154#ref-issue-1634495700
Flaky Test parallel/test-http-remove-connection-header-persists-connection #47200 https://github.com/nodejs/node/issues/47200
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 22, 2023 https://github.com/nodejs/node/pull/47154#ref-issue-1634867703
CI Reliability 2023-03-22 nodejs/reliability#532 https://github.com/nodejs/reliability/issues/532
https://github.com/anonrig
anonrighttps://github.com/anonrig
Mar 26, 2023 https://github.com/nodejs/node/pull/47154#ref-pullrequest-1636033237
Improve webstreams brand validations #47218 https://github.com/nodejs/node/pull/47218
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 3, 2023 https://github.com/nodejs/node/pull/47154#ref-pullrequest-1651807011
2023-04-18, Version 20.0.0 (Current) #47381 https://github.com/nodejs/node/pull/47381
RafaelGSShttps://github.com/RafaelGSS
Apr 5, 2023 https://github.com/nodejs/node/pull/47154#ref-commit-d639f2e
https://github.com/KhafraDev
https://github.com/RafaelGSS
buffer: use private properties for brand checks in Filehttps://github.com/nodejs/node/commit/d639f2e47c226f06eafb9dbe9a1b3f4c6b97b0b5
d639f2ehttps://github.com/nodejs/node/commit/d639f2e47c226f06eafb9dbe9a1b3f4c6b97b0b5
#47154https://github.com/nodejs/node/pull/47154
#46904https://github.com/nodejs/node/pull/46904
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 6, 2023 https://github.com/nodejs/node/pull/47154#ref-pullrequest-1656565377
v19.9.0 proposal #47441 https://github.com/nodejs/node/pull/47441
RafaelGSShttps://github.com/RafaelGSS
Apr 7, 2023 https://github.com/nodejs/node/pull/47154#ref-commit-e3d98c3
https://github.com/KhafraDev
https://github.com/RafaelGSS
buffer: use private properties for brand checks in Filehttps://github.com/nodejs/node/commit/e3d98c3e7ae39797dda9bdd3ffc0e1aea1077917
e3d98c3https://github.com/nodejs/node/commit/e3d98c3e7ae39797dda9bdd3ffc0e1aea1077917
#47154https://github.com/nodejs/node/pull/47154
#46904https://github.com/nodejs/node/pull/46904
danielleadamshttps://github.com/danielleadams
Jul 6, 2023 https://github.com/nodejs/node/pull/47154#ref-commit-4c69be4
https://github.com/KhafraDev
https://github.com/danielleadams
buffer: use private properties for brand checks in Filehttps://github.com/nodejs/node/commit/4c69be467caa26f75bf7e6b5da9640a50d38e920
4c69be4https://github.com/nodejs/node/commit/4c69be467caa26f75bf7e6b5da9640a50d38e920
#47154https://github.com/nodejs/node/pull/47154
#46904https://github.com/nodejs/node/pull/46904
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jul 10, 2023 https://github.com/nodejs/node/pull/47154#ref-pullrequest-1793607989
v18.17.0 release proposal #48694 https://github.com/nodejs/node/pull/48694
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47154
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/47154/files/393e443e2cd1ad6be0b8e487f494788ca4ed0cbd
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/47154/files/393e443e2cd1ad6be0b8e487f494788ca4ed0cbd
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/47154
https://github.com/KhafraDev
https://github.com/nodejs-github-bot
https://github.com/anonrig
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.