René's URL Explorer Experiment


Title: src: fix duplication of externalized builtin code by kvakil · Pull Request #47079 · nodejs/node · GitHub

Open Graph Title: src: fix duplication of externalized builtin code by kvakil · Pull Request #47079 · nodejs/node

X Title: src: fix duplication of externalized builtin code by kvakil · Pull Request #47079 · nodejs/node

Description: The else here was missing, causing us to append the file to its existing source already in the map. Refs: #45942

Open Graph Description: The else here was missing, causing us to append the file to its existing source already in the map. Refs: #45942

X Description: The else here was missing, causing us to append the file to its existing source already in the map. Refs: #45942

Opengraph URL: https://github.com/nodejs/node/pull/47079

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2cac5879-b55b-6a24-4d2c-74e067127c50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id810E:14C034:F35E9:148682:6969CCE8
html-safe-nonce4b7af1a0178ae8ff7df843282ed50bc92fa0fff826dc74b0fcab9ca5ddaf70b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTBFOjE0QzAzNDpGMzVFOToxNDg2ODI6Njk2OUNDRTgiLCJ2aXNpdG9yX2lkIjoiNTIxNDA5ODU1ODMzNDY1MTYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5551379b3b88e626b8efc79b29107ec745f5fe7887de34c1d3f70e3970d45f91
hovercard-subject-tagpull_request:1274450163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/47079/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f79dccad3d9c449fd783a4a6d1576141c11121cd3880efdef7af68b7720b3f4a/nodejs/node/pull/47079
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f79dccad3d9c449fd783a4a6d1576141c11121cd3880efdef7af68b7720b3f4a/nodejs/node/pull/47079
og:image:altThe else here was missing, causing us to append the file to its existing source already in the map. Refs: #45942
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekvakil
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/47079#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47079
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47079
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/47079
Reloadhttps://github.com/nodejs/node/pull/47079
Reloadhttps://github.com/nodejs/node/pull/47079
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/47079
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/47079
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/47079#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
kvakil:missingElseExternalhttps://github.com/kvakil/node/tree/missingElseExternal
src: fix duplication of externalized builtin code https://github.com/nodejs/node/pull/47079#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
kvakil:missingElseExternalhttps://github.com/kvakil/node/tree/missingElseExternal
Conversation 9 https://github.com/nodejs/node/pull/47079
Commits 1 https://github.com/nodejs/node/pull/47079/commits
Checks 0 https://github.com/nodejs/node/pull/47079/checks
Files changed https://github.com/nodejs/node/pull/47079/files
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Mar 14, 2023https://github.com/nodejs/node/pull/47079#issue-1622805480
#45942https://github.com/nodejs/node/pull/45942
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/kvakil
src: fix duplication of externalized builtin codehttps://github.com/nodejs/node/pull/47079/commits/fd3252ef580a8bd4013217bff9b144069e8f917f
fd3252ehttps://github.com/nodejs/node/pull/47079/commits/fd3252ef580a8bd4013217bff9b144069e8f917f
nodejs#45942https://github.com/nodejs/node/pull/45942
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 14, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1467430567
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Mar 14, 2023https://github.com/nodejs/node/pull/47079#event-8739503098
https://github.com/kvakil
kvakilhttps://github.com/kvakil
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 14, 2023https://github.com/nodejs/node/pull/47079#event-8739748052
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 14, 2023https://github.com/nodejs/node/pull/47079#event-8739801566
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 14, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1467492423
https://ci.nodejs.org/job/node-test-pull-request/50368/https://ci.nodejs.org/job/node-test-pull-request/50368/
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Mar 14, 2023 https://github.com/nodejs/node/pull/47079#pullrequestreview-1338984149
View reviewed changes https://github.com/nodejs/node/pull/47079/files/fd3252ef580a8bd4013217bff9b144069e8f917f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 14, 2023https://github.com/nodejs/node/pull/47079#event-8741999548
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 14, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1467858917
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Mar 14, 2023https://github.com/nodejs/node/pull/47079#event-8742037977
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47079
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Mar 14, 2023 https://github.com/nodejs/node/pull/47079#pullrequestreview-1339209781
View reviewed changes https://github.com/nodejs/node/pull/47079/files/fd3252ef580a8bd4013217bff9b144069e8f917f
https://github.com/kvakil
kvakilhttps://github.com/kvakil
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 15, 2023https://github.com/nodejs/node/pull/47079#event-8750661569
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 15, 2023 https://github.com/nodejs/node/pull/47079#pullrequestreview-1342394581
View reviewed changes https://github.com/nodejs/node/pull/47079/files/fd3252ef580a8bd4013217bff9b144069e8f917f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1471688829
https://ci.nodejs.org/job/node-test-pull-request/50397/https://ci.nodejs.org/job/node-test-pull-request/50397/
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1471911793
https://ci.nodejs.org/job/node-test-pull-request/50399/https://ci.nodejs.org/job/node-test-pull-request/50399/
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/kvakil
kvakilhttps://github.com/kvakil
Mar 16, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1472855922
https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubi81_sharedlibs_openssl111fips_x64/36558/https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubi81_sharedlibs_openssl111fips_x64/36558/
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 16, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1472858047
https://ci.nodejs.org/job/node-test-pull-request/50405/https://ci.nodejs.org/job/node-test-pull-request/50405/
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/kvakil
kvakilhttps://github.com/kvakil
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 17, 2023https://github.com/nodejs/node/pull/47079#event-8773100589
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 17, 2023 https://github.com/nodejs/node/pull/47079#ref-issue-1628494323
CI Reliability 2023-03-17 nodejs/reliability#526 https://github.com/nodejs/reliability/issues/526
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 17, 2023https://github.com/nodejs/node/pull/47079#event-8773138594
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c3537aehttps://github.com/nodejs/node/commit/c3537ae8cc220d58d95bcdf2fd52046c314c4803
Mar 17, 2023https://github.com/nodejs/node/pull/47079#event-8773138807
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 17, 2023https://github.com/nodejs/node/pull/47079#issuecomment-1472931714
c3537aehttps://github.com/nodejs/node/commit/c3537ae8cc220d58d95bcdf2fd52046c314c4803
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 18, 2023 https://github.com/nodejs/node/pull/47079#ref-issue-1630047919
CI Reliability 2023-03-18 nodejs/reliability#527 https://github.com/nodejs/reliability/issues/527
targoshttps://github.com/targos
Mar 18, 2023 https://github.com/nodejs/node/pull/47079#ref-commit-2fd0f79
https://github.com/kvakil
https://github.com/targos
src: fix duplication of externalized builtin codehttps://github.com/nodejs/node/commit/2fd0f79963a818a2872b4a421a692e898644ef7f
2fd0f79https://github.com/nodejs/node/commit/2fd0f79963a818a2872b4a421a692e898644ef7f
#45942https://github.com/nodejs/node/pull/45942
#47079https://github.com/nodejs/node/pull/47079
CI Reliability 2023-03-19 nodejs/reliability#528 https://github.com/nodejs/reliability/issues/528
CI Reliability 2023-03-20 nodejs/reliability#530 https://github.com/nodejs/reliability/issues/530
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 3, 2023 https://github.com/nodejs/node/pull/47079#ref-pullrequest-1651807011
2023-04-18, Version 20.0.0 (Current) #47381 https://github.com/nodejs/node/pull/47381
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 6, 2023 https://github.com/nodejs/node/pull/47079#ref-pullrequest-1656565377
v19.9.0 proposal #47441 https://github.com/nodejs/node/pull/47441
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
backport-blocked-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v18.x
Jun 12, 2023https://github.com/nodejs/node/pull/47079#event-9496443179
targoshttps://github.com/targos
Nov 10, 2023 https://github.com/nodejs/node/pull/47079#ref-commit-3552afb
https://github.com/kvakil
https://github.com/targos
src: fix duplication of externalized builtin codehttps://github.com/nodejs/node/commit/3552afb904ae8dcfc3b63bf9c635d3c6f7c82b07
3552afbhttps://github.com/nodejs/node/commit/3552afb904ae8dcfc3b63bf9c635d3c6f7c82b07
#45942https://github.com/nodejs/node/pull/45942
#47079https://github.com/nodejs/node/pull/47079
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/47079#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/47079#ref-commit-56fe11b
https://github.com/sercher
src: fix duplication of externalized builtin codehttps://github.com/sercher/graaljs/commit/56fe11bb1912d3af1401464b4e44123f0e6416f6
56fe11bhttps://github.com/sercher/graaljs/commit/56fe11bb1912d3af1401464b4e44123f0e6416f6
nodejs/node#45942https://github.com/nodejs/node/pull/45942
nodejs/node#47079https://github.com/nodejs/node/pull/47079
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/47079#ref-commit-591699b
https://github.com/sercher
src: fix duplication of externalized builtin codehttps://github.com/sercher/graaljs/commit/591699be83f7fd5a479199b9f35da947ff5eb0bc
591699bhttps://github.com/sercher/graaljs/commit/591699be83f7fd5a479199b9f35da947ff5eb0bc
nodejs/node#45942https://github.com/nodejs/node/pull/45942
nodejs/node#47079https://github.com/nodejs/node/pull/47079
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F47079
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/47079/files/fd3252ef580a8bd4013217bff9b144069e8f917f
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/47079/files/fd3252ef580a8bd4013217bff9b144069e8f917f
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/47079/files/fd3252ef580a8bd4013217bff9b144069e8f917f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/47079
https://github.com/kvakil
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/danielleadams
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.