René's URL Explorer Experiment


Title: test_runner: support handling errors from outside of tests by cjihrig · Pull Request #46962 · nodejs/node · GitHub

Open Graph Title: test_runner: support handling errors from outside of tests by cjihrig · Pull Request #46962 · nodejs/node

X Title: test_runner: support handling errors from outside of tests by cjihrig · Pull Request #46962 · nodejs/node

Description: test_runner: give the root test a harness reference This commit replaces the 'coverage' reference inside of the Test class with a more generic harness reference which includes coverage. This will let the root test more easily track process level state such as code coverage, uncaughtException handlers, and the state of bootstrapping. test_runner: track bootstrapping process This commit updates the test harness and root test to track when bootstrapping has completed. test_runner: throw if harness is not bootstrapped This commit updates the test harness to re-throw uncaught errors if bootstrapping has not completed. This updates the existing logic which tried to detect a specific error code. test_runner: handle errors not bound to tests This commit addresses a previously untested branch of the code. It is possible when using the test runner that an error occurs outside of a test. In this case, the test runner would simply rethrow the error. This commit updates the logic to handle the error in the same fashion as other uncaughtExceptions.

Open Graph Description: test_runner: give the root test a harness reference This commit replaces the 'coverage' reference inside of the Test class with a more generic harness reference which includes coverage. Thi...

X Description: test_runner: give the root test a harness reference This commit replaces the 'coverage' reference inside of the Test class with a more generic harness reference which includes cover...

Opengraph URL: https://github.com/nodejs/node/pull/46962

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:7e742f1b-be0b-ff5d-f279-72820c7aafdf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8590:167CFE:193BD4:22A320:69976358
html-safe-noncec15f4b04872bede06668d5cd11fa4a947c60f2d673029558ed622504bf567d4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTkwOjE2N0NGRToxOTNCRDQ6MjJBMzIwOjY5OTc2MzU4IiwidmlzaXRvcl9pZCI6Ijc1MTc0MTkzNjA4OTE2NTkwOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac17ca760e18780f0b28d59ce4cebb80fae506e0227e7c8d4318acd5b10ce6e451
hovercard-subject-tagpull_request:1263499210
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
twitter:imagehttps://avatars.githubusercontent.com/u/2512748?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2512748?s=400&v=4
og:image:alttest_runner: give the root test a harness reference This commit replaces the 'coverage' reference inside of the Test class with a more generic harness reference which includes coverage. Thi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec2f6b9675e9141deef3eda21e5cb896d461bd4d25aeaeeba804502ef0e8d01f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb05d982477497a3bcc7dafa43a01757894c08f44
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46962%2Fcommits%2F3d63d5333ddf6b08e123e1ebdace1a5600f24c80
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46962%2Fcommits%2F3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Reloadhttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Reloadhttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
cjihrighttps://github.com/cjihrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
cjihrig:harnesshttps://github.com/cjihrig/node/tree/harness
Conversation 11 https://github.com/nodejs/node/pull/46962
Commits 4 https://github.com/nodejs/node/pull/46962/commits
Checks 0 https://github.com/nodejs/node/pull/46962/checks
Files changed https://github.com/nodejs/node/pull/46962/files
Please reload this pagehttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
test_runner: support handling errors from outside of tests https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#top
Show all changes 4 commits https://github.com/nodejs/node/pull/46962/files
b191f09 test_runner: give the root test a harness reference cjihrig Mar 5, 2023 https://github.com/nodejs/node/pull/46962/commits/b191f09e6ee7d40798454e8545d83e53cab0e63c
4e3bc06 test_runner: track bootstrapping process cjihrig Mar 5, 2023 https://github.com/nodejs/node/pull/46962/commits/4e3bc06e6547c1d640111b73e80e198ba03f7e45
e079aa8 test_runner: throw if harness is not bootstrapped cjihrig Mar 5, 2023 https://github.com/nodejs/node/pull/46962/commits/e079aa80f05be11f4674f3caeb5d63c298126a6e
3d63d53 test_runner: handle errors not bound to tests cjihrig Feb 16, 2023 https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Clear filters https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Please reload this pagehttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
Please reload this pagehttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
harness.js https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
test_runner_output.js https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-a826c8e449eda053fbe1bbbf3012d5278267f550d74a5bb8118f0a82eb65da17
test_runner_output.out https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-d42cb70251f79ed2a564693aa98db0154850258570fdd1f90499cf304cc8b174
test_runner_output_cli.out https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-47aa0083df533cd39e98dee4bb74923bb4e5d9e24a1eb59fad6b69c6360a0da8
test_runner_output_spec_reporter.out https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-cc50dabe10f79c293fa4deb06a17157c66a50114b61a42c65d2df08b3de53770
Prev https://github.com/nodejs/node/pull/46962/commits/e079aa80f05be11f4674f3caeb5d63c298126a6e
#46962https://github.com/nodejs/node/pull/46962
Please reload this pagehttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
https://github.com/cjihrig
cjihrighttps://github.com/nodejs/node/commits?author=cjihrig
lib/internal/test_runner/harness.jshttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
View file https://github.com/cjihrig/node/blob/3d63d5333ddf6b08e123e1ebdace1a5600f24c80/lib/internal/test_runner/harness.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/46962/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
Please reload this pagehttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-b05fccdd396676d2cafa05396439532ca4ccf77723384065cca8eaac5dec239c
test/message/test_runner_output.jshttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-a826c8e449eda053fbe1bbbf3012d5278267f550d74a5bb8118f0a82eb65da17
View file https://github.com/cjihrig/node/blob/3d63d5333ddf6b08e123e1ebdace1a5600f24c80/test/message/test_runner_output.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/46962/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-a826c8e449eda053fbe1bbbf3012d5278267f550d74a5bb8118f0a82eb65da17
test/message/test_runner_output.outhttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-d42cb70251f79ed2a564693aa98db0154850258570fdd1f90499cf304cc8b174
View file https://github.com/cjihrig/node/blob/3d63d5333ddf6b08e123e1ebdace1a5600f24c80/test/message/test_runner_output.out
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/46962/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-d42cb70251f79ed2a564693aa98db0154850258570fdd1f90499cf304cc8b174
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-d42cb70251f79ed2a564693aa98db0154850258570fdd1f90499cf304cc8b174
test/message/test_runner_output_cli.outhttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-47aa0083df533cd39e98dee4bb74923bb4e5d9e24a1eb59fad6b69c6360a0da8
View file https://github.com/cjihrig/node/blob/3d63d5333ddf6b08e123e1ebdace1a5600f24c80/test/message/test_runner_output_cli.out
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/46962/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-47aa0083df533cd39e98dee4bb74923bb4e5d9e24a1eb59fad6b69c6360a0da8
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-47aa0083df533cd39e98dee4bb74923bb4e5d9e24a1eb59fad6b69c6360a0da8
test/message/test_runner_output_spec_reporter.outhttps://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-cc50dabe10f79c293fa4deb06a17157c66a50114b61a42c65d2df08b3de53770
View file https://github.com/cjihrig/node/blob/3d63d5333ddf6b08e123e1ebdace1a5600f24c80/test/message/test_runner_output_spec_reporter.out
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/46962/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-cc50dabe10f79c293fa4deb06a17157c66a50114b61a42c65d2df08b3de53770
https://github.com/nodejs/node/pull/46962/commits/3d63d5333ddf6b08e123e1ebdace1a5600f24c80#diff-cc50dabe10f79c293fa4deb06a17157c66a50114b61a42c65d2df08b3de53770
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.