René's URL Explorer Experiment


Title: src: fix useless call in permission.cc by tniessen · Pull Request #46833 · nodejs/node · GitHub

Open Graph Title: src: fix useless call in permission.cc by tniessen · Pull Request #46833 · nodejs/node

X Title: src: fix useless call in permission.cc by tniessen · Pull Request #46833 · nodejs/node

Description: FromMaybe() has no side effects and the return value is ignored. Use Check() instead to ensure that the operation succeeded.

Open Graph Description: FromMaybe() has no side effects and the return value is ignored. Use Check() instead to ensure that the operation succeeded.

X Description: FromMaybe() has no side effects and the return value is ignored. Use Check() instead to ensure that the operation succeeded.

Opengraph URL: https://github.com/nodejs/node/pull/46833

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:21abaaed-0731-66da-9118-8d1e696fc9ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id833C:279B15:E820AC:13EDD64:6969EFF3
html-safe-noncecea728e1b56fbd6ec101648276c1ec26a0b3621a65a3b268fcddc142e6af5c28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzNDOjI3OUIxNTpFODIwQUM6MTNFREQ2NDo2OTY5RUZGMyIsInZpc2l0b3JfaWQiOiIzMzMzMjQ5ODY4Nzk5NTM3MTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace885c6a0ed0adbedd96f5c9c6bcbef40cea7db81b171e5b7ea364b0033a0fd80
hovercard-subject-tagpull_request:1254214180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46833/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aeb24f753dc25dd4a4f32596d85fa7aa7481bf0b3c91a301d8209ba6dfbafcbd/nodejs/node/pull/46833
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aeb24f753dc25dd4a4f32596d85fa7aa7481bf0b3c91a301d8209ba6dfbafcbd/nodejs/node/pull/46833
og:image:altFromMaybe() has no side effects and the return value is ignored. Use Check() instead to ensure that the operation succeeded.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/46833#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46833
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46833
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/46833
Reloadhttps://github.com/nodejs/node/pull/46833
Reloadhttps://github.com/nodejs/node/pull/46833
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/46833
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/46833
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/46833#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:src-permission-throwaccessdenied-useless-callhttps://github.com/tniessen/node/tree/src-permission-throwaccessdenied-useless-call
src: fix useless call in permission.cc https://github.com/nodejs/node/pull/46833#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:src-permission-throwaccessdenied-useless-callhttps://github.com/tniessen/node/tree/src-permission-throwaccessdenied-useless-call
Conversation 8 https://github.com/nodejs/node/pull/46833
Commits 1 https://github.com/nodejs/node/pull/46833/commits
Checks 0 https://github.com/nodejs/node/pull/46833/checks
Files changed https://github.com/nodejs/node/pull/46833/files
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 25, 2023https://github.com/nodejs/node/pull/46833#issue-1599711356
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/tniessen
tniessenhttps://github.com/tniessen
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
Feb 25, 2023https://github.com/nodejs/node/pull/46833#event-8607932558
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Feb 25, 2023https://github.com/nodejs/node/pull/46833#event-8607932830
https://github.com/Trott
Trotthttps://github.com/Trott
Feb 25, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314533333
View reviewed changes https://github.com/nodejs/node/pull/46833/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 25, 2023https://github.com/nodejs/node/pull/46833#event-8608067197
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 25, 2023https://github.com/nodejs/node/pull/46833#event-8608074752
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46833
https://github.com/apapirovski
apapirovskihttps://github.com/apapirovski
Feb 25, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314537040
View reviewed changes https://github.com/nodejs/node/pull/46833/files
https://github.com/anonrig
anonrighttps://github.com/anonrig
Feb 25, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314537802
View reviewed changes https://github.com/nodejs/node/pull/46833/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 25, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314548505
View reviewed changes https://github.com/nodejs/node/pull/46833/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/46833#pullrequestreview-1314548505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 25, 2023https://github.com/nodejs/node/pull/46833#issuecomment-1445176024
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 25, 2023https://github.com/nodejs/node/pull/46833#issuecomment-1445196611
Please reload this pagehttps://github.com/nodejs/node/pull/46833
@tniessenhttps://github.com/tniessen
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Feb 25, 2023https://github.com/nodejs/node/pull/46833#issuecomment-1445196753
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/tniessen
src: fix useless call in permission.cchttps://github.com/nodejs/node/pull/46833/commits/0e95c5a35f719559c56f56783fd4a435a3587e8e
0e95c5ahttps://github.com/nodejs/node/pull/46833/commits/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/tniessen
tniessenhttps://github.com/tniessen
force-pushedhttps://github.com/nodejs/node/compare/598986998cd6140400d113bc29bfab3d147bae00..0e95c5a35f719559c56f56783fd4a435a3587e8e
5989869https://github.com/nodejs/node/commit/598986998cd6140400d113bc29bfab3d147bae00
0e95c5ahttps://github.com/nodejs/node/commit/0e95c5a35f719559c56f56783fd4a435a3587e8e
Compare https://github.com/nodejs/node/compare/598986998cd6140400d113bc29bfab3d147bae00..0e95c5a35f719559c56f56783fd4a435a3587e8e
February 25, 2023 21:37https://github.com/nodejs/node/pull/46833#event-8608562267
https://github.com/tniessen
tniessenhttps://github.com/tniessen
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 25, 2023https://github.com/nodejs/node/pull/46833#event-8608562638
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 25, 2023https://github.com/nodejs/node/pull/46833#event-8608566156
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 25, 2023https://github.com/nodejs/node/pull/46833#issuecomment-1445212202
https://ci.nodejs.org/job/node-test-pull-request/50006/https://ci.nodejs.org/job/node-test-pull-request/50006/
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 25, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314591907
View reviewed changes https://github.com/nodejs/node/pull/46833/files/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Feb 26, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314619158
View reviewed changes https://github.com/nodejs/node/pull/46833/files/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 26, 2023https://github.com/nodejs/node/pull/46833#issuecomment-1445317139
https://ci.nodejs.org/job/node-test-pull-request/50017/https://ci.nodejs.org/job/node-test-pull-request/50017/
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Feb 26, 2023https://github.com/nodejs/node/pull/46833#event-8609617641
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Feb 26, 2023 https://github.com/nodejs/node/pull/46833#pullrequestreview-1314690807
View reviewed changes https://github.com/nodejs/node/pull/46833/files/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 27, 2023 https://github.com/nodejs/node/pull/46833#ref-issue-1600259877
CI Reliability 2023-02-27 nodejs/reliability#508 https://github.com/nodejs/reliability/issues/508
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Feb 27, 2023https://github.com/nodejs/node/pull/46833#event-8615853318
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
3abbc38https://github.com/nodejs/node/commit/3abbc3829aeb7844eec8ccbfe2cc05cf5fcc4982
Feb 27, 2023https://github.com/nodejs/node/pull/46833#event-8615854057
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 27, 2023https://github.com/nodejs/node/pull/46833#issuecomment-1446341122
3abbc38https://github.com/nodejs/node/commit/3abbc3829aeb7844eec8ccbfe2cc05cf5fcc4982
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 28, 2023 https://github.com/nodejs/node/pull/46833#ref-issue-1602157993
CI Reliability 2023-02-28 nodejs/reliability#509 https://github.com/nodejs/reliability/issues/509
targoshttps://github.com/targos
Mar 13, 2023 https://github.com/nodejs/node/pull/46833#ref-commit-1760ae4
https://github.com/tniessen
https://github.com/targos
src: fix useless call in permission.cchttps://github.com/nodejs/node/commit/1760ae42c02dc6a6d713c019a86448d9c994ccc8
1760ae4https://github.com/nodejs/node/commit/1760ae42c02dc6a6d713c019a86448d9c994ccc8
#46833https://github.com/nodejs/node/pull/46833
https://github.com/targos
targoshttps://github.com/targos
backport-blocked-v19.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v19.x
Mar 14, 2023https://github.com/nodejs/node/pull/46833#event-8739862827
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Apr 3, 2023 https://github.com/nodejs/node/pull/46833#ref-pullrequest-1651807011
2023-04-18, Version 20.0.0 (Current) #47381 https://github.com/nodejs/node/pull/47381
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
backport-blocked-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v16.x
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
backport-blocked-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v16.x
Apr 3, 2023https://github.com/nodejs/node/pull/46833#event-8913004762
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46833
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/46833/files/598986998cd6140400d113bc29bfab3d147bae00
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/46833/files/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/46833/files/598986998cd6140400d113bc29bfab3d147bae00
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/46833/files/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/46833/files/0e95c5a35f719559c56f56783fd4a435a3587e8e
https://github.com/apapirovski
apapirovski https://github.com/apapirovski
https://github.com/nodejs/node/pull/46833/files/598986998cd6140400d113bc29bfab3d147bae00
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
experimental https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aexperimental
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/46833
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/apapirovski
https://github.com/Trott
https://github.com/anonrig
https://github.com/cjihrig
https://github.com/RaisinTen
https://github.com/targos
https://github.com/RafaelGSS
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.