| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:883f9d16-c0eb-a244-a87c-ff5a24baa3bb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9EC2:96FA2:28229A:362584:6969CCD5 |
| html-safe-nonce | 016559e206a1a1735731d836ea3bcc2c342c73f50af57968fa3da12d8ee948ca |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUMyOjk2RkEyOjI4MjI5QTozNjI1ODQ6Njk2OUNDRDUiLCJ2aXNpdG9yX2lkIjoiNTM3MDgzMDY0NjYzNDIwNDM3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9a18a60613d79bca942f8153caebae158fe630a78c23480e078973bf7ccd3a24 |
| hovercard-subject-tag | pull_request:1241178621 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46658/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/55a36f4001885b9cf2eaf8ddba878c75c0e7389c08a85a6ca9e3a78aa3c53496/nodejs/node/pull/46658 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/55a36f4001885b9cf2eaf8ddba878c75c0e7389c08a85a6ca9e3a78aa3c53496/nodejs/node/pull/46658 |
| og:image:alt | The first commits comes from #46620
benchmark: stablize encode benchmark
Increase the number of iteration to 1e6 to reduce flakes. 1e4
can introduce flakes even when comparing the main branch
agai... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/46658#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46658 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46658 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/46658 |
| Reload | https://github.com/nodejs/node/pull/46658 |
| Reload | https://github.com/nodejs/node/pull/46658 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/46658#issue-comment-box |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| joyeecheung:encode | https://github.com/joyeecheung/node/tree/encode |
|
encoding: use AliasedUint32Array for encodeInto results
| https://github.com/nodejs/node/pull/46658#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| joyeecheung:encode | https://github.com/joyeecheung/node/tree/encode |
|
Conversation
25
| https://github.com/nodejs/node/pull/46658 |
|
Commits
5
| https://github.com/nodejs/node/pull/46658/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/46658/checks |
|
Files changed
| https://github.com/nodejs/node/pull/46658/files |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 14, 2023 | https://github.com/nodejs/node/pull/46658#issue-1584828901 |
| #46620 | https://github.com/nodejs/node/pull/46620 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 14, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1430374817 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Feb 14, 2023 | https://github.com/nodejs/node/pull/46658#event-8519748920 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Feb 14, 2023 | https://github.com/nodejs/node/pull/46658#event-8520239071 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Feb 14, 2023
| https://github.com/nodejs/node/pull/46658#pullrequestreview-1298508017 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46658/files |
| src/encoding.h | https://github.com/nodejs/node/pull/46658/files#diff-191698cb65e0381a3f8bd0f5ddf5abd07e8af92257c61961afdc15365ceaf5d2 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| src/node_binding.cc | https://github.com/nodejs/node/pull/46658/files#diff-cea6643957d66774731d8224242d6e052f3da9198fbb1fa5afb7e91b896b4cc0 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| lib/internal/encoding.js | https://github.com/nodejs/node/pull/46658/files#diff-bd5ca5b3bb337c44d0c11c2e0eaef432332dcdf6eaf65a6b4171a7b3380720a3 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| src/env-inl.h | https://github.com/nodejs/node/pull/46658/files#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Feb 14, 2023
| https://github.com/nodejs/node/pull/46658#pullrequestreview-1298569856 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46658/files |
| benchmark/util/text-encoder.js | https://github.com/nodejs/node/pull/46658/files#diff-eb22e40d5cc2c612db58601860bb86621442746946db7b8140952d78b349bad0 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/535e1bf4545f2fddbf558e9bc96be304cc4dc55f..86b9a0ba7307d8e003c8470ea2a4237b18aef7ba |
| 535e1bf | https://github.com/nodejs/node/commit/535e1bf4545f2fddbf558e9bc96be304cc4dc55f |
| 86b9a0b | https://github.com/nodejs/node/commit/86b9a0ba7307d8e003c8470ea2a4237b18aef7ba |
|
Compare
| https://github.com/nodejs/node/compare/535e1bf4545f2fddbf558e9bc96be304cc4dc55f..86b9a0ba7307d8e003c8470ea2a4237b18aef7ba |
| February 15, 2023 01:40 | https://github.com/nodejs/node/pull/46658#event-8521265526 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 20, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1437194267 |
| https://ci.nodejs.org/job/node-test-pull-request/49791/ | https://ci.nodejs.org/job/node-test-pull-request/49791/ |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
CI Reliability 2023-02-21
nodejs/reliability#502
| https://github.com/nodejs/reliability/issues/502 |
|
CI Reliability 2023-02-22
nodejs/reliability#503
| https://github.com/nodejs/reliability/issues/503 |
|
| https://github.com/joyeecheung |
| benchmark: stablize encode benchmark | https://github.com/nodejs/node/pull/46658/commits/29ef3b06f75545177cc7f7040fb256970489339e |
| 29ef3b0 | https://github.com/nodejs/node/pull/46658/commits/29ef3b06f75545177cc7f7040fb256970489339e |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/86b9a0ba7307d8e003c8470ea2a4237b18aef7ba..06584ccfcbdd77c1700e39c1c710c3d859f58977 |
| 86b9a0b | https://github.com/nodejs/node/commit/86b9a0ba7307d8e003c8470ea2a4237b18aef7ba |
| 06584cc | https://github.com/nodejs/node/commit/06584ccfcbdd77c1700e39c1c710c3d859f58977 |
|
Compare
| https://github.com/nodejs/node/compare/86b9a0ba7307d8e003c8470ea2a4237b18aef7ba..06584ccfcbdd77c1700e39c1c710c3d859f58977 |
| February 28, 2023 14:38 | https://github.com/nodejs/node/pull/46658#event-8627728346 |
| joyeecheung | https://github.com/joyeecheung |
| February 28, 2023 15:41 | https://github.com/nodejs/node/pull/46658#commits-pushed-57bb217 |
|
| https://github.com/joyeecheung |
| src: move encoding bindings to a new binding | https://github.com/nodejs/node/pull/46658/commits/57bb2177405cbb7f5216d31351b59eaf39f567f9 |
| 57bb217 | https://github.com/nodejs/node/pull/46658/commits/57bb2177405cbb7f5216d31351b59eaf39f567f9 |
|
| https://github.com/joyeecheung |
| encoding: use AliasedUint32Array for encodeInto results | https://github.com/nodejs/node/pull/46658/commits/9b54d805cea39244fdfb9c1d6a3542d2f076782a |
| 9b54d80 | https://github.com/nodejs/node/pull/46658/commits/9b54d805cea39244fdfb9c1d6a3542d2f076782a |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/06584ccfcbdd77c1700e39c1c710c3d859f58977..9b54d805cea39244fdfb9c1d6a3542d2f076782a |
| 06584cc | https://github.com/nodejs/node/commit/06584ccfcbdd77c1700e39c1c710c3d859f58977 |
| 9b54d80 | https://github.com/nodejs/node/commit/9b54d805cea39244fdfb9c1d6a3542d2f076782a |
|
Compare
| https://github.com/nodejs/node/compare/06584ccfcbdd77c1700e39c1c710c3d859f58977..9b54d805cea39244fdfb9c1d6a3542d2f076782a |
| February 28, 2023 14:41 | https://github.com/nodejs/node/pull/46658#event-8627755130 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 28, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1448304017 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 28, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1448304494 |
| https://ci.nodejs.org/job/node-test-pull-request/50104/ | https://ci.nodejs.org/job/node-test-pull-request/50104/ |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
CI Reliability 2023-03-01
nodejs/reliability#510
| https://github.com/nodejs/reliability/issues/510 |
|
CI Reliability 2023-03-02
nodejs/reliability#511
| https://github.com/nodejs/reliability/issues/511 |
|
CI Reliability 2023-03-03
nodejs/reliability#512
| https://github.com/nodejs/reliability/issues/512 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 3, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1453780483 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
CI Reliability 2023-03-04
nodejs/reliability#513
| https://github.com/nodejs/reliability/issues/513 |
|
CI Reliability 2023-03-05
nodejs/reliability#514
| https://github.com/nodejs/reliability/issues/514 |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
|
Mar 6, 2023
| https://github.com/nodejs/node/pull/46658#pullrequestreview-1325683291 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46658/files/9b54d805cea39244fdfb9c1d6a3542d2f076782a |
| RaisinTen | https://github.com/RaisinTen |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/nodejs/node/pull/46658#pullrequestreview-1325683291 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 7, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1458052274 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
| https://github.com/joyeecheung |
| fixup! encoding: use AliasedUint32Array for encodeInto results | https://github.com/nodejs/node/pull/46658/commits/1233e7fef547e676073f87703e48b82705b41fb9 |
| 1233e7f | https://github.com/nodejs/node/pull/46658/commits/1233e7fef547e676073f87703e48b82705b41fb9 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 7, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1458513232 |
| https://ci.nodejs.org/job/node-test-pull-request/50249/ | https://ci.nodejs.org/job/node-test-pull-request/50249/ |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
| https://github.com/joyeecheung |
| fixup! src: move encoding bindings to a new binding | https://github.com/nodejs/node/pull/46658/commits/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
| 4ea7f2e | https://github.com/nodejs/node/pull/46658/commits/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/ea70ca87e832a5410e4fada4e11e57aa8b3f7ce7..4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
| ea70ca8 | https://github.com/nodejs/node/commit/ea70ca87e832a5410e4fada4e11e57aa8b3f7ce7 |
| 4ea7f2e | https://github.com/nodejs/node/commit/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
|
Compare
| https://github.com/nodejs/node/compare/ea70ca87e832a5410e4fada4e11e57aa8b3f7ce7..4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
| March 7, 2023 16:59 | https://github.com/nodejs/node/pull/46658#event-8688257927 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 7, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1458752438 |
| https://ci.nodejs.org/job/node-test-pull-request/50258/ | https://ci.nodejs.org/job/node-test-pull-request/50258/ |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| joyeecheung | https://github.com/joyeecheung |
|
Mar 7, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-044021d |
|
| https://github.com/joyeecheung |
| benchmark: stablize encode benchmark | https://github.com/nodejs/node/commit/044021d341cf108e7eda3e410822dae6b98a8a51 |
| 044021d | https://github.com/nodejs/node/commit/044021d341cf108e7eda3e410822dae6b98a8a51 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| joyeecheung | https://github.com/joyeecheung |
|
Mar 7, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-25c2186 |
|
| https://github.com/joyeecheung |
| src: move encoding bindings to a new binding | https://github.com/nodejs/node/commit/25c21868b8d16392835454f57bb465157661f199 |
| 25c2186 | https://github.com/nodejs/node/commit/25c21868b8d16392835454f57bb465157661f199 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| joyeecheung | https://github.com/joyeecheung |
|
Mar 7, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-e5933c8 |
|
| https://github.com/joyeecheung |
| src: use AliasedUint32Array for encodeInto results | https://github.com/nodejs/node/commit/e5933c83257b2ed4b2e71998837fd2da2b548a16 |
| e5933c8 | https://github.com/nodejs/node/commit/e5933c83257b2ed4b2e71998837fd2da2b548a16 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 7, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1458926741 |
| 3b0c047...e5933c8 | https://github.com/nodejs/node/compare/3b0c047c31eaa65294181c1df7ab49429c477d71...e5933c83257b2ed4b2e71998837fd2da2b548a16 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 7, 2023 | https://github.com/nodejs/node/pull/46658#event-8690833540 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Mar 8, 2023
| https://github.com/nodejs/node/pull/46658#ref-issue-1614418272 |
|
CI Reliability 2023-03-08
nodejs/reliability#517
| https://github.com/nodejs/reliability/issues/517 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
| Mar 8, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1459092543 |
| #47007 | https://github.com/nodejs/node/pull/47007 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Mar 8, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1459097135 |
| #47003 | https://github.com/nodejs/node/pull/47003 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 8, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1459140625 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://ci.nodejs.org/job/node-test-pull-request/50258/ | https://ci.nodejs.org/job/node-test-pull-request/50258/ |
| 4ea7f2e | https://github.com/nodejs/node/commit/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
CI Reliability 2023-03-09
nodejs/reliability#518
| https://github.com/nodejs/reliability/issues/518 |
|
CI Reliability 2023-03-10
nodejs/reliability#519
| https://github.com/nodejs/reliability/issues/519 |
|
CI Reliability 2023-03-11
nodejs/reliability#520
| https://github.com/nodejs/reliability/issues/520 |
|
CI Reliability 2023-03-12
nodejs/reliability#521
| https://github.com/nodejs/reliability/issues/521 |
|
CI Reliability 2023-03-13
nodejs/reliability#522
| https://github.com/nodejs/reliability/issues/522 |
| targos | https://github.com/targos |
|
Mar 13, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-d654f46 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| benchmark: stablize encode benchmark | https://github.com/nodejs/node/commit/d654f467892de257bd9d6629e2f44adaa510ed21 |
| d654f46 | https://github.com/nodejs/node/commit/d654f467892de257bd9d6629e2f44adaa510ed21 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| targos | https://github.com/targos |
|
Mar 13, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-db4fa93 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: move encoding bindings to a new binding | https://github.com/nodejs/node/commit/db4fa93d9484d9e3160ca822ff133d2bdd082513 |
| db4fa93 | https://github.com/nodejs/node/commit/db4fa93d9484d9e3160ca822ff133d2bdd082513 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| targos | https://github.com/targos |
|
Mar 13, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-7ec0dcb |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: use AliasedUint32Array for encodeInto results | https://github.com/nodejs/node/commit/7ec0dcb28045845bafcfdc27b8479962f849b876 |
| 7ec0dcb | https://github.com/nodejs/node/commit/7ec0dcb28045845bafcfdc27b8479962f849b876 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-0617c5e |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| benchmark: stablize encode benchmark | https://github.com/nodejs/node/commit/0617c5e81b91c2501ef769a427b43671cf9f441a |
| 0617c5e | https://github.com/nodejs/node/commit/0617c5e81b91c2501ef769a427b43671cf9f441a |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-dcba3a0 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: move encoding bindings to a new binding | https://github.com/nodejs/node/commit/dcba3a06735075b17acf7158d098217b6f5ead26 |
| dcba3a0 | https://github.com/nodejs/node/commit/dcba3a06735075b17acf7158d098217b6f5ead26 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-6b60f38 |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| src: use AliasedUint32Array for encodeInto results | https://github.com/nodejs/node/commit/6b60f386761ca1aef68a287deae5ca5fd68b58f7 |
| 6b60f38 | https://github.com/nodejs/node/commit/6b60f386761ca1aef68a287deae5ca5fd68b58f7 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46658#ref-pullrequest-1622922231 |
|
v19.8.0 release proposal
#47087
| https://github.com/nodejs/node/pull/47087 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
| Apr 3, 2023 | https://github.com/nodejs/node/pull/46658#issuecomment-1493642722 |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Apr 3, 2023 | https://github.com/nodejs/node/pull/46658#event-8908270723 |
| https://github.com/debadree25 |
| debadree25 | https://github.com/debadree25 |
|
May 5, 2023
| https://github.com/nodejs/node/pull/46658#pullrequestreview-1414484149 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46658/files/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
| src/encoding_binding.cc | https://github.com/nodejs/node/pull/46658/files/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e#diff-ae2f36d44cbc7f412b2dacfc1ccc7d741068d10372843a31e3deee89bf09ff6e |
| debadree25 | https://github.com/debadree25 |
| May 5, 2023 | https://github.com/nodejs/node/pull/46658#discussion_r1185900874 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @anonrig | https://github.com/anonrig |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
| targos | https://github.com/targos |
|
Nov 10, 2023
| https://github.com/nodejs/node/pull/46658#ref-commit-24d3fcf |
|
| https://github.com/joyeecheung |
|
| https://github.com/targos |
| benchmark: stablize encode benchmark | https://github.com/nodejs/node/commit/24d3fcf415ba83fdfbd9d8f971c58d0969a03fc1 |
| 24d3fcf | https://github.com/nodejs/node/commit/24d3fcf415ba83fdfbd9d8f971c58d0969a03fc1 |
| #46658 | https://github.com/nodejs/node/pull/46658 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/46658#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/46658#ref-commit-bf4207c |
|
| https://github.com/sercher |
| benchmark: stablize encode benchmark | https://github.com/sercher/graaljs/commit/bf4207cf4e02aafab54393c89c8c527be68a2de2 |
| bf4207c | https://github.com/sercher/graaljs/commit/bf4207cf4e02aafab54393c89c8c527be68a2de2 |
| nodejs/node#46658 | https://github.com/nodejs/node/pull/46658 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/46658#ref-commit-710b0ac |
|
| https://github.com/sercher |
| benchmark: stablize encode benchmark | https://github.com/sercher/graaljs/commit/710b0ac680f0a8078361251ebd812b71d0263a92 |
| 710b0ac | https://github.com/sercher/graaljs/commit/710b0ac680f0a8078361251ebd812b71d0263a92 |
| nodejs/node#46658 | https://github.com/nodejs/node/pull/46658 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46658 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/46658/files/535e1bf4545f2fddbf558e9bc96be304cc4dc55f |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/46658/files/535e1bf4545f2fddbf558e9bc96be304cc4dc55f |
|
| https://github.com/debadree25 |
|
debadree25
| https://github.com/debadree25 |
|
| https://github.com/nodejs/node/pull/46658/files/4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/nodejs/node/pull/46658/files/9b54d805cea39244fdfb9c1d6a3542d2f076782a |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
performance
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance |
| Please reload this page | https://github.com/nodejs/node/pull/46658 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/MoLow |
|
| https://github.com/cjihrig |
|
| https://github.com/danielleadams |
|
| https://github.com/anonrig |
|
| https://github.com/BridgeAR |
|
| https://github.com/debadree25 |
|
| https://github.com/RaisinTen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |