| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b301b6dc-adbe-e21b-59b6-b863a09d4dcb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9808:31EA40:BD99F3:1036198:6969F055 |
| html-safe-nonce | 9cb61047b2f4c4847edb991ee24e32dc2ef32e014c536c75ff9c9950f771a840 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODA4OjMxRUE0MDpCRDk5RjM6MTAzNjE5ODo2OTY5RjA1NSIsInZpc2l0b3JfaWQiOiI2MjM0OTAyNDc5NDU5OTcxMTU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1d51e8839b02daa49be8a1b36af285097bcc96c6dd60f1352d23fad58a1a6956 |
| hovercard-subject-tag | pull_request:1235305760 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46587/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4428ca9c546d8738831e8db2ea44d6dd7df9e4e0569ed7e0619cd9bfebd54223/nodejs/node/pull/46587 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4428ca9c546d8738831e8db2ea44d6dd7df9e4e0569ed7e0619cd9bfebd54223/nodejs/node/pull/46587 |
| og:image:alt | This PR reworks the implementation of autoSelectFamily in net.connect to better swap internal TCPWrap when the connection is successful. It also fixes several issues with TLS.
It also add a global ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ShogunPanda |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/46587#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46587 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46587 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/46587 |
| Reload | https://github.com/nodejs/node/pull/46587 |
| Reload | https://github.com/nodejs/node/pull/46587 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/46587#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| ShogunPanda:autoselectfamily-default-on | https://github.com/ShogunPanda/node/tree/autoselectfamily-default-on |
|
net: rework autoSelectFamily implementation
| https://github.com/nodejs/node/pull/46587#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| ShogunPanda:autoselectfamily-default-on | https://github.com/ShogunPanda/node/tree/autoselectfamily-default-on |
|
Conversation
81
| https://github.com/nodejs/node/pull/46587 |
|
Commits
1
| https://github.com/nodejs/node/pull/46587/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/46587/checks |
|
Files changed
| https://github.com/nodejs/node/pull/46587/files |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 9, 2023 | https://github.com/nodejs/node/pull/46587#issue-1578109596 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| #46669 | https://github.com/nodejs/node/issues/46669 |
| #46679 | https://github.com/nodejs/node/issues/46679 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Feb 9, 2023 | https://github.com/nodejs/node/pull/46587#event-8480692571 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 9, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1424374825 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Feb 9, 2023 | https://github.com/nodejs/node/pull/46587#event-8480695706 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| February 9, 2023 15:30 | https://github.com/nodejs/node/pull/46587#event-8480717684 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 9, 2023
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1291452820 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46587/files |
| src/node_options.cc | https://github.com/nodejs/node/pull/46587/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Feb 9, 2023
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1291581028 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46587/files |
| anonrig | https://github.com/anonrig |
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1291581028 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Feb 11, 2023
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1294589010 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46587/files |
| doc/api/net.md | https://github.com/nodejs/node/pull/46587/files#diff-d76469e9e7f555294a7a5488c5c8fc4ef8ce5aea448cc26a1322d1ab693e09ca |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| doc/api/net.md | https://github.com/nodejs/node/pull/46587/files#diff-d76469e9e7f555294a7a5488c5c8fc4ef8ce5aea448cc26a1322d1ab693e09ca |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
tsc-agenda
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda |
| Feb 11, 2023 | https://github.com/nodejs/node/pull/46587#event-8497216615 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Feb 11, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426861795 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 11, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426862249 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Feb 11, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426862380 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 11, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426864048 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Feb 11, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426892626 |
| @ShogunPanda | https://github.com/ShogunPanda |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 12, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426902863 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Feb 12, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1426908608 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/f4ffcb895abad3595d119074e3424cd8f3f27e2c..c8b5f22bf37c38d8a288cb3a4aff19d39d99dcb3 |
| f4ffcb8 | https://github.com/nodejs/node/commit/f4ffcb895abad3595d119074e3424cd8f3f27e2c |
| c8b5f22 | https://github.com/nodejs/node/commit/c8b5f22bf37c38d8a288cb3a4aff19d39d99dcb3 |
|
Compare
| https://github.com/nodejs/node/compare/f4ffcb895abad3595d119074e3424cd8f3f27e2c..c8b5f22bf37c38d8a288cb3a4aff19d39d99dcb3 |
| February 13, 2023 09:04 | https://github.com/nodejs/node/pull/46587#event-8501878175 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1427583714 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| @mcollina | https://github.com/mcollina |
| @addaleax | https://github.com/addaleax |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#event-8501921795 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#event-8502023210 |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
|
Feb 13, 2023
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1295314255 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46587/files |
| src/tcp_wrap.cc | https://github.com/nodejs/node/pull/46587/files#diff-52cd0d4033b202215092161a06d1f17a6e91c39470098a6479a2583eec005532 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 13, 2023
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1295528015 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46587/files |
| src/tcp_wrap.cc | https://github.com/nodejs/node/pull/46587/files#diff-52cd0d4033b202215092161a06d1f17a6e91c39470098a6479a2583eec005532 |
| addaleax | https://github.com/addaleax |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1104390445 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1104405269 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1104472672 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| addaleax | https://github.com/addaleax |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1104494949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @bnoordhuis | https://github.com/bnoordhuis |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 13, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1104496218 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| bnoordhuis | https://github.com/bnoordhuis |
| Feb 17, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1109954320 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 17, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1109956883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| addaleax | https://github.com/addaleax |
| Feb 17, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1109989257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 17, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1110016043 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 21, 2023 | https://github.com/nodejs/node/pull/46587#discussion_r1113286042 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Feb 13, 2023
| https://github.com/nodejs/node/pull/46587#ref-issue-1582817788 |
|
Node.js Technical Steering Committee (TSC) Meeting 2023-02-15
nodejs/TSC#1341
| https://github.com/nodejs/TSC/issues/1341 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Feb 15, 2023
| https://github.com/nodejs/node/pull/46587#pullrequestreview-1299069974 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46587/files |
| test/parallel/test-http2-ping-settings-heapdump.js | https://github.com/nodejs/node/pull/46587/files#diff-298f3ec77345bcea0201c22dd42f67a8d63b06ce404a8ea5c15e239e5c681f3a |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Feb 15, 2023
| https://github.com/nodejs/node/pull/46587#ref-issue-1586085807 |
|
Error [ERR_INTERNAL_ASSERTION] with autoSelectFamily enabled
#46669
| https://github.com/nodejs/node/issues/46669 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Feb 17, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1434715248 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/873bbcc28f20c1daafe078bece70a3f33765bb7a..fe56de97ce66d457e93c2c09ddab3c1fe043638d |
| 873bbcc | https://github.com/nodejs/node/commit/873bbcc28f20c1daafe078bece70a3f33765bb7a |
| fe56de9 | https://github.com/nodejs/node/commit/fe56de97ce66d457e93c2c09ddab3c1fe043638d |
|
Compare
| https://github.com/nodejs/node/compare/873bbcc28f20c1daafe078bece70a3f33765bb7a..fe56de97ce66d457e93c2c09ddab3c1fe043638d |
| February 21, 2023 10:41 | https://github.com/nodejs/node/pull/46587#event-8569508189 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
Feb 21, 2023
| https://github.com/nodejs/node/pull/46587#ref-issue-1587462496 |
|
autoSelectFamily: true breaks TLS
#46679
| https://github.com/nodejs/node/issues/46679 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/fe56de97ce66d457e93c2c09ddab3c1fe043638d..8e3a06cdf885ae87c8622244b6a2e78637bd17fb |
| fe56de9 | https://github.com/nodejs/node/commit/fe56de97ce66d457e93c2c09ddab3c1fe043638d |
| 8e3a06c | https://github.com/nodejs/node/commit/8e3a06cdf885ae87c8622244b6a2e78637bd17fb |
|
Compare
| https://github.com/nodejs/node/compare/fe56de97ce66d457e93c2c09ddab3c1fe043638d..8e3a06cdf885ae87c8622244b6a2e78637bd17fb |
| February 21, 2023 16:13 | https://github.com/nodejs/node/pull/46587#event-8572747252 |
| targos | https://github.com/targos |
|
Mar 13, 2023
| https://github.com/nodejs/node/pull/46587#ref-commit-e0d098b |
|
| https://github.com/ShogunPanda |
|
| https://github.com/targos |
| net: rework autoSelectFamily implementation | https://github.com/nodejs/node/commit/e0d098bd21a978a9a4facc825731922357da11dd |
| e0d098b | https://github.com/nodejs/node/commit/e0d098bd21a978a9a4facc825731922357da11dd |
| #46587 | https://github.com/nodejs/node/pull/46587 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46587#ref-pullrequest-1622922231 |
|
v19.8.0 release proposal
#47087
| https://github.com/nodejs/node/pull/47087 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Apr 24, 2023
| https://github.com/nodejs/node/pull/46587#ref-issue-1677001639 |
|
SIGNAL USERS READ THIS FIRST: code: 'ERR_INTERNAL_ASSERTION' in internalConnectMultiple
#47644
| https://github.com/nodejs/node/issues/47644 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
May 31, 2023
| https://github.com/nodejs/node/pull/46587#ref-pullrequest-1732847424 |
|
tls: reapply servername on happy eyeballs connect
#48255
| https://github.com/nodejs/node/pull/48255 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
dont-land-on-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v18.x |
| Jul 27, 2023 | https://github.com/nodejs/node/pull/46587#event-9936457744 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jul 27, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1653718284 |
| @juanarbol | https://github.com/juanarbol |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 27, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1653724253 |
| @juanarbol | https://github.com/juanarbol |
| #48275 | https://github.com/nodejs/node/pull/48275 |
| #47029 | https://github.com/nodejs/node/pull/47029 |
| #48189 | https://github.com/nodejs/node/pull/48189 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 27, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1653737913 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| @ShogunPanda | https://github.com/ShogunPanda |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Jul 27, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1654187648 |
| @juanarbol | https://github.com/juanarbol |
| #48275 | https://github.com/nodejs/node/pull/48275 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Jul 27, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1654199787 |
| @juanarbol | https://github.com/juanarbol |
| #46790 | https://github.com/nodejs/node/pull/46790 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jul 29, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1656623456 |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 2, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1662918921 |
| @juanarbol | https://github.com/juanarbol |
| @ShogunPanda | https://github.com/ShogunPanda |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| mhdawson | https://github.com/mhdawson |
|
Aug 4, 2023
| https://github.com/nodejs/node/pull/46587#ref-commit-568975f |
|
| https://github.com/ShogunPanda |
|
| https://github.com/mhdawson |
| net: rework autoSelectFamily implementation | https://github.com/mhdawson/io.js/commit/568975f89f8030f3362c54e07a855a8e07d8a61c |
| 568975f | https://github.com/mhdawson/io.js/commit/568975f89f8030f3362c54e07a855a8e07d8a61c |
| nodejs#46587 | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 4, 2023
| https://github.com/nodejs/node/pull/46587#ref-pullrequest-1836915733 |
|
[v18.x] Backport 48969 to v18.x staging
#49016
| https://github.com/nodejs/node/pull/49016 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 4, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1665811633 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| @juanarbol | https://github.com/juanarbol |
| @ShogunPanda | https://github.com/ShogunPanda |
| @ruyadorno | https://github.com/ruyadorno |
| #49016 | https://github.com/nodejs/node/pull/49016 |
| #48969 | https://github.com/nodejs/node/pull/48969 |
| #48275 | https://github.com/nodejs/node/pull/48275 |
| @ruyadorno | https://github.com/ruyadorno |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 14, 2023
| https://github.com/nodejs/node/pull/46587#ref-commit-73d930d |
|
| https://github.com/ShogunPanda |
|
| https://github.com/ruyadorno |
| net: rework autoSelectFamily implementation | https://github.com/nodejs/node/commit/73d930d88d0e824c0f26ead327bf1e50a0897aa0 |
| 73d930d | https://github.com/nodejs/node/commit/73d930d88d0e824c0f26ead327bf1e50a0897aa0 |
| #46587 | https://github.com/nodejs/node/pull/46587 |
| #49016 | https://github.com/nodejs/node/pull/49016 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
| Aug 14, 2023 | https://github.com/nodejs/node/pull/46587#event-10092044814 |
| mhdawson | https://github.com/mhdawson |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/46587#ref-commit-5dc04c4 |
|
| https://github.com/ShogunPanda |
|
| https://github.com/mhdawson |
| net: rework autoSelectFamily implementation | https://github.com/mhdawson/io.js/commit/5dc04c44323606a8d56fffbc9f5d1b5ca97382ab |
| 5dc04c4 | https://github.com/mhdawson/io.js/commit/5dc04c44323606a8d56fffbc9f5d1b5ca97382ab |
| nodejs#46587 | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/46587#ref-pullrequest-1851631960 |
|
Backport 48969 to v18.x staging v2
#49183
| https://github.com/nodejs/node/pull/49183 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/46587#issuecomment-1679117656 |
| #49183 | https://github.com/nodejs/node/pull/49183 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
backport-open-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v18.x |
| Aug 15, 2023 | https://github.com/nodejs/node/pull/46587#event-10100351241 |
| mhdawson | https://github.com/mhdawson |
|
Aug 15, 2023
| https://github.com/nodejs/node/pull/46587#ref-commit-6e19fdb |
|
| https://github.com/ShogunPanda |
|
| https://github.com/mhdawson |
| net: rework autoSelectFamily implementation | https://github.com/mhdawson/io.js/commit/6e19fdb954e5d91c91175416917bc3058bd9a936 |
| 6e19fdb | https://github.com/mhdawson/io.js/commit/6e19fdb954e5d91c91175416917bc3058bd9a936 |
| nodejs#46587 | https://github.com/nodejs/node/pull/46587 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 17, 2023
| https://github.com/nodejs/node/pull/46587#ref-commit-267439f |
|
| https://github.com/ShogunPanda |
|
| https://github.com/ruyadorno |
| net: rework autoSelectFamily implementation | https://github.com/nodejs/node/commit/267439fc344f22f5d58a9bf2d71ec67f5f5e3310 |
| 267439f | https://github.com/nodejs/node/commit/267439fc344f22f5d58a9bf2d71ec67f5f5e3310 |
| #46587 | https://github.com/nodejs/node/pull/46587 |
| #49183 | https://github.com/nodejs/node/pull/49183 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Aug 17, 2023 | https://github.com/nodejs/node/pull/46587#event-10122322917 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 17, 2023
| https://github.com/nodejs/node/pull/46587#ref-pullrequest-1855772061 |
|
v18.18.0 proposal
#49220
| https://github.com/nodejs/node/pull/49220 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46587 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/46587/files/8e3a06cdf885ae87c8622244b6a2e78637bd17fb |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/46587/files/b771831ccde4080dd44a4419dfd99121c52307d4 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/46587/files/8e3a06cdf885ae87c8622244b6a2e78637bd17fb |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/46587/files/5f2f32788169adf63a1310003009d8b28c9c82d7 |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
autoSelectFamily: true breaks TLS
| https://github.com/nodejs/node/issues/46679 |
|
Error [ERR_INTERNAL_ASSERTION] with autoSelectFamily enabled
| https://github.com/nodejs/node/issues/46669 |
| Please reload this page | https://github.com/nodejs/node/pull/46587 |
|
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mcollina |
|
| https://github.com/anonrig |
|
| https://github.com/tniessen |
|
| https://github.com/juanarbol |
|
| https://github.com/mhdawson |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/RaisinTen |
|
| https://github.com/ruyadorno |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |