René's URL Explorer Experiment


Title: src: allow optional Isolate termination in `node::Stop()` by codebytere · Pull Request #46583 · nodejs/node · GitHub

Open Graph Title: src: allow optional Isolate termination in `node::Stop()` by codebytere · Pull Request #46583 · nodejs/node

X Title: src: allow optional Isolate termination in `node::Stop()` by codebytere · Pull Request #46583 · nodejs/node

Description: This patch allows for node::Stop() to conditionally call v8:Isolate::TerminateExecution(). In several cases, we do not want to invoke a termination exception at exit when we're running with only_te...

Open Graph Description: This patch allows for node::Stop() to conditionally call v8:Isolate::TerminateExecution(). In several cases, we do not want to invoke a termination exception at exit when we're running with onl...

X Description: This patch allows for node::Stop() to conditionally call v8:Isolate::TerminateExecution(). In several cases, we do not want to invoke a termination exception at exit when we're running with...

Opengraph URL: https://github.com/nodejs/node/pull/46583

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7f0412bd-6e0b-f1cf-85a8-e4bc3ab6d654
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9396:FB3A6:C76E6C:112FA6B:6969EF67
html-safe-noncea45f522a7e899a60328f606fb9f2c22e92c606940cfe61a8831b38b0e67de9d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mzk2OkZCM0E2OkM3NkU2QzoxMTJGQTZCOjY5NjlFRjY3IiwidmlzaXRvcl9pZCI6IjgwNTE3Mjg4Nzg5NDczOTc0NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbb24f3167ae81b47f856cf3a4eeb10ce07ccc076e6344d2bb03837a6419d3cb2
hovercard-subject-tagpull_request:1234764195
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46583/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/91656a38023c25c932f8227cfdd694944e049cc9dc40985619c0fa26f279d3f2/nodejs/node/pull/46583
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/91656a38023c25c932f8227cfdd694944e049cc9dc40985619c0fa26f279d3f2/nodejs/node/pull/46583
og:image:altThis patch allows for node::Stop() to conditionally call v8:Isolate::TerminateExecution(). In several cases, we do not want to invoke a termination exception at exit when we're running with onl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodebytere
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/46583#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46583
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46583
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/46583
Reloadhttps://github.com/nodejs/node/pull/46583
Reloadhttps://github.com/nodejs/node/pull/46583
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/46583
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/46583
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/46583#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
codebytere:optional-isolate-terminationhttps://github.com/codebytere/node/tree/optional-isolate-termination
src: allow optional Isolate termination in node::Stop() https://github.com/nodejs/node/pull/46583#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
codebytere:optional-isolate-terminationhttps://github.com/codebytere/node/tree/optional-isolate-termination
Conversation 14 https://github.com/nodejs/node/pull/46583
Commits 1 https://github.com/nodejs/node/pull/46583/commits
Checks 0 https://github.com/nodejs/node/pull/46583/checks
Files changed https://github.com/nodejs/node/pull/46583/files
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 9, 2023https://github.com/nodejs/node/pull/46583#issue-1577497564
herehttps://github.com/nodejs/node/blob/fcfde3412efbe7e990018c8453222d20a1a637ca/src/inspector_profiler.cc#L256
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/codebytere
codebyterehttps://github.com/codebytere
addaleaxhttps://github.com/addaleax
joyeecheunghttps://github.com/joyeecheung
February 9, 2023 09:01https://github.com/nodejs/node/pull/46583#event-8476975357
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 9, 2023https://github.com/nodejs/node/pull/46583#issuecomment-1423847084
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Feb 9, 2023https://github.com/nodejs/node/pull/46583#event-8476977876
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Feb 9, 2023https://github.com/nodejs/node/pull/46583#event-8476987712
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/5c253ead4e7d3f5b32da90ff77b08ecafaf5f60b..24c67778b07bde9de60dee14528ad18c052eb76c
5c253eahttps://github.com/nodejs/node/commit/5c253ead4e7d3f5b32da90ff77b08ecafaf5f60b
24c6777https://github.com/nodejs/node/commit/24c67778b07bde9de60dee14528ad18c052eb76c
Compare https://github.com/nodejs/node/compare/5c253ead4e7d3f5b32da90ff77b08ecafaf5f60b..24c67778b07bde9de60dee14528ad18c052eb76c
February 9, 2023 09:03https://github.com/nodejs/node/pull/46583#event-8476990769
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Feb 9, 2023https://github.com/nodejs/node/pull/46583#event-8478232053
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 9, 2023https://github.com/nodejs/node/pull/46583#issuecomment-1424024415
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 9, 2023 https://github.com/nodejs/node/pull/46583#pullrequestreview-1290924491
View reviewed changes https://github.com/nodejs/node/pull/46583/files
src/node.hhttps://github.com/nodejs/node/pull/46583/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/2be2d9ba6bc56ae900293515f64fa0bb7206d8a1..7a99e131920590ad15660fb9637e905ef8936a3b
2be2d9bhttps://github.com/nodejs/node/commit/2be2d9ba6bc56ae900293515f64fa0bb7206d8a1
7a99e13https://github.com/nodejs/node/commit/7a99e131920590ad15660fb9637e905ef8936a3b
Compare https://github.com/nodejs/node/compare/2be2d9ba6bc56ae900293515f64fa0bb7206d8a1..7a99e131920590ad15660fb9637e905ef8936a3b
February 10, 2023 09:08https://github.com/nodejs/node/pull/46583#event-8487720953
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Feb 10, 2023 https://github.com/nodejs/node/pull/46583#pullrequestreview-1292971383
View reviewed changes https://github.com/nodejs/node/pull/46583/files
src/node.hhttps://github.com/nodejs/node/pull/46583/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 10, 2023 https://github.com/nodejs/node/pull/46583#pullrequestreview-1292980971
View reviewed changes https://github.com/nodejs/node/pull/46583/files
src/node.hhttps://github.com/nodejs/node/pull/46583/files#diff-7c19dd5fd5584cd4a8111f4c82a9f49f4aa1bdb9470ad11daa90f3d394a23b4e
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Feb 10, 2023https://github.com/nodejs/node/pull/46583#event-8489046713
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 12, 2023https://github.com/nodejs/node/pull/46583#event-8498615360
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/72f00941f638e47c1359afcc1599d575acaf65c8..f50bf1d24bae8ee435670577773d87b91e68aff6
72f0094https://github.com/nodejs/node/commit/72f00941f638e47c1359afcc1599d575acaf65c8
f50bf1dhttps://github.com/nodejs/node/commit/f50bf1d24bae8ee435670577773d87b91e68aff6
Compare https://github.com/nodejs/node/compare/72f00941f638e47c1359afcc1599d575acaf65c8..f50bf1d24bae8ee435670577773d87b91e68aff6
February 13, 2023 14:18https://github.com/nodejs/node/pull/46583#event-8504976133
https://github.com/codebytere
src: allow optional Isolate termination in node::Stop()https://github.com/nodejs/node/pull/46583/commits/37d0e400c5f9b328b2c592049e991962a736e8aa
37d0e40https://github.com/nodejs/node/pull/46583/commits/37d0e400c5f9b328b2c592049e991962a736e8aa
https://github.com/codebytere
codebyterehttps://github.com/codebytere
force-pushedhttps://github.com/nodejs/node/compare/f50bf1d24bae8ee435670577773d87b91e68aff6..37d0e400c5f9b328b2c592049e991962a736e8aa
f50bf1dhttps://github.com/nodejs/node/commit/f50bf1d24bae8ee435670577773d87b91e68aff6
37d0e40https://github.com/nodejs/node/commit/37d0e400c5f9b328b2c592049e991962a736e8aa
Compare https://github.com/nodejs/node/compare/f50bf1d24bae8ee435670577773d87b91e68aff6..37d0e400c5f9b328b2c592049e991962a736e8aa
February 13, 2023 14:18https://github.com/nodejs/node/pull/46583#event-8504981567
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Feb 13, 2023 https://github.com/nodejs/node/pull/46583#pullrequestreview-1295789360
View reviewed changes https://github.com/nodejs/node/pull/46583/files/37d0e400c5f9b328b2c592049e991962a736e8aa
https://github.com/codebytere
codebyterehttps://github.com/codebytere
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 13, 2023https://github.com/nodejs/node/pull/46583#event-8506387330
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 17, 2023https://github.com/nodejs/node/pull/46583#event-8546268921
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 17, 2023https://github.com/nodejs/node/pull/46583#event-8546296694
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
Feb 17, 2023https://github.com/nodejs/node/pull/46583#event-8551601557
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Feb 17, 2023https://github.com/nodejs/node/pull/46583#event-8551622126
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c566a04https://github.com/nodejs/node/commit/c566a04c867544ee2d32c8ddfdf68122bd7ec498
Feb 17, 2023https://github.com/nodejs/node/pull/46583#event-8551622399
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 17, 2023https://github.com/nodejs/node/pull/46583#issuecomment-1435370401
c566a04https://github.com/nodejs/node/commit/c566a04c867544ee2d32c8ddfdf68122bd7ec498
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 18, 2023 https://github.com/nodejs/node/pull/46583#ref-issue-1590123736
CI Reliability 2023-02-18 nodejs/reliability#499 https://github.com/nodejs/reliability/issues/499
MylesBorinshttps://github.com/MylesBorins
Feb 18, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-c3897bf
https://github.com/codebytere
https://github.com/MylesBorins
src: allow optional Isolate termination in node::Stop()https://github.com/nodejs/node/commit/c3897bfd9bb175d97f748c52d2ce8ff7588f4742
c3897bfhttps://github.com/nodejs/node/commit/c3897bfd9bb175d97f748c52d2ce8ff7588f4742
#46583https://github.com/nodejs/node/pull/46583
MylesBorinshttps://github.com/MylesBorins
Feb 19, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-eb53c0f
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/nodejs/node/commit/eb53c0f68791d34b85c273f86a932f0abb1d0933
eb53c0fhttps://github.com/nodejs/node/commit/eb53c0f68791d34b85c273f86a932f0abb1d0933
#46673https://github.com/nodejs/node/pull/46673
#46410https://github.com/nodejs/node/pull/46410
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46017https://github.com/nodejs/node/pull/46017
#46494https://github.com/nodejs/node/pull/46494
#45038https://github.com/nodejs/node/pull/45038
#46583https://github.com/nodejs/node/pull/46583
#46491https://github.com/nodejs/node/pull/46491
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46017https://github.com/nodejs/node/pull/46017
#46410https://github.com/nodejs/node/pull/46410
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 19, 2023 https://github.com/nodejs/node/pull/46583#ref-pullrequest-1590507827
v19.7.0 proposal #46725 https://github.com/nodejs/node/pull/46725
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 19, 2023 https://github.com/nodejs/node/pull/46583#ref-issue-1590510254
CI Reliability 2023-02-19 nodejs/reliability#500 https://github.com/nodejs/reliability/issues/500
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-051c9c3
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/nodejs/node/commit/051c9c398038b992039e05e2b13c6622ba4f4826
051c9c3https://github.com/nodejs/node/commit/051c9c398038b992039e05e2b13c6622ba4f4826
#46673https://github.com/nodejs/node/pull/46673
#46410https://github.com/nodejs/node/pull/46410
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46017https://github.com/nodejs/node/pull/46017
#46494https://github.com/nodejs/node/pull/46494
#45038https://github.com/nodejs/node/pull/45038
#46583https://github.com/nodejs/node/pull/46583
#46491https://github.com/nodejs/node/pull/46491
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46017https://github.com/nodejs/node/pull/46017
#46410https://github.com/nodejs/node/pull/46410
#46725https://github.com/nodejs/node/pull/46725
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-397dc01
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/MylesBorins/node/commit/397dc0155a1fbbf270fec509cda87c62b6446467
397dc01https://github.com/MylesBorins/node/commit/397dc0155a1fbbf270fec509cda87c62b6446467
nodejs#46673https://github.com/nodejs/node/pull/46673
nodejs#46410https://github.com/nodejs/node/pull/46410
nodejs#46716https://github.com/nodejs/node/pull/46716
nodejs#46444https://github.com/nodejs/node/pull/46444
nodejs#46017https://github.com/nodejs/node/pull/46017
nodejs#46494https://github.com/nodejs/node/pull/46494
nodejs#45038https://github.com/nodejs/node/pull/45038
nodejs#46583https://github.com/nodejs/node/pull/46583
nodejs#46491https://github.com/nodejs/node/pull/46491
nodejs#45888https://github.com/nodejs/node/pull/45888
nodejs#45888https://github.com/nodejs/node/pull/45888
nodejs#45888https://github.com/nodejs/node/pull/45888
nodejs#46368https://github.com/nodejs/node/pull/46368
nodejs#46273https://github.com/nodejs/node/pull/46273
nodejs#46017https://github.com/nodejs/node/pull/46017
nodejs#46410https://github.com/nodejs/node/pull/46410
nodejs#46725https://github.com/nodejs/node/pull/46725
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-3ee97ee
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/nodejs/node/commit/3ee97ee0ead30e9b831fccc7edba8e803efb4a57
3ee97eehttps://github.com/nodejs/node/commit/3ee97ee0ead30e9b831fccc7edba8e803efb4a57
#46673https://github.com/nodejs/node/pull/46673
#46410https://github.com/nodejs/node/pull/46410
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46017https://github.com/nodejs/node/pull/46017
#46494https://github.com/nodejs/node/pull/46494
#45038https://github.com/nodejs/node/pull/45038
#46583https://github.com/nodejs/node/pull/46583
#46491https://github.com/nodejs/node/pull/46491
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46017https://github.com/nodejs/node/pull/46017
#46410https://github.com/nodejs/node/pull/46410
#46725https://github.com/nodejs/node/pull/46725
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-a7dbed7
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/nodejs/node/commit/a7dbed7e445c051e00ca912cd5d137fa7ffec5d4
a7dbed7https://github.com/nodejs/node/commit/a7dbed7e445c051e00ca912cd5d137fa7ffec5d4
#46673https://github.com/nodejs/node/pull/46673
#46410https://github.com/nodejs/node/pull/46410
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46017https://github.com/nodejs/node/pull/46017
#46494https://github.com/nodejs/node/pull/46494
#45038https://github.com/nodejs/node/pull/45038
#46583https://github.com/nodejs/node/pull/46583
#46491https://github.com/nodejs/node/pull/46491
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46017https://github.com/nodejs/node/pull/46017
#46410https://github.com/nodejs/node/pull/46410
#46725https://github.com/nodejs/node/pull/46725
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-f390841
https://github.com/codebytere
https://github.com/MylesBorins
src: allow optional Isolate termination in node::Stop()https://github.com/nodejs/node/commit/f3908411fd772a3131e478370dd18373b109a64e
f390841https://github.com/nodejs/node/commit/f3908411fd772a3131e478370dd18373b109a64e
#46583https://github.com/nodejs/node/pull/46583
MylesBorinshttps://github.com/MylesBorins
Feb 20, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-00a428e
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/nodejs/node/commit/00a428eedd8bbed0da77416675db87dda7d473cd
00a428ehttps://github.com/nodejs/node/commit/00a428eedd8bbed0da77416675db87dda7d473cd
#46673https://github.com/nodejs/node/pull/46673
#46410https://github.com/nodejs/node/pull/46410
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46017https://github.com/nodejs/node/pull/46017
#46494https://github.com/nodejs/node/pull/46494
#45038https://github.com/nodejs/node/pull/45038
#46583https://github.com/nodejs/node/pull/46583
#46491https://github.com/nodejs/node/pull/46491
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46017https://github.com/nodejs/node/pull/46017
#46410https://github.com/nodejs/node/pull/46410
#46725https://github.com/nodejs/node/pull/46725
MylesBorinshttps://github.com/MylesBorins
Feb 21, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-89322ae
https://github.com/MylesBorins
2023-02-21, Version 19.7.0 (Current)https://github.com/nodejs/node/commit/89322aed7e2570541835db7a19e75ab063dab011
89322aehttps://github.com/nodejs/node/commit/89322aed7e2570541835db7a19e75ab063dab011
#46673https://github.com/nodejs/node/pull/46673
#46410https://github.com/nodejs/node/pull/46410
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46017https://github.com/nodejs/node/pull/46017
#46494https://github.com/nodejs/node/pull/46494
#45038https://github.com/nodejs/node/pull/45038
#46583https://github.com/nodejs/node/pull/46583
#46491https://github.com/nodejs/node/pull/46491
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#45888https://github.com/nodejs/node/pull/45888
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46017https://github.com/nodejs/node/pull/46017
#46410https://github.com/nodejs/node/pull/46410
#46725https://github.com/nodejs/node/pull/46725
danielleadamshttps://github.com/danielleadams
Apr 11, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-ea411d6
https://github.com/codebytere
https://github.com/danielleadams
src: allow optional Isolate termination in node::Stop()https://github.com/nodejs/node/commit/ea411d642200138889809b440f6138ae7078ac9f
ea411d6https://github.com/nodejs/node/commit/ea411d642200138889809b440f6138ae7078ac9f
#46583https://github.com/nodejs/node/pull/46583
danielleadamshttps://github.com/danielleadams
Apr 11, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-330ca41
https://github.com/danielleadams
2023-04-11, Version 18.16.0 'Hydrogen' (LTS)https://github.com/nodejs/node/commit/330ca41e5db5a238115cd2a1d2c509977b435d1b
330ca41https://github.com/nodejs/node/commit/330ca41e5db5a238115cd2a1d2c509977b435d1b
#46500https://github.com/nodejs/node/pull/46500
#46816https://github.com/nodejs/node/pull/46816
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46523https://github.com/nodejs/node/pull/46523
#46387https://github.com/nodejs/node/pull/46387
#46494https://github.com/nodejs/node/pull/46494
#46583https://github.com/nodejs/node/pull/46583
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46978https://github.com/nodejs/node/pull/46978
#46308https://github.com/nodejs/node/pull/46308
#46832https://github.com/nodejs/node/pull/46832
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Apr 11, 2023 https://github.com/nodejs/node/pull/46583#ref-pullrequest-1661695566
v18.16.0 release proposal #47502 https://github.com/nodejs/node/pull/47502
danielleadamshttps://github.com/danielleadams
Apr 11, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-410905a
https://github.com/danielleadams
2023-04-11, Version 18.16.0 'Hydrogen' (LTS)https://github.com/nodejs/node/commit/410905a44f39e53c10e336c03889a3e20afa5217
410905ahttps://github.com/nodejs/node/commit/410905a44f39e53c10e336c03889a3e20afa5217
#46500https://github.com/nodejs/node/pull/46500
#46816https://github.com/nodejs/node/pull/46816
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46523https://github.com/nodejs/node/pull/46523
#46387https://github.com/nodejs/node/pull/46387
#46494https://github.com/nodejs/node/pull/46494
#46583https://github.com/nodejs/node/pull/46583
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46978https://github.com/nodejs/node/pull/46978
#46308https://github.com/nodejs/node/pull/46308
#46832https://github.com/nodejs/node/pull/46832
#47502https://github.com/nodejs/node/pull/47502
danielleadamshttps://github.com/danielleadams
Apr 11, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-50edc7f
https://github.com/danielleadams
2023-04-11, Version 18.16.0 'Hydrogen' (LTS)https://github.com/nodejs/node/commit/50edc7f8cecb91bcf81f3f99e3c08173ec585090
50edc7fhttps://github.com/nodejs/node/commit/50edc7f8cecb91bcf81f3f99e3c08173ec585090
#46500https://github.com/nodejs/node/pull/46500
#46816https://github.com/nodejs/node/pull/46816
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46523https://github.com/nodejs/node/pull/46523
#46387https://github.com/nodejs/node/pull/46387
#46494https://github.com/nodejs/node/pull/46494
#46583https://github.com/nodejs/node/pull/46583
#46368https://github.com/nodejs/node/pull/46368
#45038https://github.com/nodejs/node/pull/45038
#46273https://github.com/nodejs/node/pull/46273
#46978https://github.com/nodejs/node/pull/46978
#46308https://github.com/nodejs/node/pull/46308
#46832https://github.com/nodejs/node/pull/46832
#47502https://github.com/nodejs/node/pull/47502
danielleadamshttps://github.com/danielleadams
Apr 12, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-43d167a
https://github.com/danielleadams
2023-04-12, Version 18.16.0 'Hydrogen' (LTS)https://github.com/nodejs/node/commit/43d167a262d0772a73ec1e21316e722bad71e4f8
43d167ahttps://github.com/nodejs/node/commit/43d167a262d0772a73ec1e21316e722bad71e4f8
#45038https://github.com/nodejs/node/pull/45038
#46410https://github.com/nodejs/node/pull/46410
#46500https://github.com/nodejs/node/pull/46500
#46816https://github.com/nodejs/node/pull/46816
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46523https://github.com/nodejs/node/pull/46523
#46387https://github.com/nodejs/node/pull/46387
#46494https://github.com/nodejs/node/pull/46494
#46583https://github.com/nodejs/node/pull/46583
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46978https://github.com/nodejs/node/pull/46978
#46308https://github.com/nodejs/node/pull/46308
#46832https://github.com/nodejs/node/pull/46832
#47502https://github.com/nodejs/node/pull/47502
danielleadamshttps://github.com/danielleadams
Apr 13, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-5273947
https://github.com/danielleadams
2023-04-12, Version 18.16.0 'Hydrogen' (LTS)https://github.com/nodejs/node/commit/527394783ece910bf8c543f5a01f100ae37e5c33
5273947https://github.com/nodejs/node/commit/527394783ece910bf8c543f5a01f100ae37e5c33
#45038https://github.com/nodejs/node/pull/45038
#46410https://github.com/nodejs/node/pull/46410
#46500https://github.com/nodejs/node/pull/46500
#46816https://github.com/nodejs/node/pull/46816
#46716https://github.com/nodejs/node/pull/46716
#46444https://github.com/nodejs/node/pull/46444
#46523https://github.com/nodejs/node/pull/46523
#46387https://github.com/nodejs/node/pull/46387
#46494https://github.com/nodejs/node/pull/46494
#46583https://github.com/nodejs/node/pull/46583
#46368https://github.com/nodejs/node/pull/46368
#46273https://github.com/nodejs/node/pull/46273
#46978https://github.com/nodejs/node/pull/46978
#46308https://github.com/nodejs/node/pull/46308
#46832https://github.com/nodejs/node/pull/46832
#47502https://github.com/nodejs/node/pull/47502
codebyterehttps://github.com/codebytere
Apr 14, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-1705615
https://github.com/codebytere
src: allow optional Isolate termination in node::Stop()https://github.com/electron/electron/commit/1705615cb0ec749f13f206f5603f15959b31c767
1705615https://github.com/electron/electron/commit/1705615cb0ec749f13f206f5603f15959b31c767
nodejs/node#46583https://github.com/nodejs/node/pull/46583
codebyterehttps://github.com/codebytere
Apr 16, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-9a6cb3c
https://github.com/codebytere
src: allow optional Isolate termination in node::Stop()https://github.com/electron/electron/commit/9a6cb3cfabc8aba75e79ef81cdcb515af91ede2f
9a6cb3chttps://github.com/electron/electron/commit/9a6cb3cfabc8aba75e79ef81cdcb515af91ede2f
nodejs/node#46583https://github.com/nodejs/node/pull/46583
codebyterehttps://github.com/codebytere
Apr 17, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-5671b5d
https://github.com/codebytere
src: allow optional Isolate termination in node::Stop()https://github.com/electron/electron/commit/5671b5dc31a90db1882d7f17f67b021404878ebd
5671b5dhttps://github.com/electron/electron/commit/5671b5dc31a90db1882d7f17f67b021404878ebd
nodejs/node#46583https://github.com/nodejs/node/pull/46583
codebyterehttps://github.com/codebytere
Apr 18, 2023 https://github.com/nodejs/node/pull/46583#ref-commit-de192c2
https://github.com/apps/electron-roller
https://github.com/codebytere
chore: bump node to v18.16.0 (main) (https://github.com/electron/electron/commit/de192c2db26c673b5dd0fcc0e44990d580b3543e
#37973https://github.com/electron/electron/pull/37973
)https://github.com/electron/electron/commit/de192c2db26c673b5dd0fcc0e44990d580b3543e
de192c2https://github.com/electron/electron/commit/de192c2db26c673b5dd0fcc0e44990d580b3543e
nodejs/node#46739https://github.com/nodejs/node/pull/46739
nodejs/node#46881https://github.com/nodejs/node/pull/46881
nodejs/node#45038https://github.com/nodejs/node/pull/45038
nodejs/node#41023https://github.com/nodejs/node/pull/41023
nodejs/node#46672https://github.com/nodejs/node/pull/46672
nodejs/node#46368https://github.com/nodejs/node/pull/46368
nodejs/node#46583https://github.com/nodejs/node/pull/46583
nodejs/node#46864https://github.com/nodejs/node/pull/46864
nodejs/node#46471https://github.com/nodejs/node/pull/46471
nodejs/node#46472https://github.com/nodejs/node/pull/46472
nodejs/node#46410https://github.com/nodejs/node/pull/46410
nodejs/node#46978https://github.com/nodejs/node/pull/46978
nodejs/node#46528https://github.com/nodejs/node/pull/46528
nodejs/node#46410https://github.com/nodejs/node/pull/46410
nodejs/node#46150https://github.com/nodejs/node/pull/46150
https://github.com/codebytere
codebyterehttps://github.com/codebytere
February 8, 2024 13:09https://github.com/nodejs/node/pull/46583#event-11745516034
https://github.com/deepak1556
deepak1556https://github.com/deepak1556
Nov 26, 2025 https://github.com/nodejs/node/pull/46583#ref-pullrequest-3667081477
fix: crash when attempting to resolve modules during process exit electron/electron#49090 https://github.com/electron/electron/pull/49090
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46583
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/46583/files/7a99e131920590ad15660fb9637e905ef8936a3b
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/46583/files/37d0e400c5f9b328b2c592049e991962a736e8aa
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/46583/files/37d0e400c5f9b328b2c592049e991962a736e8aa
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
embedding https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aembedding
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
semver-minor https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor
Please reload this pagehttps://github.com/nodejs/node/pull/46583
https://github.com/codebytere
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/bnoordhuis
https://github.com/joyeecheung
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.