| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5675638b-e07e-e73d-37bd-5b4f41110b0f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B846:76F86:865B37:B782AF:6969EA5D |
| html-safe-nonce | 8252f44047a9e9124be01636214323ac2ee3651f4e0739b9aeaf03a734c71834 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODQ2Ojc2Rjg2Ojg2NUIzNzpCNzgyQUY6Njk2OUVBNUQiLCJ2aXNpdG9yX2lkIjoiOTAwNDA2MzY0NjkxNTYxOTQyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cd04f68485c7b950220fff83235d9af81f4510427f731c80e002246aaac02fea |
| hovercard-subject-tag | pull_request:1227976861 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46482/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/74d4098dba99a0c38ea6965749965f7104957a0c986a169e13c1292273f5da75/nodejs/node/pull/46482 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/74d4098dba99a0c38ea6965749965f7104957a0c986a169e13c1292273f5da75/nodejs/node/pull/46482 |
| og:image:alt | The tls.DEFAULT_CIPHERS var already exists, this change shows how to use it.
Fixes: #46462
I have attempted to keep my changes in style with the rest, I tried finding the Style Guide but the link j... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | andreas-ibm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/46482#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46482 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46482 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/46482 |
| Reload | https://github.com/nodejs/node/pull/46482 |
| Reload | https://github.com/nodejs/node/pull/46482 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/46482#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| andreas-ibm:dre/doc-ciphers | https://github.com/andreas-ibm/node/tree/dre/doc-ciphers |
|
doc: document how to use the tls.DEFAULT_CIPHERS
| https://github.com/nodejs/node/pull/46482#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| andreas-ibm:dre/doc-ciphers | https://github.com/andreas-ibm/node/tree/dre/doc-ciphers |
|
Conversation
7
| https://github.com/nodejs/node/pull/46482 |
|
Commits
4
| https://github.com/nodejs/node/pull/46482/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/46482/checks |
|
Files changed
| https://github.com/nodejs/node/pull/46482/files |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/andreas-ibm |
| andreas-ibm | https://github.com/andreas-ibm |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#issue-1569659927 |
| #46462 | https://github.com/nodejs/node/issues/46462 |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
|
| https://github.com/andreas-ibm |
| doc: document how to use the tls.DEFAULT_CIPHERS | https://github.com/nodejs/node/pull/46482/commits/c951d3d69d6a88f3161110aad3ddfce560f9a051 |
| c951d3d | https://github.com/nodejs/node/pull/46482/commits/c951d3d69d6a88f3161110aad3ddfce560f9a051 |
| nodejs#46462 | https://github.com/nodejs/node/issues/46462 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#event-8430979172 |
| https://github.com/andreas-ibm |
| andreas-ibm | https://github.com/andreas-ibm |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#issuecomment-1415738822 |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
lts-watch-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#event-8431684696 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#issuecomment-1415803991 |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
| https://github.com/andreas-ibm |
| andreas-ibm | https://github.com/andreas-ibm |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#issuecomment-1415809247 |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
| andreas-ibm | https://github.com/andreas-ibm |
| February 3, 2023 13:20 | https://github.com/nodejs/node/pull/46482#commits-pushed-e2c0b05 |
|
| https://github.com/andreas-ibm |
| doc: fix lint errors and warnings | https://github.com/nodejs/node/pull/46482/commits/e2c0b05def54e91fe25ba68eac5199f2ddb6b343 |
| e2c0b05 | https://github.com/nodejs/node/pull/46482/commits/e2c0b05def54e91fe25ba68eac5199f2ddb6b343 |
|
| https://github.com/andreas-ibm |
| doc: remove copy-paste typo | https://github.com/nodejs/node/pull/46482/commits/8167f895d081111f73a1073f515833236c7379e2 |
| 8167f89 | https://github.com/nodejs/node/pull/46482/commits/8167f895d081111f73a1073f515833236c7379e2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Feb 3, 2023
| https://github.com/nodejs/node/pull/46482#pullrequestreview-1283336697 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46482/files/8167f895d081111f73a1073f515833236c7379e2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Feb 3, 2023 | https://github.com/nodejs/node/pull/46482#event-8434392109 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Feb 5, 2023
| https://github.com/nodejs/node/pull/46482#pullrequestreview-1284152053 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46482/files/8167f895d081111f73a1073f515833236c7379e2 |
| doc/api/tls.md | https://github.com/nodejs/node/pull/46482/files/8167f895d081111f73a1073f515833236c7379e2#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
|
| https://github.com/andreas-ibm |
|
| https://github.com/VoltrexKeyva |
| Update doc/api/tls.md | https://github.com/nodejs/node/pull/46482/commits/0c6719eafc2eb4e43d9a60c996b17187ab374d57 |
| 0c6719e | https://github.com/nodejs/node/pull/46482/commits/0c6719eafc2eb4e43d9a60c996b17187ab374d57 |
| https://github.com/aymen94 |
| aymen94 | https://github.com/aymen94 |
|
Feb 6, 2023
| https://github.com/nodejs/node/pull/46482#pullrequestreview-1285979434 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46482/files/0c6719eafc2eb4e43d9a60c996b17187ab374d57 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 7, 2023
| https://github.com/nodejs/node/pull/46482#pullrequestreview-1286210206 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46482/files/0c6719eafc2eb4e43d9a60c996b17187ab374d57 |
| https://github.com/andreas-ibm |
| andreas-ibm | https://github.com/andreas-ibm |
| Feb 23, 2023 | https://github.com/nodejs/node/pull/46482#issuecomment-1442075704 |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Feb 23, 2023 | https://github.com/nodejs/node/pull/46482#event-8593702515 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Feb 23, 2023 | https://github.com/nodejs/node/pull/46482#event-8593739219 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 42be7f6 | https://github.com/nodejs/node/commit/42be7f6a0335c396810be91c3f3724007029f83d |
| Feb 23, 2023 | https://github.com/nodejs/node/pull/46482#event-8593739970 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 23, 2023 | https://github.com/nodejs/node/pull/46482#issuecomment-1442082346 |
| 42be7f6 | https://github.com/nodejs/node/commit/42be7f6a0335c396810be91c3f3724007029f83d |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
| https://github.com/andreas-ibm |
| andreas-ibm | https://github.com/andreas-ibm |
| February 23, 2023 16:38 | https://github.com/nodejs/node/pull/46482#event-8593782736 |
| targos | https://github.com/targos |
|
Mar 13, 2023
| https://github.com/nodejs/node/pull/46482#ref-commit-60d1a48 |
|
| https://github.com/andreas-ibm |
|
| https://github.com/targos |
| doc: document how to use the tls.DEFAULT_CIPHERS | https://github.com/nodejs/node/commit/60d1a4887f33ee0d66355e2e0d3784925c340aa3 |
| 60d1a48 | https://github.com/nodejs/node/commit/60d1a4887f33ee0d66355e2e0d3784925c340aa3 |
| #46462 | https://github.com/nodejs/node/issues/46462 |
| #46482 | https://github.com/nodejs/node/pull/46482 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46482#ref-pullrequest-1622922231 |
|
v19.8.0 release proposal
#47087
| https://github.com/nodejs/node/pull/47087 |
| danielleadams | https://github.com/danielleadams |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46482#ref-commit-7e08ca1 |
|
| https://github.com/andreas-ibm |
|
| https://github.com/danielleadams |
| doc: document how to use the tls.DEFAULT_CIPHERS | https://github.com/nodejs/node/commit/7e08ca125ac217a7ea236ef7f372c9fec4c9033b |
| 7e08ca1 | https://github.com/nodejs/node/commit/7e08ca125ac217a7ea236ef7f372c9fec4c9033b |
| #46462 | https://github.com/nodejs/node/issues/46462 |
| #46482 | https://github.com/nodejs/node/pull/46482 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46482#ref-pullrequest-1661695566 |
|
v18.16.0 release proposal
#47502
| https://github.com/nodejs/node/pull/47502 |
| https://github.com/pimterry |
| pimterry | https://github.com/pimterry |
|
Aug 29, 2023
| https://github.com/nodejs/node/pull/46482#ref-pullrequest-1069731499 |
|
Clarify the documentation for TLS cipher configuration & defaults
#41061
| https://github.com/nodejs/node/pull/41061 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
lts-watch-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v18.x |
| Oct 27, 2023 | https://github.com/nodejs/node/pull/46482#event-10792791753 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46482 |
|
| https://github.com/VoltrexKeyva |
|
VoltrexKeyva
| https://github.com/VoltrexKeyva |
|
| https://github.com/nodejs/node/pull/46482/files/8167f895d081111f73a1073f515833236c7379e2 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/46482/files/0c6719eafc2eb4e43d9a60c996b17187ab374d57 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/46482/files/8167f895d081111f73a1073f515833236c7379e2 |
|
| https://github.com/aymen94 |
|
aymen94
| https://github.com/aymen94 |
|
| https://github.com/nodejs/node/pull/46482/files/0c6719eafc2eb4e43d9a60c996b17187ab374d57 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
Externalise tls.DEFAULT_CIPHERS please!
| https://github.com/nodejs/node/issues/46462 |
| Please reload this page | https://github.com/nodejs/node/pull/46482 |
|
| https://github.com/andreas-ibm |
|
| https://github.com/richardlau |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/aymen94 |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |