| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bad53ed0-ca3e-0d16-ef34-efae96c7b3fe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A44:27A664:29F6F7:3AAB09:696A07B9 |
| html-safe-nonce | 24af16b4fc872d3338ed1f29d724aa3dfa5c1dacd3f5bac65881749da9e1a8fe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTQ0OjI3QTY2NDoyOUY2Rjc6M0FBQjA5OjY5NkEwN0I5IiwidmlzaXRvcl9pZCI6IjEyMzM5NzYyNDUxNDk2MzI0NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9d99af67ce334e7ec350572348b30667c356abe553acd9d7edd2e77597af6d2b |
| hovercard-subject-tag | pull_request:1220786173 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46410/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0542dddc6b01c8054beec4322278ba1837523a3c922ec96fe2e055f547b2adfa/nodejs/node/pull/46410 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0542dddc6b01c8054beec4322278ba1837523a3c922ec96fe2e055f547b2adfa/nodejs/node/pull/46410 |
| og:image:alt | This work was done in collaboration with me, @miguelteixeiraa and @lemire. I would also like to thank @addaleax and @ronag for their help.
This pull request replaces the existing URL parser with Ad... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/46410#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46410 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46410 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/46410 |
| Reload | https://github.com/nodejs/node/pull/46410 |
| Reload | https://github.com/nodejs/node/pull/46410 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/46410#issue-comment-box |
| anonrig | https://github.com/anonrig |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:deps/ada | https://github.com/anonrig/node/tree/deps/ada |
|
deps: replace url parser with Ada
| https://github.com/nodejs/node/pull/46410#top |
| anonrig | https://github.com/anonrig |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:deps/ada | https://github.com/anonrig/node/tree/deps/ada |
|
Conversation
71
| https://github.com/nodejs/node/pull/46410 |
|
Commits
2
| https://github.com/nodejs/node/pull/46410/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/46410/checks |
|
Files changed
| https://github.com/nodejs/node/pull/46410/files |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jan 29, 2023 | https://github.com/nodejs/node/pull/46410#issue-1561480812 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| @miguelteixeiraa | https://github.com/miguelteixeiraa |
| @lemire | https://github.com/lemire |
| @addaleax | https://github.com/addaleax |
| @ronag | https://github.com/ronag |
| Ada | https://github.com/ada-url/ada |
| Ada | https://github.com/ada-url/ada |
| https://ada-url.github.io/ada | https://ada-url.github.io/ada |
| Dropping ICU as a dependency of Ada | https://github.com/ada-url/ada/issues/89 |
| Current benchmarks | https://github.com/ada-url/ada/issues/142#issuecomment-1407732727 |
| similar but sometimes faster | https://github.com/nodejs/performance/issues/33#issuecomment-1407731293 |
| #46332 | https://github.com/nodejs/node/issues/46332 |
| #46063 | https://github.com/nodejs/node/issues/46063 |
| #30334 | https://github.com/nodejs/node/issues/30334 |
| #44476 | https://github.com/nodejs/node/issues/44476 |
| nodejs/performance#33 | https://github.com/nodejs/performance/issues/33 |
| #41220 | https://github.com/nodejs/node/issues/41220 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 29, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1407785339 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jan 29, 2023 | https://github.com/nodejs/node/pull/46410#event-8382725324 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/8f4d1a463d29da08c29fb20d0835ca813100841e..4a68c848ba0a101b04ab670745fe3b82b6f4ca8d |
| 8f4d1a4 | https://github.com/nodejs/node/commit/8f4d1a463d29da08c29fb20d0835ca813100841e |
| 4a68c84 | https://github.com/nodejs/node/commit/4a68c848ba0a101b04ab670745fe3b82b6f4ca8d |
|
Compare
| https://github.com/nodejs/node/compare/8f4d1a463d29da08c29fb20d0835ca813100841e..4a68c848ba0a101b04ab670745fe3b82b6f4ca8d |
| January 30, 2023 02:37 | https://github.com/nodejs/node/pull/46410#event-8383589281 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jan 30, 2023
| https://github.com/nodejs/node/pull/46410#pullrequestreview-1274719754 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46410/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/46410#pullrequestreview-1274719754 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/21adb013aa1819f224deb8111a5065c96b58d005..6f070dc149b2ff2cc693d1ad709974a6662b9e03 |
| 21adb01 | https://github.com/nodejs/node/commit/21adb013aa1819f224deb8111a5065c96b58d005 |
| 6f070dc | https://github.com/nodejs/node/commit/6f070dc149b2ff2cc693d1ad709974a6662b9e03 |
|
Compare
| https://github.com/nodejs/node/compare/21adb013aa1819f224deb8111a5065c96b58d005..6f070dc149b2ff2cc693d1ad709974a6662b9e03 |
| January 30, 2023 17:28 | https://github.com/nodejs/node/pull/46410#event-8390705856 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Jan 30, 2023
| https://github.com/nodejs/node/pull/46410#ref-issue-1560415727 |
|
Add Ada to Node.js
ada-url/ada#142
| https://github.com/ada-url/ada/issues/142 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Jan 30, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1409054821 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jan 30, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1409068485 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/5e1e1acec1d8ea232bddd41b3da9538fefb01644..a1c7401fa6324320e5732c04d89d01a198c65837 |
| 5e1e1ac | https://github.com/nodejs/node/commit/5e1e1acec1d8ea232bddd41b3da9538fefb01644 |
| a1c7401 | https://github.com/nodejs/node/commit/a1c7401fa6324320e5732c04d89d01a198c65837 |
|
Compare
| https://github.com/nodejs/node/compare/5e1e1acec1d8ea232bddd41b3da9538fefb01644..a1c7401fa6324320e5732c04d89d01a198c65837 |
| January 30, 2023 20:35 | https://github.com/nodejs/node/pull/46410#event-8392280145 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Jan 30, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1409338059 |
| @targos | https://github.com/targos |
| @Trott | https://github.com/Trott |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
| Jan 30, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1409356894 |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/eb45d676a2c7dc1a4bb71706afd67713a732a80c..17d3ed7620240a1790a4b0afb774546b678968e0 |
| eb45d67 | https://github.com/nodejs/node/commit/eb45d676a2c7dc1a4bb71706afd67713a732a80c |
| 17d3ed7 | https://github.com/nodejs/node/commit/17d3ed7620240a1790a4b0afb774546b678968e0 |
|
Compare
| https://github.com/nodejs/node/compare/eb45d676a2c7dc1a4bb71706afd67713a732a80c..17d3ed7620240a1790a4b0afb774546b678968e0 |
| February 1, 2023 19:14 | https://github.com/nodejs/node/pull/46410#event-8413751834 |
| https://github.com/TimothyGu |
| TimothyGu | https://github.com/TimothyGu |
| Feb 1, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1412600757 |
| ada-url/ada#89 | https://github.com/ada-url/ada/issues/89 |
| whatwg/url#744 | https://github.com/whatwg/url/issues/744 |
| https://github.com/jsdom/tr46 | https://github.com/jsdom/tr46 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| https://github.com/lemire |
| lemire | https://github.com/lemire |
| Feb 1, 2023 | https://github.com/nodejs/node/pull/46410#issuecomment-1412622851 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
| anonrig | https://github.com/anonrig |
|
Apr 5, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-f9c58e7 |
|
| https://github.com/anonrig |
| url: replace url-parser with ada | https://github.com/anonrig/node/commit/f9c58e7d444abe4b2aaa23d8285c8cdebead5c4b |
| f9c58e7 | https://github.com/anonrig/node/commit/f9c58e7d444abe4b2aaa23d8285c8cdebead5c4b |
| nodejs#46410 | https://github.com/nodejs/node/pull/46410 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46410#ref-pullrequest-1595264208 |
|
meta: update CODEOWNERS of url implementations
#46775
| https://github.com/nodejs/node/pull/46775 |
| anonrig | https://github.com/anonrig |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-f5efd65 |
|
| https://github.com/anonrig |
| deps: add ada as a dependency | https://github.com/anonrig/node/commit/f5efd65dad1c3844e32b995e030187b2c4194cd2 |
| f5efd65 | https://github.com/anonrig/node/commit/f5efd65dad1c3844e32b995e030187b2c4194cd2 |
| nodejs#46410 | https://github.com/nodejs/node/pull/46410 |
| anonrig | https://github.com/anonrig |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-e5385e5 |
|
| https://github.com/anonrig |
| url: replace url-parser with ada | https://github.com/anonrig/node/commit/e5385e5a99bba50c794b554455b2dd7b957904c4 |
| e5385e5 | https://github.com/anonrig/node/commit/e5385e5a99bba50c794b554455b2dd7b957904c4 |
| nodejs#46410 | https://github.com/nodejs/node/pull/46410 |
| anonrig | https://github.com/anonrig |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-ea03c6f |
|
| https://github.com/anonrig |
| deps: add ada as a dependency | https://github.com/anonrig/node/commit/ea03c6f7c78e76f4e96d0d2659aa102440e185a0 |
| ea03c6f | https://github.com/anonrig/node/commit/ea03c6f7c78e76f4e96d0d2659aa102440e185a0 |
| nodejs#46410 | https://github.com/nodejs/node/pull/46410 |
| anonrig | https://github.com/anonrig |
|
Apr 11, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-b227448 |
|
| https://github.com/anonrig |
| url: replace url-parser with ada | https://github.com/anonrig/node/commit/b227448cfcb0c457277986cd106c522a2bc6db81 |
| b227448 | https://github.com/anonrig/node/commit/b227448cfcb0c457277986cd106c522a2bc6db81 |
| nodejs#46410 | https://github.com/nodejs/node/pull/46410 |
| danielleadams | https://github.com/danielleadams |
|
Apr 12, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-0bc4c17 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| deps: add ada as a dependency | https://github.com/nodejs/node/commit/0bc4c17e5705ea042cda392343d7301bb91873ed |
| 0bc4c17 | https://github.com/nodejs/node/commit/0bc4c17e5705ea042cda392343d7301bb91873ed |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| #47435 | https://github.com/nodejs/node/pull/47435 |
| danielleadams | https://github.com/danielleadams |
|
Apr 12, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-e926354 |
|
| https://github.com/anonrig |
|
| https://github.com/danielleadams |
| url: replace url-parser with ada | https://github.com/nodejs/node/commit/e9263541a76e23c6d58c5f480de0a3cf8b00967a |
| e926354 | https://github.com/nodejs/node/commit/e9263541a76e23c6d58c5f480de0a3cf8b00967a |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| #47435 | https://github.com/nodejs/node/pull/47435 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
backported-to-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackported-to-v18.x |
|
backport-open-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v18.x |
| Apr 12, 2023 | https://github.com/nodejs/node/pull/46410#event-8980296691 |
| danielleadams | https://github.com/danielleadams |
|
Apr 12, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-43d167a |
|
| https://github.com/danielleadams |
| 2023-04-12, Version 18.16.0 'Hydrogen' (LTS) | https://github.com/nodejs/node/commit/43d167a262d0772a73ec1e21316e722bad71e4f8 |
| 43d167a | https://github.com/nodejs/node/commit/43d167a262d0772a73ec1e21316e722bad71e4f8 |
| #45038 | https://github.com/nodejs/node/pull/45038 |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| #46500 | https://github.com/nodejs/node/pull/46500 |
| #46816 | https://github.com/nodejs/node/pull/46816 |
| #46716 | https://github.com/nodejs/node/pull/46716 |
| #46444 | https://github.com/nodejs/node/pull/46444 |
| #46523 | https://github.com/nodejs/node/pull/46523 |
| #46387 | https://github.com/nodejs/node/pull/46387 |
| #46494 | https://github.com/nodejs/node/pull/46494 |
| #46583 | https://github.com/nodejs/node/pull/46583 |
| #46368 | https://github.com/nodejs/node/pull/46368 |
| #46273 | https://github.com/nodejs/node/pull/46273 |
| #46978 | https://github.com/nodejs/node/pull/46978 |
| #46308 | https://github.com/nodejs/node/pull/46308 |
| #46832 | https://github.com/nodejs/node/pull/46832 |
| #47502 | https://github.com/nodejs/node/pull/47502 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Apr 12, 2023
| https://github.com/nodejs/node/pull/46410#ref-pullrequest-1661695566 |
|
v18.16.0 release proposal
#47502
| https://github.com/nodejs/node/pull/47502 |
| danielleadams | https://github.com/danielleadams |
|
Apr 13, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-5273947 |
|
| https://github.com/danielleadams |
| 2023-04-12, Version 18.16.0 'Hydrogen' (LTS) | https://github.com/nodejs/node/commit/527394783ece910bf8c543f5a01f100ae37e5c33 |
| 5273947 | https://github.com/nodejs/node/commit/527394783ece910bf8c543f5a01f100ae37e5c33 |
| #45038 | https://github.com/nodejs/node/pull/45038 |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| #46500 | https://github.com/nodejs/node/pull/46500 |
| #46816 | https://github.com/nodejs/node/pull/46816 |
| #46716 | https://github.com/nodejs/node/pull/46716 |
| #46444 | https://github.com/nodejs/node/pull/46444 |
| #46523 | https://github.com/nodejs/node/pull/46523 |
| #46387 | https://github.com/nodejs/node/pull/46387 |
| #46494 | https://github.com/nodejs/node/pull/46494 |
| #46583 | https://github.com/nodejs/node/pull/46583 |
| #46368 | https://github.com/nodejs/node/pull/46368 |
| #46273 | https://github.com/nodejs/node/pull/46273 |
| #46978 | https://github.com/nodejs/node/pull/46978 |
| #46308 | https://github.com/nodejs/node/pull/46308 |
| #46832 | https://github.com/nodejs/node/pull/46832 |
| #47502 | https://github.com/nodejs/node/pull/47502 |
| codebytere | https://github.com/codebytere |
|
Apr 15, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-349b9df |
|
| https://github.com/codebytere |
| deps: replace url parser with Ada | https://github.com/electron/electron/commit/349b9df251b2c7d5907c6a68d45fa27251fb8533 |
| 349b9df | https://github.com/electron/electron/commit/349b9df251b2c7d5907c6a68d45fa27251fb8533 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 16, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-7ac0d54 |
|
| https://github.com/codebytere |
| deps: replace url parser with Ada | https://github.com/electron/electron/commit/7ac0d5407e720a4e95f8de5c55c1644d92dd8461 |
| 7ac0d54 | https://github.com/electron/electron/commit/7ac0d5407e720a4e95f8de5c55c1644d92dd8461 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 17, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-8d2558f |
|
| https://github.com/codebytere |
| deps: replace url parser with Ada | https://github.com/electron/electron/commit/8d2558f3b1d9d7610c98485c1c632314fe499c64 |
| 8d2558f | https://github.com/electron/electron/commit/8d2558f3b1d9d7610c98485c1c632314fe499c64 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-c1b8515 |
|
| https://github.com/codebytere |
| fix: libc++ buffer overflow in string_view ctor | https://github.com/electron/electron/commit/c1b85153f9b42cddaf8672036360a5568c268f41 |
| c1b8515 | https://github.com/electron/electron/commit/c1b85153f9b42cddaf8672036360a5568c268f41 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-6b325be |
|
| https://github.com/codebytere |
| fix: libc++ buffer overflow in string_view ctor | https://github.com/electron/electron/commit/6b325be7e2e9304298e5f0dfcbe269509208c795 |
| 6b325be | https://github.com/electron/electron/commit/6b325be7e2e9304298e5f0dfcbe269509208c795 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-bdb5238 |
|
| https://github.com/codebytere |
| fix: libc++ buffer overflow in string_view ctor | https://github.com/electron/electron/commit/bdb5238ebee8edefc78abad5748d752d88047f14 |
| bdb5238 | https://github.com/electron/electron/commit/bdb5238ebee8edefc78abad5748d752d88047f14 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-3e0eb41 |
|
| https://github.com/codebytere |
| fix: libc++ buffer overflow in string_view ctor | https://github.com/electron/electron/commit/3e0eb41002ea5ba99a8f26b4dca4b49b6ea7909d |
| 3e0eb41 | https://github.com/electron/electron/commit/3e0eb41002ea5ba99a8f26b4dca4b49b6ea7909d |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| codebytere | https://github.com/codebytere |
|
Apr 18, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-de192c2 |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
| chore: bump node to v18.16.0 (main) ( | https://github.com/electron/electron/commit/de192c2db26c673b5dd0fcc0e44990d580b3543e |
| #37973 | https://github.com/electron/electron/pull/37973 |
| ) | https://github.com/electron/electron/commit/de192c2db26c673b5dd0fcc0e44990d580b3543e |
| de192c2 | https://github.com/electron/electron/commit/de192c2db26c673b5dd0fcc0e44990d580b3543e |
| nodejs/node#46739 | https://github.com/nodejs/node/pull/46739 |
| nodejs/node#46881 | https://github.com/nodejs/node/pull/46881 |
| nodejs/node#45038 | https://github.com/nodejs/node/pull/45038 |
| nodejs/node#41023 | https://github.com/nodejs/node/pull/41023 |
| nodejs/node#46672 | https://github.com/nodejs/node/pull/46672 |
| nodejs/node#46368 | https://github.com/nodejs/node/pull/46368 |
| nodejs/node#46583 | https://github.com/nodejs/node/pull/46583 |
| nodejs/node#46864 | https://github.com/nodejs/node/pull/46864 |
| nodejs/node#46471 | https://github.com/nodejs/node/pull/46471 |
| nodejs/node#46472 | https://github.com/nodejs/node/pull/46472 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| nodejs/node#46978 | https://github.com/nodejs/node/pull/46978 |
| nodejs/node#46528 | https://github.com/nodejs/node/pull/46528 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| nodejs/node#46150 | https://github.com/nodejs/node/pull/46150 |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
|
May 6, 2023
| https://github.com/nodejs/node/pull/46410#ref-issue-1698490934 |
|
Ada's license
#47894
| https://github.com/nodejs/node/issues/47894 |
| https://github.com/pluris |
| pluris | https://github.com/pluris |
|
Aug 10, 2023
| https://github.com/nodejs/node/pull/46410#ref-pullrequest-1845501473 |
|
src: add a condition if the argument of DomainToUnicode is empty
#49097
| https://github.com/nodejs/node/pull/49097 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Aug 20, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-45e5ec8 |
| src: add a condition if the argument of DomainToUnicode is empty | https://github.com/nodejs/node/commit/45e5ec89a66eded97401b45343fe385208678ec6 |
| 45e5ec8 | https://github.com/nodejs/node/commit/45e5ec89a66eded97401b45343fe385208678ec6 |
| #49097 | https://github.com/nodejs/node/pull/49097 |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| UlisesGascon | https://github.com/UlisesGascon |
|
Sep 10, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-4a9ae31 |
|
| https://github.com/UlisesGascon |
| src: add a condition if the argument of DomainToUnicode is empty | https://github.com/nodejs/node/commit/4a9ae315198d19b8289f764463a5f2379d09dce1 |
| 4a9ae31 | https://github.com/nodejs/node/commit/4a9ae315198d19b8289f764463a5f2379d09dce1 |
| #49097 | https://github.com/nodejs/node/pull/49097 |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| https://github.com/pluris |
| pluris | https://github.com/pluris |
|
Oct 18, 2023
| https://github.com/nodejs/node/pull/46410#ref-pullrequest-1950149415 |
|
src: use ostringstream instead of string in FromFilePath()
#50253
| https://github.com/nodejs/node/pull/50253 |
| targos | https://github.com/targos |
|
Nov 27, 2023
| https://github.com/nodejs/node/pull/46410#ref-commit-8c33731 |
|
| https://github.com/targos |
| src: add a condition if the argument of DomainToUnicode is empty | https://github.com/nodejs/node/commit/8c33731ac63a3ec07a99ab3a533a71470fd8921f |
| 8c33731 | https://github.com/nodejs/node/commit/8c33731ac63a3ec07a99ab3a533a71470fd8921f |
| #49097 | https://github.com/nodejs/node/pull/49097 |
| #46410 | https://github.com/nodejs/node/pull/46410 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/46410#ref-commit-ff49d15 |
|
| https://github.com/sercher |
| src: add a condition if the argument of DomainToUnicode is | https://github.com/sercher/graaljs/commit/ff49d159d6210665fb5a2e8fb2540f2698084076 |
| ff49d15 | https://github.com/sercher/graaljs/commit/ff49d159d6210665fb5a2e8fb2540f2698084076 |
| nodejs/node#49097 | https://github.com/nodejs/node/pull/49097 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/46410#ref-commit-d4dcab4 |
|
| https://github.com/sercher |
| src: add a condition if the argument of DomainToUnicode is | https://github.com/sercher/graaljs/commit/d4dcab43e2e803f61b955c181e797bde6243e33c |
| d4dcab4 | https://github.com/sercher/graaljs/commit/d4dcab43e2e803f61b955c181e797bde6243e33c |
| nodejs/node#49097 | https://github.com/nodejs/node/pull/49097 |
| nodejs/node#46410 | https://github.com/nodejs/node/pull/46410 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
baking-for-lts
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abaking-for-lts |
| May 8, 2024 | https://github.com/nodejs/node/pull/46410#event-12744260879 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46410 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/46410/files/d3150d64c968aa9a372aacd9a5bca6810c0b6463 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/46410/files/52d346dfd24dc14ef62a20cea2ad4bb2d9289250 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/46410/files/50779eaefd94ff81e298f54932ae6f08dd8c5566 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/46410/files/52d346dfd24dc14ef62a20cea2ad4bb2d9289250 |
|
| https://github.com/RafaelGSS |
|
RafaelGSS
| https://github.com/RafaelGSS |
|
| https://github.com/nodejs/node/pull/46410/files/52d346dfd24dc14ef62a20cea2ad4bb2d9289250 |
|
| https://github.com/dougwilson |
|
dougwilson
| https://github.com/dougwilson |
|
| https://github.com/nodejs/node/pull/46410/files/b17126dcfc50eef4d0324bf823fd131653540139 |
|
| https://github.com/bmeck |
|
bmeck
| https://github.com/bmeck |
|
| https://github.com/nodejs/node/pull/46410/files/d3150d64c968aa9a372aacd9a5bca6810c0b6463 |
|
| https://github.com/TimothyGu |
|
TimothyGu
| https://github.com/TimothyGu |
|
| https://github.com/nodejs/node/pull/46410/files/6cfc59bb6b736123ed7ec72e96df4e133ee8ccfc |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
review wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22 |
|
URL API: ensure it roundtrips for opaque paths
| https://github.com/nodejs/node/issues/46063 |
|
Investigate slow new URL
| https://github.com/nodejs/performance/issues/33 |
|
custom protocol parse result is different from chrome and firefox
| https://github.com/nodejs/node/issues/44476 |
|
Bug in WHATWG URL parsing
| https://github.com/nodejs/node/issues/41220 |
|
Performance of WHATWG URL API
| https://github.com/nodejs/node/issues/30334 |
|
Strip tab and newline from URL's protocol setter
| https://github.com/nodejs/node/issues/46332 |
| Please reload this page | https://github.com/nodejs/node/pull/46410 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joyeecheung |
|
| https://github.com/MoLow |
|
| https://github.com/TimothyGu |
|
| https://github.com/lemire |
|
| https://github.com/Trott |
|
| https://github.com/targos |
|
| https://github.com/radekg |
|
| https://github.com/richardlau |
|
| https://github.com/danielleadams |
|
| https://github.com/mcollina |
|
| https://github.com/dougwilson |
|
| https://github.com/bmeck |
|
| https://github.com/jasnell |
|
| https://github.com/benjamingr |
|
| https://github.com/ronag |
|
| https://github.com/RafaelGSS |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |