| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dd7668d4-7baf-6eae-da29-4592e32b7299 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8946:178041:6F7A0E:9AE1E2:696A7196 |
| html-safe-nonce | 871f7a156e36446f712d0dcbfae220c7a26e8171dd9f7a7c6a94d563e712da40 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTQ2OjE3ODA0MTo2RjdBMEU6OUFFMUUyOjY5NkE3MTk2IiwidmlzaXRvcl9pZCI6IjIxNjUyNzMyMTUzMzAwNTQ1NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 88fc837272f02e5f52e0bf32b0046aaa759213041a4df8201d598b1157acfb05 |
| hovercard-subject-tag | pull_request:1209234981 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46263/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0922285a53bddfbd03954190bd091f8ba38f46c63d61a395270f22ecd75dcee0/nodejs/node/pull/46263 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0922285a53bddfbd03954190bd091f8ba38f46c63d61a395270f22ecd75dcee0/nodejs/node/pull/46263 |
| og:image:alt | Refs: nodejs/build#2998
Small icu seems broken from 14.x since it uses
python2. Although main no longer supports python2
landing and backporting this change to the 14.x line would allow us to simpl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/46263#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46263 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46263 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/46263 |
| Reload | https://github.com/nodejs/node/pull/46263 |
| Reload | https://github.com/nodejs/node/pull/46263 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/46263#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| mhdawson:fix-icu-trim | https://github.com/mhdawson/io.js/tree/fix-icu-trim |
|
tools: allow icutrim.py to run on python2
| https://github.com/nodejs/node/pull/46263#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| mhdawson:fix-icu-trim | https://github.com/mhdawson/io.js/tree/fix-icu-trim |
|
Conversation
13
| https://github.com/nodejs/node/pull/46263 |
|
Commits
2
| https://github.com/nodejs/node/pull/46263/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/46263/checks |
|
Files changed
| https://github.com/nodejs/node/pull/46263/files |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 18, 2023 | https://github.com/nodejs/node/pull/46263#issue-1548239190 |
| nodejs/build#2998 | https://github.com/nodejs/build/issues/2998 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
|
| https://github.com/mhdawson |
| tools: allow icutrim.py to run on python2 | https://github.com/nodejs/node/pull/46263/commits/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
| 1714f3d | https://github.com/nodejs/node/pull/46263/commits/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
| nodejs/build#2998 | https://github.com/nodejs/build/issues/2998 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
icu
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aicu |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Jan 18, 2023 | https://github.com/nodejs/node/pull/46263#event-8306644142 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 18, 2023
| https://github.com/nodejs/node/pull/46263#ref-issue-1304802107 |
|
testing with small icu
nodejs/build#2998
| https://github.com/nodejs/build/issues/2998 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Jan 19, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1261098348 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 19, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1261184813 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
| targos | https://github.com/targos |
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1261184813 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jan 19, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1261611516 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
| tools/icu/icutrim.py | https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9#diff-33177a3cb56ffddea7f24c734292cf2fcc26ba11a3e12ccbd93266c2aabc6da3 |
| bnoordhuis | https://github.com/bnoordhuis |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/46263#discussion_r1081142800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1397119372 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1397211384 |
| #40209 | https://github.com/nodejs/node/issues/40209 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1398225469 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 20, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1264213823 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
| tools/icu/icutrim.py | https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9#diff-33177a3cb56ffddea7f24c734292cf2fcc26ba11a3e12ccbd93266c2aabc6da3 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
|
| https://github.com/mhdawson |
| Update tools/icu/icutrim.py | https://github.com/nodejs/node/pull/46263/commits/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
| b7e4e19 | https://github.com/nodejs/node/pull/46263/commits/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1398843843 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 20, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1264224724 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1398870796 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/46263#event-8324768638 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/46263#event-8324816427 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1398879031 |
| https://ci.nodejs.org/job/node-test-pull-request/49109/ | https://ci.nodejs.org/job/node-test-pull-request/49109/ |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 21, 2023
| https://github.com/nodejs/node/pull/46263#ref-issue-1551611099 |
|
CI Reliability 2023-01-21
nodejs/reliability#490
| https://github.com/nodejs/reliability/issues/490 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 21, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1399192178 |
| https://ci.nodejs.org/job/node-test-pull-request/49115/ | https://ci.nodejs.org/job/node-test-pull-request/49115/ |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jan 21, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1264655326 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 21, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1399316422 |
| https://ci.nodejs.org/job/node-test-pull-request/49121/ | https://ci.nodejs.org/job/node-test-pull-request/49121/ |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 21, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1264658228 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Jan 21, 2023 | https://github.com/nodejs/node/pull/46263#event-8327727280 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jan 21, 2023 | https://github.com/nodejs/node/pull/46263#event-8327733824 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 7ea2fc8 | https://github.com/nodejs/node/commit/7ea2fc8cc47be8f064a6946ca801c830b97df879 |
| Jan 21, 2023 | https://github.com/nodejs/node/pull/46263#event-8327733890 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 21, 2023 | https://github.com/nodejs/node/pull/46263#issuecomment-1399323320 |
| 7ea2fc8 | https://github.com/nodejs/node/commit/7ea2fc8cc47be8f064a6946ca801c830b97df879 |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
|
CI Reliability 2023-01-22
nodejs/reliability#491
| https://github.com/nodejs/reliability/issues/491 |
|
CI Reliability 2023-01-23
nodejs/reliability#492
| https://github.com/nodejs/reliability/issues/492 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
lts-watch-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v14.x |
| Jan 23, 2023 | https://github.com/nodejs/node/pull/46263#event-8334311693 |
|
CI Reliability 2023-01-24
nodejs/reliability#493
| https://github.com/nodejs/reliability/issues/493 |
|
CI Reliability 2023-01-25
nodejs/reliability#494
| https://github.com/nodejs/reliability/issues/494 |
| ruyadorno | https://github.com/ruyadorno |
|
Feb 1, 2023
| https://github.com/nodejs/node/pull/46263#ref-commit-e75faff |
|
| https://github.com/mhdawson |
|
| https://github.com/ruyadorno |
| tools: allow icutrim.py to run on python2 | https://github.com/nodejs/node/commit/e75faff4bddd414408038beadaf8b73f217fdd45 |
| e75faff | https://github.com/nodejs/node/commit/e75faff4bddd414408038beadaf8b73f217fdd45 |
| nodejs/build#2998 | https://github.com/nodejs/build/issues/2998 |
| #46263 | https://github.com/nodejs/node/pull/46263 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Feb 1, 2023
| https://github.com/nodejs/node/pull/46263#ref-pullrequest-1565364938 |
|
v19.6.0 proposal
#46455
| https://github.com/nodejs/node/pull/46455 |
| juanarbol | https://github.com/juanarbol |
|
Mar 3, 2023
| https://github.com/nodejs/node/pull/46263#ref-commit-56709e8 |
|
| https://github.com/mhdawson |
|
| https://github.com/juanarbol |
| tools: allow icutrim.py to run on python2 | https://github.com/nodejs/node/commit/56709e87aa459f0f02995e7da143bfc0d1f4c2db |
| 56709e8 | https://github.com/nodejs/node/commit/56709e87aa459f0f02995e7da143bfc0d1f4c2db |
| nodejs/build#2998 | https://github.com/nodejs/build/issues/2998 |
| #46263 | https://github.com/nodejs/node/pull/46263 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Mar 3, 2023
| https://github.com/nodejs/node/pull/46263#ref-pullrequest-1607843583 |
|
V18.15.0 proposal
#46920
| https://github.com/nodejs/node/pull/46920 |
| juanarbol | https://github.com/juanarbol |
|
Mar 5, 2023
| https://github.com/nodejs/node/pull/46263#ref-commit-60d714e |
|
| https://github.com/mhdawson |
|
| https://github.com/juanarbol |
| tools: allow icutrim.py to run on python2 | https://github.com/nodejs/node/commit/60d714e0c31f2ba188a66e16922992f5d02cd5bd |
| 60d714e | https://github.com/nodejs/node/commit/60d714e0c31f2ba188a66e16922992f5d02cd5bd |
| nodejs/build#2998 | https://github.com/nodejs/build/issues/2998 |
| #46263 | https://github.com/nodejs/node/pull/46263 |
| https://github.com/srl295 |
| srl295 | https://github.com/srl295 |
|
Apr 4, 2023
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1371861593 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
| srl295 | https://github.com/srl295 |
| https://github.com/nodejs/node/pull/46263#pullrequestreview-1371861593 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46263 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
|
| https://github.com/srl295 |
|
srl295
| https://github.com/srl295 |
|
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/46263/files/1714f3d1145cc53afa0dab20a9c341a3a4498ef9 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/46263/files/b7e4e1934085ae960dc5727ba82b4c24b74d2581 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
i18n-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api |
|
icu
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aicu |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/46263 |
|
| https://github.com/mhdawson |
|
| https://github.com/richardlau |
|
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/srl295 |
|
| https://github.com/lpinca |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |