René's URL Explorer Experiment


Title: src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid by miguelteixeiraa · Pull Request #46227 · nodejs/node · GitHub

Open Graph Title: src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid by miguelteixeiraa · Pull Request #46227 · nodejs/node

X Title: src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid by miguelteixeiraa · Pull Request #46227 · nodejs/node

Description: Removes the use of vector in EndsInANumber and uses IsIPv4NumberValid instead of parsing the number to check if it is valid. Fixes: nodejs/performance#36 Refs: ada-url/ada#36

Open Graph Description: Removes the use of vector in EndsInANumber and uses IsIPv4NumberValid instead of parsing the number to check if it is valid. Fixes: nodejs/performance#36 Refs: ada-url/ada#36

X Description: Removes the use of vector in EndsInANumber and uses IsIPv4NumberValid instead of parsing the number to check if it is valid. Fixes: nodejs/performance#36 Refs: ada-url/ada#36

Opengraph URL: https://github.com/nodejs/node/pull/46227

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e8d0c0d-d00b-0946-86c7-a4995841de19
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8660:359CC2:B1E9D:F88B4:696A3DB1
html-safe-nonce37f4649818e71158862656a772cfb1012bae30b052104723db44a18eda9a699f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjYwOjM1OUNDMjpCMUU5RDpGODhCNDo2OTZBM0RCMSIsInZpc2l0b3JfaWQiOiI1MjMzNTg0NzUxOTQyMTg4NDY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac409bee5d6ab883a5f8c003afb6eb0810ffea1dfaf0d7a56881b8293a710a5b0b
hovercard-subject-tagpull_request:1199520381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46227/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6b3dd8bef4ef0d910cc32d1f073739743008a8b155b6cce23e93d21db74bff8c/nodejs/node/pull/46227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6b3dd8bef4ef0d910cc32d1f073739743008a8b155b6cce23e93d21db74bff8c/nodejs/node/pull/46227
og:image:altRemoves the use of vector in EndsInANumber and uses IsIPv4NumberValid instead of parsing the number to check if it is valid. Fixes: nodejs/performance#36 Refs: ada-url/ada#36
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiguelteixeiraa
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/46227#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46227
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46227
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/46227
Reloadhttps://github.com/nodejs/node/pull/46227
Reloadhttps://github.com/nodejs/node/pull/46227
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/46227#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
miguelteixeiraa:node-performance-36https://github.com/miguelteixeiraa/node/tree/node-performance-36
src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValid https://github.com/nodejs/node/pull/46227#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
miguelteixeiraa:node-performance-36https://github.com/miguelteixeiraa/node/tree/node-performance-36
Conversation 92 https://github.com/nodejs/node/pull/46227
Commits 14 https://github.com/nodejs/node/pull/46227/commits
Checks 0 https://github.com/nodejs/node/pull/46227/checks
Files changed https://github.com/nodejs/node/pull/46227/files
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issue-1535512896
nodejs/performance#36https://github.com/nodejs/performance/issues/36
ada-url/ada#36https://github.com/ada-url/ada/pull/36
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValidhttps://github.com/nodejs/node/pull/46227/commits/ff9c478e8fc74bd98c61ced7021779c6eb8a52b2
ff9c478https://github.com/nodejs/node/pull/46227/commits/ff9c478e8fc74bd98c61ced7021779c6eb8a52b2
nodejs/performance#36https://github.com/nodejs/performance/issues/36
ada-url/ada#36https://github.com/ada-url/ada/pull/36
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Jan 16, 2023https://github.com/nodejs/node/pull/46227#event-8240219993
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1384595585
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1384597396
@miguelteixeiraahttps://github.com/miguelteixeiraa
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
src: fix node_url.cc code formattinghttps://github.com/nodejs/node/pull/46227/commits/f07693501d5d1303709085c1da44c63a39b5faa5
f076935https://github.com/nodejs/node/pull/46227/commits/f07693501d5d1303709085c1da44c63a39b5faa5
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1384617072
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1384619382
@miguelteixeiraahttps://github.com/miguelteixeiraa
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1384619990
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
src: fix node_url.cc code formatting (back to what it was)https://github.com/nodejs/node/pull/46227/commits/b1f4c83a57a455647fba52e6c9d4099e9a6d4155
b1f4c83https://github.com/nodejs/node/pull/46227/commits/b1f4c83a57a455647fba52e6c9d4099e9a6d4155
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 16, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1384632817
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 16, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1250708053
View reviewed changes https://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/b1f4c83a57a455647fba52e6c9d4099e9a6d4155#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 16, 2023https://github.com/nodejs/node/pull/46227#event-8240471136
miguelteixeiraahttps://github.com/miguelteixeiraa
January 16, 2023 21:27https://github.com/nodejs/node/pull/46227#commits-pushed-95d3081
https://github.com/miguelteixeiraa
src: refactor EndsInANumber in node_url.cc to use string_view::rfindhttps://github.com/nodejs/node/pull/46227/commits/95d3081e305e59fd8975fb25c045afd3119a40ac
95d3081https://github.com/nodejs/node/pull/46227/commits/95d3081e305e59fd8975fb25c045afd3119a40ac
https://github.com/miguelteixeiraa
src: fix imports typo in node_url.cchttps://github.com/nodejs/node/pull/46227/commits/e9282ad65a63d8d2dcc637495cd7164545b1ca98
e9282adhttps://github.com/nodejs/node/pull/46227/commits/e9282ad65a63d8d2dcc637495cd7164545b1ca98
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 17, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1250831688
View reviewed changes https://github.com/nodejs/node/pull/46227/files/e9282ad65a63d8d2dcc637495cd7164545b1ca98
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/e9282ad65a63d8d2dcc637495cd7164545b1ca98#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 17, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1251307213
View reviewed changes https://github.com/nodejs/node/pull/46227/files/e9282ad65a63d8d2dcc637495cd7164545b1ca98
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/e9282ad65a63d8d2dcc637495cd7164545b1ca98#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
January 17, 2023 10:06https://github.com/nodejs/node/pull/46227#commits-pushed-a683d34
https://github.com/miguelteixeiraa
src: removes unnecessary if statement from EndsInANumber in node_url.cchttps://github.com/nodejs/node/pull/46227/commits/a683d340f33c4094cb84b5087b46e1921d610218
a683d34https://github.com/nodejs/node/pull/46227/commits/a683d340f33c4094cb84b5087b46e1921d610218
https://github.com/miguelteixeiraa
src: use string_view instead of string in EndsInANumber in node_url.cchttps://github.com/nodejs/node/pull/46227/commits/d165e39a9ae4620c2f6025543595ba01e909838c
d165e39https://github.com/nodejs/node/pull/46227/commits/d165e39a9ae4620c2f6025543595ba01e909838c
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 17, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1385493259
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1293/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1293/
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 17, 2023https://github.com/nodejs/node/pull/46227#event-8246142637
https://github.com/anonrig
anonrighttps://github.com/anonrig
jasnellhttps://github.com/jasnell
January 17, 2023 14:15https://github.com/nodejs/node/pull/46227#event-8246143354
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 17, 2023https://github.com/nodejs/node/pull/46227#event-8246166534
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 17, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1385497669
https://ci.nodejs.org/job/node-test-pull-request/49009/https://ci.nodejs.org/job/node-test-pull-request/49009/
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 17, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1385617953
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
src: fix string_view constructor call for IsIPv4NumberValid in node_u…https://github.com/nodejs/node/pull/46227/commits/573dd4af7dda4da573f6f165f5f5898852a46f1d
573dd4ahttps://github.com/nodejs/node/pull/46227/commits/573dd4af7dda4da573f6f165f5f5898852a46f1d
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 17, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1252547915
View reviewed changes https://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
anonrighttps://github.com/anonrig
Jan 17, 2023https://github.com/nodejs/node/pull/46227#discussion_r1072892229
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073566324
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073653163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073951221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
&(*it);https://stackoverflow.com/a/19569899
Please reload this pagehttps://github.com/nodejs/node/pull/46227
anonrighttps://github.com/anonrig
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073953073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073988829
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1074029016
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://en.cppreference.com/w/cpp/named_req/RandomAccessIteratorhttps://en.cppreference.com/w/cpp/named_req/RandomAccessIterator
https://stackoverflow.com/questions/32654108/c-stdvectoriterator-is-not-a-pointer-why/64910815#64910815https://stackoverflow.com/questions/32654108/c-stdvectoriterator-is-not-a-pointer-why/64910815#64910815
Please reload this pagehttps://github.com/nodejs/node/pull/46227
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
anonrighttps://github.com/anonrig
Jan 17, 2023https://github.com/nodejs/node/pull/46227#discussion_r1072892421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073566080
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073654729
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
anonrighttps://github.com/anonrig
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1073967792
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
addaleaxhttps://github.com/addaleax
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1080616184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 18, 2023https://github.com/nodejs/node/pull/46227#discussion_r1080623500
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 17, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1252549233
View reviewed changes https://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 17, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1252549401
View reviewed changes https://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d
src/node_url.cchttps://github.com/nodejs/node/pull/46227/files/573dd4af7dda4da573f6f165f5f5898852a46f1d#diff-3ea8ea727fd1024465c848244a01d422fa4647b640ef6c91ee536bf5de6c86b7
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 20, 2023 https://github.com/nodejs/node/pull/46227#ref-issue-1550136675
CI Reliability 2023-01-20 nodejs/reliability#489 https://github.com/nodejs/reliability/issues/489
https://github.com/miguelteixeiraa
src: refactor EndsInANumber to be more readable in node_url.cchttps://github.com/nodejs/node/pull/46227/commits/9534455fbf68c055ca2453d1722a0a640289b474
9534455https://github.com/nodejs/node/pull/46227/commits/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 20, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1263694149
View reviewed changes https://github.com/nodejs/node/pull/46227/files/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 20, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1398918861
http://www.hello.benchhttp://www.hello.bench
http://www.hello.benchhttp://www.hello.bench
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/anonrig
anonrighttps://github.com/anonrig
RafaelGSShttps://github.com/RafaelGSS
addaleaxhttps://github.com/addaleax
bnoordhuishttps://github.com/bnoordhuis
January 20, 2023 21:04https://github.com/nodejs/node/pull/46227#event-8325178470
https://github.com/anonrig
anonrighttps://github.com/anonrig
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 20, 2023https://github.com/nodejs/node/pull/46227#event-8325179975
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 20, 2023https://github.com/nodejs/node/pull/46227#event-8325241858
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 20, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1398952847
https://ci.nodejs.org/job/node-test-pull-request/49110/https://ci.nodejs.org/job/node-test-pull-request/49110/
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 20, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1399007926
http://www.hello.benchhttp://www.hello.bench
http://www.hello.benchhttp://www.hello.bench
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
miguelteixeiraahttps://github.com/miguelteixeiraa
Jan 20, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1399015539
Please reload this pagehttps://github.com/nodejs/node/pull/46227
Please reload this pagehttps://github.com/nodejs/node/pull/46227
CI Reliability 2023-01-21 nodejs/reliability#490 https://github.com/nodejs/reliability/issues/490
CI Reliability 2023-01-22 nodejs/reliability#491 https://github.com/nodejs/reliability/issues/491
CI Reliability 2023-01-23 nodejs/reliability#492 https://github.com/nodejs/reliability/issues/492
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 23, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1399673290
https://ci.nodejs.org/job/node-test-pull-request/49136/https://ci.nodejs.org/job/node-test-pull-request/49136/
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 23, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1265443595
View reviewed changes https://github.com/nodejs/node/pull/46227/files/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 23, 2023 https://github.com/nodejs/node/pull/46227#pullrequestreview-1265722563
View reviewed changes https://github.com/nodejs/node/pull/46227/files/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jan 23, 2023https://github.com/nodejs/node/pull/46227#event-8335142382
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jan 23, 2023https://github.com/nodejs/node/pull/46227#event-8335193312
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
762a3a8https://github.com/nodejs/node/commit/762a3a8ad925d56a12b43e0e7f7c811e93097784
Jan 23, 2023https://github.com/nodejs/node/pull/46227#event-8335194397
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 23, 2023https://github.com/nodejs/node/pull/46227#issuecomment-1400500438
762a3a8https://github.com/nodejs/node/commit/762a3a8ad925d56a12b43e0e7f7c811e93097784
Please reload this pagehttps://github.com/nodejs/node/pull/46227
CI Reliability 2023-01-24 nodejs/reliability#493 https://github.com/nodejs/reliability/issues/493
CI Reliability 2023-01-25 nodejs/reliability#494 https://github.com/nodejs/reliability/issues/494
ruyadornohttps://github.com/ruyadorno
Feb 1, 2023 https://github.com/nodejs/node/pull/46227#ref-commit-640d111
https://github.com/miguelteixeiraa
https://github.com/ruyadorno
src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValidhttps://github.com/nodejs/node/commit/640d111f956c1bcdbb0d49e70467d8c2afe71d08
640d111https://github.com/nodejs/node/commit/640d111f956c1bcdbb0d49e70467d8c2afe71d08
nodejs/performance#36https://github.com/nodejs/performance/issues/36
ada-url/ada#36https://github.com/ada-url/ada/pull/36
#46227https://github.com/nodejs/node/pull/46227
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Feb 1, 2023 https://github.com/nodejs/node/pull/46227#ref-pullrequest-1565364938
v19.6.0 proposal #46455 https://github.com/nodejs/node/pull/46455
juanarbolhttps://github.com/juanarbol
Mar 3, 2023 https://github.com/nodejs/node/pull/46227#ref-commit-8d90f5c
https://github.com/miguelteixeiraa
https://github.com/juanarbol
src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValidhttps://github.com/nodejs/node/commit/8d90f5ce87a0bfe2166042f2ba77a813ee7859e5
8d90f5chttps://github.com/nodejs/node/commit/8d90f5ce87a0bfe2166042f2ba77a813ee7859e5
nodejs/performance#36https://github.com/nodejs/performance/issues/36
ada-url/ada#36https://github.com/ada-url/ada/pull/36
#46227https://github.com/nodejs/node/pull/46227
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Mar 3, 2023 https://github.com/nodejs/node/pull/46227#ref-pullrequest-1607843583
V18.15.0 proposal #46920 https://github.com/nodejs/node/pull/46920
juanarbolhttps://github.com/juanarbol
Mar 5, 2023 https://github.com/nodejs/node/pull/46227#ref-commit-b06298c
https://github.com/miguelteixeiraa
https://github.com/juanarbol
src: refactor EndsInANumber in node_url.cc and adds IsIPv4NumberValidhttps://github.com/nodejs/node/commit/b06298c98e49ea4d288451d8611222a321e27221
b06298chttps://github.com/nodejs/node/commit/b06298c98e49ea4d288451d8611222a321e27221
nodejs/performance#36https://github.com/nodejs/performance/issues/36
ada-url/ada#36https://github.com/ada-url/ada/pull/36
#46227https://github.com/nodejs/node/pull/46227
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46227
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/46227/files/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/46227/files/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/46227/files/9534455fbf68c055ca2453d1722a0a640289b474
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/RafaelGSS
RafaelGSS https://github.com/RafaelGSS
https://github.com/anonrig
anonrig https://github.com/anonrig
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Do not parse numbers on url parsers - ipv4 https://github.com/nodejs/performance/issues/36
Please reload this pagehttps://github.com/nodejs/node/pull/46227
https://github.com/miguelteixeiraa
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/RafaelGSS
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.