| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5495c23b-2b06-1db8-d9ee-cb369a818644 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E14C:29F2E0:13EED4D:1AD0D3F:69699CB8 |
| html-safe-nonce | 92149d2858ba1a14a2245d20fb87b228f46bd00373bafd12d291a2003f5ba1e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRDOjI5RjJFMDoxM0VFRDREOjFBRDBEM0Y6Njk2OTlDQjgiLCJ2aXNpdG9yX2lkIjoiNDQwMDExNDMzMzQ2NzEyMjg3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | eaa5c982205f9ec464889cdb09c60ce07b4bf3587bca875bb78c020b5eb0261f |
| hovercard-subject-tag | pull_request:1191694950 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46153/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e6f137adf44491e811e7dd333a0f4aaaa395e958f9fb2a2f64f2e16228bb6d2f/nodejs/node/pull/46153 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e6f137adf44491e811e7dd333a0f4aaaa395e958f9fb2a2f64f2e16228bb6d2f/nodejs/node/pull/46153 |
| og:image:alt | As part of #44710 @targos discovered that our test fixture loader for “assertionless” JSON imports—import data from './file.json' where there’s no assert { type: 'json' }—was only w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | GeoffreyBooth |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/46153#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/46153 |
| Reload | https://github.com/nodejs/node/pull/46153 |
| Reload | https://github.com/nodejs/node/pull/46153 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/46153#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| GeoffreyBooth:resolve-hook-returns-import-assertions | https://github.com/GeoffreyBooth/node/tree/resolve-hook-returns-import-assertions |
|
esm: allow resolve to optionally return import assertions
| https://github.com/nodejs/node/pull/46153#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| GeoffreyBooth:resolve-hook-returns-import-assertions | https://github.com/GeoffreyBooth/node/tree/resolve-hook-returns-import-assertions |
|
Conversation
90
| https://github.com/nodejs/node/pull/46153 |
|
Commits
1
| https://github.com/nodejs/node/pull/46153/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/46153/checks |
|
Files changed
| https://github.com/nodejs/node/pull/46153/files |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#issue-1526609075 |
| #44710 | https://github.com/nodejs/node/pull/44710 |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#event-8187353519 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| aduh95 | https://github.com/aduh95 |
| January 10, 2023 01:29 | https://github.com/nodejs/node/pull/46153#event-8187353528 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1376596689 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#event-8187354346 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/52f571cc96cd469590584382d001e7347cf10b7f..c797d07f670c7e7f49338f3e3e8082ebb2340bc5 |
| 52f571c | https://github.com/nodejs/node/commit/52f571cc96cd469590584382d001e7347cf10b7f |
| c797d07 | https://github.com/nodejs/node/commit/c797d07f670c7e7f49338f3e3e8082ebb2340bc5 |
|
Compare
| https://github.com/nodejs/node/compare/52f571cc96cd469590584382d001e7347cf10b7f..c797d07f670c7e7f49338f3e3e8082ebb2340bc5 |
| January 10, 2023 01:32 | https://github.com/nodejs/node/pull/46153#event-8187364085 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| targos | https://github.com/targos |
| January 10, 2023 01:32 | https://github.com/nodejs/node/pull/46153#event-8187366303 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/d34bf01ea940b13a12d05a307e44e3e369c1a991..e80eaa65abfe85ff4645041aa93587dbf10b68c6 |
| d34bf01 | https://github.com/nodejs/node/commit/d34bf01ea940b13a12d05a307e44e3e369c1a991 |
| e80eaa6 | https://github.com/nodejs/node/commit/e80eaa65abfe85ff4645041aa93587dbf10b68c6 |
|
Compare
| https://github.com/nodejs/node/compare/d34bf01ea940b13a12d05a307e44e3e369c1a991..e80eaa65abfe85ff4645041aa93587dbf10b68c6 |
| January 10, 2023 01:55 | https://github.com/nodejs/node/pull/46153#event-8187461905 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1376616308 |
| https://ci.nodejs.org/job/node-test-pull-request/48922/ | https://ci.nodejs.org/job/node-test-pull-request/48922/ |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#event-8188125995 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/e80eaa65abfe85ff4645041aa93587dbf10b68c6..1a9e7d68a14724f7310c2788af4132e0c87ce061 |
| e80eaa6 | https://github.com/nodejs/node/commit/e80eaa65abfe85ff4645041aa93587dbf10b68c6 |
| 1a9e7d6 | https://github.com/nodejs/node/commit/1a9e7d68a14724f7310c2788af4132e0c87ce061 |
|
Compare
| https://github.com/nodejs/node/compare/e80eaa65abfe85ff4645041aa93587dbf10b68c6..1a9e7d68a14724f7310c2788af4132e0c87ce061 |
| January 10, 2023 06:27 | https://github.com/nodejs/node/pull/46153#event-8188549278 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1376792625 |
| https://ci.nodejs.org/job/node-test-pull-request/48924/ | https://ci.nodejs.org/job/node-test-pull-request/48924/ |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1241625162 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1241627710 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| doc/api/esm.md | https://github.com/nodejs/node/pull/46153/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1241631772 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| doc/api/esm.md | https://github.com/nodejs/node/pull/46153/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b |
| targos | https://github.com/targos |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#discussion_r1065408216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#discussion_r1066423011 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| targos | https://github.com/targos |
| Jan 11, 2023 | https://github.com/nodejs/node/pull/46153#discussion_r1066704777 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1241830391 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| doc/api/esm.md | https://github.com/nodejs/node/pull/46153/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1241833089 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/46153/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/46153/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/resolve.js | https://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/resolve.js | https://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/resolve.js | https://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/resolve.js | https://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#event-8190440343 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 10, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1377046016 |
| node/doc/contributing/pull-requests.md | https://github.com/nodejs/node/blob/5af202186016e8e7b2960285ddc928a20b62be0f/doc/contributing/pull-requests.md#L168-L169 |
| 5af2021 | https://github.com/nodejs/node/commit/5af202186016e8e7b2960285ddc928a20b62be0f |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/1a9e7d68a14724f7310c2788af4132e0c87ce061..0a014413ffb1c1771ec2782873d9b98eff6c15d1 |
| 1a9e7d6 | https://github.com/nodejs/node/commit/1a9e7d68a14724f7310c2788af4132e0c87ce061 |
| 0a01441 | https://github.com/nodejs/node/commit/0a014413ffb1c1771ec2782873d9b98eff6c15d1 |
|
Compare
| https://github.com/nodejs/node/compare/1a9e7d68a14724f7310c2788af4132e0c87ce061..0a014413ffb1c1771ec2782873d9b98eff6c15d1 |
| January 10, 2023 18:28 | https://github.com/nodejs/node/pull/46153#event-8194809646 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1242778346 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1242818736 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/0a014413ffb1c1771ec2782873d9b98eff6c15d1..246694f59e8bcecfc3f474798b75db2b2898a66c |
| 0a01441 | https://github.com/nodejs/node/commit/0a014413ffb1c1771ec2782873d9b98eff6c15d1 |
| 246694f | https://github.com/nodejs/node/commit/246694f59e8bcecfc3f474798b75db2b2898a66c |
|
Compare
| https://github.com/nodejs/node/compare/0a014413ffb1c1771ec2782873d9b98eff6c15d1..246694f59e8bcecfc3f474798b75db2b2898a66c |
| January 10, 2023 19:32 | https://github.com/nodejs/node/pull/46153#event-8195245762 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1242850173 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/246694f59e8bcecfc3f474798b75db2b2898a66c..c3a2e8b7b4bfac4d63af02932fc73334bb9b61f4 |
| 246694f | https://github.com/nodejs/node/commit/246694f59e8bcecfc3f474798b75db2b2898a66c |
| c3a2e8b | https://github.com/nodejs/node/commit/c3a2e8b7b4bfac4d63af02932fc73334bb9b61f4 |
|
Compare
| https://github.com/nodejs/node/compare/246694f59e8bcecfc3f474798b75db2b2898a66c..c3a2e8b7b4bfac4d63af02932fc73334bb9b61f4 |
| January 10, 2023 20:04 | https://github.com/nodejs/node/pull/46153#event-8195465245 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 10, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1242889807 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| test/fixtures/es-module-loaders/assertionless-json-import.mjs | https://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| force-pushed | https://github.com/nodejs/node/compare/e9822be22979a333e610212cbf8c5c0f42f86435..349d05475c7b44221eb0ee752aac96b9b41a11cf |
| e9822be | https://github.com/nodejs/node/commit/e9822be22979a333e610212cbf8c5c0f42f86435 |
| 349d054 | https://github.com/nodejs/node/commit/349d05475c7b44221eb0ee752aac96b9b41a11cf |
|
Compare
| https://github.com/nodejs/node/compare/e9822be22979a333e610212cbf8c5c0f42f86435..349d05475c7b44221eb0ee752aac96b9b41a11cf |
| January 10, 2023 20:18 | https://github.com/nodejs/node/pull/46153#event-8195559504 |
| https://github.com/bmeck |
| bmeck | https://github.com/bmeck |
| Jan 11, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1379003759 |
| https://tc39.es/proposal-import-assertions/#sec-semantics | https://tc39.es/proposal-import-assertions/#sec-semantics |
| https://tc39.es/ecma262/#sec-completion-record-specification-type | https://tc39.es/ecma262/#sec-completion-record-specification-type |
| … | https://github.com/nodejs/node/pull/46153 |
| https://github.com/nodejs/node/blob/611d5b46f8457df4c924c237bcaeb55ecf104116/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs#L23 | https://github.com/nodejs/node/blob/611d5b46f8457df4c924c237bcaeb55ecf104116/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs#L23 |
| #46153 (comment) | https://github.com/nodejs/node/pull/46153#issuecomment-1378864782 |
| https://github.com/notifications/unsubscribe-auth/AABZJI6IEWKVRI7ACOZTJSTWR3B53ANCNFSM6AAAAAATWCNIPA | https://github.com/notifications/unsubscribe-auth/AABZJI6IEWKVRI7ACOZTJSTWR3B53ANCNFSM6AAAAAATWCNIPA |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jan 11, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1379218291 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Jan 11, 2023
| https://github.com/nodejs/node/pull/46153#pullrequestreview-1244533728 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979 |
| lib/internal/modules/esm/hooks.js | https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/ljharb |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 12, 2023
| https://github.com/nodejs/node/pull/46153#ref-issue-1529897909 |
|
CI Reliability 2023-01-12
nodejs/reliability#481
| https://github.com/nodejs/reliability/issues/481 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Jan 12, 2023 | https://github.com/nodejs/node/pull/46153#event-8206956766 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 91ca2d4 | https://github.com/nodejs/node/commit/91ca2d40419244a9c542be5ff162a837fcc3be82 |
| Jan 12, 2023 | https://github.com/nodejs/node/pull/46153#event-8206956977 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 12, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1379712880 |
| 91ca2d4 | https://github.com/nodejs/node/commit/91ca2d40419244a9c542be5ff162a837fcc3be82 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| January 12, 2023 03:55 | https://github.com/nodejs/node/pull/46153#event-8207386686 |
|
CI Reliability 2023-01-13
nodejs/reliability#482
| https://github.com/nodejs/reliability/issues/482 |
|
CI Reliability 2023-01-14
nodejs/reliability#483
| https://github.com/nodejs/reliability/issues/483 |
|
CI Reliability 2023-01-15
nodejs/reliability#484
| https://github.com/nodejs/reliability/issues/484 |
|
CI Reliability 2023-01-16
nodejs/reliability#485
| https://github.com/nodejs/reliability/issues/485 |
|
CI Reliability 2023-01-17
nodejs/reliability#486
| https://github.com/nodejs/reliability/issues/486 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
backport-requested-v19.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v19.x |
| Jan 17, 2023 | https://github.com/nodejs/node/pull/46153#event-8248161688 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
| Jan 17, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1385795123 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jan 17, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1385846912 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| @RafaelGSS | https://github.com/RafaelGSS |
| #45869 (comment) | https://github.com/nodejs/node/pull/45869#issuecomment-1369419536 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 18, 2023
| https://github.com/nodejs/node/pull/46153#ref-issue-1537206132 |
|
CI Reliability 2023-01-18
nodejs/reliability#487
| https://github.com/nodejs/reliability/issues/487 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
backport-requested-v18.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x |
| Jan 25, 2023 | https://github.com/nodejs/node/pull/46153#event-8358484826 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
| Jan 25, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1404189204 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jan 25, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1404291803 |
| #43772 | https://github.com/nodejs/node/pull/43772 |
| #45869 | https://github.com/nodejs/node/pull/45869 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
backport-requested-v19.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v19.x |
| Mar 14, 2023 | https://github.com/nodejs/node/pull/46153#event-8739867930 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Mar 14, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1467507684 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46153#ref-commit-18f0398 |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/targos |
| esm: allow resolve to return import assertions | https://github.com/nodejs/node/commit/18f03982423712dae1a049f3912890bd4cd8470f |
| 18f0398 | https://github.com/nodejs/node/commit/18f03982423712dae1a049f3912890bd4cd8470f |
| #46153 | https://github.com/nodejs/node/pull/46153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Mar 14, 2023
| https://github.com/nodejs/node/pull/46153#ref-pullrequest-1622922231 |
|
v19.8.0 release proposal
#47087
| https://github.com/nodejs/node/pull/47087 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Mar 14, 2023 | https://github.com/nodejs/node/pull/46153#issuecomment-1468433258 |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
| targos | https://github.com/targos |
|
Nov 10, 2023
| https://github.com/nodejs/node/pull/46153#ref-commit-45de8d1 |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/targos |
| esm: allow resolve to return import assertions | https://github.com/nodejs/node/commit/45de8d1bd7b199e9a13f23f42c4abbf9b33a6321 |
| 45de8d1 | https://github.com/nodejs/node/commit/45de8d1bd7b199e9a13f23f42c4abbf9b33a6321 |
| #46153 | https://github.com/nodejs/node/pull/46153 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/46153#ref-pullrequest-2014162105 |
|
v18.19.0 release proposal
#50953
| https://github.com/nodejs/node/pull/50953 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/46153#ref-commit-d1377b5 |
|
| https://github.com/sercher |
| esm: allow resolve to return import assertions | https://github.com/sercher/graaljs/commit/d1377b54f25facc19588fc5ff3cfa6adfff9f2cf |
| d1377b5 | https://github.com/sercher/graaljs/commit/d1377b54f25facc19588fc5ff3cfa6adfff9f2cf |
| nodejs/node#46153 | https://github.com/nodejs/node/pull/46153 |
| sercher | https://github.com/sercher |
|
Apr 25, 2024
| https://github.com/nodejs/node/pull/46153#ref-commit-3b8eb99 |
|
| https://github.com/sercher |
| esm: allow resolve to return import assertions | https://github.com/sercher/graaljs/commit/3b8eb998c189267b4b985fc861351e78bd87e1fd |
| 3b8eb99 | https://github.com/sercher/graaljs/commit/3b8eb998c189267b4b985fc861351e78bd87e1fd |
| nodejs/node#46153 | https://github.com/nodejs/node/pull/46153 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979 |
|
| https://github.com/JakobJingleheimer |
|
JakobJingleheimer
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/46153/files/cf7490b54ee919d00d54bcedd68066cb745720c1 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
| Please reload this page | https://github.com/nodejs/node/pull/46153 |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/aduh95 |
|
| https://github.com/bmeck |
|
| https://github.com/ljharb |
|
| https://github.com/RafaelGSS |
|
| https://github.com/juanarbol |
|
| https://github.com/targos |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |