René's URL Explorer Experiment


Title: esm: allow `resolve` to optionally return import assertions by GeoffreyBooth · Pull Request #46153 · nodejs/node · GitHub

Open Graph Title: esm: allow `resolve` to optionally return import assertions by GeoffreyBooth · Pull Request #46153 · nodejs/node

X Title: esm: allow `resolve` to optionally return import assertions by GeoffreyBooth · Pull Request #46153 · nodejs/node

Description: As part of #44710 @targos discovered that our test fixture loader for “assertionless” JSON imports—import data from './file.json' where there’s no assert { type: 'json' }—was only working because i...

Open Graph Description: As part of #44710 @targos discovered that our test fixture loader for “assertionless” JSON imports—import data from './file.json' where there’s no assert { type: 'json' }—was only w...

X Description: As part of #44710 @targos discovered that our test fixture loader for “assertionless” JSON imports—import data from './file.json' where there’s no assert { type: 'json&#...

Opengraph URL: https://github.com/nodejs/node/pull/46153

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5495c23b-2b06-1db8-d9ee-cb369a818644
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE14C:29F2E0:13EED4D:1AD0D3F:69699CB8
html-safe-nonce92149d2858ba1a14a2245d20fb87b228f46bd00373bafd12d291a2003f5ba1e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTRDOjI5RjJFMDoxM0VFRDREOjFBRDBEM0Y6Njk2OTlDQjgiLCJ2aXNpdG9yX2lkIjoiNDQwMDExNDMzMzQ2NzEyMjg3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceaa5c982205f9ec464889cdb09c60ce07b4bf3587bca875bb78c020b5eb0261f
hovercard-subject-tagpull_request:1191694950
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46153/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e6f137adf44491e811e7dd333a0f4aaaa395e958f9fb2a2f64f2e16228bb6d2f/nodejs/node/pull/46153
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e6f137adf44491e811e7dd333a0f4aaaa395e958f9fb2a2f64f2e16228bb6d2f/nodejs/node/pull/46153
og:image:altAs part of #44710 @targos discovered that our test fixture loader for “assertionless” JSON imports—import data from './file.json' where there’s no assert { type: 'json' }—was only w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGeoffreyBooth
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/46153#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/46153
Reloadhttps://github.com/nodejs/node/pull/46153
Reloadhttps://github.com/nodejs/node/pull/46153
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/46153
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/46153
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/46153#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
GeoffreyBooth:resolve-hook-returns-import-assertionshttps://github.com/GeoffreyBooth/node/tree/resolve-hook-returns-import-assertions
esm: allow resolve to optionally return import assertions https://github.com/nodejs/node/pull/46153#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
GeoffreyBooth:resolve-hook-returns-import-assertionshttps://github.com/GeoffreyBooth/node/tree/resolve-hook-returns-import-assertions
Conversation 90 https://github.com/nodejs/node/pull/46153
Commits 1 https://github.com/nodejs/node/pull/46153/commits
Checks 0 https://github.com/nodejs/node/pull/46153/checks
Files changed https://github.com/nodejs/node/pull/46153/files
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jan 10, 2023https://github.com/nodejs/node/pull/46153#issue-1526609075
#44710https://github.com/nodejs/node/pull/44710
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
Jan 10, 2023https://github.com/nodejs/node/pull/46153#event-8187353519
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
JakobJingleheimerhttps://github.com/JakobJingleheimer
aduh95https://github.com/aduh95
January 10, 2023 01:29https://github.com/nodejs/node/pull/46153#event-8187353528
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1376596689
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 10, 2023https://github.com/nodejs/node/pull/46153#event-8187354346
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/52f571cc96cd469590584382d001e7347cf10b7f..c797d07f670c7e7f49338f3e3e8082ebb2340bc5
52f571chttps://github.com/nodejs/node/commit/52f571cc96cd469590584382d001e7347cf10b7f
c797d07https://github.com/nodejs/node/commit/c797d07f670c7e7f49338f3e3e8082ebb2340bc5
Compare https://github.com/nodejs/node/compare/52f571cc96cd469590584382d001e7347cf10b7f..c797d07f670c7e7f49338f3e3e8082ebb2340bc5
January 10, 2023 01:32https://github.com/nodejs/node/pull/46153#event-8187364085
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
targoshttps://github.com/targos
January 10, 2023 01:32https://github.com/nodejs/node/pull/46153#event-8187366303
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/d34bf01ea940b13a12d05a307e44e3e369c1a991..e80eaa65abfe85ff4645041aa93587dbf10b68c6
d34bf01https://github.com/nodejs/node/commit/d34bf01ea940b13a12d05a307e44e3e369c1a991
e80eaa6https://github.com/nodejs/node/commit/e80eaa65abfe85ff4645041aa93587dbf10b68c6
Compare https://github.com/nodejs/node/compare/d34bf01ea940b13a12d05a307e44e3e369c1a991..e80eaa65abfe85ff4645041aa93587dbf10b68c6
January 10, 2023 01:55https://github.com/nodejs/node/pull/46153#event-8187461905
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1376616308
https://ci.nodejs.org/job/node-test-pull-request/48922/https://ci.nodejs.org/job/node-test-pull-request/48922/
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 10, 2023https://github.com/nodejs/node/pull/46153#event-8188125995
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/e80eaa65abfe85ff4645041aa93587dbf10b68c6..1a9e7d68a14724f7310c2788af4132e0c87ce061
e80eaa6https://github.com/nodejs/node/commit/e80eaa65abfe85ff4645041aa93587dbf10b68c6
1a9e7d6https://github.com/nodejs/node/commit/1a9e7d68a14724f7310c2788af4132e0c87ce061
Compare https://github.com/nodejs/node/compare/e80eaa65abfe85ff4645041aa93587dbf10b68c6..1a9e7d68a14724f7310c2788af4132e0c87ce061
January 10, 2023 06:27https://github.com/nodejs/node/pull/46153#event-8188549278
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 10, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1376792625
https://ci.nodejs.org/job/node-test-pull-request/48924/https://ci.nodejs.org/job/node-test-pull-request/48924/
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/targos
targoshttps://github.com/targos
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1241625162
View reviewed changes https://github.com/nodejs/node/pull/46153/files
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/targos
targoshttps://github.com/targos
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1241627710
View reviewed changes https://github.com/nodejs/node/pull/46153/files
doc/api/esm.mdhttps://github.com/nodejs/node/pull/46153/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/targos
targoshttps://github.com/targos
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1241631772
View reviewed changes https://github.com/nodejs/node/pull/46153/files
doc/api/esm.mdhttps://github.com/nodejs/node/pull/46153/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
targoshttps://github.com/targos
Jan 10, 2023https://github.com/nodejs/node/pull/46153#discussion_r1065408216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46153
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jan 10, 2023https://github.com/nodejs/node/pull/46153#discussion_r1066423011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46153
targoshttps://github.com/targos
Jan 11, 2023https://github.com/nodejs/node/pull/46153#discussion_r1066704777
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1241830391
View reviewed changes https://github.com/nodejs/node/pull/46153/files
doc/api/esm.mdhttps://github.com/nodejs/node/pull/46153/files#diff-f404db6c314f6baf7acc00e537fd4ade2761d9674199268712e6102ee3136c6b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1241833089
View reviewed changes https://github.com/nodejs/node/pull/46153/files
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/46153/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/46153/files#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/46153/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023https://github.com/nodejs/node/pull/46153#event-8190440343
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1377046016
node/doc/contributing/pull-requests.mdhttps://github.com/nodejs/node/blob/5af202186016e8e7b2960285ddc928a20b62be0f/doc/contributing/pull-requests.md#L168-L169
5af2021https://github.com/nodejs/node/commit/5af202186016e8e7b2960285ddc928a20b62be0f
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/1a9e7d68a14724f7310c2788af4132e0c87ce061..0a014413ffb1c1771ec2782873d9b98eff6c15d1
1a9e7d6https://github.com/nodejs/node/commit/1a9e7d68a14724f7310c2788af4132e0c87ce061
0a01441https://github.com/nodejs/node/commit/0a014413ffb1c1771ec2782873d9b98eff6c15d1
Compare https://github.com/nodejs/node/compare/1a9e7d68a14724f7310c2788af4132e0c87ce061..0a014413ffb1c1771ec2782873d9b98eff6c15d1
January 10, 2023 18:28https://github.com/nodejs/node/pull/46153#event-8194809646
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1242778346
View reviewed changes https://github.com/nodejs/node/pull/46153/files
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/46153/files#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/46153
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1242818736
View reviewed changes https://github.com/nodejs/node/pull/46153/files
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/0a014413ffb1c1771ec2782873d9b98eff6c15d1..246694f59e8bcecfc3f474798b75db2b2898a66c
0a01441https://github.com/nodejs/node/commit/0a014413ffb1c1771ec2782873d9b98eff6c15d1
246694fhttps://github.com/nodejs/node/commit/246694f59e8bcecfc3f474798b75db2b2898a66c
Compare https://github.com/nodejs/node/compare/0a014413ffb1c1771ec2782873d9b98eff6c15d1..246694f59e8bcecfc3f474798b75db2b2898a66c
January 10, 2023 19:32https://github.com/nodejs/node/pull/46153#event-8195245762
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1242850173
View reviewed changes https://github.com/nodejs/node/pull/46153/files
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/246694f59e8bcecfc3f474798b75db2b2898a66c..c3a2e8b7b4bfac4d63af02932fc73334bb9b61f4
246694fhttps://github.com/nodejs/node/commit/246694f59e8bcecfc3f474798b75db2b2898a66c
c3a2e8bhttps://github.com/nodejs/node/commit/c3a2e8b7b4bfac4d63af02932fc73334bb9b61f4
Compare https://github.com/nodejs/node/compare/246694f59e8bcecfc3f474798b75db2b2898a66c..c3a2e8b7b4bfac4d63af02932fc73334bb9b61f4
January 10, 2023 20:04https://github.com/nodejs/node/pull/46153#event-8195465245
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 10, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1242889807
View reviewed changes https://github.com/nodejs/node/pull/46153/files
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
test/fixtures/es-module-loaders/assertionless-json-import.mjshttps://github.com/nodejs/node/pull/46153/files#diff-0a561aa9e8d312a3e185a365d3485f3785d09d3bfbb73605aa283e518a211d3a
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
force-pushedhttps://github.com/nodejs/node/compare/e9822be22979a333e610212cbf8c5c0f42f86435..349d05475c7b44221eb0ee752aac96b9b41a11cf
e9822behttps://github.com/nodejs/node/commit/e9822be22979a333e610212cbf8c5c0f42f86435
349d054https://github.com/nodejs/node/commit/349d05475c7b44221eb0ee752aac96b9b41a11cf
Compare https://github.com/nodejs/node/compare/e9822be22979a333e610212cbf8c5c0f42f86435..349d05475c7b44221eb0ee752aac96b9b41a11cf
January 10, 2023 20:18https://github.com/nodejs/node/pull/46153#event-8195559504
https://github.com/bmeck
bmeckhttps://github.com/bmeck
Jan 11, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1379003759
https://tc39.es/proposal-import-assertions/#sec-semanticshttps://tc39.es/proposal-import-assertions/#sec-semantics
https://tc39.es/ecma262/#sec-completion-record-specification-typehttps://tc39.es/ecma262/#sec-completion-record-specification-type
https://github.com/nodejs/node/pull/46153
https://github.com/nodejs/node/blob/611d5b46f8457df4c924c237bcaeb55ecf104116/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs#L23https://github.com/nodejs/node/blob/611d5b46f8457df4c924c237bcaeb55ecf104116/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs#L23
#46153 (comment)https://github.com/nodejs/node/pull/46153#issuecomment-1378864782
https://github.com/notifications/unsubscribe-auth/AABZJI6IEWKVRI7ACOZTJSTWR3B53ANCNFSM6AAAAAATWCNIPAhttps://github.com/notifications/unsubscribe-auth/AABZJI6IEWKVRI7ACOZTJSTWR3B53ANCNFSM6AAAAAATWCNIPA
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jan 11, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1379218291
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jan 11, 2023 https://github.com/nodejs/node/pull/46153#pullrequestreview-1244533728
View reviewed changes https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979
lib/internal/modules/esm/hooks.jshttps://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979#diff-15847fb1d42ec31618a186ad743b13da05f05a0708f93399f7cba82088ac8a8d
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/ljharb
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 12, 2023 https://github.com/nodejs/node/pull/46153#ref-issue-1529897909
CI Reliability 2023-01-12 nodejs/reliability#481 https://github.com/nodejs/reliability/issues/481
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jan 12, 2023https://github.com/nodejs/node/pull/46153#event-8206956766
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
91ca2d4https://github.com/nodejs/node/commit/91ca2d40419244a9c542be5ff162a837fcc3be82
Jan 12, 2023https://github.com/nodejs/node/pull/46153#event-8206956977
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 12, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1379712880
91ca2d4https://github.com/nodejs/node/commit/91ca2d40419244a9c542be5ff162a837fcc3be82
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/ljharb
ljharbhttps://github.com/ljharb
January 12, 2023 03:55https://github.com/nodejs/node/pull/46153#event-8207386686
CI Reliability 2023-01-13 nodejs/reliability#482 https://github.com/nodejs/reliability/issues/482
CI Reliability 2023-01-14 nodejs/reliability#483 https://github.com/nodejs/reliability/issues/483
CI Reliability 2023-01-15 nodejs/reliability#484 https://github.com/nodejs/reliability/issues/484
CI Reliability 2023-01-16 nodejs/reliability#485 https://github.com/nodejs/reliability/issues/485
CI Reliability 2023-01-17 nodejs/reliability#486 https://github.com/nodejs/reliability/issues/486
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
backport-requested-v19.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v19.x
Jan 17, 2023https://github.com/nodejs/node/pull/46153#event-8248161688
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 17, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1385795123
@GeoffreyBoothhttps://github.com/GeoffreyBooth
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jan 17, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1385846912
Please reload this pagehttps://github.com/nodejs/node/pull/46153
@RafaelGSShttps://github.com/RafaelGSS
#45869 (comment)https://github.com/nodejs/node/pull/45869#issuecomment-1369419536
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 18, 2023 https://github.com/nodejs/node/pull/46153#ref-issue-1537206132
CI Reliability 2023-01-18 nodejs/reliability#487 https://github.com/nodejs/reliability/issues/487
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
backport-requested-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v18.x
Jan 25, 2023https://github.com/nodejs/node/pull/46153#event-8358484826
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Jan 25, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1404189204
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jan 25, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1404291803
#43772https://github.com/nodejs/node/pull/43772
#45869https://github.com/nodejs/node/pull/45869
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/targos
targoshttps://github.com/targos
backport-requested-v19.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v19.x
Mar 14, 2023https://github.com/nodejs/node/pull/46153#event-8739867930
https://github.com/targos
targoshttps://github.com/targos
Mar 14, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1467507684
Please reload this pagehttps://github.com/nodejs/node/pull/46153
targoshttps://github.com/targos
Mar 14, 2023 https://github.com/nodejs/node/pull/46153#ref-commit-18f0398
https://github.com/GeoffreyBooth
https://github.com/targos
esm: allow resolve to return import assertionshttps://github.com/nodejs/node/commit/18f03982423712dae1a049f3912890bd4cd8470f
18f0398https://github.com/nodejs/node/commit/18f03982423712dae1a049f3912890bd4cd8470f
#46153https://github.com/nodejs/node/pull/46153
https://github.com/targos
targoshttps://github.com/targos
Mar 14, 2023 https://github.com/nodejs/node/pull/46153#ref-pullrequest-1622922231
v19.8.0 release proposal #47087 https://github.com/nodejs/node/pull/47087
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Mar 14, 2023https://github.com/nodejs/node/pull/46153#issuecomment-1468433258
Please reload this pagehttps://github.com/nodejs/node/pull/46153
targoshttps://github.com/targos
Nov 10, 2023 https://github.com/nodejs/node/pull/46153#ref-commit-45de8d1
https://github.com/GeoffreyBooth
https://github.com/targos
esm: allow resolve to return import assertionshttps://github.com/nodejs/node/commit/45de8d1bd7b199e9a13f23f42c4abbf9b33a6321
45de8d1https://github.com/nodejs/node/commit/45de8d1bd7b199e9a13f23f42c4abbf9b33a6321
#46153https://github.com/nodejs/node/pull/46153
https://github.com/targos
targoshttps://github.com/targos
Nov 28, 2023 https://github.com/nodejs/node/pull/46153#ref-pullrequest-2014162105
v18.19.0 release proposal #50953 https://github.com/nodejs/node/pull/50953
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/46153#ref-commit-d1377b5
https://github.com/sercher
esm: allow resolve to return import assertionshttps://github.com/sercher/graaljs/commit/d1377b54f25facc19588fc5ff3cfa6adfff9f2cf
d1377b5https://github.com/sercher/graaljs/commit/d1377b54f25facc19588fc5ff3cfa6adfff9f2cf
nodejs/node#46153https://github.com/nodejs/node/pull/46153
sercherhttps://github.com/sercher
Apr 25, 2024 https://github.com/nodejs/node/pull/46153#ref-commit-3b8eb99
https://github.com/sercher
esm: allow resolve to return import assertionshttps://github.com/sercher/graaljs/commit/3b8eb998c189267b4b985fc861351e78bd87e1fd
3b8eb99https://github.com/sercher/graaljs/commit/3b8eb998c189267b4b985fc861351e78bd87e1fd
nodejs/node#46153https://github.com/nodejs/node/pull/46153
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46153
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979
https://github.com/JakobJingleheimer
JakobJingleheimer https://github.com/JakobJingleheimer
https://github.com/nodejs/node/pull/46153/files/b551843ef47312f708c4f9f1a997e25017532979
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/46153/files/cf7490b54ee919d00d54bcedd68066cb745720c1
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
Please reload this pagehttps://github.com/nodejs/node/pull/46153
https://github.com/GeoffreyBooth
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/bmeck
https://github.com/ljharb
https://github.com/RafaelGSS
https://github.com/juanarbol
https://github.com/targos
https://github.com/JakobJingleheimer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.