René's URL Explorer Experiment


Title: [v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors by fossamagna · Pull Request #46005 · nodejs/node · GitHub

Open Graph Title: [v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors by fossamagna · Pull Request #46005 · nodejs/node

X Title: [v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors by fossamagna · Pull Request #46005 · nodejs/node

Description: This RP is backport of #45264 to v18.x. Refs: #45264 (comment)

Open Graph Description: This RP is backport of #45264 to v18.x. Refs: #45264 (comment)

X Description: This RP is backport of #45264 to v18.x. Refs: #45264 (comment)

Opengraph URL: https://github.com/nodejs/node/pull/46005

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ff2971ad-bdb9-c589-ea09-c4c02c496640
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC400:2E3F95:DA854B:12E02FC:696A841F
html-safe-noncea269278f950884303ce2a78b5809315f20f2b3293dc4b8bedcbdd15c33edce7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDAwOjJFM0Y5NTpEQTg1NEI6MTJFMDJGQzo2OTZBODQxRiIsInZpc2l0b3JfaWQiOiI3NjQ5MTU0NzQzODIwNTE4NDMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac37d5bfaf8967c5c13639c374d970e5a27f5d8faa30bbed609390959850a20cc2
hovercard-subject-tagpull_request:1179882501
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/46005/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d81ed5950c8bc0a464eb56d0b7bc0538a55b0b3aa02c59782fdb87996e035c75/nodejs/node/pull/46005
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d81ed5950c8bc0a464eb56d0b7bc0538a55b0b3aa02c59782fdb87996e035c75/nodejs/node/pull/46005
og:image:altThis RP is backport of #45264 to v18.x. Refs: #45264 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefossamagna
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/46005#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46005
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46005
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/46005
Reloadhttps://github.com/nodejs/node/pull/46005
Reloadhttps://github.com/nodejs/node/pull/46005
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/46005
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/46005
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/46005#issue-comment-box
fossamagnahttps://github.com/fossamagna
nodejs:v18.x-staginghttps://github.com/nodejs/node/tree/v18.x-staging
fossamagna:backport-v18-test-runner-extraneous-async-failhttps://github.com/fossamagna/node/tree/backport-v18-test-runner-extraneous-async-fail
[v18.x backport] test_runner: avoid swallowing of asynchronously thrown errors https://github.com/nodejs/node/pull/46005#top
fossamagnahttps://github.com/fossamagna
nodejs:v18.x-staginghttps://github.com/nodejs/node/tree/v18.x-staging
fossamagna:backport-v18-test-runner-extraneous-async-failhttps://github.com/fossamagna/node/tree/backport-v18-test-runner-extraneous-async-fail
Conversation 5 https://github.com/nodejs/node/pull/46005
Commits 3 https://github.com/nodejs/node/pull/46005/commits
Checks 0 https://github.com/nodejs/node/pull/46005/checks
Files changed https://github.com/nodejs/node/pull/46005/files
Please reload this pagehttps://github.com/nodejs/node/pull/46005
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/fossamagna
fossamagnahttps://github.com/fossamagna
Dec 29, 2022https://github.com/nodejs/node/pull/46005#issue-1513318206
#45264https://github.com/nodejs/node/pull/45264
#45264 (comment)https://github.com/nodejs/node/pull/45264#issuecomment-1366958584
Please reload this pagehttps://github.com/nodejs/node/pull/46005
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 29, 2022https://github.com/nodejs/node/pull/46005#issuecomment-1367036673
Please reload this pagehttps://github.com/nodejs/node/pull/46005
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Dec 29, 2022https://github.com/nodejs/node/pull/46005#event-8124013687
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Dec 29, 2022 https://github.com/nodejs/node/pull/46005#pullrequestreview-1232179960
View reviewed changes https://github.com/nodejs/node/pull/46005/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Dec 30, 2022https://github.com/nodejs/node/pull/46005#issuecomment-1368055156
https://ci.nodejs.org/job/node-test-pull-request/48768/https://ci.nodejs.org/job/node-test-pull-request/48768/
Please reload this pagehttps://github.com/nodejs/node/pull/46005
CI Reliability 2022-12-31 nodejs/reliability#474 https://github.com/nodejs/reliability/issues/474
CI Reliability 2023-01-01 nodejs/reliability#475 https://github.com/nodejs/reliability/issues/475
CI Reliability 2023-01-02 nodejs/reliability#476 https://github.com/nodejs/reliability/issues/476
CI Reliability 2023-01-03 nodejs/reliability#477 https://github.com/nodejs/reliability/issues/477
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
force-pushedhttps://github.com/nodejs/node/compare/68cca1e2dbdc6a07749214483d238a4dc73470b3..2098d7a966364d078374de2f96e1c6c53ff152d1
68cca1ehttps://github.com/nodejs/node/commit/68cca1e2dbdc6a07749214483d238a4dc73470b3
2098d7ahttps://github.com/nodejs/node/commit/2098d7a966364d078374de2f96e1c6c53ff152d1
Compare https://github.com/nodejs/node/compare/68cca1e2dbdc6a07749214483d238a4dc73470b3..2098d7a966364d078374de2f96e1c6c53ff152d1
January 3, 2023 15:48https://github.com/nodejs/node/pull/46005#event-8144008391
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 4, 2023 https://github.com/nodejs/node/pull/46005#ref-issue-1518090510
CI Reliability 2023-01-04 nodejs/reliability#478 https://github.com/nodejs/reliability/issues/478
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
force-pushedhttps://github.com/nodejs/node/compare/2098d7a966364d078374de2f96e1c6c53ff152d1..bac6b7d900d2adb8fea4e0ef271db6a731f0c8d8
2098d7ahttps://github.com/nodejs/node/commit/2098d7a966364d078374de2f96e1c6c53ff152d1
bac6b7dhttps://github.com/nodejs/node/commit/bac6b7d900d2adb8fea4e0ef271db6a731f0c8d8
Compare https://github.com/nodejs/node/compare/2098d7a966364d078374de2f96e1c6c53ff152d1..bac6b7d900d2adb8fea4e0ef271db6a731f0c8d8
January 4, 2023 17:10https://github.com/nodejs/node/pull/46005#event-8153062980
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 5, 2023 https://github.com/nodejs/node/pull/46005#ref-issue-1519768915
CI Reliability 2023-01-05 nodejs/reliability#479 https://github.com/nodejs/reliability/issues/479
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Jan 22, 2023https://github.com/nodejs/node/pull/46005#issuecomment-1399580943
Please reload this pagehttps://github.com/nodejs/node/pull/46005
legendecashttps://github.com/legendecas
January 23, 2023 09:15https://github.com/nodejs/node/pull/46005#commits-pushed-997da3d
https://github.com/legendecas
https://github.com/fossamagna
src: per-environment time origin valuehttps://github.com/nodejs/node/pull/46005/commits/997da3d1342d91721f81ecf9eae1b7f6bbfabae2
997da3dhttps://github.com/nodejs/node/pull/46005/commits/997da3d1342d91721f81ecf9eae1b7f6bbfabae2
https://html.spec.whatwg.org/#environment-settings-objecthttps://html.spec.whatwg.org/#environment-settings-object
nodejs#43781https://github.com/nodejs/node/pull/43781
https://github.com/legendecas
https://github.com/fossamagna
src: introduce node::Realmhttps://github.com/nodejs/node/pull/46005/commits/299e6b44cc496913dd81a4d26638d605085ab9fc
299e6b4https://github.com/nodejs/node/pull/46005/commits/299e6b44cc496913dd81a4d26638d605085ab9fc
nodejs#44179https://github.com/nodejs/node/pull/44179
nodejs#42528https://github.com/nodejs/node/issues/42528
https://github.com/fossamagna
test_runner: avoid swallowing of asynchronously thrown errorshttps://github.com/nodejs/node/pull/46005/commits/024450a320af0c1fa170e0fd16160d554a4355a4
024450ahttps://github.com/nodejs/node/pull/46005/commits/024450a320af0c1fa170e0fd16160d554a4355a4
nodejs#44612https://github.com/nodejs/node/issues/44612
nodejs#45264https://github.com/nodejs/node/pull/45264
https://github.com/fossamagna
fossamagnahttps://github.com/fossamagna
force-pushedhttps://github.com/nodejs/node/compare/6bba8f912a10e25dec02662331b37482a9bffdd5..024450a320af0c1fa170e0fd16160d554a4355a4
6bba8f9https://github.com/nodejs/node/commit/6bba8f912a10e25dec02662331b37482a9bffdd5
024450ahttps://github.com/nodejs/node/commit/024450a320af0c1fa170e0fd16160d554a4355a4
Compare https://github.com/nodejs/node/compare/6bba8f912a10e25dec02662331b37482a9bffdd5..024450a320af0c1fa170e0fd16160d554a4355a4
January 23, 2023 01:30https://github.com/nodejs/node/pull/46005#event-8330051016
https://github.com/fossamagna
fossamagnahttps://github.com/fossamagna
Jan 24, 2023https://github.com/nodejs/node/pull/46005#issuecomment-1401395965
@juanarbolhttps://github.com/juanarbol
Please reload this pagehttps://github.com/nodejs/node/pull/46005
https://github.com/MoLow
MoLowhttps://github.com/MoLow
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 24, 2023https://github.com/nodejs/node/pull/46005#event-8344912929
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jan 26, 2023 https://github.com/nodejs/node/pull/46005#ref-pullrequest-1524694836
test: fix flaky test-runner-exit-code.js #46138 https://github.com/nodejs/node/pull/46138
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jan 26, 2023https://github.com/nodejs/node/pull/46005#issuecomment-1404665029
#46360https://github.com/nodejs/node/pull/46360
Please reload this pagehttps://github.com/nodejs/node/pull/46005
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jan 26, 2023https://github.com/nodejs/node/pull/46005#event-8361694154
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F46005
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/46005/files/6bba8f912a10e25dec02662331b37482a9bffdd5
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av18.x
Please reload this pagehttps://github.com/nodejs/node/pull/46005
https://github.com/fossamagna
https://github.com/nodejs-github-bot
https://github.com/juanarbol
https://github.com/MoLow
https://github.com/legendecas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.