| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:86dd71e5-26dc-26ed-c6ef-70db0600f2b0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB12:2171D7:786684:A7BFDB:696A2A24 |
| html-safe-nonce | 11e654fb334cb61fe628ea5137e2bd55ec9ed68d69de40a011e1e4d13cd146d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjEyOjIxNzFENzo3ODY2ODQ6QTdCRkRCOjY5NkEyQTI0IiwidmlzaXRvcl9pZCI6IjgxNzUzNjU2MzI4OTExNjkzMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9f9a5a8c3400ff3ab5bcd81060f5144a1d0a1d44c2798c0fe59f47ae25e9113d |
| hovercard-subject-tag | pull_request:1169744757 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45903/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cdc097ee338d19973f35525227b6405a9a60d8cef9b96944d1132c80fcb8f4d0/nodejs/node/pull/45903 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cdc097ee338d19973f35525227b6405a9a60d8cef9b96944d1132c80fcb8f4d0/nodejs/node/pull/45903 |
| og:image:alt | As status quo, the cleanup hooks are invoked before the napi_finalize
callbacks at the exit of Node.js environments. This gives addons a
chance to release their resource in a proper order manually.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | legendecas |
| hostname | github.com |
| expected-hostname | github.com |
| None | a1022f03e4f0d91ea173e4e5dac892c982e0588c62f1ce56121d755a320a3569 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f472b8e6c7b3fdd5d0354972a3f4c516289bf0be |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/45903#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45903 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45903 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/45903 |
| Reload | https://github.com/nodejs/node/pull/45903 |
| Reload | https://github.com/nodejs/node/pull/45903 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/45903#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| legendecas:node-api/shutdown | https://github.com/legendecas/node/tree/node-api/shutdown |
|
node-api: document node-api shutdown finalization
| https://github.com/nodejs/node/pull/45903#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| legendecas:node-api/shutdown | https://github.com/legendecas/node/tree/node-api/shutdown |
|
Conversation
10
| https://github.com/nodejs/node/pull/45903 |
|
Commits
1
| https://github.com/nodejs/node/pull/45903/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/45903/checks |
|
Files changed
| https://github.com/nodejs/node/pull/45903/files |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Dec 18, 2022 | https://github.com/nodejs/node/pull/45903#issue-1501785289 |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| #45088 | https://github.com/nodejs/node/issues/45088 |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
|
| https://github.com/legendecas |
| node-api: document node-api shutdown finalization | https://github.com/nodejs/node/pull/45903/commits/79fecec40c280a1175714420f4faf03937b26980 |
| 79fecec | https://github.com/nodejs/node/pull/45903/commits/79fecec40c280a1175714420f4faf03937b26980 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 18, 2022 | https://github.com/nodejs/node/pull/45903#issuecomment-1356709205 |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Dec 18, 2022 | https://github.com/nodejs/node/pull/45903#event-8063465271 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Dec 18, 2022
| https://github.com/nodejs/node/pull/45903#ref-issue-1077586002 |
|
(Typed)ThreadSafeFunction.Release() crashes renderer process on reload (& abort?)
nodejs/node-addon-api#1109
| https://github.com/nodejs/node-addon-api/issues/1109 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Dec 19, 2022
| https://github.com/nodejs/node/pull/45903#pullrequestreview-1223476535 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| mhdawson | https://github.com/mhdawson |
| Dec 19, 2022 | https://github.com/nodejs/node/pull/45903#discussion_r1052597740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| legendecas | https://github.com/legendecas |
| Dec 22, 2022 | https://github.com/nodejs/node/pull/45903#discussion_r1055229707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Dec 19, 2022
| https://github.com/nodejs/node/pull/45903#pullrequestreview-1223477175 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| mhdawson | https://github.com/mhdawson |
| Dec 19, 2022 | https://github.com/nodejs/node/pull/45903#discussion_r1052598168 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| legendecas | https://github.com/legendecas |
| Dec 22, 2022 | https://github.com/nodejs/node/pull/45903#discussion_r1055235673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| nodejs/node-addon-api#1109 | https://github.com/nodejs/node-addon-api/issues/1109 |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| mmomtchev | https://github.com/mmomtchev |
| Jan 17, 2023 | https://github.com/nodejs/node/pull/45903#discussion_r1072193620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @legendecas | https://github.com/legendecas |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| mmomtchev | https://github.com/mmomtchev |
| Jan 17, 2023 | https://github.com/nodejs/node/pull/45903#discussion_r1072253425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @legendecas | https://github.com/legendecas |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| legendecas | https://github.com/legendecas |
| Feb 17, 2023 | https://github.com/nodejs/node/pull/45903#discussion_r1109506155 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @mmomtchev | https://github.com/mmomtchev |
| #46692 | https://github.com/nodejs/node/pull/46692 |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 17, 2023
| https://github.com/nodejs/node/pull/45903#pullrequestreview-1251772137 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Mar 17, 2023
| https://github.com/nodejs/node/pull/45903#pullrequestreview-1346309827 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
| mhdawson | https://github.com/mhdawson |
| https://github.com/nodejs/node/pull/45903#pullrequestreview-1346309827 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Mar 20, 2023 | https://github.com/nodejs/node/pull/45903#event-8792342742 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Mar 20, 2023 | https://github.com/nodejs/node/pull/45903#event-8792437340 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 2984cc3 | https://github.com/nodejs/node/commit/2984cc38da49a15dd198d4610fda9217353014dc |
| Mar 20, 2023 | https://github.com/nodejs/node/pull/45903#event-8792438186 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 20, 2023 | https://github.com/nodejs/node/pull/45903#issuecomment-1475929188 |
| 2984cc3 | https://github.com/nodejs/node/commit/2984cc38da49a15dd198d4610fda9217353014dc |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| March 20, 2023 09:59 | https://github.com/nodejs/node/pull/45903#event-8792451374 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 3, 2023
| https://github.com/nodejs/node/pull/45903#ref-pullrequest-1651807011 |
|
2023-04-18, Version 20.0.0 (Current)
#47381
| https://github.com/nodejs/node/pull/47381 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 5, 2023
| https://github.com/nodejs/node/pull/45903#ref-commit-7195f23 |
|
| https://github.com/legendecas |
|
| https://github.com/RafaelGSS |
| node-api: document node-api shutdown finalization | https://github.com/nodejs/node/commit/7195f23a4733da5afadb20be2292b6b6071f806c |
| 7195f23 | https://github.com/nodejs/node/commit/7195f23a4733da5afadb20be2292b6b6071f806c |
| #45903 | https://github.com/nodejs/node/pull/45903 |
| #45088 | https://github.com/nodejs/node/issues/45088 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 6, 2023
| https://github.com/nodejs/node/pull/45903#ref-pullrequest-1656565377 |
|
v19.9.0 proposal
#47441
| https://github.com/nodejs/node/pull/47441 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Apr 7, 2023
| https://github.com/nodejs/node/pull/45903#ref-commit-55f3d21 |
|
| https://github.com/legendecas |
|
| https://github.com/RafaelGSS |
| node-api: document node-api shutdown finalization | https://github.com/nodejs/node/commit/55f3d215b87656b68e17cfff295debdd4bfebea5 |
| 55f3d21 | https://github.com/nodejs/node/commit/55f3d215b87656b68e17cfff295debdd4bfebea5 |
| #45903 | https://github.com/nodejs/node/pull/45903 |
| #45088 | https://github.com/nodejs/node/issues/45088 |
| danielleadams | https://github.com/danielleadams |
|
Jul 6, 2023
| https://github.com/nodejs/node/pull/45903#ref-commit-6e66371 |
|
| https://github.com/legendecas |
|
| https://github.com/danielleadams |
| node-api: document node-api shutdown finalization | https://github.com/nodejs/node/commit/6e66371eeed4571bf85f666e9b8db2ac97f76a08 |
| 6e66371 | https://github.com/nodejs/node/commit/6e66371eeed4571bf85f666e9b8db2ac97f76a08 |
| #45903 | https://github.com/nodejs/node/pull/45903 |
| #45088 | https://github.com/nodejs/node/issues/45088 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Jul 10, 2023
| https://github.com/nodejs/node/pull/45903#ref-pullrequest-1793607989 |
|
v18.17.0 release proposal
#48694
| https://github.com/nodejs/node/pull/48694 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45903 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
|
| https://github.com/mhdawson |
|
mhdawson
| https://github.com/mhdawson |
|
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
|
| https://github.com/mmomtchev |
|
mmomtchev
| https://github.com/mmomtchev |
|
| https://github.com/nodejs/node/pull/45903/files/79fecec40c280a1175714420f4faf03937b26980 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
|
ObjectWrap destructors run after CleanupHook
| https://github.com/nodejs/node/issues/45088 |
| Please reload this page | https://github.com/nodejs/node/pull/45903 |
|
| https://github.com/legendecas |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/mhdawson |
|
| https://github.com/mmomtchev |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |