| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:476932ff-d488-17a0-7d6d-9726b66236ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A208:9CED1:BFAD6B:108AE4A:696A8B97 |
| html-safe-nonce | 9beb3a1c9ad924c66f3b1f17992ad088dcce6a9870dc33684525a2fc03c1010c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjA4OjlDRUQxOkJGQUQ2QjoxMDhBRTRBOjY5NkE4Qjk3IiwidmlzaXRvcl9pZCI6IjIyNzQyOTQ4NTY5OTA0OTM1OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ddff4f1770b7622373c0554ab02d9beda26c16eb244e5b2e85eef22b5b396407 |
| hovercard-subject-tag | pull_request:1131249726 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45571/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7db37f90ba6ee498c3399b24d26cf25896b05d206619765d82ccc6d5574bf8d0/nodejs/node/pull/45571 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7db37f90ba6ee498c3399b24d26cf25896b05d206619765d82ccc6d5574bf8d0/nodejs/node/pull/45571 |
| og:image:alt | Re-land this as a breaking change. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/45571#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45571 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45571 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/45571 |
| Reload | https://github.com/nodejs/node/pull/45571 |
| Reload | https://github.com/nodejs/node/pull/45571 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/45571#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Trott:reland | https://github.com/Trott/io.js/tree/reland |
|
http: headers(Distinct), trailers(Distinct) setters to be no-op
| https://github.com/nodejs/node/pull/45571#top |
| Trott | https://github.com/Trott |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Trott:reland | https://github.com/Trott/io.js/tree/reland |
|
Conversation
4
| https://github.com/nodejs/node/pull/45571 |
|
Commits
1
| https://github.com/nodejs/node/pull/45571/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/45571/checks |
|
Files changed
| https://github.com/nodejs/node/pull/45571/files |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#issue-1459269329 |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
|
| https://github.com/sonimadhuri |
|
| https://github.com/Trott |
| http: headers(Distinct), trailers(Distinct) setters to be no-op | https://github.com/nodejs/node/pull/45571/commits/2b77fe3aee38db6d1f70fa3a09676544695daab5 |
| 2b77fe3 | https://github.com/nodejs/node/pull/45571/commits/2b77fe3aee38db6d1f70fa3a09676544695daab5 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#event-7864715386 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#issuecomment-1323212035 |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#event-7864716403 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#event-7864716826 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#event-7864758550 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 22, 2022 | https://github.com/nodejs/node/pull/45571#issuecomment-1323217773 |
| https://ci.nodejs.org/job/node-test-pull-request/48083/ | https://ci.nodejs.org/job/node-test-pull-request/48083/ |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
|
Nov 22, 2022
| https://github.com/nodejs/node/pull/45571#pullrequestreview-1189685373 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/45571/files/2b77fe3aee38db6d1f70fa3a09676544695daab5 |
| ShogunPanda | https://github.com/ShogunPanda |
| https://github.com/nodejs/node/pull/45571#pullrequestreview-1189685373 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 22, 2022
| https://github.com/nodejs/node/pull/45571#pullrequestreview-1189856355 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/45571/files/2b77fe3aee38db6d1f70fa3a09676544695daab5 |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/45571#pullrequestreview-1189856355 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
|
CI Reliability 2022-11-24
nodejs/reliability#438
| https://github.com/nodejs/reliability/issues/438 |
|
CI Reliability 2022-11-25
nodejs/reliability#439
| https://github.com/nodejs/reliability/issues/439 |
| Trott | https://github.com/Trott |
|
Dec 1, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-38845b3 |
|
| https://github.com/Trott |
| http: add doc-only deprecation for headers/trailers setters | https://github.com/Trott/io.js/commit/38845b3c3404484cf624cd2d41e82e9775eca8ea |
| 38845b3 | https://github.com/Trott/io.js/commit/38845b3c3404484cf624cd2d41e82e9775eca8ea |
| nodejs#45571 | https://github.com/nodejs/node/pull/45571 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Dec 1, 2022
| https://github.com/nodejs/node/pull/45571#ref-pullrequest-1471007880 |
|
doc: add doc-only deprecation for headers/trailers setters
#45697
| https://github.com/nodejs/node/pull/45697 |
| Trott | https://github.com/Trott |
|
Dec 1, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-286a8bb |
|
| https://github.com/Trott |
| http: add doc-only deprecation for headers/trailers setters | https://github.com/Trott/io.js/commit/286a8bbab4608e70c91d6b98075f14084dcf6778 |
| 286a8bb | https://github.com/Trott/io.js/commit/286a8bbab4608e70c91d6b98075f14084dcf6778 |
| nodejs#45571 | https://github.com/nodejs/node/pull/45571 |
| Trott | https://github.com/Trott |
|
Dec 1, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-f73a07c |
|
| https://github.com/Trott |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/Trott/io.js/commit/f73a07c86ee369d232ad3a42b0d016f327126033 |
| f73a07c | https://github.com/Trott/io.js/commit/f73a07c86ee369d232ad3a42b0d016f327126033 |
| nodejs#45571 | https://github.com/nodejs/node/pull/45571 |
| Trott | https://github.com/Trott |
|
Dec 1, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-70b90f7 |
|
| https://github.com/Trott |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/Trott/io.js/commit/70b90f76668068ead13bbd3f227e1216560b2e8c |
| 70b90f7 | https://github.com/Trott/io.js/commit/70b90f76668068ead13bbd3f227e1216560b2e8c |
| nodejs#45571 | https://github.com/nodejs/node/pull/45571 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Dec 3, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-4712d60 |
|
| https://github.com/Trott |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/4712d6083d564255d2a3ad8601bcd639f0fc6e33 |
| 4712d60 | https://github.com/nodejs/node/commit/4712d6083d564255d2a3ad8601bcd639f0fc6e33 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| targos | https://github.com/targos |
|
Dec 12, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-9f51b9e |
|
| https://github.com/Trott |
|
| https://github.com/targos |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/9f51b9e50d99b67d1289a9de468514edf5711f64 |
| 9f51b9e | https://github.com/nodejs/node/commit/9f51b9e50d99b67d1289a9de468514edf5711f64 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| danielleadams | https://github.com/danielleadams |
|
Dec 30, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-ee569b5 |
|
| https://github.com/Trott |
|
| https://github.com/danielleadams |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/ee569b522d5da19ed503d16954d21d08923697c2 |
| ee569b5 | https://github.com/nodejs/node/commit/ee569b522d5da19ed503d16954d21d08923697c2 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| danielleadams | https://github.com/danielleadams |
|
Dec 30, 2022
| https://github.com/nodejs/node/pull/45571#ref-commit-14a0e1b |
|
| https://github.com/Trott |
|
| https://github.com/danielleadams |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/14a0e1b1818762dd62301baf69863fab6d9bc794 |
| 14a0e1b | https://github.com/nodejs/node/commit/14a0e1b1818762dd62301baf69863fab6d9bc794 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| danielleadams | https://github.com/danielleadams |
|
Jan 3, 2023
| https://github.com/nodejs/node/pull/45571#ref-commit-8203c02 |
|
| https://github.com/Trott |
|
| https://github.com/danielleadams |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/8203c021dc4cbd2e74a2fb6aa390a058b7d3b092 |
| 8203c02 | https://github.com/nodejs/node/commit/8203c021dc4cbd2e74a2fb6aa390a058b7d3b092 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| danielleadams | https://github.com/danielleadams |
|
Jan 4, 2023
| https://github.com/nodejs/node/pull/45571#ref-commit-625a7fa |
|
| https://github.com/Trott |
|
| https://github.com/danielleadams |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/625a7fad332bfe3007c5ce0e755aee3ff9eb2dab |
| 625a7fa | https://github.com/nodejs/node/commit/625a7fad332bfe3007c5ce0e755aee3ff9eb2dab |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| danielleadams | https://github.com/danielleadams |
|
Jan 5, 2023
| https://github.com/nodejs/node/pull/45571#ref-commit-7a56409 |
|
| https://github.com/Trott |
|
| https://github.com/danielleadams |
| doc: add doc-only deprecation for headers/trailers setters | https://github.com/nodejs/node/commit/7a56409aae46037698011c30dbcb257e13b2c723 |
| 7a56409 | https://github.com/nodejs/node/commit/7a56409aae46037698011c30dbcb257e13b2c723 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| #45697 | https://github.com/nodejs/node/pull/45697 |
| #45571 | https://github.com/nodejs/node/pull/45571 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 7, 2024 | https://github.com/nodejs/node/pull/45571#event-12048440629 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45571 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/45571/files/2b77fe3aee38db6d1f70fa3a09676544695daab5 |
|
| https://github.com/ShogunPanda |
|
ShogunPanda
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs/node/pull/45571/files/2b77fe3aee38db6d1f70fa3a09676544695daab5 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
| Please reload this page | https://github.com/nodejs/node/pull/45571 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ShogunPanda |
|
| https://github.com/aduh95 |
|
| https://github.com/sonimadhuri |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |