René's URL Explorer Experiment


Title: src: don't run tasks on isolate termination by santigimeno · Pull Request #45444 · nodejs/node · GitHub

Open Graph Title: src: don't run tasks on isolate termination by santigimeno · Pull Request #45444 · nodejs/node

X Title: src: don't run tasks on isolate termination by santigimeno · Pull Request #45444 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #45419

X Description: Fixes: #45419

Opengraph URL: https://github.com/nodejs/node/pull/45444

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3376ef0e-19de-a5b1-bc35-6dd42eddaaaf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9238:2B6CAA:D9784:12300A:6A4D93C9
html-safe-nonceac397312bac1428a462c7f4fc7a39db8f3e0c91cab2a1edae937f6711ff75c4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjM4OjJCNkNBQTpEOTc4NDoxMjMwMEE6NkE0RDkzQzkiLCJ2aXNpdG9yX2lkIjoiMzIwNTAzMTg0OTM0OTcxNDg4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac149d2b6f99dcea511e5329ecf72bb2c638f31b3b0bdad5cbda6a010dd367cb47
hovercard-subject-tagpull_request:1120271091
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45444/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5af617a5bce0e3ed4986b1390306d3d9f1c61f1998c2f0163d6e1d28772c7e30/nodejs/node/pull/45444
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5af617a5bce0e3ed4986b1390306d3d9f1c61f1998c2f0163d6e1d28772c7e30/nodejs/node/pull/45444
og:image:altFixes: #45419
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesantigimeno
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release74e2a9c78f1e38588de4f25885878349d721eedf
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/45444#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45444
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45444
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/45444
Reloadhttps://github.com/nodejs/node/pull/45444
Reloadhttps://github.com/nodejs/node/pull/45444
Please reload this pagehttps://github.com/nodejs/node/pull/45444
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/45444
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
santigimeno:santi/fix_45419https://github.com/santigimeno/node/tree/santi/fix_45419
Conversationhttps://github.com/nodejs/node/pull/45444
Commits1 (1)https://github.com/nodejs/node/pull/45444/commits
Checkshttps://github.com/nodejs/node/pull/45444/checks
Files changedhttps://github.com/nodejs/node/pull/45444/files
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/pull/45444#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
santigimeno:santi/fix_45419https://github.com/santigimeno/node/tree/santi/fix_45419
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Nov 13, 2022https://github.com/nodejs/node/pull/45444#issue-1446812835
#45419https://github.com/nodejs/node/issues/45419
Please reload this pagehttps://github.com/nodejs/node/pull/45444
https://github.com/santigimeno
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/pull/45444/commits/639311fa604e9ceae36a498da1328c5ff1cc7de6
639311fhttps://github.com/nodejs/node/pull/45444/commits/639311fa604e9ceae36a498da1328c5ff1cc7de6
nodejs#45419https://github.com/nodejs/node/issues/45419
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 13, 2022https://github.com/nodejs/node/pull/45444#event-7797994639
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Nov 13, 2022 https://github.com/nodejs/node/pull/45444#pullrequestreview-1178244653
View reviewed changes https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 13, 2022 https://github.com/nodejs/node/pull/45444#pullrequestreview-1178270843
View reviewed changes https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/Trott
Trotthttps://github.com/Trott
Nov 13, 2022https://github.com/nodejs/node/pull/45444#issuecomment-1312774862
Please reload this pagehttps://github.com/nodejs/node/pull/45444
https://github.com/Trott
Trotthttps://github.com/Trott
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 13, 2022https://github.com/nodejs/node/pull/45444#event-7798715252
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 13, 2022https://github.com/nodejs/node/pull/45444#event-7798722333
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 13, 2022https://github.com/nodejs/node/pull/45444#issuecomment-1312776120
https://ci.nodejs.org/job/node-test-pull-request/47910/https://ci.nodejs.org/job/node-test-pull-request/47910/
Please reload this pagehttps://github.com/nodejs/node/pull/45444
CI Reliability 2022-11-14 nodejs/reliability#428 https://github.com/nodejs/reliability/issues/428
CI Reliability 2022-11-15 nodejs/reliability#429 https://github.com/nodejs/reliability/issues/429
CI Reliability 2022-11-16 nodejs/reliability#430 https://github.com/nodejs/reliability/issues/430
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Nov 16, 2022 https://github.com/nodejs/node/pull/45444#pullrequestreview-1183485608
View reviewed changes https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 17, 2022 https://github.com/nodejs/node/pull/45444#ref-issue-1452482055
CI Reliability 2022-11-17 nodejs/reliability#431 https://github.com/nodejs/reliability/issues/431
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Nov 17, 2022https://github.com/nodejs/node/pull/45444#issuecomment-1318425304
Please reload this pagehttps://github.com/nodejs/node/pull/45444
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 17, 2022https://github.com/nodejs/node/pull/45444#event-7832471903
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 17, 2022https://github.com/nodejs/node/pull/45444#event-7832546920
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 17, 2022https://github.com/nodejs/node/pull/45444#issuecomment-1318437911
https://ci.nodejs.org/job/node-test-pull-request/47980/https://ci.nodejs.org/job/node-test-pull-request/47980/
Please reload this pagehttps://github.com/nodejs/node/pull/45444
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 17, 2022https://github.com/nodejs/node/pull/45444#issuecomment-1318951129
https://ci.nodejs.org/job/node-test-pull-request/47994/https://ci.nodejs.org/job/node-test-pull-request/47994/
Please reload this pagehttps://github.com/nodejs/node/pull/45444
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 17, 2022 https://github.com/nodejs/node/pull/45444#pullrequestreview-1185050580
View reviewed changes https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/lpinca
lpincahttps://github.com/lpinca
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 17, 2022https://github.com/nodejs/node/pull/45444#event-7837626936
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 17, 2022https://github.com/nodejs/node/pull/45444#event-7837646829
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
b18ec04https://github.com/nodejs/node/commit/b18ec0433e602d17693a316ddcd60357fa1892d8
Nov 17, 2022https://github.com/nodejs/node/pull/45444#event-7837647452
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 17, 2022https://github.com/nodejs/node/pull/45444#issuecomment-1319176186
b18ec04https://github.com/nodejs/node/commit/b18ec0433e602d17693a316ddcd60357fa1892d8
Please reload this pagehttps://github.com/nodejs/node/pull/45444
CI Reliability 2022-11-18 nodejs/reliability#432 https://github.com/nodejs/reliability/issues/432
CI Reliability 2022-11-19 nodejs/reliability#433 https://github.com/nodejs/reliability/issues/433
CI Reliability 2022-11-20 nodejs/reliability#434 https://github.com/nodejs/reliability/issues/434
CI Reliability 2022-11-21 nodejs/reliability#435 https://github.com/nodejs/reliability/issues/435
ruyadornohttps://github.com/ruyadorno
Nov 21, 2022 https://github.com/nodejs/node/pull/45444#ref-commit-5e5bf0c
https://github.com/santigimeno
https://github.com/ruyadorno
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/commit/5e5bf0c236eaea58b59e9ee0984b4630a716bfe8
5e5bf0chttps://github.com/nodejs/node/commit/5e5bf0c236eaea58b59e9ee0984b4630a716bfe8
#45419https://github.com/nodejs/node/issues/45419
#45444https://github.com/nodejs/node/pull/45444
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 22, 2022 https://github.com/nodejs/node/pull/45444#ref-issue-1458785052
CI Reliability 2022-11-22 nodejs/reliability#436 https://github.com/nodejs/reliability/issues/436
marco-ippolitohttps://github.com/marco-ippolito
Nov 23, 2022 https://github.com/nodejs/node/pull/45444#ref-commit-3f0e136
https://github.com/santigimeno
https://github.com/marco-ippolito
src: don't run tasks on isolate terminationhttps://github.com/marco-ippolito/node/commit/3f0e136e9bde67e2c1c080d96ce522f2438937b0
3f0e136https://github.com/marco-ippolito/node/commit/3f0e136e9bde67e2c1c080d96ce522f2438937b0
nodejs#45419https://github.com/nodejs/node/issues/45419
nodejs#45444https://github.com/nodejs/node/pull/45444
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Nov 24, 2022 https://github.com/nodejs/node/pull/45444#ref-pullrequest-1463685824
v19.2.0 proposal #45615 https://github.com/nodejs/node/pull/45615
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45444#ref-commit-dfddaa5
https://github.com/santigimeno
https://github.com/danielleadams
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/commit/dfddaa5e81210060908498b3580e02a0b558988f
dfddaa5https://github.com/nodejs/node/commit/dfddaa5e81210060908498b3580e02a0b558988f
#45419https://github.com/nodejs/node/issues/45419
#45444https://github.com/nodejs/node/pull/45444
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45444#ref-pullrequest-1514807368
v18.13.0 release proposal #46025 https://github.com/nodejs/node/pull/46025
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45444#ref-commit-e343511
https://github.com/santigimeno
https://github.com/danielleadams
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/commit/e343511b643a8e63c0d9b2eef80dbe03c621cd87
e343511https://github.com/nodejs/node/commit/e343511b643a8e63c0d9b2eef80dbe03c621cd87
#45419https://github.com/nodejs/node/issues/45419
#45444https://github.com/nodejs/node/pull/45444
danielleadamshttps://github.com/danielleadams
Jan 3, 2023 https://github.com/nodejs/node/pull/45444#ref-commit-2c6a4fd
https://github.com/santigimeno
https://github.com/danielleadams
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/commit/2c6a4fd6fa214d06f220792a02b42eb7f2e7d05d
2c6a4fdhttps://github.com/nodejs/node/commit/2c6a4fd6fa214d06f220792a02b42eb7f2e7d05d
#45419https://github.com/nodejs/node/issues/45419
#45444https://github.com/nodejs/node/pull/45444
danielleadamshttps://github.com/danielleadams
Jan 4, 2023 https://github.com/nodejs/node/pull/45444#ref-commit-8874833
https://github.com/santigimeno
https://github.com/danielleadams
src: don't run tasks on isolate terminationhttps://github.com/nodejs/node/commit/887483314704beb5a9049301c8421f24123f4b92
8874833https://github.com/nodejs/node/commit/887483314704beb5a9049301c8421f24123f4b92
#45419https://github.com/nodejs/node/issues/45419
#45444https://github.com/nodejs/node/pull/45444
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45444
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/45444/files/639311fa604e9ceae36a498da1328c5ff1cc7de6
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
crash when running undici's wpt runner in node v19 https://github.com/nodejs/node/issues/45419
Please reload this pagehttps://github.com/nodejs/node/pull/45444
https://github.com/santigimeno
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.