René's URL Explorer Experiment


Title: [v19.x] lib: fix eslint early return by RafaelGSS · Pull Request #45409 · nodejs/node · GitHub

Open Graph Title: [v19.x] lib: fix eslint early return by RafaelGSS · Pull Request #45409 · nodejs/node

X Title: [v19.x] lib: fix eslint early return by RafaelGSS · Pull Request #45409 · nodejs/node

Description: The #45243 updated eslint, and apparently when you specify a @returns early returns aren't considered valid. This PR fixes this lint issue. In the main branch it's not failing because #41276 fixes ...

Open Graph Description: The #45243 updated eslint, and apparently when you specify a @returns early returns aren't considered valid. This PR fixes this lint issue. In the main branch it's not failing because #4127...

X Description: The #45243 updated eslint, and apparently when you specify a @returns early returns aren't considered valid. This PR fixes this lint issue. In the main branch it's not failing becau...

Opengraph URL: https://github.com/nodejs/node/pull/45409

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4c9be538-99b0-a0e6-5cc9-b8cd0c30217e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D3A:70C3B:12EC195:1A268F3:696A0065
html-safe-noncecc226a7162d5598ab03140e656da24da014cb11e6383a58b964dc03883075139
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDNBOjcwQzNCOjEyRUMxOTU6MUEyNjhGMzo2OTZBMDA2NSIsInZpc2l0b3JfaWQiOiIxNjU4Mzc5MTczNjAxMzQ1NjM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4bc09140b9995c37b77c615710e9d18add9be7d14b79a9c1f0e53cbea5b91e06
hovercard-subject-tagpull_request:1118008376
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45409/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4b42bac111f8332ffba4b75a665c253a3ef9dc276d547c18037bbe5700636488/nodejs/node/pull/45409
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b42bac111f8332ffba4b75a665c253a3ef9dc276d547c18037bbe5700636488/nodejs/node/pull/45409
og:image:altThe #45243 updated eslint, and apparently when you specify a @returns early returns aren't considered valid. This PR fixes this lint issue. In the main branch it's not failing because #4127...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRafaelGSS
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/45409#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/45409
Reloadhttps://github.com/nodejs/node/pull/45409
Reloadhttps://github.com/nodejs/node/pull/45409
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/45409
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/45409
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/45409#issue-comment-box
RafaelGSShttps://github.com/RafaelGSS
nodejs:v19.x-staginghttps://github.com/nodejs/node/tree/v19.x-staging
RafaelGSS:fix-eslint-return-earlyhttps://github.com/RafaelGSS/node/tree/fix-eslint-return-early
[v19.x] lib: fix eslint early return https://github.com/nodejs/node/pull/45409#top
RafaelGSShttps://github.com/RafaelGSS
nodejs:v19.x-staginghttps://github.com/nodejs/node/tree/v19.x-staging
RafaelGSS:fix-eslint-return-earlyhttps://github.com/RafaelGSS/node/tree/fix-eslint-return-early
Conversation 11 https://github.com/nodejs/node/pull/45409
Commits 1 https://github.com/nodejs/node/pull/45409/commits
Checks 0 https://github.com/nodejs/node/pull/45409/checks
Files changed https://github.com/nodejs/node/pull/45409/files
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022https://github.com/nodejs/node/pull/45409#issue-1444233937
#45243https://github.com/nodejs/node/pull/45243
#41276https://github.com/nodejs/node/pull/41276
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
lib: fix eslint early returnhttps://github.com/nodejs/node/pull/45409/commits/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
8e21b8fhttps://github.com/nodejs/node/pull/45409/commits/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
nodejs#45243https://github.com/nodejs/node/pull/45243
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
v19.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av19.x
Nov 10, 2022https://github.com/nodejs/node/pull/45409#event-7785195395
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1310586986
#45269https://github.com/nodejs/node/pull/45269
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Nov 10, 2022https://github.com/nodejs/node/pull/45409#event-7785198265
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 10, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1310587369
@RafaelGSShttps://github.com/RafaelGSS
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1310587377
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/panva
panvahttps://github.com/panva
Nov 10, 2022 https://github.com/nodejs/node/pull/45409#pullrequestreview-1176162118
View reviewed changes https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 10, 2022https://github.com/nodejs/node/pull/45409#event-7785253800
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 10, 2022https://github.com/nodejs/node/pull/45409#event-7785364333
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
https://github.com/lpinca
lpincahttps://github.com/lpinca
Nov 10, 2022 https://github.com/nodejs/node/pull/45409#pullrequestreview-1176229119
View reviewed changes https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Nov 10, 2022 https://github.com/nodejs/node/pull/45409#pullrequestreview-1176359789
View reviewed changes https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 11, 2022 https://github.com/nodejs/node/pull/45409#ref-issue-1444737103
CI Reliability 2022-11-11 nodejs/reliability#425 https://github.com/nodejs/reliability/issues/425
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 11, 2022https://github.com/nodejs/node/pull/45409#event-7791791806
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 11, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1311647698
https://ci.nodejs.org/job/node-test-pull-request/47864/https://ci.nodejs.org/job/node-test-pull-request/47864/
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Nov 11, 2022 https://github.com/nodejs/node/pull/45409#pullrequestreview-1177579105
View reviewed changes https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 11, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1311923972
#45269https://github.com/nodejs/node/pull/45269
Please reload this pagehttps://github.com/nodejs/node/pull/45409
RafaelGSShttps://github.com/RafaelGSS
Nov 11, 2022 https://github.com/nodejs/node/pull/45409#ref-commit-e2181e0
https://github.com/RafaelGSS
lib: fix eslint early returnhttps://github.com/nodejs/node/commit/e2181e057b68ca392f817646575f9926b2e20ebd
e2181e0https://github.com/nodejs/node/commit/e2181e057b68ca392f817646575f9926b2e20ebd
#45243https://github.com/nodejs/node/pull/45243
#45409https://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 11, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1311927061
e2181e0https://github.com/nodejs/node/commit/e2181e057b68ca392f817646575f9926b2e20ebd
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 11, 2022https://github.com/nodejs/node/pull/45409#event-7793521533
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 11, 2022https://github.com/nodejs/node/pull/45409#issuecomment-1311928687
nodejs/build#3075https://github.com/nodejs/build/issues/3075
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 11, 2022 https://github.com/nodejs/node/pull/45409#ref-pullrequest-1431783629
v19.1.0 proposal #45269 https://github.com/nodejs/node/pull/45269
CI Reliability 2022-11-12 nodejs/reliability#426 https://github.com/nodejs/reliability/issues/426
CI Reliability 2022-11-13 nodejs/reliability#427 https://github.com/nodejs/reliability/issues/427
CI Reliability 2022-11-14 nodejs/reliability#428 https://github.com/nodejs/reliability/issues/428
CI Reliability 2022-11-15 nodejs/reliability#429 https://github.com/nodejs/reliability/issues/429
CI Reliability 2022-11-16 nodejs/reliability#430 https://github.com/nodejs/reliability/issues/430
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45409#ref-commit-964166f
https://github.com/RafaelGSS
https://github.com/danielleadams
lib: fix eslint early returnhttps://github.com/nodejs/node/commit/964166f68040d9691988d9e382bcf278584f0ca1
964166fhttps://github.com/nodejs/node/commit/964166f68040d9691988d9e382bcf278584f0ca1
#45243https://github.com/nodejs/node/pull/45243
#45409https://github.com/nodejs/node/pull/45409
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45409#ref-pullrequest-1514807368
v18.13.0 release proposal #46025 https://github.com/nodejs/node/pull/46025
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45409#ref-commit-93eb5bd
https://github.com/RafaelGSS
https://github.com/danielleadams
lib: fix eslint early returnhttps://github.com/nodejs/node/commit/93eb5bdcd2f615a5a730679f0d2d1c891eaafacf
93eb5bdhttps://github.com/nodejs/node/commit/93eb5bdcd2f615a5a730679f0d2d1c891eaafacf
#45243https://github.com/nodejs/node/pull/45243
#45409https://github.com/nodejs/node/pull/45409
danielleadamshttps://github.com/danielleadams
Jan 3, 2023 https://github.com/nodejs/node/pull/45409#ref-commit-b9d4ac2
https://github.com/RafaelGSS
https://github.com/danielleadams
lib: fix eslint early returnhttps://github.com/nodejs/node/commit/b9d4ac2c7ee44ffffbaea19a2ad1686c50fd260f
b9d4ac2https://github.com/nodejs/node/commit/b9d4ac2c7ee44ffffbaea19a2ad1686c50fd260f
#45243https://github.com/nodejs/node/pull/45243
#45409https://github.com/nodejs/node/pull/45409
danielleadamshttps://github.com/danielleadams
Jan 4, 2023 https://github.com/nodejs/node/pull/45409#ref-commit-6099a39
https://github.com/RafaelGSS
https://github.com/danielleadams
lib: fix eslint early returnhttps://github.com/nodejs/node/commit/6099a393ccf70b1e9e6f3881302afbb2c576b71c
6099a39https://github.com/nodejs/node/commit/6099a393ccf70b1e9e6f3881302afbb2c576b71c
#45243https://github.com/nodejs/node/pull/45243
#45409https://github.com/nodejs/node/pull/45409
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45409
https://github.com/ruyadorno
ruyadorno https://github.com/ruyadorno
https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
https://github.com/BethGriggs
BethGriggs https://github.com/BethGriggs
https://github.com/nodejs/node/pull/45409/files/8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/45409
https://github.com/RafaelGSS
https://github.com/nodejs-github-bot
https://github.com/ruyadorno
https://github.com/panva
https://github.com/lpinca
https://github.com/BethGriggs
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.