René's URL Explorer Experiment


Title: fs: protect fs.watch from monkeypatches by anonrig · Pull Request #45265 · nodejs/node · GitHub

Open Graph Title: fs: protect fs.watch from monkeypatches by anonrig · Pull Request #45265 · nodejs/node

X Title: fs: protect fs.watch from monkeypatches by anonrig · Pull Request #45265 · nodejs/node

Description: Follow up on comments from #45098 CC @nodejs/fs

Open Graph Description: Follow up on comments from #45098 CC @nodejs/fs

X Description: Follow up on comments from #45098 CC @nodejs/fs

Mail addresses
duhamelantoine1995@gmail.com
rafael.nunu@hotmail.com
moshe@atlow.co.il
yagiz@nizipli.com
duhamelantoine1995@gmail.com
rafael.nunu@hotmail.com
moshe@atlow.co.il
yagiz@nizipli.com

Opengraph URL: https://github.com/nodejs/node/pull/45265

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6b57fae4-0141-bd97-390d-f0ddbbbe266c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC5C:201472:14523D8:1C897F7:696A35AE
html-safe-nonce40ed2e7255dbac60ff2192f3acc38ab416f1b9db66525fb7e4fc649587a0cdae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzVDOjIwMTQ3MjoxNDUyM0Q4OjFDODk3Rjc6Njk2QTM1QUUiLCJ2aXNpdG9yX2lkIjoiMjI3NDUyMDk5NTYwODU0MDU5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf2f0a9deed6b965dc9c3384b6de9300d0b36232f6d30a6720b042a11a7cc81c6
hovercard-subject-tagpull_request:1106773837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45265/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/48f01c61b0a83eb1f6f985e64c3bfbd54ccb1680725e50b88949de79c467c807/nodejs/node/pull/45265
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/48f01c61b0a83eb1f6f985e64c3bfbd54ccb1680725e50b88949de79c467c807/nodejs/node/pull/45265
og:image:altFollow up on comments from #45098 CC @nodejs/fs
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/45265#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45265
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45265
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/45265
Reloadhttps://github.com/nodejs/node/pull/45265
Reloadhttps://github.com/nodejs/node/pull/45265
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/45265
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/45265
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/45265#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:fs/recursive-followuphttps://github.com/anonrig/node/tree/fs/recursive-followup
fs: protect fs.watch from monkeypatches https://github.com/nodejs/node/pull/45265#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:fs/recursive-followuphttps://github.com/anonrig/node/tree/fs/recursive-followup
Conversation 6 https://github.com/nodejs/node/pull/45265
Commits 2 https://github.com/nodejs/node/pull/45265/commits
Checks 0 https://github.com/nodejs/node/pull/45265/checks
Files changed https://github.com/nodejs/node/pull/45265/files
Please reload this pagehttps://github.com/nodejs/node/pull/45265
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/anonrig
anonrighttps://github.com/anonrig
Nov 1, 2022https://github.com/nodejs/node/pull/45265#issue-1431468743
Please reload this pagehttps://github.com/nodejs/node/pull/45265
#45098https://github.com/nodejs/node/pull/45098
Please reload this pagehttps://github.com/nodejs/node/pull/45265
anonrighttps://github.com/anonrig
November 1, 2022 09:51https://github.com/nodejs/node/pull/45265#commits-pushed-0fc80d2
https://github.com/anonrig
fs: update todo messagehttps://github.com/nodejs/node/pull/45265/commits/0fc80d2d60cd88f2672c710e5389282ab72220b1
0fc80d2https://github.com/nodejs/node/pull/45265/commits/0fc80d2d60cd88f2672c710e5389282ab72220b1
https://github.com/anonrig
fs: protect fs.watch from monkeypatcheshttps://github.com/nodejs/node/pull/45265/commits/1673db412c4bf9595a1aeab0a565861459ce4d15
1673db4https://github.com/nodejs/node/pull/45265/commits/1673db412c4bf9595a1aeab0a565861459ce4d15
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7713540558
https://github.com/anonrig
anonrighttps://github.com/anonrig
Nov 1, 2022 https://github.com/nodejs/node/pull/45265#ref-pullrequest-1417116179
fs: add recursive watch for linux #45098 https://github.com/nodejs/node/pull/45098
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7713548727
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7713591467
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2022https://github.com/nodejs/node/pull/45265#issuecomment-1298552139
https://ci.nodejs.org/job/node-test-pull-request/47617/https://ci.nodejs.org/job/node-test-pull-request/47617/
Please reload this pagehttps://github.com/nodejs/node/pull/45265
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 1, 2022 https://github.com/nodejs/node/pull/45265#pullrequestreview-1163697719
View reviewed changes https://github.com/nodejs/node/pull/45265/files/1673db412c4bf9595a1aeab0a565861459ce4d15
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7715327690
https://github.com/anonrig
anonrighttps://github.com/anonrig
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7715566584
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 1, 2022https://github.com/nodejs/node/pull/45265#issuecomment-1298867673
@anonrighttps://github.com/anonrig
Please reload this pagehttps://github.com/nodejs/node/pull/45265
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022 https://github.com/nodejs/node/pull/45265#pullrequestreview-1163772612
View reviewed changes https://github.com/nodejs/node/pull/45265/files/1673db412c4bf9595a1aeab0a565861459ce4d15
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Nov 1, 2022 https://github.com/nodejs/node/pull/45265#pullrequestreview-1163822822
View reviewed changes https://github.com/nodejs/node/pull/45265/files/1673db412c4bf9595a1aeab0a565861459ce4d15
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7715937823
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7715983524
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2022https://github.com/nodejs/node/pull/45265#issuecomment-1298927200
#45265https://github.com/nodejs/node/pull/45265
#45265https://github.com/nodejs/node/pull/45265
https://github.com/nodejs/node/actions/runs/3371785169
https://github.com/nodejs/node/actions/runs/3371785169https://github.com/nodejs/node/actions/runs/3371785169
Please reload this pagehttps://github.com/nodejs/node/pull/45265
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7715997372
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7716096359
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
a5c6f3ehttps://github.com/nodejs/node/commit/a5c6f3e8a1868f39283afc123c2c222af9a91d52
Nov 1, 2022https://github.com/nodejs/node/pull/45265#event-7716096780
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 1, 2022https://github.com/nodejs/node/pull/45265#issuecomment-1298944149
a5c6f3ehttps://github.com/nodejs/node/commit/a5c6f3e8a1868f39283afc123c2c222af9a91d52
Please reload this pagehttps://github.com/nodejs/node/pull/45265
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022https://github.com/nodejs/node/pull/45265#issuecomment-1299094174
@anonrighttps://github.com/anonrig
a5c6f3ehttps://github.com/nodejs/node/commit/a5c6f3e8a1868f39283afc123c2c222af9a91d52
Please reload this pagehttps://github.com/nodejs/node/pull/45265
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022 https://github.com/nodejs/node/pull/45265#ref-commit-e9e2b27
https://github.com/anonrig
https://github.com/RafaelGSS
fs: update todo messagehttps://github.com/nodejs/node/commit/e9e2b276c77116f03e85db577c2587a9ce161238
e9e2b27https://github.com/nodejs/node/commit/e9e2b276c77116f03e85db577c2587a9ce161238
#45265https://github.com/nodejs/node/pull/45265
https://github.com/anonrig
anonrighttps://github.com/anonrig
Nov 2, 2022https://github.com/nodejs/node/pull/45265#issuecomment-1300582905
@RafaelGSShttps://github.com/RafaelGSS
Please reload this pagehttps://github.com/nodejs/node/pull/45265
lucshihttps://github.com/lucshi
Nov 9, 2022 https://github.com/nodejs/node/pull/45265#ref-commit-9e1e527
https://github.com/anonrig
fs: update todo messagehttps://github.com/lucshi/node/commit/9e1e527fbb4c99d7922989f7517763c2e768ff1d
9e1e527https://github.com/lucshi/node/commit/9e1e527fbb4c99d7922989f7517763c2e768ff1d
nodejs#45265https://github.com/nodejs/node/pull/45265
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022 https://github.com/nodejs/node/pull/45265#ref-commit-daff3b8
https://github.com/anonrig
https://github.com/RafaelGSS
fs: update todo messagehttps://github.com/nodejs/node/commit/daff3b8b09e9a8f7d658392a9e4d5ecbe04f9c8a
daff3b8https://github.com/nodejs/node/commit/daff3b8b09e9a8f7d658392a9e4d5ecbe04f9c8a
#45265https://github.com/nodejs/node/pull/45265
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022 https://github.com/nodejs/node/pull/45265#ref-pullrequest-1431783629
v19.1.0 proposal #45269 https://github.com/nodejs/node/pull/45269
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45265#ref-commit-097c81a
https://github.com/anonrig
https://github.com/danielleadams
fs: update todo messagehttps://github.com/nodejs/node/commit/097c81a213018897399b6b6c03e561e86cd1ee33
097c81ahttps://github.com/nodejs/node/commit/097c81a213018897399b6b6c03e561e86cd1ee33
#45265https://github.com/nodejs/node/pull/45265
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45265#ref-pullrequest-1514807368
v18.13.0 release proposal #46025 https://github.com/nodejs/node/pull/46025
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45265#ref-commit-8f2e9fe
https://github.com/anonrig
https://github.com/danielleadams
fs: update todo messagehttps://github.com/nodejs/node/commit/8f2e9febdc16131b7451a1110c4c26d45d146940
8f2e9fehttps://github.com/nodejs/node/commit/8f2e9febdc16131b7451a1110c4c26d45d146940
#45265https://github.com/nodejs/node/pull/45265
danielleadamshttps://github.com/danielleadams
Jan 3, 2023 https://github.com/nodejs/node/pull/45265#ref-commit-c2f0377
https://github.com/anonrig
https://github.com/danielleadams
fs: update todo messagehttps://github.com/nodejs/node/commit/c2f0377b8faa5331f49eb9314b6c07f16b16e46d
c2f0377https://github.com/nodejs/node/commit/c2f0377b8faa5331f49eb9314b6c07f16b16e46d
#45265https://github.com/nodejs/node/pull/45265
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45265
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/45265/files/1673db412c4bf9595a1aeab0a565861459ce4d15
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/45265/files/1673db412c4bf9595a1aeab0a565861459ce4d15
https://github.com/RafaelGSS
RafaelGSS https://github.com/RafaelGSS
https://github.com/nodejs/node/pull/45265/files/1673db412c4bf9595a1aeab0a565861459ce4d15
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/45265
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/RafaelGSS
https://github.com/MoLow
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.