René's URL Explorer Experiment


Title: http2: fix crash on Http2Stream::diagnostic_name() by santigimeno · Pull Request #45123 · nodejs/node · GitHub

Open Graph Title: http2: fix crash on Http2Stream::diagnostic_name() by santigimeno · Pull Request #45123 · nodejs/node

X Title: http2: fix crash on Http2Stream::diagnostic_name() by santigimeno · Pull Request #45123 · nodejs/node

Description: It can happen that the Http2Stream::session_ has already been deleted when the Http2Stream destructor is called, causing diagnostic_name() to crash. Observed when running some http2 tests on Window...

Open Graph Description: It can happen that the Http2Stream::session_ has already been deleted when the Http2Stream destructor is called, causing diagnostic_name() to crash. Observed when running some http2 tests on Window...

X Description: It can happen that the Http2Stream::session_ has already been deleted when the Http2Stream destructor is called, causing diagnostic_name() to crash. Observed when running some http2 tests on Window...

Opengraph URL: https://github.com/nodejs/node/pull/45123

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b7c845c8-be43-c70c-4841-a758e4d73093
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB15C:145B07:2D0B06:3F4C0F:696A1D29
html-safe-noncedb4a3cf9d16fc964715058986621ccbd43d9e2715df65b6d3eba5da7f980205a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTVDOjE0NUIwNzoyRDBCMDY6M0Y0QzBGOjY5NkExRDI5IiwidmlzaXRvcl9pZCI6IjUxMzI4Nzg3NDI0OTI0MjE0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf298bbcc9333956373a2c0316e41cc7b1ff2a6a51be5aff53bae0611126de824
hovercard-subject-tagpull_request:1096106101
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45123/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/537573e30ad81f7a372506f2db2c1022f086361aa2ab0b1bd34b42aa49398c23/nodejs/node/pull/45123
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/537573e30ad81f7a372506f2db2c1022f086361aa2ab0b1bd34b42aa49398c23/nodejs/node/pull/45123
og:image:altIt can happen that the Http2Stream::session_ has already been deleted when the Http2Stream destructor is called, causing diagnostic_name() to crash. Observed when running some http2 tests on Window...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesantigimeno
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/45123#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45123
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45123
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/45123
Reloadhttps://github.com/nodejs/node/pull/45123
Reloadhttps://github.com/nodejs/node/pull/45123
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/45123
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/45123
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/45123#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
santigimeno:santi/fix_http2_diag_name_crashhttps://github.com/santigimeno/node/tree/santi/fix_http2_diag_name_crash
http2: fix crash on Http2Stream::diagnostic_name() https://github.com/nodejs/node/pull/45123#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
santigimeno:santi/fix_http2_diag_name_crashhttps://github.com/santigimeno/node/tree/santi/fix_http2_diag_name_crash
Conversation 7 https://github.com/nodejs/node/pull/45123
Commits 1 https://github.com/nodejs/node/pull/45123/commits
Checks 0 https://github.com/nodejs/node/pull/45123/checks
Files changed 1 https://github.com/nodejs/node/pull/45123/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Oct 22, 2022https://github.com/nodejs/node/pull/45123#issue-1419228946
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2022https://github.com/nodejs/node/pull/45123#issuecomment-1287754186
Please reload this pagehttps://github.com/nodejs/node/pull/45123
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 22, 2022https://github.com/nodejs/node/pull/45123#event-7645669079
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 22, 2022 https://github.com/nodejs/node/pull/45123#pullrequestreview-1151946850
View reviewed changes https://github.com/nodejs/node/pull/45123/files
RafaelGSShttps://github.com/RafaelGSS
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/nodejs/node/pull/45123#pullrequestreview-1151946850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 22, 2022 https://github.com/nodejs/node/pull/45123#pullrequestreview-1152082287
View reviewed changes https://github.com/nodejs/node/pull/45123/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/45123#pullrequestreview-1152082287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2022 https://github.com/nodejs/node/pull/45123#pullrequestreview-1152086493
View reviewed changes https://github.com/nodejs/node/pull/45123/files
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 23, 2022 https://github.com/nodejs/node/pull/45123#pullrequestreview-1152321058
View reviewed changes https://github.com/nodejs/node/pull/45123/files
https://github.com/santigimeno
http2: fix crash on Http2Stream::diagnostic_name()https://github.com/nodejs/node/pull/45123/commits/d96a37c5929d5a13d43178127a2ac8e0f2276d09
d96a37chttps://github.com/nodejs/node/pull/45123/commits/d96a37c5929d5a13d43178127a2ac8e0f2276d09
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
force-pushedhttps://github.com/nodejs/node/compare/96eae978707d498a936c55e460ca092ca011b7e5..d96a37c5929d5a13d43178127a2ac8e0f2276d09
96eae97https://github.com/nodejs/node/commit/96eae978707d498a936c55e460ca092ca011b7e5
d96a37chttps://github.com/nodejs/node/commit/d96a37c5929d5a13d43178127a2ac8e0f2276d09
Compare https://github.com/nodejs/node/compare/96eae978707d498a936c55e460ca092ca011b7e5..d96a37c5929d5a13d43178127a2ac8e0f2276d09
October 25, 2022 09:33https://github.com/nodejs/node/pull/45123#event-7661770026
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Oct 25, 2022https://github.com/nodejs/node/pull/45123#issuecomment-1290266482
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 25, 2022https://github.com/nodejs/node/pull/45123#event-7661780787
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 25, 2022https://github.com/nodejs/node/pull/45123#event-7661804088
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 25, 2022https://github.com/nodejs/node/pull/45123#issuecomment-1290270853
https://ci.nodejs.org/job/node-test-pull-request/47462/https://ci.nodejs.org/job/node-test-pull-request/47462/
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Oct 25, 2022 https://github.com/nodejs/node/pull/45123#pullrequestreview-1154735893
View reviewed changes https://github.com/nodejs/node/pull/45123/files/d96a37c5929d5a13d43178127a2ac8e0f2276d09
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 25, 2022 https://github.com/nodejs/node/pull/45123#pullrequestreview-1154784617
View reviewed changes https://github.com/nodejs/node/pull/45123/files/d96a37c5929d5a13d43178127a2ac8e0f2276d09
RafaelGSShttps://github.com/RafaelGSS
https://github.com/nodejs/node/pull/45123#pullrequestreview-1154784617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 25, 2022https://github.com/nodejs/node/pull/45123#event-7663443102
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 25, 2022https://github.com/nodejs/node/pull/45123#event-7663549376
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
67828d5https://github.com/nodejs/node/commit/67828d58fb700737f170436a596659b61bb111a8
Oct 25, 2022https://github.com/nodejs/node/pull/45123#event-7663549977
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 25, 2022https://github.com/nodejs/node/pull/45123#issuecomment-1290545988
67828d5https://github.com/nodejs/node/commit/67828d58fb700737f170436a596659b61bb111a8
Please reload this pagehttps://github.com/nodejs/node/pull/45123
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022 https://github.com/nodejs/node/pull/45123#ref-commit-2e528fa
https://github.com/santigimeno
https://github.com/RafaelGSS
http2: fix crash on Http2Stream::diagnostic_name()https://github.com/nodejs/node/commit/2e528fab44c933525654e48d70e54ae7d6add846
2e528fahttps://github.com/nodejs/node/commit/2e528fab44c933525654e48d70e54ae7d6add846
#45123https://github.com/nodejs/node/pull/45123
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022 https://github.com/nodejs/node/pull/45123#ref-pullrequest-1431783629
v19.1.0 proposal #45269 https://github.com/nodejs/node/pull/45269
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022 https://github.com/nodejs/node/pull/45123#ref-commit-1635140
https://github.com/santigimeno
https://github.com/RafaelGSS
http2: fix crash on Http2Stream::diagnostic_name()https://github.com/nodejs/node/commit/1635140952ba98561c263d62876dbe07fc8462ac
1635140https://github.com/nodejs/node/commit/1635140952ba98561c263d62876dbe07fc8462ac
#45123https://github.com/nodejs/node/pull/45123
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45123#ref-commit-b212b58
https://github.com/santigimeno
https://github.com/danielleadams
http2: fix crash on Http2Stream::diagnostic_name()https://github.com/nodejs/node/commit/b212b581f944cfb6dd9a9a3bf502b4b4611a198f
b212b58https://github.com/nodejs/node/commit/b212b581f944cfb6dd9a9a3bf502b4b4611a198f
#45123https://github.com/nodejs/node/pull/45123
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45123#ref-pullrequest-1514807368
v18.13.0 release proposal #46025 https://github.com/nodejs/node/pull/46025
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45123#ref-commit-6d78dc5
https://github.com/santigimeno
https://github.com/danielleadams
http2: fix crash on Http2Stream::diagnostic_name()https://github.com/nodejs/node/commit/6d78dc55dbdf3c0db0bd05cf58bf3c6222bc8178
6d78dc5https://github.com/nodejs/node/commit/6d78dc55dbdf3c0db0bd05cf58bf3c6222bc8178
#45123https://github.com/nodejs/node/pull/45123
danielleadamshttps://github.com/danielleadams
Jan 3, 2023 https://github.com/nodejs/node/pull/45123#ref-commit-a534175
https://github.com/santigimeno
https://github.com/danielleadams
http2: fix crash on Http2Stream::diagnostic_name()https://github.com/nodejs/node/commit/a534175aa51edca34af5966fe31ccfcf8aafda3f
a534175https://github.com/nodejs/node/commit/a534175aa51edca34af5966fe31ccfcf8aafda3f
#45123https://github.com/nodejs/node/pull/45123
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45123
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/45123/files/96eae978707d498a936c55e460ca092ca011b7e5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/45123/files/96eae978707d498a936c55e460ca092ca011b7e5
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/45123/files/d96a37c5929d5a13d43178127a2ac8e0f2276d09
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/45123/files/96eae978707d498a936c55e460ca092ca011b7e5
https://github.com/RafaelGSS
RafaelGSS https://github.com/RafaelGSS
https://github.com/nodejs/node/pull/45123/files/d96a37c5929d5a13d43178127a2ac8e0f2276d09
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/45123
https://github.com/santigimeno
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/RafaelGSS
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.