René's URL Explorer Experiment


Title: http2: improve session close/destroy procedures by santigimeno · Pull Request #45115 · nodejs/node · GitHub

Open Graph Title: http2: improve session close/destroy procedures by santigimeno · Pull Request #45115 · nodejs/node

X Title: http2: improve session close/destroy procedures by santigimeno · Pull Request #45115 · nodejs/node

Description: Don't destroy the socket when closing the session but let it end gracefully. Also, when destroying the session, on Windows, we would get ECONNRESET errors, make sure we take those into account in o...

Open Graph Description: Don't destroy the socket when closing the session but let it end gracefully. Also, when destroying the session, on Windows, we would get ECONNRESET errors, make sure we take those into account ...

X Description: Don't destroy the socket when closing the session but let it end gracefully. Also, when destroying the session, on Windows, we would get ECONNRESET errors, make sure we take those into acco...

Opengraph URL: https://github.com/nodejs/node/pull/45115

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7f3e0fd8-20a4-8562-d471-e7b9dd1f8c28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBA4:333370:E9077D:142D6C6:696A3575
html-safe-nonce2d39c6344d664a9841614e671400c0c44193770c05c65a7478b05d085306ec28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkE0OjMzMzM3MDpFOTA3N0Q6MTQyRDZDNjo2OTZBMzU3NSIsInZpc2l0b3JfaWQiOiI4MjYxNzc3NDE5OTQ5MTkyNTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2fdb61d644f67b3eff681e880ff5c5474a291f1be7390b5f9ca1af6946290cd1
hovercard-subject-tagpull_request:1095848273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/45115/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/02170cbd5ee87785b2f0a7aa94af8204d0509a620a5a47243637a0771c4dc146/nodejs/node/pull/45115
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/02170cbd5ee87785b2f0a7aa94af8204d0509a620a5a47243637a0771c4dc146/nodejs/node/pull/45115
og:image:altDon't destroy the socket when closing the session but let it end gracefully. Also, when destroying the session, on Windows, we would get ECONNRESET errors, make sure we take those into account ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesantigimeno
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/45115#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45115
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45115
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/45115
Reloadhttps://github.com/nodejs/node/pull/45115
Reloadhttps://github.com/nodejs/node/pull/45115
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/45115
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/45115
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/45115#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
santigimeno:santi/fix_http2_close_destroyhttps://github.com/santigimeno/node/tree/santi/fix_http2_close_destroy
http2: improve session close/destroy procedures https://github.com/nodejs/node/pull/45115#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
santigimeno:santi/fix_http2_close_destroyhttps://github.com/santigimeno/node/tree/santi/fix_http2_close_destroy
Conversation 6 https://github.com/nodejs/node/pull/45115
Commits 1 https://github.com/nodejs/node/pull/45115/commits
Checks 0 https://github.com/nodejs/node/pull/45115/checks
Files changed https://github.com/nodejs/node/pull/45115/files
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Oct 21, 2022https://github.com/nodejs/node/pull/45115#issue-1418930932
#42340https://github.com/nodejs/node/pull/42340
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/santigimeno
http2: improve session close/destroy procedureshttps://github.com/nodejs/node/pull/45115/commits/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
727abc2https://github.com/nodejs/node/pull/45115/commits/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
jasnellhttps://github.com/jasnell
October 21, 2022 22:45https://github.com/nodejs/node/pull/45115#event-7644089122
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 21, 2022https://github.com/nodejs/node/pull/45115#issuecomment-1287507261
Please reload this pagehttps://github.com/nodejs/node/pull/45115
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 21, 2022https://github.com/nodejs/node/pull/45115#event-7644089896
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
Oct 21, 2022 https://github.com/nodejs/node/pull/45115#ref-pullrequest-1169386045
deps: upgrade to libuv 1.44.2 #42340 https://github.com/nodejs/node/pull/42340
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 22, 2022 https://github.com/nodejs/node/pull/45115#pullrequestreview-1151901796
View reviewed changes https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/45115#pullrequestreview-1151901796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 22, 2022 https://github.com/nodejs/node/pull/45115#pullrequestreview-1151946424
View reviewed changes https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2022 https://github.com/nodejs/node/pull/45115#pullrequestreview-1152085228
View reviewed changes https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 22, 2022https://github.com/nodejs/node/pull/45115#issuecomment-1287867210
https://ci.nodejs.org/job/node-test-pull-request/47400/https://ci.nodejs.org/job/node-test-pull-request/47400/
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Oct 23, 2022 https://github.com/nodejs/node/pull/45115#pullrequestreview-1152323710
View reviewed changes https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/santigimeno
santigimenohttps://github.com/santigimeno
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Oct 25, 2022https://github.com/nodejs/node/pull/45115#event-7661634271
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 25, 2022https://github.com/nodejs/node/pull/45115#event-7661654047
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 25, 2022https://github.com/nodejs/node/pull/45115#issuecomment-1290247900
https://ci.nodejs.org/job/node-test-pull-request/47461/https://ci.nodejs.org/job/node-test-pull-request/47461/
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 25, 2022https://github.com/nodejs/node/pull/45115#issuecomment-1290942159
https://ci.nodejs.org/job/node-test-pull-request/47476/https://ci.nodejs.org/job/node-test-pull-request/47476/
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 26, 2022 https://github.com/nodejs/node/pull/45115#ref-issue-1423256685
CI Reliability 2022-10-26 nodejs/reliability#411 https://github.com/nodejs/reliability/issues/411
https://github.com/mcollina
mcollinahttps://github.com/mcollina
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 26, 2022https://github.com/nodejs/node/pull/45115#event-7670831316
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 26, 2022https://github.com/nodejs/node/pull/45115#event-7670878202
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
5374e15https://github.com/nodejs/node/commit/5374e15d241051d6c61993974568730498daea22
Oct 26, 2022https://github.com/nodejs/node/pull/45115#event-7670878962
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2022https://github.com/nodejs/node/pull/45115#issuecomment-1291743003
5374e15https://github.com/nodejs/node/commit/5374e15d241051d6c61993974568730498daea22
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 27, 2022 https://github.com/nodejs/node/pull/45115#ref-issue-1424838898
CI Reliability 2022-10-27 nodejs/reliability#412 https://github.com/nodejs/reliability/issues/412
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022 https://github.com/nodejs/node/pull/45115#ref-commit-67eaf0f
https://github.com/santigimeno
https://github.com/RafaelGSS
http2: improve session close/destroy procedureshttps://github.com/nodejs/node/commit/67eaf0fed8e7a8784a451d40a2c4231c2024c3dd
67eaf0fhttps://github.com/nodejs/node/commit/67eaf0fed8e7a8784a451d40a2c4231c2024c3dd
#45115https://github.com/nodejs/node/pull/45115
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2022 https://github.com/nodejs/node/pull/45115#ref-pullrequest-1431783629
v19.1.0 proposal #45269 https://github.com/nodejs/node/pull/45269
RafaelGSShttps://github.com/RafaelGSS
Nov 10, 2022 https://github.com/nodejs/node/pull/45115#ref-commit-316354e
https://github.com/santigimeno
https://github.com/RafaelGSS
http2: improve session close/destroy procedureshttps://github.com/nodejs/node/commit/316354e3d35db1a14f505a30bbbfcb7e72c49829
316354ehttps://github.com/nodejs/node/commit/316354e3d35db1a14f505a30bbbfcb7e72c49829
#45115https://github.com/nodejs/node/pull/45115
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45115#ref-commit-f5a6126
https://github.com/santigimeno
https://github.com/danielleadams
http2: improve session close/destroy procedureshttps://github.com/nodejs/node/commit/f5a61266a2b00e812666435a1f968727d841e07f
f5a6126https://github.com/nodejs/node/commit/f5a61266a2b00e812666435a1f968727d841e07f
#45115https://github.com/nodejs/node/pull/45115
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45115#ref-pullrequest-1514807368
v18.13.0 release proposal #46025 https://github.com/nodejs/node/pull/46025
danielleadamshttps://github.com/danielleadams
Dec 30, 2022 https://github.com/nodejs/node/pull/45115#ref-commit-5618916
https://github.com/santigimeno
https://github.com/danielleadams
http2: improve session close/destroy procedureshttps://github.com/nodejs/node/commit/5618916015b8e4c4a0e4cdad137810f67c44bb2f
5618916https://github.com/nodejs/node/commit/5618916015b8e4c4a0e4cdad137810f67c44bb2f
#45115https://github.com/nodejs/node/pull/45115
danielleadamshttps://github.com/danielleadams
Jan 3, 2023 https://github.com/nodejs/node/pull/45115#ref-commit-b45878b
https://github.com/santigimeno
https://github.com/danielleadams
http2: improve session close/destroy procedureshttps://github.com/nodejs/node/commit/b45878b2f1a56c1a833bb5029924bd7f73e144fd
b45878bhttps://github.com/nodejs/node/commit/b45878b2f1a56c1a833bb5029924bd7f73e144fd
#45115https://github.com/nodejs/node/pull/45115
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F45115
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
https://github.com/RafaelGSS
RafaelGSS https://github.com/RafaelGSS
https://github.com/nodejs/node/pull/45115/files/727abc2aa2400be6bdb6d8e5f355dd1e9922a14a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/45115
https://github.com/santigimeno
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/RafaelGSS
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.