René's URL Explorer Experiment


Title: src: fix MakeCallback error handling by trevnorris · Pull Request #4507 · nodejs/node · GitHub

Open Graph Title: src: fix MakeCallback error handling by trevnorris · Pull Request #4507 · nodejs/node

X Title: src: fix MakeCallback error handling by trevnorris · Pull Request #4507 · nodejs/node

Description: The final goal of this PR is to allow MakeCallback (in both node:: and AsyncWrap::) to be reentrant. Reason is because the HTTPParser may enter the JS call stack initially, or be called while alrea...

Open Graph Description: The final goal of this PR is to allow MakeCallback (in both node:: and AsyncWrap::) to be reentrant. Reason is because the HTTPParser may enter the JS call stack initially, or be called while alrea...

X Description: The final goal of this PR is to allow MakeCallback (in both node:: and AsyncWrap::) to be reentrant. Reason is because the HTTPParser may enter the JS call stack initially, or be called while alrea...

Opengraph URL: https://github.com/nodejs/node/pull/4507

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:51df8dc2-2436-a4e8-0a7a-5d94922ac070
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA89A:C9338:961F43:C3CFF0:696B1BFB
html-safe-nonce25ea2ead38f14f349686a9a3683cec5b1ae83136ed82a5eabc818e2cfd1a7321
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODlBOkM5MzM4Ojk2MUY0MzpDM0NGRjA6Njk2QjFCRkIiLCJ2aXNpdG9yX2lkIjoiMzM3NDczNDUzMjcwOTkxNTY0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5fd16a6bb8559fd67300b487875916f3dc3348299c3b85fb875e25b4b83f67b8
hovercard-subject-tagpull_request:54895949
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4507/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bbb892f1a03420dbc57d1330e4563204127eccbd86de755e80f18cb401a214fe/nodejs/node/pull/4507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bbb892f1a03420dbc57d1330e4563204127eccbd86de755e80f18cb401a214fe/nodejs/node/pull/4507
og:image:altThe final goal of this PR is to allow MakeCallback (in both node:: and AsyncWrap::) to be reentrant. Reason is because the HTTPParser may enter the JS call stack initially, or be called while alrea...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrevnorris
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/4507#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4507
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4507
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/4507
Reloadhttps://github.com/nodejs/node/pull/4507
Reloadhttps://github.com/nodejs/node/pull/4507
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/4507
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/4507
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/4507#issue-comment-box
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:throw-mc-fixhttps://github.com/trevnorris/node/tree/throw-mc-fix
src: fix MakeCallback error handling https://github.com/nodejs/node/pull/4507#top
trevnorrishttps://github.com/trevnorris
nodejs:masterhttps://github.com/nodejs/node/tree/master
trevnorris:throw-mc-fixhttps://github.com/trevnorris/node/tree/throw-mc-fix
Conversation 67 https://github.com/nodejs/node/pull/4507
Commits 6 https://github.com/nodejs/node/pull/4507/commits
Checks 0 https://github.com/nodejs/node/pull/4507/checks
Files changed https://github.com/nodejs/node/pull/4507/files
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 1, 2016https://github.com/nodejs/node/pull/4507#issue-124560068
@indutnyhttps://github.com/indutny
#4509https://github.com/nodejs/node/pull/4509
@misterdjuleshttps://github.com/misterdjules
nodejs/node-v0.x-archive#9245https://github.com/nodejs/node-v0.x-archive/issues/9245
@bnoordhuishttps://github.com/bnoordhuis
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jan 1, 2016https://github.com/nodejs/node/pull/4507#event-503843191
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 1, 2016 https://github.com/nodejs/node/pull/4507#ref-pullrequest-124563769
Fix async wrap http #4509 https://github.com/nodejs/node/pull/4509
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jan 2, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168405682
@bajtoshttps://github.com/bajtos
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/indutny
indutnyhttps://github.com/indutny
Jan 2, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168417539
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 4, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168640818
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/indutny
indutnyhttps://github.com/indutny
Jan 4, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168672398
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 4, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168729530
@indutnyhttps://github.com/indutny
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 4, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168825309
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/62f58b86619a65f6ed15d56fd29fd6cf1a1e892c..be27b71604a3de7a4e4a388d8d37424e00ca3290
62f58b8https://github.com/nodejs/node/commit/62f58b86619a65f6ed15d56fd29fd6cf1a1e892c
be27b71https://github.com/nodejs/node/commit/be27b71604a3de7a4e4a388d8d37424e00ca3290
Compare https://github.com/nodejs/node/compare/62f58b86619a65f6ed15d56fd29fd6cf1a1e892c..be27b71604a3de7a4e4a388d8d37424e00ca3290
January 4, 2016 22:22https://github.com/nodejs/node/pull/4507#event-505305182
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 4, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168831742
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/be27b71604a3de7a4e4a388d8d37424e00ca3290..eb725449951a087c16b7a6246c49f021107bad62
be27b71https://github.com/nodejs/node/commit/be27b71604a3de7a4e4a388d8d37424e00ca3290
eb72544https://github.com/nodejs/node/commit/eb725449951a087c16b7a6246c49f021107bad62
Compare https://github.com/nodejs/node/compare/be27b71604a3de7a4e4a388d8d37424e00ca3290..eb725449951a087c16b7a6246c49f021107bad62
January 4, 2016 23:46https://github.com/nodejs/node/pull/4507#event-505370323
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 4, 2016https://github.com/nodejs/node/pull/4507#event-505370836
misterdjuleshttps://github.com/misterdjules
Jan 5, 2016 https://github.com/nodejs/node/pull/4507#discussion-diff-48799258
View reviewed changes https://github.com/nodejs/node/pull/4507/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
src/async-wrap.cchttps://github.com/nodejs/node/pull/4507/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
misterdjuleshttps://github.com/misterdjules
Jan 5, 2016https://github.com/nodejs/node/pull/4507#discussion_r48799258
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/eb725449951a087c16b7a6246c49f021107bad62..edade1170c7093e3982d64ddf3826142e4c08b8a
eb72544https://github.com/nodejs/node/commit/eb725449951a087c16b7a6246c49f021107bad62
edade11https://github.com/nodejs/node/commit/edade1170c7093e3982d64ddf3826142e4c08b8a
Compare https://github.com/nodejs/node/compare/eb725449951a087c16b7a6246c49f021107bad62..edade1170c7093e3982d64ddf3826142e4c08b8a
January 5, 2016 00:17https://github.com/nodejs/node/pull/4507#event-505388674
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 5, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168851932
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/4507
misterdjuleshttps://github.com/misterdjules
Jan 5, 2016 https://github.com/nodejs/node/pull/4507#discussion-diff-48800042
View reviewed changes https://github.com/nodejs/node/pull/4507/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
src/async-wrap.cchttps://github.com/nodejs/node/pull/4507/files#diff-eb96d4137061363ca88665d48df2f0f4fbd6d999ae156a0ef1caf6855e18d890
misterdjuleshttps://github.com/misterdjules
Jan 5, 2016https://github.com/nodejs/node/pull/4507#discussion_r48800042
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Jan 5, 2016https://github.com/nodejs/node/pull/4507#issuecomment-168866165
@trevnorrishttps://github.com/trevnorris
all domains on the stack are clearedhttps://github.com/nodejs/node/blob/master/lib/domain.js#L65-L75
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/bajtos
bajtoshttps://github.com/bajtos
Jan 5, 2016https://github.com/nodejs/node/pull/4507#issuecomment-169007102
nodejs/node-v0.x-archive#5713https://github.com/nodejs/node-v0.x-archive/pull/5713
nodejs/node-v0.x-archive#6460https://github.com/nodejs/node-v0.x-archive/pull/6460
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 5, 2016https://github.com/nodejs/node/pull/4507#issuecomment-169078362
@misterdjuleshttps://github.com/misterdjules
@bajtoshttps://github.com/bajtos
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 5, 2016https://github.com/nodejs/node/pull/4507#event-506200496
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/1a6831740e8b6b3c474169dc6448b14f60267ef6..160b3d1c45d7396d7765e386a93fc9b1cb5d4331
1a68317https://github.com/nodejs/node/commit/1a6831740e8b6b3c474169dc6448b14f60267ef6
160b3d1https://github.com/nodejs/node/commit/160b3d1c45d7396d7765e386a93fc9b1cb5d4331
Compare https://github.com/nodejs/node/compare/1a6831740e8b6b3c474169dc6448b14f60267ef6..160b3d1c45d7396d7765e386a93fc9b1cb5d4331
January 5, 2016 18:02https://github.com/nodejs/node/pull/4507#event-506203148
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 5, 2016https://github.com/nodejs/node/pull/4507#issuecomment-169084666
https://ci.nodejs.org/job/node-test-pull-request/1147/https://ci.nodejs.org/job/node-test-pull-request/1147/
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/joaocgreis
joaocgreishttps://github.com/joaocgreis
Jan 5, 2016https://github.com/nodejs/node/pull/4507#issuecomment-169099148
@trevnorrishttps://github.com/trevnorris
https://ci.nodejs.org/job/node-test-commit-windows-fanned/815/https://ci.nodejs.org/job/node-test-commit-windows-fanned/815/
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
force-pushedhttps://github.com/nodejs/node/compare/57702ae001e53eb0b0cd15fce2e1037a9094af20..f9af215b9bbebd62de84295b887e438a4842112d
57702aehttps://github.com/nodejs/node/commit/57702ae001e53eb0b0cd15fce2e1037a9094af20
f9af215https://github.com/nodejs/node/commit/f9af215b9bbebd62de84295b887e438a4842112d
Compare https://github.com/nodejs/node/compare/57702ae001e53eb0b0cd15fce2e1037a9094af20..f9af215b9bbebd62de84295b887e438a4842112d
January 7, 2016 00:09https://github.com/nodejs/node/pull/4507#event-507708400
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Jan 7, 2016https://github.com/nodejs/node/pull/4507#issuecomment-169519837
@trevnorrishttps://github.com/trevnorris
https://gist.github.com/misterdjules/fac76caa775b3ad63ac8https://gist.github.com/misterdjules/fac76caa775b3ad63ac8
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Jan 7, 2016https://github.com/nodejs/node/pull/4507#issuecomment-169728337
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 7, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-e538407
https://github.com/trevnorris
src: remove TryCatch in MakeCallbackhttps://github.com/nodejs/node/commit/e53840796ff02eb670e9b64a7aadb2623716ad4f
e538407https://github.com/nodejs/node/commit/e53840796ff02eb670e9b64a7aadb2623716ad4f
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 7, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-0da5fdd
https://github.com/trevnorris
test: add addons test for MakeCallbackhttps://github.com/nodejs/node/commit/0da5fdd2254b9c9c6af1d780ea6e0d4984a08fce
0da5fddhttps://github.com/nodejs/node/commit/0da5fdd2254b9c9c6af1d780ea6e0d4984a08fce
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jun 14, 2016https://github.com/nodejs/node/pull/4507#event-691221596
MylesBorinshttps://github.com/MylesBorins
Jun 24, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-36b9a79
https://github.com/trevnorris
src: fix MakeCallback error handlinghttps://github.com/nodejs/node/commit/36b9a79446f6ad8c8b44689c295065f3920659c6
36b9a79https://github.com/nodejs/node/commit/36b9a79446f6ad8c8b44689c295065f3920659c6
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 24, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-de02175
https://github.com/trevnorris
src: add AsyncCallbackScopehttps://github.com/nodejs/node/commit/de02175c46b074cbe40dcfde8f237fd445f11bf5
de02175https://github.com/nodejs/node/commit/de02175c46b074cbe40dcfde8f237fd445f11bf5
nodejs/node-v0.x-archive#9245https://github.com/nodejs/node-v0.x-archive/issues/9245
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 24, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-5d899e3
https://github.com/trevnorris
src: remove unused of TickInfo::last_threw()https://github.com/nodejs/node/commit/5d899e351cc6550dbf8d5d44750c69b0dd9f3224
5d899e3https://github.com/nodejs/node/commit/5d899e351cc6550dbf8d5d44750c69b0dd9f3224
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 24, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-359f304
https://github.com/trevnorris
src: remove unused TickInfo::in_tick()https://github.com/nodejs/node/commit/359f3045eb52ff88242d513b027ecae06d3163c8
359f304https://github.com/nodejs/node/commit/359f3045eb52ff88242d513b027ecae06d3163c8
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 24, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-b40f120
https://github.com/trevnorris
src: remove TryCatch in MakeCallbackhttps://github.com/nodejs/node/commit/b40f120e1d7db36540b00478bbfc1cbc4cd37b1c
b40f120https://github.com/nodejs/node/commit/b40f120e1d7db36540b00478bbfc1cbc4cd37b1c
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 24, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-662e496
https://github.com/trevnorris
test: add addons test for MakeCallbackhttps://github.com/nodejs/node/commit/662e496c19aa03e3d7966c956afd62984585d62d
662e496https://github.com/nodejs/node/commit/662e496c19aa03e3d7966c956afd62984585d62d
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 28, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-a32b8fb
https://github.com/trevnorris
src: fix MakeCallback error handlinghttps://github.com/nodejs/node/commit/a32b8fbdef72bb2fc6a821451ff30ff3f9409bbf
a32b8fbhttps://github.com/nodejs/node/commit/a32b8fbdef72bb2fc6a821451ff30ff3f9409bbf
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 28, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-42aeff4
https://github.com/trevnorris
src: add AsyncCallbackScopehttps://github.com/nodejs/node/commit/42aeff4b9093ce974dff5ed86ae84d03eedcdef9
42aeff4https://github.com/nodejs/node/commit/42aeff4b9093ce974dff5ed86ae84d03eedcdef9
nodejs/node-v0.x-archive#9245https://github.com/nodejs/node-v0.x-archive/issues/9245
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 28, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-ed6d0cd
https://github.com/trevnorris
src: remove unused of TickInfo::last_threw()https://github.com/nodejs/node/commit/ed6d0cdd796c7bf602fddcadbd1e2bc990a55be6
ed6d0cdhttps://github.com/nodejs/node/commit/ed6d0cdd796c7bf602fddcadbd1e2bc990a55be6
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 28, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-0860758
https://github.com/trevnorris
src: remove unused TickInfo::in_tick()https://github.com/nodejs/node/commit/08607588ec173284aed38d304326e706b94f5f11
0860758https://github.com/nodejs/node/commit/08607588ec173284aed38d304326e706b94f5f11
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 28, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-a2f17f1
https://github.com/trevnorris
src: remove TryCatch in MakeCallbackhttps://github.com/nodejs/node/commit/a2f17f16c3c7cc67895eddaefe826f36472729fa
a2f17f1https://github.com/nodejs/node/commit/a2f17f16c3c7cc67895eddaefe826f36472729fa
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jun 28, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-8fbc8ff
https://github.com/trevnorris
test: add addons test for MakeCallbackhttps://github.com/nodejs/node/commit/8fbc8ff193a5ff9ffb48e7e13617c1c3d1e73e50
8fbc8ffhttps://github.com/nodejs/node/commit/8fbc8ff193a5ff9ffb48e7e13617c1c3d1e73e50
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-2eb097f
https://github.com/trevnorris
src: fix MakeCallback error handlinghttps://github.com/nodejs/node/commit/2eb097f212a8e843d8193cd5e0bc80e7934537b1
2eb097fhttps://github.com/nodejs/node/commit/2eb097f212a8e843d8193cd5e0bc80e7934537b1
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-cb291d5
https://github.com/trevnorris
src: add AsyncCallbackScopehttps://github.com/nodejs/node/commit/cb291d5c7f980a591be637c80d3d095d43d47217
cb291d5https://github.com/nodejs/node/commit/cb291d5c7f980a591be637c80d3d095d43d47217
nodejs/node-v0.x-archive#9245https://github.com/nodejs/node-v0.x-archive/issues/9245
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-d77b28c
https://github.com/trevnorris
src: remove unused of TickInfo::last_threw()https://github.com/nodejs/node/commit/d77b28c6b3bf81cda19694004bef7bd8c7cc9108
d77b28chttps://github.com/nodejs/node/commit/d77b28c6b3bf81cda19694004bef7bd8c7cc9108
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-48b7b71
https://github.com/trevnorris
src: remove unused TickInfo::in_tick()https://github.com/nodejs/node/commit/48b7b71352f0b11453468a876e8a28d2ef2927a2
48b7b71https://github.com/nodejs/node/commit/48b7b71352f0b11453468a876e8a28d2ef2927a2
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-981bbcd
https://github.com/trevnorris
src: remove TryCatch in MakeCallbackhttps://github.com/nodejs/node/commit/981bbcd9256379d15d5d2fafd60e78f749579729
981bbcdhttps://github.com/nodejs/node/commit/981bbcd9256379d15d5d2fafd60e78f749579729
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-commit-1186b7a
https://github.com/trevnorris
test: add addons test for MakeCallbackhttps://github.com/nodejs/node/commit/1186b7a40144836ae0dbfb76fa7d2789593945d6
1186b7ahttps://github.com/nodejs/node/commit/1186b7a40144836ae0dbfb76fa7d2789593945d6
#7048https://github.com/nodejs/node/pull/7048
#4507https://github.com/nodejs/node/pull/4507
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 12, 2016 https://github.com/nodejs/node/pull/4507#ref-pullrequest-165144525
v4.5.0 proposal #7688 https://github.com/nodejs/node/pull/7688
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4507
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/4507
https://github.com/trevnorris
https://github.com/bnoordhuis
https://github.com/indutny
https://github.com/misterdjules
https://github.com/bajtos
https://github.com/joaocgreis
https://github.com/jasnell
https://github.com/rvagg
https://github.com/kkoopa
https://github.com/MylesBorins
https://github.com/petkaantonov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.