| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7c7d2f34-f1fe-1760-e954-b15d09df458e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 909E:2A5BE9:7AFB2:9E0CB:696AF920 |
| html-safe-nonce | 6e515e4578c6acf484032efbc05fe4ee116f1e4fbf98f09f0db398d764aab88c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDlFOjJBNUJFOTo3QUZCMjo5RTBDQjo2OTZBRjkyMCIsInZpc2l0b3JfaWQiOiI2MDY5NTU5NzEwNjE0MTQxNzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 10d954b8dd028f27466fca6f9925422dfd5aea655ba69702dd7470b1e5f45eb0 |
| hovercard-subject-tag | pull_request:54809788 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4484/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ad898be0a1512649e27e024cb35e1d469ce76ee8b2690c39f89a0576da89b3cd/nodejs/node/pull/4484 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ad898be0a1512649e27e024cb35e1d469ce76ee8b2690c39f89a0576da89b3cd/nodejs/node/pull/4484 |
| og:image:alt | Move argument validation out of C++ and into JS. Improves performance
by about 15-20%.
Benchmark comparisons between current master and this branch are below:
$ node benchmark/compare.js ./node ./n... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | evanlucas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/4484#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4484 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4484 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/4484 |
| Reload | https://github.com/nodejs/node/pull/4484 |
| Reload | https://github.com/nodejs/node/pull/4484 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/4484#issue-comment-box |
| evanlucas | https://github.com/evanlucas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| evanlucas:hrtime | https://github.com/evanlucas/node/tree/hrtime |
|
node: improve performance of process.hrtime()
| https://github.com/nodejs/node/pull/4484#top |
| evanlucas | https://github.com/evanlucas |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| evanlucas:hrtime | https://github.com/evanlucas/node/tree/hrtime |
|
Conversation
10
| https://github.com/nodejs/node/pull/4484 |
|
Commits
1
| https://github.com/nodejs/node/pull/4484/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/4484/checks |
|
Files changed
| https://github.com/nodejs/node/pull/4484/files |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#issue-124366281 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#issuecomment-168024886 |
| https://ci.nodejs.org/job/node-test-pull-request/1113/ | https://ci.nodejs.org/job/node-test-pull-request/1113/ |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#event-502914451 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#issuecomment-168034234 |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#issuecomment-168067105 |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#event-503034161 |
|
| https://github.com/evanlucas |
| node: improve performance of process.hrtime() | https://github.com/nodejs/node/pull/4484/commits/78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
| 78fd435 | https://github.com/nodejs/node/pull/4484/commits/78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
| nodejs#4484 | https://github.com/nodejs/node/pull/4484 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| force-pushed | https://github.com/nodejs/node/compare/aba604e58db33b4ea4ee69123af58d94ba63ba3d..78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
| aba604e | https://github.com/nodejs/node/commit/aba604e58db33b4ea4ee69123af58d94ba63ba3d |
| 78fd435 | https://github.com/nodejs/node/commit/78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
|
Compare
| https://github.com/nodejs/node/compare/aba604e58db33b4ea4ee69123af58d94ba63ba3d..78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
| December 30, 2015 22:55 | https://github.com/nodejs/node/pull/4484#event-503116505 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#event-503116516 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| December 30, 2015 22:55 | https://github.com/nodejs/node/pull/4484#event-503116517 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| 78fd435 | https://github.com/nodejs/node/commit/78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#event-503116633 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4484#issuecomment-168090838 |
| 78fd435 | https://github.com/nodejs/node/commit/78fd43514f1dc5144c71f9dbc2be3f6698da5522 |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jan 6, 2016
| https://github.com/nodejs/node/pull/4484#ref-commit-921fb54 |
|
| https://github.com/evanlucas |
|
| https://github.com/Fishrock123 |
| node: improve performance of process.hrtime() | https://github.com/Fishrock123/node/commit/921fb540c13c09c93a447088d5c0f709469416e9 |
| 921fb54 | https://github.com/Fishrock123/node/commit/921fb540c13c09c93a447088d5c0f709469416e9 |
| nodejs#4484 | https://github.com/nodejs/node/pull/4484 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jan 6, 2016
| https://github.com/nodejs/node/pull/4484#ref-commit-af591d4 |
|
| https://github.com/Fishrock123 |
| 2016-01-06, Version 5.4.0 (Stable) | https://github.com/Fishrock123/node/commit/af591d494070a978d23fdb6c7c46ff52060b61b1 |
| af591d4 | https://github.com/Fishrock123/node/commit/af591d494070a978d23fdb6c7c46ff52060b61b1 |
| nodejs#4377 | https://github.com/nodejs/node/pull/4377 |
| nodejs#4482 | https://github.com/nodejs/node/pull/4482 |
| nodejs#4330 | https://github.com/nodejs/node/pull/4330 |
| nodejs#3622 | https://github.com/nodejs/node/pull/3622 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#4484 | https://github.com/nodejs/node/pull/4484 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#3964 | https://github.com/nodejs/node/pull/3964 |
| nodejs#4547 | https://github.com/nodejs/node/pull/4547 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jan 11, 2016
| https://github.com/nodejs/node/pull/4484#ref-commit-5f0abd6 |
|
| https://github.com/Fishrock123 |
| 2016-01-06, Version 5.4.0 (Stable) | https://github.com/Fishrock123/node/commit/5f0abd6472cee0478e0b8cf057e2fddb3eb4c021 |
| 5f0abd6 | https://github.com/Fishrock123/node/commit/5f0abd6472cee0478e0b8cf057e2fddb3eb4c021 |
| nodejs#4377 | https://github.com/nodejs/node/pull/4377 |
| nodejs#4482 | https://github.com/nodejs/node/pull/4482 |
| nodejs#4330 | https://github.com/nodejs/node/pull/4330 |
| nodejs#3622 | https://github.com/nodejs/node/pull/3622 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#4484 | https://github.com/nodejs/node/pull/4484 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#3964 | https://github.com/nodejs/node/pull/3964 |
| nodejs#4547 | https://github.com/nodejs/node/pull/4547 |
| nodejs#4623 | https://github.com/nodejs/node/pull/4623 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 13, 2016 | https://github.com/nodejs/node/pull/4484#issuecomment-171423965 |
| @evanlucas | https://github.com/evanlucas |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Jan 14, 2016 | https://github.com/nodejs/node/pull/4484#issuecomment-171500652 |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
| Jan 14, 2016 | https://github.com/nodejs/node/pull/4484#issuecomment-171629566 |
| @thealphanerd | https://github.com/thealphanerd |
| 36e8a2c | https://github.com/nodejs/node/commit/36e8a2c63dc17d7f6e473d0ce5bfa67f8d0fe31d |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 14, 2016 | https://github.com/nodejs/node/pull/4484#issuecomment-171630370 |
| @trevnorris | https://github.com/trevnorris |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 14, 2016 | https://github.com/nodejs/node/pull/4484#issuecomment-171651776 |
| 36e8a2c | https://github.com/nodejs/node/commit/36e8a2c63dc17d7f6e473d0ce5bfa67f8d0fe31d |
| @trevnorris | https://github.com/trevnorris |
| https://github.com/trevnorris | https://github.com/trevnorris |
| #4484 (comment) | https://github.com/nodejs/node/pull/4484#issuecomment-171630370 |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jan 28, 2016 | https://github.com/nodejs/node/pull/4484#event-530343017 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Jan 28, 2016 | https://github.com/nodejs/node/pull/4484#issuecomment-176408890 |
| #3780 | https://github.com/nodejs/node/pull/3780 |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
| scovetta | https://github.com/scovetta |
|
Apr 2, 2016
| https://github.com/nodejs/node/pull/4484#ref-commit-027d385 |
|
| https://github.com/evanlucas |
| node: improve performance of process.hrtime() | https://github.com/scovetta/node/commit/027d38558ef9285c9e7a9dc5ac5988ec1600e5fc |
| 027d385 | https://github.com/scovetta/node/commit/027d38558ef9285c9e7a9dc5ac5988ec1600e5fc |
| nodejs#4484 | https://github.com/nodejs/node/pull/4484 |
| scovetta | https://github.com/scovetta |
|
Apr 2, 2016
| https://github.com/nodejs/node/pull/4484#ref-commit-3991aa8 |
|
| https://github.com/Fishrock123 |
| 2016-01-06, Version 5.4.0 (Stable) | https://github.com/scovetta/node/commit/3991aa8e2e0e7a26e8ae15b4962bbdafbb2612b4 |
| 3991aa8 | https://github.com/scovetta/node/commit/3991aa8e2e0e7a26e8ae15b4962bbdafbb2612b4 |
| nodejs#4377 | https://github.com/nodejs/node/pull/4377 |
| nodejs#4482 | https://github.com/nodejs/node/pull/4482 |
| nodejs#4330 | https://github.com/nodejs/node/pull/4330 |
| nodejs#3622 | https://github.com/nodejs/node/pull/3622 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#4484 | https://github.com/nodejs/node/pull/4484 |
| nodejs#3780 | https://github.com/nodejs/node/pull/3780 |
| nodejs#3964 | https://github.com/nodejs/node/pull/3964 |
| nodejs#4547 | https://github.com/nodejs/node/pull/4547 |
| nodejs#4623 | https://github.com/nodejs/node/pull/4623 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4484 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Please reload this page | https://github.com/nodejs/node/pull/4484 |
|
| https://github.com/evanlucas |
|
| https://github.com/trevnorris |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |