René's URL Explorer Experiment


Title: test: clarify role of domains in microtask queue tests by Trott · Pull Request #4474 · nodejs/node · GitHub

Open Graph Title: test: clarify role of domains in microtask queue tests by Trott · Pull Request #4474 · nodejs/node

X Title: test: clarify role of domains in microtask queue tests by Trott · Pull Request #4474 · nodejs/node

Description: Add this comment: > Requiring domain calls _setupDomainUse which in turns changes the > tickCallback function that is used to call callbacks scheduled with > process.nextTick. > > So requiring doma...

Open Graph Description: Add this comment: > Requiring domain calls _setupDomainUse which in turns changes the > tickCallback function that is used to call callbacks scheduled with > process.nextTick. > > So...

X Description: Add this comment: > Requiring domain calls _setupDomainUse which in turns changes the > tickCallback function that is used to call callbacks scheduled with > process.nextTick. ...

Opengraph URL: https://github.com/nodejs/node/pull/4474

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:93204733-68d7-efa1-3474-7b9ae6eb5a30
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8188:3A6082:130B83E:18A1E13:696B1B36
html-safe-nonce4be71aa92acee5ccf246eae9aac49504b2a5456791ba087e6c84e4d5f8c97ec7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTg4OjNBNjA4MjoxMzBCODNFOjE4QTFFMTM6Njk2QjFCMzYiLCJ2aXNpdG9yX2lkIjoiNTQ3MjY2OTAxNTYyMTcwNDUwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac83202bb594cda935b1677db40556dac784742536b1ce9942bc92d5e0939fa803
hovercard-subject-tagpull_request:54772872
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4474/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e39a66289d12988c3b9ac92ee382e3fbcfa8a21cf27a5818b579e8db6f6174b/nodejs/node/pull/4474
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e39a66289d12988c3b9ac92ee382e3fbcfa8a21cf27a5818b579e8db6f6174b/nodejs/node/pull/4474
og:image:altAdd this comment: > Requiring domain calls _setupDomainUse which in turns changes the > tickCallback function that is used to call callbacks scheduled with > process.nextTick. > > So...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/4474#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4474
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4474
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/4474
Reloadhttps://github.com/nodejs/node/pull/4474
Reloadhttps://github.com/nodejs/node/pull/4474
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/4474
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/4474
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/4474#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:rm-borked-testshttps://github.com/Trott/io.js/tree/rm-borked-tests
test: clarify role of domains in microtask queue tests https://github.com/nodejs/node/pull/4474#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:rm-borked-testshttps://github.com/Trott/io.js/tree/rm-borked-tests
Conversation 13 https://github.com/nodejs/node/pull/4474
Commits 1 https://github.com/nodejs/node/pull/4474/commits
Checks 0 https://github.com/nodejs/node/pull/4474/checks
Files changed https://github.com/nodejs/node/pull/4474/files
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 30, 2015https://github.com/nodejs/node/pull/4474#issue-124293629
@misterdjuleshttps://github.com/misterdjules
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Dec 30, 2015https://github.com/nodejs/node/pull/4474#event-502528051
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 30, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168066077
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Dec 30, 2015https://github.com/nodejs/node/pull/4474#event-503034156
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Dec 30, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168073944
calls _setupDomainUsehttps://github.com/nodejs/node/blob/master/lib/domain.js#L36
changes the tickCallback function that is used to call callbacks scheduled with process.nextTickhttps://github.com/nodejs/node/blob/master/src/node.cc#L1025-L1035
the _tickDomainCallback functionhttps://github.com/nodejs/node/blob/master/src/node.js#L402-L443
the _tickCallback functionhttps://github.com/nodejs/node/blob/master/src/node.js#L364-L400
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 30, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168078663
@misterdjuleshttps://github.com/misterdjules
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 30, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168092373
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Dec 31, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168131949
@jasnellhttps://github.com/jasnell
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/5505f68dc3bbad8701b339d3ef73e7e5bbd0628c..a1316d8a9569ba2e6f4fae35c471cc4422b8c5b1
5505f68https://github.com/nodejs/node/commit/5505f68dc3bbad8701b339d3ef73e7e5bbd0628c
a1316d8https://github.com/nodejs/node/commit/a1316d8a9569ba2e6f4fae35c471cc4422b8c5b1
Compare https://github.com/nodejs/node/compare/5505f68dc3bbad8701b339d3ef73e7e5bbd0628c..a1316d8a9569ba2e6f4fae35c471cc4422b8c5b1
December 31, 2015 16:24https://github.com/nodejs/node/pull/4474#event-503451866
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 31, 2015https://github.com/nodejs/node/pull/4474#event-503452201
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 31, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168216652
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 31, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168216793
Please reload this pagehttps://github.com/nodejs/node/pull/4474
misterdjuleshttps://github.com/misterdjules
Dec 31, 2015 https://github.com/nodejs/node/pull/4474#discussion-diff-48668696
View reviewed changes https://github.com/nodejs/node/pull/4474/files#diff-e94572d01454bd01313979a1e583e885a9bfd4bc2b050776c4d24700e0545aa3
test/parallel/test-microtask-queue-integration-domain.jshttps://github.com/nodejs/node/pull/4474/files#diff-e94572d01454bd01313979a1e583e885a9bfd4bc2b050776c4d24700e0545aa3
misterdjuleshttps://github.com/misterdjules
Dec 31, 2015https://github.com/nodejs/node/pull/4474#discussion_r48668696
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Dec 31, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168238290
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 31, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168252129
@misterdjuleshttps://github.com/misterdjules
https://ci.nodejs.org/job/node-test-pull-request/1126/https://ci.nodejs.org/job/node-test-pull-request/1126/
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/misterdjules
misterdjuleshttps://github.com/misterdjules
Dec 31, 2015https://github.com/nodejs/node/pull/4474#issuecomment-168256240
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
test: clarify role of domains in testhttps://github.com/nodejs/node/pull/4474/commits/b0b9163dd09d2c79d7e73dbe8fa60f8e200a6686
b0b9163https://github.com/nodejs/node/pull/4474/commits/b0b9163dd09d2c79d7e73dbe8fa60f8e200a6686
nodejs#4474https://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/67009217c86f322820a09d3889493a222aef46be..b0b9163dd09d2c79d7e73dbe8fa60f8e200a6686
6700921https://github.com/nodejs/node/commit/67009217c86f322820a09d3889493a222aef46be
b0b9163https://github.com/nodejs/node/commit/b0b9163dd09d2c79d7e73dbe8fa60f8e200a6686
Compare https://github.com/nodejs/node/compare/67009217c86f322820a09d3889493a222aef46be..b0b9163dd09d2c79d7e73dbe8fa60f8e200a6686
January 1, 2016 23:59https://github.com/nodejs/node/pull/4474#event-503873380
Trotthttps://github.com/Trott
Jan 2, 2016 https://github.com/nodejs/node/pull/4474#ref-commit-b16a50d
https://github.com/Trott
test: clarify role of domains in testhttps://github.com/Trott/io.js/commit/b16a50d32d750cf8b9f4bed7d90b38d87d76c34a
b16a50dhttps://github.com/Trott/io.js/commit/b16a50d32d750cf8b9f4bed7d90b38d87d76c34a
nodejs#4474https://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 2, 2016https://github.com/nodejs/node/pull/4474#issuecomment-168351826
b16a50dhttps://github.com/nodejs/node/commit/b16a50d32d750cf8b9f4bed7d90b38d87d76c34a
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
Trotthttps://github.com/Trott
Jan 2, 2016https://github.com/nodejs/node/pull/4474#event-503874513
Fishrock123https://github.com/Fishrock123
Jan 6, 2016 https://github.com/nodejs/node/pull/4474#ref-commit-f1a66bc
https://github.com/Trott
https://github.com/Fishrock123
test: clarify role of domains in testhttps://github.com/Fishrock123/node/commit/f1a66bc24976ac977f138476725919bb21b752b4
f1a66bchttps://github.com/Fishrock123/node/commit/f1a66bc24976ac977f138476725919bb21b752b4
nodejs#4474https://github.com/nodejs/node/pull/4474
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Jan 13, 2016https://github.com/nodejs/node/pull/4474#event-514179381
MylesBorinshttps://github.com/MylesBorins
Jan 13, 2016 https://github.com/nodejs/node/pull/4474#ref-commit-aa6e704
https://github.com/Trott
test: clarify role of domains in testhttps://github.com/nodejs/node/commit/aa6e704753cfc2dac3a07546a65a201dd1717638
aa6e704https://github.com/nodejs/node/commit/aa6e704753cfc2dac3a07546a65a201dd1717638
#4474https://github.com/nodejs/node/pull/4474
MylesBorinshttps://github.com/MylesBorins
Jan 19, 2016 https://github.com/nodejs/node/pull/4474#ref-commit-610727d
https://github.com/Trott
test: clarify role of domains in testhttps://github.com/nodejs/node/commit/610727dea7cfd491e6dad59ef4642641fd471942
610727dhttps://github.com/nodejs/node/commit/610727dea7cfd491e6dad59ef4642641fd471942
#4474https://github.com/nodejs/node/pull/4474
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 19, 2016 https://github.com/nodejs/node/pull/4474#ref-pullrequest-127531954
V4.2.5 proposal #4768 https://github.com/nodejs/node/pull/4768
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-landed-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-landed-on-v4.x
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
Jan 28, 2016https://github.com/nodejs/node/pull/4474#event-530337511
scovettahttps://github.com/scovetta
Apr 2, 2016 https://github.com/nodejs/node/pull/4474#ref-commit-b2cc871
https://github.com/Trott
test: clarify role of domains in testhttps://github.com/scovetta/node/commit/b2cc871366e013788644274be942dd1fa5cc045b
b2cc871https://github.com/scovetta/node/commit/b2cc871366e013788644274be942dd1fa5cc045b
nodejs#4474https://github.com/nodejs/node/pull/4474
[Snyk] Security upgrade mocha from 7.2.0 to 8.2.0 turkdevops/node#22 https://github.com/turkdevops/node/pull/22
[Snyk] Security upgrade mocha from 6.2.3 to 8.2.0 adamlaska/node#40 https://github.com/adamlaska/node/pull/40
[Snyk] Security upgrade mocha from 6.2.3 to 8.2.0 turkdevops/node#23 https://github.com/turkdevops/node/pull/23
[Snyk] Security upgrade mocha from 7.2.0 to 8.2.0 turkdevops/node#32 https://github.com/turkdevops/node/pull/32
[Snyk] Security upgrade mocha from 6.2.3 to 8.2.0 adamlaska/node#45 https://github.com/adamlaska/node/pull/45
[Snyk] Security upgrade mocha from 6.2.3 to 8.2.0 turkdevops/node#33 https://github.com/turkdevops/node/pull/33
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:31https://github.com/nodejs/node/pull/4474#event-5890883245
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4474
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/4474
https://github.com/Trott
https://github.com/jasnell
https://github.com/misterdjules
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.