René's URL Explorer Experiment


Title: http: fix non-string header value concatenation by mscdex · Pull Request #4460 · nodejs/node · GitHub

Open Graph Title: http: fix non-string header value concatenation by mscdex · Pull Request #4460 · nodejs/node

X Title: http: fix non-string header value concatenation by mscdex · Pull Request #4460 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Since headers are stored in an empty literal object ({}) instead of an object created with Object.create(null), care must be taken with property names inherited from Object. Currently there are onl...

X Description: Since headers are stored in an empty literal object ({}) instead of an object created with Object.create(null), care must be taken with property names inherited from Object. Currently there are onl...

Opengraph URL: https://github.com/nodejs/node/pull/4460

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fe77488d-ce98-29a4-948d-cde6e0ce998d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85D4:34B1A9:A8FA61:F6DF57:6A4E1FBC
html-safe-nonce5948c14b1d50fcb8d35b6e451802bc00511026429a80c9ed17353e610e94c8bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUQ0OjM0QjFBOTpBOEZBNjE6RjZERjU3OjZBNEUxRkJDIiwidmlzaXRvcl9pZCI6IjM3MDU3Mzc3MjM2NzMxOTAzMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0689045c33f69b6713ba2bce8c5d13bf73ebd20eb09cf03241d4c3d0292846ef
hovercard-subject-tagpull_request:54692423
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4460/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5abff8c25794648ca8d7dfa6c4f603dcf853555334e427641226a2d4b95b6b17/nodejs/node/pull/4460
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5abff8c25794648ca8d7dfa6c4f603dcf853555334e427641226a2d4b95b6b17/nodejs/node/pull/4460
og:image:altSince headers are stored in an empty literal object ({}) instead of an object created with Object.create(null), care must be taken with property names inherited from Object. Currently there are onl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/4460#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4460
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4460
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/4460
Reloadhttps://github.com/nodejs/node/pull/4460
Reloadhttps://github.com/nodejs/node/pull/4460
Please reload this pagehttps://github.com/nodejs/node/pull/4460
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/4460
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-http-non-string-header-concathttps://github.com/mscdex/io.js/tree/fix-http-non-string-header-concat
Conversationhttps://github.com/nodejs/node/pull/4460
Commits1 (1)https://github.com/nodejs/node/pull/4460/commits
Checkshttps://github.com/nodejs/node/pull/4460/checks
Files changedhttps://github.com/nodejs/node/pull/4460/files
http: fix non-string header value concatenationhttps://github.com/nodejs/node/pull/4460#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-http-non-string-header-concathttps://github.com/mscdex/io.js/tree/fix-http-non-string-header-concat
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 28, 2015https://github.com/nodejs/node/pull/4460#issue-124141852
#4456https://github.com/nodejs/node/issues/4456
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/82d1159e00488d8e498235282939b2e312b78fe2..7878d43e791418a8032cca89b24a39524f5356fb
82d1159https://github.com/nodejs/node/commit/82d1159e00488d8e498235282939b2e312b78fe2
7878d43https://github.com/nodejs/node/commit/7878d43e791418a8032cca89b24a39524f5356fb
Compare https://github.com/nodejs/node/compare/82d1159e00488d8e498235282939b2e312b78fe2..7878d43e791418a8032cca89b24a39524f5356fb
December 28, 2015 23:43https://github.com/nodejs/node/pull/4460#event-501765569
https://github.com/mscdex
mscdexhttps://github.com/mscdex
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Dec 28, 2015https://github.com/nodejs/node/pull/4460#event-501765732
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/nodejs/node/pull/4460/commits/070b617eb067bba6faa37a26b9abda8548d7a4ea
070b617https://github.com/nodejs/node/pull/4460/commits/070b617eb067bba6faa37a26b9abda8548d7a4ea
nodejs#4456https://github.com/nodejs/node/issues/4456
https://github.com/mscdex
mscdexhttps://github.com/mscdex
force-pushedhttps://github.com/nodejs/node/compare/7878d43e791418a8032cca89b24a39524f5356fb..070b617eb067bba6faa37a26b9abda8548d7a4ea
7878d43https://github.com/nodejs/node/commit/7878d43e791418a8032cca89b24a39524f5356fb
070b617https://github.com/nodejs/node/commit/070b617eb067bba6faa37a26b9abda8548d7a4ea
Compare https://github.com/nodejs/node/compare/7878d43e791418a8032cca89b24a39524f5356fb..070b617eb067bba6faa37a26b9abda8548d7a4ea
December 28, 2015 23:44https://github.com/nodejs/node/pull/4460#event-501766087
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 28, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167680148
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 29, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167688470
https://ci.nodejs.org/job/node-test-pull-request/1098/https://ci.nodejs.org/job/node-test-pull-request/1098/
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/indutny
indutnyhttps://github.com/indutny
Dec 29, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167700695
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/Trott
Trotthttps://github.com/Trott
Dec 29, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167714792
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 29, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167827038
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 29, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167873958
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/JungMinu
JungMinuhttps://github.com/JungMinu
Dec 30, 2015https://github.com/nodejs/node/pull/4460#issuecomment-167918064
Please reload this pagehttps://github.com/nodejs/node/pull/4460
mscdexhttps://github.com/mscdex
Dec 30, 2015 https://github.com/nodejs/node/pull/4460#ref-commit-2a1ef97
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/nodejs/node/commit/2a1ef977e3b12b74520027d238039fcf38f240d1
2a1ef97https://github.com/nodejs/node/commit/2a1ef977e3b12b74520027d238039fcf38f240d1
#4456https://github.com/nodejs/node/issues/4456
#4460https://github.com/nodejs/node/pull/4460
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 30, 2015https://github.com/nodejs/node/pull/4460#issuecomment-168042690
2a1ef97https://github.com/nodejs/node/commit/2a1ef977e3b12b74520027d238039fcf38f240d1
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 30, 2015https://github.com/nodejs/node/pull/4460#event-502940210
https://github.com/mscdex
mscdexhttps://github.com/mscdex
December 30, 2015 17:41https://github.com/nodejs/node/pull/4460#event-502940676
Fishrock123https://github.com/Fishrock123
Jan 6, 2016 https://github.com/nodejs/node/pull/4460#ref-commit-ffb4a6e
https://github.com/mscdex
https://github.com/Fishrock123
http: fix non-string header value concatenationhttps://github.com/Fishrock123/node/commit/ffb4a6e0e4f0aaeb39b829d3fba9897a5c97720a
ffb4a6ehttps://github.com/Fishrock123/node/commit/ffb4a6e0e4f0aaeb39b829d3fba9897a5c97720a
nodejs#4456https://github.com/nodejs/node/issues/4456
nodejs#4460https://github.com/nodejs/node/pull/4460
https://github.com/rvagg
rvagghttps://github.com/rvagg
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jan 15, 2016https://github.com/nodejs/node/pull/4460#event-515922931
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Jan 28, 2016https://github.com/nodejs/node/pull/4460#event-530332778
MylesBorinshttps://github.com/MylesBorins
Jan 28, 2016 https://github.com/nodejs/node/pull/4460#ref-commit-5cf66eb
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/nodejs/node/commit/5cf66ebf91b761e43c09b9be6fb9d1f6f9d59dc1
5cf66ebhttps://github.com/nodejs/node/commit/5cf66ebf91b761e43c09b9be6fb9d1f6f9d59dc1
#4456https://github.com/nodejs/node/issues/4456
#4460https://github.com/nodejs/node/pull/4460
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016 https://github.com/nodejs/node/pull/4460#ref-commit-39ef824
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/nodejs/node/commit/39ef82402f22e6ae04695015b1ea2a5d67e5b8d7
39ef824https://github.com/nodejs/node/commit/39ef82402f22e6ae04695015b1ea2a5d67e5b8d7
#4456https://github.com/nodejs/node/issues/4456
#4460https://github.com/nodejs/node/pull/4460
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016 https://github.com/nodejs/node/pull/4460#ref-commit-1aa9411
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/MylesBorins/node/commit/1aa941172d6409f623b5c4d9c30b9c3462fd99bd
1aa9411https://github.com/MylesBorins/node/commit/1aa941172d6409f623b5c4d9c30b9c3462fd99bd
nodejs#4456https://github.com/nodejs/node/issues/4456
nodejs#4460https://github.com/nodejs/node/pull/4460
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Feb 11, 2016 https://github.com/nodejs/node/pull/4460#ref-pullrequest-133119871
V4.3.1 proposal #5200 https://github.com/nodejs/node/pull/5200
MylesBorinshttps://github.com/MylesBorins
Feb 15, 2016 https://github.com/nodejs/node/pull/4460#ref-commit-1bb2967
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/MylesBorins/node/commit/1bb2967d48ecfd53cf6dd9d340392e017426ab6b
1bb2967https://github.com/MylesBorins/node/commit/1bb2967d48ecfd53cf6dd9d340392e017426ab6b
nodejs#4456https://github.com/nodejs/node/issues/4456
nodejs#4460https://github.com/nodejs/node/pull/4460
scovettahttps://github.com/scovetta
Apr 2, 2016 https://github.com/nodejs/node/pull/4460#ref-commit-0b16dfe
https://github.com/mscdex
http: fix non-string header value concatenationhttps://github.com/scovetta/node/commit/0b16dfe1a2364a273f5dab263c73186d088cba18
0b16dfehttps://github.com/scovetta/node/commit/0b16dfe1a2364a273f5dab263c73186d088cba18
nodejs#4456https://github.com/nodejs/node/issues/4456
nodejs#4460https://github.com/nodejs/node/pull/4460
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4460
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Please reload this pagehttps://github.com/nodejs/node/pull/4460
https://github.com/mscdex
https://github.com/indutny
https://github.com/Trott
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com/JungMinu
https://github.com/rvagg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.