| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:75586ae1-6005-0010-b605-8f94e93f0e15 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A996:E3F0D:112479C:163DD3C:696B106A |
| html-safe-nonce | 2c1b2862c4c60fd16d70e8d83b47f5bd3c5bc74b11e0ee6abad23f7b23b8fa5d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTk2OkUzRjBEOjExMjQ3OUM6MTYzREQzQzo2OTZCMTA2QSIsInZpc2l0b3JfaWQiOiI5MDQ1MDc3OTY4OTU3NDExNDM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 966dbe01272e764c086948a124ce51d3fb16575d02776383bbc9ded3370b4e14 |
| hovercard-subject-tag | pull_request:54691222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4458/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/149df44aa61a5260e85abd8ea30a103a484e4a76a46cbd9bb8a708c4a27e7471/nodejs/node/pull/4458 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/149df44aa61a5260e85abd8ea30a103a484e4a76a46cbd9bb8a708c4a27e7471/nodejs/node/pull/4458 |
| og:image:alt | State a time unit for the timeout parameter in ClientRequest#setTimeout |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bripkens |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/4458#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4458 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4458 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/4458 |
| Reload | https://github.com/nodejs/node/pull/4458 |
| Reload | https://github.com/nodejs/node/pull/4458 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/4458#issue-comment-box |
| bripkens | https://github.com/bripkens |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bripkens:document-settimeout | https://github.com/bripkens/node/tree/document-settimeout |
|
doc: explain ClientRequest#setTimeout time unit
| https://github.com/nodejs/node/pull/4458#top |
| bripkens | https://github.com/bripkens |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| bripkens:document-settimeout | https://github.com/bripkens/node/tree/document-settimeout |
|
Conversation
5
| https://github.com/nodejs/node/pull/4458 |
|
Commits
1
| https://github.com/nodejs/node/pull/4458/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/4458/checks |
|
Files changed
| https://github.com/nodejs/node/pull/4458/files |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bripkens |
| bripkens | https://github.com/bripkens |
| Dec 28, 2015 | https://github.com/nodejs/node/pull/4458#issue-124139723 |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
|
| https://github.com/bripkens |
| doc: explain ClientRequest#setTimeout time unit | https://github.com/nodejs/node/pull/4458/commits/d434cd966d41a805ca03d306a91b484c40b129d7 |
| d434cd9 | https://github.com/nodejs/node/pull/4458/commits/d434cd966d41a805ca03d306a91b484c40b129d7 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Dec 28, 2015 | https://github.com/nodejs/node/pull/4458#event-501766670 |
| https://github.com/Qard |
| Qard | https://github.com/Qard |
| Dec 29, 2015 | https://github.com/nodejs/node/pull/4458#issuecomment-167896495 |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4458#issuecomment-168065267 |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
| jasnell | https://github.com/jasnell |
|
Dec 30, 2015
| https://github.com/nodejs/node/pull/4458#ref-commit-c280596 |
|
| https://github.com/bripkens |
|
| https://github.com/jasnell |
| doc: explain ClientRequest#setTimeout time unit | https://github.com/nodejs/node/commit/c2805969443a9bc8fda25b0d4e246252acac104c |
| c280596 | https://github.com/nodejs/node/commit/c2805969443a9bc8fda25b0d4e246252acac104c |
| #4458 | https://github.com/nodejs/node/pull/4458 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4458#issuecomment-168065635 |
| c280596 | https://github.com/nodejs/node/commit/c2805969443a9bc8fda25b0d4e246252acac104c |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4458#event-503025153 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Dec 30, 2015 | https://github.com/nodejs/node/pull/4458#event-503025222 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Jan 4, 2016 | https://github.com/nodejs/node/pull/4458#issuecomment-168580313 |
| @bripkens | https://github.com/bripkens |
| #4463 | https://github.com/nodejs/node/pull/4463 |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
| https://github.com/bripkens |
| bripkens | https://github.com/bripkens |
| January 4, 2016 07:41 | https://github.com/nodejs/node/pull/4458#event-504485484 |
| https://github.com/bripkens |
| bripkens | https://github.com/bripkens |
| Jan 4, 2016 | https://github.com/nodejs/node/pull/4458#issuecomment-168604156 |
| @rvagg | https://github.com/rvagg |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jan 6, 2016
| https://github.com/nodejs/node/pull/4458#ref-commit-c745b4d |
|
| https://github.com/bripkens |
|
| https://github.com/Fishrock123 |
| doc: explain ClientRequest#setTimeout time unit | https://github.com/Fishrock123/node/commit/c745b4d5f8cb0ad66361faf506527adb6f567457 |
| c745b4d | https://github.com/Fishrock123/node/commit/c745b4d5f8cb0ad66361faf506527adb6f567457 |
| nodejs#4458 | https://github.com/nodejs/node/pull/4458 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jan 13, 2016 | https://github.com/nodejs/node/pull/4458#event-514178664 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 13, 2016
| https://github.com/nodejs/node/pull/4458#ref-commit-abf50ac |
|
| https://github.com/bripkens |
| doc: explain ClientRequest#setTimeout time unit | https://github.com/nodejs/node/commit/abf50ac97061b15ddf1cc587bf47d7fc2cc3023c |
| abf50ac | https://github.com/nodejs/node/commit/abf50ac97061b15ddf1cc587bf47d7fc2cc3023c |
| #4458 | https://github.com/nodejs/node/pull/4458 |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 19, 2016
| https://github.com/nodejs/node/pull/4458#ref-commit-bf56d50 |
|
| https://github.com/bripkens |
| doc: explain ClientRequest#setTimeout time unit | https://github.com/nodejs/node/commit/bf56d509b9f258ff80190e0fec6c269ef7713c85 |
| bf56d50 | https://github.com/nodejs/node/commit/bf56d509b9f258ff80190e0fec6c269ef7713c85 |
| #4458 | https://github.com/nodejs/node/pull/4458 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 19, 2016
| https://github.com/nodejs/node/pull/4458#ref-pullrequest-127531954 |
|
V4.2.5 proposal
#4768
| https://github.com/nodejs/node/pull/4768 |
| scovetta | https://github.com/scovetta |
|
Apr 2, 2016
| https://github.com/nodejs/node/pull/4458#ref-commit-b00266c |
|
| https://github.com/bripkens |
| doc: explain ClientRequest#setTimeout time unit | https://github.com/scovetta/node/commit/b00266ca29feea75dcda4c05a723eb077776fbb2 |
| b00266c | https://github.com/scovetta/node/commit/b00266ca29feea75dcda4c05a723eb077776fbb2 |
| nodejs#4458 | https://github.com/nodejs/node/pull/4458 |
| https://github.com/leonardoadame |
| leonardoadame | https://github.com/leonardoadame |
|
May 16, 2024
| https://github.com/nodejs/node/pull/4458#ref-pullrequest-2299421780 |
|
[Snyk] Fix for 4 vulnerabilities
leonardoadame/node#966
| https://github.com/leonardoadame/node/pull/966 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4458 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
| Please reload this page | https://github.com/nodejs/node/pull/4458 |
|
| https://github.com/bripkens |
|
| https://github.com/Qard |
|
| https://github.com/jasnell |
|
| https://github.com/rvagg |
|
| https://github.com/mscdex |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |