| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c7c8b970-c7cd-4c85-b7ea-9756fda46e8f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D38C:155BED:D4FE21:1254F27:696A8CBE |
| html-safe-nonce | c13dfa8a48479b44884b77436f868dba69a402d17bcc9a587c42992302ead1d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzhDOjE1NUJFRDpENEZFMjE6MTI1NEYyNzo2OTZBOENCRSIsInZpc2l0b3JfaWQiOiIyNzEzNTEyMzI1OTQxOTg4NTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 320b997e5d996e66d60edf7b2adffd16a70bc0882a1d8f80f5bef388bbbd62d2 |
| hovercard-subject-tag | pull_request:1022079916 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/44196/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7c6673675f2bd80b2cc8334815da81991b5be2516a466e5081a6bc52d01284db/nodejs/node/pull/44196 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7c6673675f2bd80b2cc8334815da81991b5be2516a466e5081a6bc52d01284db/nodejs/node/pull/44196 |
| og:image:alt | Use mustSucceed instead of mustCall + ifError. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | fossamagna |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/44196#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44196 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44196 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/44196 |
| Reload | https://github.com/nodejs/node/pull/44196 |
| Reload | https://github.com/nodejs/node/pull/44196 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/44196#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| fossamagna:test-inspector-open-must-succeed | https://github.com/fossamagna/node/tree/test-inspector-open-must-succeed |
|
test: use mustSucceed instead of mustCall with assert.ifError
| https://github.com/nodejs/node/pull/44196#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| fossamagna:test-inspector-open-must-succeed | https://github.com/fossamagna/node/tree/test-inspector-open-must-succeed |
|
Conversation
4
| https://github.com/nodejs/node/pull/44196 |
|
Commits
1
| https://github.com/nodejs/node/pull/44196/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/44196/checks |
|
Files changed
| https://github.com/nodejs/node/pull/44196/files |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/fossamagna |
| fossamagna | https://github.com/fossamagna |
| Aug 9, 2022 | https://github.com/nodejs/node/pull/44196#issue-1333901089 |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
|
| https://github.com/fossamagna |
| test: usemustSucceed instead of mustCall with assert.ifError | https://github.com/nodejs/node/pull/44196/commits/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
| fc37133 | https://github.com/nodejs/node/pull/44196/commits/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 9, 2022 | https://github.com/nodejs/node/pull/44196#event-7159521327 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 10, 2022
| https://github.com/nodejs/node/pull/44196#pullrequestreview-1068119908 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 10, 2022 | https://github.com/nodejs/node/pull/44196#event-7162997851 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 10, 2022 | https://github.com/nodejs/node/pull/44196#event-7163005856 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 10, 2022 | https://github.com/nodejs/node/pull/44196#issuecomment-1210549176 |
| https://ci.nodejs.org/job/node-test-pull-request/45966/ | https://ci.nodejs.org/job/node-test-pull-request/45966/ |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
| https://github.com/RaisinTen |
| RaisinTen | https://github.com/RaisinTen |
|
Aug 10, 2022
| https://github.com/nodejs/node/pull/44196#pullrequestreview-1068270505 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 10, 2022
| https://github.com/nodejs/node/pull/44196#pullrequestreview-1068790414 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 10, 2022 | https://github.com/nodejs/node/pull/44196#issuecomment-1211144617 |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
| https://github.com/fossamagna |
| fossamagna | https://github.com/fossamagna |
| Aug 10, 2022 | https://github.com/nodejs/node/pull/44196#event-7167892320 |
| https://github.com/fossamagna |
| fossamagna | https://github.com/fossamagna |
| Aug 10, 2022 | https://github.com/nodejs/node/pull/44196#issuecomment-1211412339 |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 11, 2022
| https://github.com/nodejs/node/pull/44196#pullrequestreview-1069095144 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| 25d78de | https://github.com/nodejs/node/commit/25d78de4f674ab482a4f4207018b8ff20472f8a2 |
| Aug 12, 2022 | https://github.com/nodejs/node/pull/44196#event-7177330085 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Aug 12, 2022 | https://github.com/nodejs/node/pull/44196#issuecomment-1212852628 |
| 25d78de | https://github.com/nodejs/node/commit/25d78de4f674ab482a4f4207018b8ff20472f8a2 |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
| danielleadams | https://github.com/danielleadams |
|
Aug 16, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-b0e3e69 |
|
| https://github.com/fossamagna |
|
| https://github.com/danielleadams |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/nodejs/node/commit/b0e3e69686667d44f864127f570edabbc89ba291 |
| b0e3e69 | https://github.com/nodejs/node/commit/b0e3e69686667d44f864127f570edabbc89ba291 |
| #44196 | https://github.com/nodejs/node/pull/44196 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 16, 2022
| https://github.com/nodejs/node/pull/44196#ref-pullrequest-1339725975 |
|
v18.8.0 release proposal
#44246
| https://github.com/nodejs/node/pull/44246 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-beaf5f5 |
|
| https://github.com/fossamagna |
|
| https://github.com/ruyadorno |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/nodejs/node/commit/beaf5f577605d50eb881782296106bebc499c5ed |
| beaf5f5 | https://github.com/nodejs/node/commit/beaf5f577605d50eb881782296106bebc499c5ed |
| #44196 | https://github.com/nodejs/node/pull/44196 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/44196#ref-pullrequest-1347304857 |
|
v18.8.0 release proposal
#44353
| https://github.com/nodejs/node/pull/44353 |
| targos | https://github.com/targos |
|
Sep 5, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-8eac53d |
|
| https://github.com/fossamagna |
|
| https://github.com/targos |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/nodejs/node/commit/8eac53d96c449de9382a35230510546e113d9e41 |
| 8eac53d | https://github.com/nodejs/node/commit/8eac53d96c449de9382a35230510546e113d9e41 |
| #44196 | https://github.com/nodejs/node/pull/44196 |
| Fyko | https://github.com/Fyko |
|
Sep 15, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-be37afb |
|
| https://github.com/fossamagna |
|
| https://github.com/Fyko |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/Fyko/node/commit/be37afbda885132de2e16b5ebb2b3e55f64f2f6c |
| be37afb | https://github.com/Fyko/node/commit/be37afbda885132de2e16b5ebb2b3e55f64f2f6c |
| nodejs#44196 | https://github.com/nodejs/node/pull/44196 |
| juanarbol | https://github.com/juanarbol |
|
Oct 10, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-6935e01 |
|
| https://github.com/fossamagna |
|
| https://github.com/juanarbol |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/nodejs/node/commit/6935e012eb0d3b9829d02e17ad956470a99facb1 |
| 6935e01 | https://github.com/nodejs/node/commit/6935e012eb0d3b9829d02e17ad956470a99facb1 |
| #44196 | https://github.com/nodejs/node/pull/44196 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Oct 11, 2022
| https://github.com/nodejs/node/pull/44196#ref-pullrequest-1395630632 |
|
V16.18.0 proposal
#44886
| https://github.com/nodejs/node/pull/44886 |
| juanarbol | https://github.com/juanarbol |
|
Oct 11, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-8725a87 |
|
| https://github.com/fossamagna |
|
| https://github.com/juanarbol |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/nodejs/node/commit/8725a87fd9b317fddc6c74daa35de36171df856d |
| 8725a87 | https://github.com/nodejs/node/commit/8725a87fd9b317fddc6c74daa35de36171df856d |
| #44196 | https://github.com/nodejs/node/pull/44196 |
| mwalbeck | https://github.com/mwalbeck |
|
Oct 18, 2022
| https://github.com/nodejs/node/pull/44196#ref-commit-ea08b68 |
|
| https://github.com/mwalbeck |
| Update Node.js to v16.18.0 (#102) | https://github.com/mwalbeck/docker-cyberchef/commit/ea08b68c2abb087dd768f92bd498d50717537241 |
| ea08b68 | https://github.com/mwalbeck/docker-cyberchef/commit/ea08b68c2abb087dd768f92bd498d50717537241 |
| guangwong | https://github.com/guangwong |
|
Jan 3, 2023
| https://github.com/nodejs/node/pull/44196#ref-commit-dd01c65 |
|
| https://github.com/fossamagna |
|
| https://github.com/guangwong |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/noslate-project/node/commit/dd01c652710e5f280283523f95f08a60a4633584 |
| dd01c65 | https://github.com/noslate-project/node/commit/dd01c652710e5f280283523f95f08a60a4633584 |
| nodejs/node#44196 | https://github.com/nodejs/node/pull/44196 |
| guangwong | https://github.com/guangwong |
|
Jan 3, 2023
| https://github.com/nodejs/node/pull/44196#ref-commit-da24df4 |
|
| https://github.com/fossamagna |
|
| https://github.com/guangwong |
| test: use mustSucceed instead of mustCall with assert.ifError | https://github.com/noslate-project/node/commit/da24df491eca22d615841d9401cc5c649cf60fc8 |
| da24df4 | https://github.com/noslate-project/node/commit/da24df491eca22d615841d9401cc5c649cf60fc8 |
| nodejs/node#44196 | https://github.com/nodejs/node/pull/44196 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44196 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
|
| https://github.com/RaisinTen |
|
RaisinTen
| https://github.com/RaisinTen |
|
| https://github.com/nodejs/node/pull/44196/files/fc37133db97bc402ffb367c1c5f0d172dd962af2 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/44196 |
|
| https://github.com/fossamagna |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/lpinca |
|
| https://github.com/aduh95 |
|
| https://github.com/cjihrig |
|
| https://github.com/RaisinTen |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |