René's URL Explorer Experiment


Title: node-api: generalize finalizer second pass callback by legendecas · Pull Request #44141 · nodejs/node · GitHub

Open Graph Title: node-api: generalize finalizer second pass callback by legendecas · Pull Request #44141 · nodejs/node

X Title: node-api: generalize finalizer second pass callback by legendecas · Pull Request #44141 · nodejs/node

Description: Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize/RefBase::Fi...

Open Graph Description: Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize/RefBase...

X Description: Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize/Ref...

Opengraph URL: https://github.com/nodejs/node/pull/44141

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7b5cdeb3-10ac-1a72-7cad-3530e4966c32
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD92:1E9341:E2B57F:136E145:6969EEE6
html-safe-nonce7bb652af9697e73be5b285d3abf8dc1caf1b408d3373145031c5d1da122fdec6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDkyOjFFOTM0MTpFMkI1N0Y6MTM2RTE0NTo2OTY5RUVFNiIsInZpc2l0b3JfaWQiOiI3NTkwNzcyODIzODY5MjIyNjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccf66e63008d22ae6ffc71fe5d36028ea1c6f82f5a71f8c265c26a63dc543b2d3
hovercard-subject-tagpull_request:1018331987
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/44141/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ba2d2dbf794482920a3967d2439c76e00fb355d3efdaf522653dde729e4fab49/nodejs/node/pull/44141
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ba2d2dbf794482920a3967d2439c76e00fb355d3efdaf522653dde729e4fab49/nodejs/node/pull/44141
og:image:altGeneralize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize/RefBase...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelegendecas
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/44141#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44141
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44141
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/44141
Reloadhttps://github.com/nodejs/node/pull/44141
Reloadhttps://github.com/nodejs/node/pull/44141
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/44141
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/44141
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/44141#issue-comment-box
legendecashttps://github.com/legendecas
nodejs:mainhttps://github.com/nodejs/node/tree/main
legendecas:node-api/second-passhttps://github.com/legendecas/node/tree/node-api/second-pass
node-api: generalize finalizer second pass callback https://github.com/nodejs/node/pull/44141#top
legendecashttps://github.com/legendecas
nodejs:mainhttps://github.com/nodejs/node/tree/main
legendecas:node-api/second-passhttps://github.com/legendecas/node/tree/node-api/second-pass
Conversation 50 https://github.com/nodejs/node/pull/44141
Commits 2 https://github.com/nodejs/node/pull/44141/commits
Checks 0 https://github.com/nodejs/node/pull/44141/checks
Files changed https://github.com/nodejs/node/pull/44141/files
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/legendecas
legendecashttps://github.com/legendecas
Aug 5, 2022https://github.com/nodejs/node/pull/44141#issue-1329541491
Please reload this pagehttps://github.com/nodejs/node/pull/44141
#44071https://github.com/nodejs/node/issues/44071
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 5, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1206119721
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 5, 2022https://github.com/nodejs/node/pull/44141#event-7133580469
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/486add4826ce6a2b0e00b784e5f6b8f45cbdac36..40562fc02f4818922376981ceef088e01c01ee98
486add4https://github.com/nodejs/node/commit/486add4826ce6a2b0e00b784e5f6b8f45cbdac36
40562fchttps://github.com/nodejs/node/commit/40562fc02f4818922376981ceef088e01c01ee98
Compare https://github.com/nodejs/node/compare/486add4826ce6a2b0e00b784e5f6b8f45cbdac36..40562fc02f4818922376981ceef088e01c01ee98
August 5, 2022 07:17https://github.com/nodejs/node/pull/44141#event-7133628736
https://github.com/legendecas
legendecashttps://github.com/legendecas
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Aug 5, 2022https://github.com/nodejs/node/pull/44141#event-7133628796
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/e9ac1e2532340b02e944fd416408092d00ace9c6..d71cdd6932135230fcc1a2924e12620f52414b2c
e9ac1e2https://github.com/nodejs/node/commit/e9ac1e2532340b02e944fd416408092d00ace9c6
d71cdd6https://github.com/nodejs/node/commit/d71cdd6932135230fcc1a2924e12620f52414b2c
Compare https://github.com/nodejs/node/compare/e9ac1e2532340b02e944fd416408092d00ace9c6..d71cdd6932135230fcc1a2924e12620f52414b2c
August 5, 2022 07:27https://github.com/nodejs/node/pull/44141#event-7133683977
https://github.com/legendecas
legendecashttps://github.com/legendecas
August 5, 2022 07:41https://github.com/nodejs/node/pull/44141#event-7133773769
https://github.com/legendecas
legendecashttps://github.com/legendecas
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 5, 2022https://github.com/nodejs/node/pull/44141#event-7133774361
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 5, 2022https://github.com/nodejs/node/pull/44141#event-7133812479
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44141
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/d71cdd6932135230fcc1a2924e12620f52414b2c..2a14bf39f718b3171f752f3b01899147927c4c11
d71cdd6https://github.com/nodejs/node/commit/d71cdd6932135230fcc1a2924e12620f52414b2c
2a14bf3https://github.com/nodejs/node/commit/2a14bf39f718b3171f752f3b01899147927c4c11
Compare https://github.com/nodejs/node/compare/d71cdd6932135230fcc1a2924e12620f52414b2c..2a14bf39f718b3171f752f3b01899147927c4c11
August 7, 2022 06:13https://github.com/nodejs/node/pull/44141#event-7141768188
https://github.com/legendecas
legendecashttps://github.com/legendecas
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 7, 2022https://github.com/nodejs/node/pull/44141#event-7141773205
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 7, 2022https://github.com/nodejs/node/pull/44141#event-7141775054
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1207340393
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://ci.nodejs.org/job/node-test-pull-request/45890/https://ci.nodejs.org/job/node-test-pull-request/45890/
test.parallel/test-diagnostics-channel-nethttps://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/26421/testReport/junit/(root)/test/parallel_test_diagnostics_channel_net/
Please reload this pagehttps://github.com/nodejs/node/pull/44141
CI Reliability 2022-08-08 nodejs/reliability#340 https://github.com/nodejs/reliability/issues/340
CI Reliability 2022-08-09 nodejs/reliability#341 https://github.com/nodejs/reliability/issues/341
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1208860908
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://ci.nodejs.org/job/node-test-pull-request/45940/https://ci.nodejs.org/job/node-test-pull-request/45940/
https://ci.nodejs.org/job/node-test-commit-freebsd/45349/nodes=freebsd12-x64/https://ci.nodejs.org/job/node-test-commit-freebsd/45349/nodes=freebsd12-x64/
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1209634244
https://ci.nodejs.org/job/node-test-pull-request/45952/https://ci.nodejs.org/job/node-test-pull-request/45952/
Please reload this pagehttps://github.com/nodejs/node/pull/44141
CI Reliability 2022-08-10 nodejs/reliability#342 https://github.com/nodejs/reliability/issues/342
CI Reliability 2022-08-11 nodejs/reliability#343 https://github.com/nodejs/reliability/issues/343
CI Reliability 2022-08-12 nodejs/reliability#344 https://github.com/nodejs/reliability/issues/344
CI Reliability 2022-08-13 nodejs/reliability#345 https://github.com/nodejs/reliability/issues/345
CI Reliability 2022-08-14 nodejs/reliability#346 https://github.com/nodejs/reliability/issues/346
CI Reliability 2022-08-15 nodejs/reliability#347 https://github.com/nodejs/reliability/issues/347
CI Reliability 2022-08-16 nodejs/reliability#348 https://github.com/nodejs/reliability/issues/348
https://github.com/vmoroz
vmorozhttps://github.com/vmoroz
Aug 18, 2022 https://github.com/nodejs/node/pull/44141#pullrequestreview-1078065189
View reviewed changes https://github.com/nodejs/node/pull/44141/files
src/node_api.cchttps://github.com/nodejs/node/pull/44141/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
vmorozhttps://github.com/vmoroz
Aug 18, 2022https://github.com/nodejs/node/pull/44141#discussion_r949641616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44141
legendecashttps://github.com/legendecas
Aug 19, 2022https://github.com/nodejs/node/pull/44141#discussion_r949757626
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/vmoroz
vmorozhttps://github.com/vmoroz
Aug 18, 2022 https://github.com/nodejs/node/pull/44141#pullrequestreview-1078079409
View reviewed changes https://github.com/nodejs/node/pull/44141/files
src/node_api.cchttps://github.com/nodejs/node/pull/44141/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
vmorozhttps://github.com/vmoroz
Aug 18, 2022https://github.com/nodejs/node/pull/44141#discussion_r949652191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44141
legendecashttps://github.com/legendecas
Aug 19, 2022https://github.com/nodejs/node/pull/44141#discussion_r949758567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/vmoroz
vmorozhttps://github.com/vmoroz
Aug 18, 2022 https://github.com/nodejs/node/pull/44141#pullrequestreview-1078085381
View reviewed changes https://github.com/nodejs/node/pull/44141/files
src/node_api.cchttps://github.com/nodejs/node/pull/44141/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/9416d37bb02a4f7bf27fdf89306a2d3463315298..c6b1b47e7c9d9ad1c9d43ad938919781563e5792
9416d37https://github.com/nodejs/node/commit/9416d37bb02a4f7bf27fdf89306a2d3463315298
c6b1b47https://github.com/nodejs/node/commit/c6b1b47e7c9d9ad1c9d43ad938919781563e5792
Compare https://github.com/nodejs/node/compare/9416d37bb02a4f7bf27fdf89306a2d3463315298..c6b1b47e7c9d9ad1c9d43ad938919781563e5792
October 14, 2022 07:13https://github.com/nodejs/node/pull/44141#event-7587628370
https://github.com/legendecas
legendecashttps://github.com/legendecas
Oct 14, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1278585120
Please reload this pagehttps://github.com/nodejs/node/pull/44141
@mhdawsonhttps://github.com/mhdawson
https://nodejs.org/api/n-api.html#napi_remove_wraphttps://nodejs.org/api/n-api.html#napi_remove_wrap
https://github.com/nodejs/node/pull/44141/files#diff-8037a0113a35b91ac2d997501123d0b8be5b341907e9e350fe4f70082afa361fhttps://github.com/nodejs/node/pull/44141/files#diff-8037a0113a35b91ac2d997501123d0b8be5b341907e9e350fe4f70082afa361f
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/c6b1b47e7c9d9ad1c9d43ad938919781563e5792..65fce2be5cb1b766acc97a623760f9a54f3dae76
c6b1b47https://github.com/nodejs/node/commit/c6b1b47e7c9d9ad1c9d43ad938919781563e5792
65fce2bhttps://github.com/nodejs/node/commit/65fce2be5cb1b766acc97a623760f9a54f3dae76
Compare https://github.com/nodejs/node/compare/c6b1b47e7c9d9ad1c9d43ad938919781563e5792..65fce2be5cb1b766acc97a623760f9a54f3dae76
October 14, 2022 09:07https://github.com/nodejs/node/pull/44141#event-7588497955
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 10, 2022 https://github.com/nodejs/node/pull/44141#ref-pullrequest-1443654906
node-api: fix immediate napi_remove_wrap test #45406 https://github.com/nodejs/node/pull/45406
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/44141#event-7795751398
legendecashttps://github.com/legendecas
November 18, 2022 09:33https://github.com/nodejs/node/pull/44141#commits-pushed-57a58d1
https://github.com/legendecas
node-api: generalize finalizer second pass callbackhttps://github.com/nodejs/node/pull/44141/commits/57a58d1bb8cb452139cdf590c6b8de90bf28a8db
57a58d1https://github.com/nodejs/node/pull/44141/commits/57a58d1bb8cb452139cdf590c6b8de90bf28a8db
https://github.com/legendecas
fixup! verify dangling napi_ref in napi_wraphttps://github.com/nodejs/node/pull/44141/commits/344493a3854b7e7602bf19de751402b9b34db3fe
344493ahttps://github.com/nodejs/node/pull/44141/commits/344493a3854b7e7602bf19de751402b9b34db3fe
https://github.com/legendecas
legendecashttps://github.com/legendecas
force-pushedhttps://github.com/nodejs/node/compare/65fce2be5cb1b766acc97a623760f9a54f3dae76..344493a3854b7e7602bf19de751402b9b34db3fe
65fce2bhttps://github.com/nodejs/node/commit/65fce2be5cb1b766acc97a623760f9a54f3dae76
344493ahttps://github.com/nodejs/node/commit/344493a3854b7e7602bf19de751402b9b34db3fe
Compare https://github.com/nodejs/node/compare/65fce2be5cb1b766acc97a623760f9a54f3dae76..344493a3854b7e7602bf19de751402b9b34db3fe
November 18, 2022 09:33https://github.com/nodejs/node/pull/44141#event-7841953686
https://github.com/legendecas
legendecashttps://github.com/legendecas
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 18, 2022https://github.com/nodejs/node/pull/44141#event-7845573940
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Nov 18, 2022https://github.com/nodejs/node/pull/44141#event-7845601929
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 18, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1320271078
https://ci.nodejs.org/job/node-test-pull-request/48011/https://ci.nodejs.org/job/node-test-pull-request/48011/
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/legendecas
legendecashttps://github.com/legendecas
Nov 21, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1321746483
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 22, 2022 https://github.com/nodejs/node/pull/44141#pullrequestreview-1190694760
View reviewed changes https://github.com/nodejs/node/pull/44141/files/344493a3854b7e7602bf19de751402b9b34db3fe
src/node_api.cchttps://github.com/nodejs/node/pull/44141/files/344493a3854b7e7602bf19de751402b9b34db3fe#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Nov 22, 2022 https://github.com/nodejs/node/pull/44141#pullrequestreview-1190717618
View reviewed changes https://github.com/nodejs/node/pull/44141/files/344493a3854b7e7602bf19de751402b9b34db3fe
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/44141#pullrequestreview-1190717618
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44141
legendecashttps://github.com/legendecas
Dec 19, 2022 https://github.com/nodejs/node/pull/44141#ref-commit-f14fa1b
https://github.com/legendecas
node-api: generalize finalizer second pass callbackhttps://github.com/nodejs/node/commit/f14fa1bbca5022166037cbf2a3d7d884ff157120
f14fa1bhttps://github.com/nodejs/node/commit/f14fa1bbca5022166037cbf2a3d7d884ff157120
#44141https://github.com/nodejs/node/pull/44141
#44071https://github.com/nodejs/node/issues/44071
https://github.com/legendecas
legendecashttps://github.com/legendecas
Dec 19, 2022https://github.com/nodejs/node/pull/44141#issuecomment-1358019168
f14fa1bhttps://github.com/nodejs/node/commit/f14fa1bbca5022166037cbf2a3d7d884ff157120
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/legendecas
legendecashttps://github.com/legendecas
Dec 19, 2022https://github.com/nodejs/node/pull/44141#event-8071665656
https://github.com/legendecas
legendecashttps://github.com/legendecas
December 19, 2022 17:45https://github.com/nodejs/node/pull/44141#event-8071666385
toyobayashihttps://github.com/toyobayashi
Dec 26, 2022 https://github.com/nodejs/node/pull/44141#ref-commit-0b985bf
https://github.com/toyobayashi
refactor: generalize finalizer second pass callback (https://github.com/toyobayashi/emnapi/commit/0b985bf9c0cf65f75643b4f6368dc4bb79e097cf
nodejs/node#44141https://github.com/nodejs/node/pull/44141
)https://github.com/toyobayashi/emnapi/commit/0b985bf9c0cf65f75643b4f6368dc4bb79e097cf
0b985bfhttps://github.com/toyobayashi/emnapi/commit/0b985bf9c0cf65f75643b4f6368dc4bb79e097cf
targoshttps://github.com/targos
Jan 1, 2023 https://github.com/nodejs/node/pull/44141#ref-commit-71025cf
https://github.com/legendecas
https://github.com/targos
node-api: generalize finalizer second pass callbackhttps://github.com/nodejs/node/commit/71025cff93e3918507e02bc69aa8386642fdffc6
71025cfhttps://github.com/nodejs/node/commit/71025cff93e3918507e02bc69aa8386642fdffc6
#44141https://github.com/nodejs/node/pull/44141
#44071https://github.com/nodejs/node/issues/44071
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jan 2, 2023 https://github.com/nodejs/node/pull/44141#ref-pullrequest-1516469641
v19.4.0 proposal #46061 https://github.com/nodejs/node/pull/46061
guangwonghttps://github.com/guangwong
Jan 3, 2023 https://github.com/nodejs/node/pull/44141#ref-commit-4a555e6
https://github.com/legendecas
https://github.com/guangwong
node-api: cleanup redundant static modifiershttps://github.com/noslate-project/node/commit/4a555e6148e4e9fd692913e42bdc7a3ae88a812d
4a555e6https://github.com/noslate-project/node/commit/4a555e6148e4e9fd692913e42bdc7a3ae88a812d
nodejs/node#44301https://github.com/nodejs/node/pull/44301
nodejs/node#44141https://github.com/nodejs/node/pull/44141
guangwonghttps://github.com/guangwong
Jan 3, 2023 https://github.com/nodejs/node/pull/44141#ref-commit-9ceeb24
https://github.com/legendecas
https://github.com/guangwong
node-api: cleanup redundant static modifiershttps://github.com/noslate-project/node/commit/9ceeb249f52bf65ddeac638b76a0072641ad0204
9ceeb24https://github.com/noslate-project/node/commit/9ceeb249f52bf65ddeac638b76a0072641ad0204
nodejs/node#44301https://github.com/nodejs/node/pull/44301
nodejs/node#44141https://github.com/nodejs/node/pull/44141
RafaelGSShttps://github.com/RafaelGSS
Jan 4, 2023 https://github.com/nodejs/node/pull/44141#ref-commit-1494175
https://github.com/legendecas
https://github.com/RafaelGSS
node-api: generalize finalizer second pass callbackhttps://github.com/nodejs/node/commit/1494175000625f4e3c5b9aff2c10378b1cb104ef
1494175https://github.com/nodejs/node/commit/1494175000625f4e3c5b9aff2c10378b1cb104ef
#44141https://github.com/nodejs/node/pull/44141
#44071https://github.com/nodejs/node/issues/44071
RafaelGSShttps://github.com/RafaelGSS
Jan 5, 2023 https://github.com/nodejs/node/pull/44141#ref-commit-f3bb6a3
https://github.com/legendecas
https://github.com/RafaelGSS
node-api: generalize finalizer second pass callbackhttps://github.com/nodejs/node/commit/f3bb6a38ae35b33fd24b8158cc95b5c9fd23acb6
f3bb6a3https://github.com/nodejs/node/commit/f3bb6a38ae35b33fd24b8158cc95b5c9fd23acb6
#44141https://github.com/nodejs/node/pull/44141
#44071https://github.com/nodejs/node/issues/44071
juanarbolhttps://github.com/juanarbol
Jan 26, 2023 https://github.com/nodejs/node/pull/44141#ref-commit-6e9676e
https://github.com/legendecas
https://github.com/juanarbol
node-api: generalize finalizer second pass callbackhttps://github.com/nodejs/node/commit/6e9676e986b7454fe36d2cb1947b5cdfd803b4d4
6e9676ehttps://github.com/nodejs/node/commit/6e9676e986b7454fe36d2cb1947b5cdfd803b4d4
#44141https://github.com/nodejs/node/pull/44141
#44071https://github.com/nodejs/node/issues/44071
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Jan 28, 2023 https://github.com/nodejs/node/pull/44141#ref-pullrequest-1561026091
V18.14.0 proposal #46396 https://github.com/nodejs/node/pull/46396
Xmaderhttps://github.com/Xmader
May 14, 2025 https://github.com/nodejs/node/pull/44141#ref-commit-134caf5
https://github.com/Xmader
Reference::Finalize/RefBase::Finalize was generalizedhttps://github.com/Distributive-Network/node/commit/134caf5def5e6cdf68cefe0887c7dc61a16ab0a0
134caf5https://github.com/Distributive-Network/node/commit/134caf5def5e6cdf68cefe0887c7dc61a16ab0a0
nodejs#44141https://github.com/nodejs/node/pull/44141
Xmaderhttps://github.com/Xmader
Nov 24, 2025 https://github.com/nodejs/node/pull/44141#ref-commit-823bbf7
https://github.com/Xmader
Reference::Finalize/RefBase::Finalize was generalizedhttps://github.com/Distributive-Network/node/commit/823bbf7285956833ddea62acf6ac058326806c5d
823bbf7https://github.com/Distributive-Network/node/commit/823bbf7285956833ddea62acf6ac058326806c5d
nodejs#44141https://github.com/nodejs/node/pull/44141
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44141
https://github.com/vmoroz
vmoroz https://github.com/vmoroz
https://github.com/nodejs/node/pull/44141/files/2a14bf39f718b3171f752f3b01899147927c4c11
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/44141/files/344493a3854b7e7602bf19de751402b9b34db3fe
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Please reload this pagehttps://github.com/nodejs/node/pull/44141
https://github.com/legendecas
https://github.com/nodejs-github-bot
https://github.com/mhdawson
https://github.com/vmoroz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.