René's URL Explorer Experiment


Title: esm: do not bind loader hook functions by aduh95 · Pull Request #44122 · nodejs/node · GitHub

Open Graph Title: esm: do not bind loader hook functions by aduh95 · Pull Request #44122 · nodejs/node

X Title: esm: do not bind loader hook functions by aduh95 · Pull Request #44122 · nodejs/node

Description: Previous code was binding function hooks twice, but there's no need for binding given how the code is written. Adding a test to ensure it stays this way. /cc @nodejs/loaders

Open Graph Description: Previous code was binding function hooks twice, but there's no need for binding given how the code is written. Adding a test to ensure it stays this way. /cc @nodejs/loaders

X Description: Previous code was binding function hooks twice, but there's no need for binding given how the code is written. Adding a test to ensure it stays this way. /cc @nodejs/loaders

Opengraph URL: https://github.com/nodejs/node/pull/44122

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dba84a2a-e086-e55b-f38e-4ebe24a69ac2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3AE:312517:8C35BA:C356FD:696A76F9
html-safe-nonce895442ded63ea898fdb655e54409fa1bade00e5ba9aa67f27ca33fcea2702eb6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0FFOjMxMjUxNzo4QzM1QkE6QzM1NkZEOjY5NkE3NkY5IiwidmlzaXRvcl9pZCI6IjE4OTA0NTA1MDczMDU3NDQxMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2714bdfb9d47b3fd056037a663aa6912bbbd945ef91b5b23f7578bcd7fac3374
hovercard-subject-tagpull_request:1016838962
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/44122/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/963d5b24479903cac327102808173b8f1c47ce9e0ef1769419cfda306a4aa587/nodejs/node/pull/44122
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/963d5b24479903cac327102808173b8f1c47ce9e0ef1769419cfda306a4aa587/nodejs/node/pull/44122
og:image:altPrevious code was binding function hooks twice, but there's no need for binding given how the code is written. Adding a test to ensure it stays this way. /cc @nodejs/loaders
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None5b774e44f85c14a75886edd04ddda4e5a25ddebbb241bcbb590b08a3048730e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecc5f4eee261b3601c1e98e217ceaf28508b9567e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/44122#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44122
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44122
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/44122
Reloadhttps://github.com/nodejs/node/pull/44122
Reloadhttps://github.com/nodejs/node/pull/44122
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/44122
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/44122
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/44122#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:no-unnecessary-bindshttps://github.com/aduh95/node/tree/no-unnecessary-binds
esm: do not bind loader hook functions https://github.com/nodejs/node/pull/44122#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:no-unnecessary-bindshttps://github.com/aduh95/node/tree/no-unnecessary-binds
Conversation 5 https://github.com/nodejs/node/pull/44122
Commits 1 https://github.com/nodejs/node/pull/44122/commits
Checks 0 https://github.com/nodejs/node/pull/44122/checks
Files changed https://github.com/nodejs/node/pull/44122/files
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022https://github.com/nodejs/node/pull/44122#issue-1327822195
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/aduh95
esm: do not bind loader hook functionshttps://github.com/nodejs/node/pull/44122/commits/0f90e96e56a076d42268cbbced9259de3d42f3ee
0f90e96https://github.com/nodejs/node/pull/44122/commits/0f90e96e56a076d42268cbbced9259de3d42f3ee
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 3, 2022https://github.com/nodejs/node/pull/44122#issuecomment-1204516552
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 3, 2022https://github.com/nodejs/node/pull/44122#event-7122971104
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Aug 3, 2022 https://github.com/nodejs/node/pull/44122#pullrequestreview-1061069988
View reviewed changes https://github.com/nodejs/node/pull/44122/files/0f90e96e56a076d42268cbbced9259de3d42f3ee
GeoffreyBoothhttps://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/44122#pullrequestreview-1061069988
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
Aug 3, 2022https://github.com/nodejs/node/pull/44122#event-7123102166
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022https://github.com/nodejs/node/pull/44122#issuecomment-1204546716
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 3, 2022https://github.com/nodejs/node/pull/44122#event-7123138172
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 3, 2022https://github.com/nodejs/node/pull/44122#event-7123183134
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 3, 2022https://github.com/nodejs/node/pull/44122#issuecomment-1204552736
https://ci.nodejs.org/job/node-test-pull-request/45826/https://ci.nodejs.org/job/node-test-pull-request/45826/
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 4, 2022 https://github.com/nodejs/node/pull/44122#pullrequestreview-1061353638
View reviewed changes https://github.com/nodejs/node/pull/44122/files/0f90e96e56a076d42268cbbced9259de3d42f3ee
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 8, 2022https://github.com/nodejs/node/pull/44122#event-7145090408
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 8, 2022https://github.com/nodejs/node/pull/44122#event-7145120396
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
6f9eff8https://github.com/nodejs/node/commit/6f9eff880bc660a80240f23884dcd3253a56fd1e
Aug 8, 2022https://github.com/nodejs/node/pull/44122#event-7145121036
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2022https://github.com/nodejs/node/pull/44122#issuecomment-1207847312
6f9eff8https://github.com/nodejs/node/commit/6f9eff880bc660a80240f23884dcd3253a56fd1e
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/aduh95
aduh95https://github.com/aduh95
August 8, 2022 08:56https://github.com/nodejs/node/pull/44122#event-7145160845
danielleadamshttps://github.com/danielleadams
Aug 16, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-c975427
https://github.com/aduh95
https://github.com/danielleadams
esm: do not bind loader hook functionshttps://github.com/nodejs/node/commit/c975427fd5e51c9a395e9ccf8976e9baebcb91d2
c975427https://github.com/nodejs/node/commit/c975427fd5e51c9a395e9ccf8976e9baebcb91d2
#44122https://github.com/nodejs/node/pull/44122
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 16, 2022 https://github.com/nodejs/node/pull/44122#ref-pullrequest-1339725975
v18.8.0 release proposal #44246 https://github.com/nodejs/node/pull/44246
ruyadornohttps://github.com/ruyadorno
Aug 23, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-a6dccc9
https://github.com/aduh95
https://github.com/ruyadorno
esm: do not bind loader hook functionshttps://github.com/nodejs/node/commit/a6dccc969f032a13794d7dac169f3bae4b24558d
a6dccc9https://github.com/nodejs/node/commit/a6dccc969f032a13794d7dac169f3bae4b24558d
#44122https://github.com/nodejs/node/pull/44122
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Aug 23, 2022 https://github.com/nodejs/node/pull/44122#ref-pullrequest-1347304857
v18.8.0 release proposal #44353 https://github.com/nodejs/node/pull/44353
targoshttps://github.com/targos
Sep 5, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-46c8f5d
https://github.com/aduh95
https://github.com/targos
esm: do not bind loader hook functionshttps://github.com/nodejs/node/commit/46c8f5dd8997d6906bd7b7457c8febdf0a376a52
46c8f5dhttps://github.com/nodejs/node/commit/46c8f5dd8997d6906bd7b7457c8febdf0a376a52
#44122https://github.com/nodejs/node/pull/44122
Fykohttps://github.com/Fyko
Sep 15, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-3392748
https://github.com/aduh95
https://github.com/Fyko
esm: do not bind loader hook functionshttps://github.com/Fyko/node/commit/3392748f148971fec959d0d5b27564079e53d869
3392748https://github.com/Fyko/node/commit/3392748f148971fec959d0d5b27564079e53d869
nodejs#44122https://github.com/nodejs/node/pull/44122
juanarbolhttps://github.com/juanarbol
Oct 10, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-bcec653
https://github.com/aduh95
https://github.com/juanarbol
esm: do not bind loader hook functionshttps://github.com/nodejs/node/commit/bcec6531fb54b26f0f68c3c89792c88fbf74ad99
bcec653https://github.com/nodejs/node/commit/bcec6531fb54b26f0f68c3c89792c88fbf74ad99
#44122https://github.com/nodejs/node/pull/44122
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Oct 11, 2022 https://github.com/nodejs/node/pull/44122#ref-pullrequest-1395630632
V16.18.0 proposal #44886 https://github.com/nodejs/node/pull/44886
juanarbolhttps://github.com/juanarbol
Oct 11, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-5d33dfd
https://github.com/aduh95
https://github.com/juanarbol
esm: do not bind loader hook functionshttps://github.com/nodejs/node/commit/5d33dfd7876d0f2b8e43af9424d4b12d0dc65b27
5d33dfdhttps://github.com/nodejs/node/commit/5d33dfd7876d0f2b8e43af9424d4b12d0dc65b27
#44122https://github.com/nodejs/node/pull/44122
mwalbeckhttps://github.com/mwalbeck
Oct 18, 2022 https://github.com/nodejs/node/pull/44122#ref-commit-ea08b68
https://github.com/mwalbeck
Update Node.js to v16.18.0 (#102)https://github.com/mwalbeck/docker-cyberchef/commit/ea08b68c2abb087dd768f92bd498d50717537241
ea08b68https://github.com/mwalbeck/docker-cyberchef/commit/ea08b68c2abb087dd768f92bd498d50717537241
guangwonghttps://github.com/guangwong
Jan 3, 2023 https://github.com/nodejs/node/pull/44122#ref-commit-6e17dfa
https://github.com/aduh95
https://github.com/guangwong
esm: do not bind loader hook functionshttps://github.com/noslate-project/node/commit/6e17dfadb8569328a93e8493221491796cf155ac
6e17dfahttps://github.com/noslate-project/node/commit/6e17dfadb8569328a93e8493221491796cf155ac
nodejs/node#44122https://github.com/nodejs/node/pull/44122
guangwonghttps://github.com/guangwong
Jan 3, 2023 https://github.com/nodejs/node/pull/44122#ref-commit-19f873d
https://github.com/aduh95
https://github.com/guangwong
esm: do not bind loader hook functionshttps://github.com/noslate-project/node/commit/19f873decb20cbf08b2263d899a38bdacf78f438
19f873dhttps://github.com/noslate-project/node/commit/19f873decb20cbf08b2263d899a38bdacf78f438
nodejs/node#44122https://github.com/nodejs/node/pull/44122
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44122
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/44122/files/0f90e96e56a076d42268cbbced9259de3d42f3ee
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/44122/files/0f90e96e56a076d42268cbbced9259de3d42f3ee
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/44122
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/GeoffreyBooth
https://github.com/benjamingr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.