René's URL Explorer Experiment


Title: esm: fix loader hooks accepting too many arguments by JakobJingleheimer · Pull Request #44109 · nodejs/node · GitHub

Open Graph Title: esm: fix loader hooks accepting too many arguments by JakobJingleheimer · Pull Request #44109 · nodejs/node

X Title: esm: fix loader hooks accepting too many arguments by JakobJingleheimer · Pull Request #44109 · nodejs/node

Description: When a user supplies too many arguments, those beyond the 2nd arg are currently blindly passed to the next function. Now, those extra args are ignored. It assumes both resolve and load sh...

Open Graph Description: When a user supplies too many arguments, those beyond the 2nd arg are currently blindly passed to the next<HookName> function. Now, those extra args are ignored. It assumes both resolve and l...

X Description: When a user supplies too many arguments, those beyond the 2nd arg are currently blindly passed to the next&lt;HookName&gt; function. Now, those extra args are ignored. It assumes both resol...

Opengraph URL: https://github.com/nodejs/node/pull/44109

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3a685f1b-c0be-eb5e-724f-6bc20822b66f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1EC:2EC266:8A268A:BE8CE4:696A7719
html-safe-noncef3299c7b529ef137350be1f53e93e07b30b8407a5d0ad84d10c9bd51e6bc2318
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUVDOjJFQzI2Njo4QTI2OEE6QkU4Q0U0OjY5NkE3NzE5IiwidmlzaXRvcl9pZCI6Ijc2MzA0MzQ0OTE5NDMxMzQ5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a9de94677d713b3983154d5cc3ad569e2dc18ff22211fca96d900c791c4bdaa
hovercard-subject-tagpull_request:1015567181
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/44109/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/982b787827497a3b82fbdc052db26bcbe2ef77863445028af12c4c6c1f5a91e9/nodejs/node/pull/44109
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/982b787827497a3b82fbdc052db26bcbe2ef77863445028af12c4c6c1f5a91e9/nodejs/node/pull/44109
og:image:altWhen a user supplies too many arguments, those beyond the 2nd arg are currently blindly passed to the next<HookName> function. Now, those extra args are ignored. It assumes both resolve and l...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJakobJingleheimer
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/44109#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44109
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44109
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/44109
Reloadhttps://github.com/nodejs/node/pull/44109
Reloadhttps://github.com/nodejs/node/pull/44109
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/44109
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/44109
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/44109#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
JakobJingleheimer:fix/esm-loader-accepts-too-many-argshttps://github.com/JakobJingleheimer/node/tree/fix/esm-loader-accepts-too-many-args
esm: fix loader hooks accepting too many arguments https://github.com/nodejs/node/pull/44109#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
JakobJingleheimer:fix/esm-loader-accepts-too-many-argshttps://github.com/JakobJingleheimer/node/tree/fix/esm-loader-accepts-too-many-args
Conversation 47 https://github.com/nodejs/node/pull/44109
Commits 7 https://github.com/nodejs/node/pull/44109/commits
Checks 0 https://github.com/nodejs/node/pull/44109/checks
Files changed https://github.com/nodejs/node/pull/44109/files
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Aug 2, 2022https://github.com/nodejs/node/pull/44109#issue-1326364539
Please reload this pagehttps://github.com/nodejs/node/pull/44109
#44108https://github.com/nodejs/node/issues/44108
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/JakobJingleheimer
esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/pull/44109/commits/2f1d595f240366bbd1900f78f2850fcb13711f9f
2f1d595https://github.com/nodejs/node/pull/44109/commits/2f1d595f240366bbd1900f78f2850fcb13711f9f
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
Aug 2, 2022https://github.com/nodejs/node/pull/44109#event-7113149754
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
ESM Loaders: Stable (CJS parity)https://github.com/nodejs/node/milestone/33
Aug 2, 2022https://github.com/nodejs/node/pull/44109#event-7113149767
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
GeoffreyBoothhttps://github.com/GeoffreyBooth
aduh95https://github.com/aduh95
August 2, 2022 20:24https://github.com/nodejs/node/pull/44109#event-7113149776
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1203178864
Please reload this pagehttps://github.com/nodejs/node/pull/44109
@cspotcodehttps://github.com/cspotcode
@targoshttps://github.com/targos
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 2, 2022https://github.com/nodejs/node/pull/44109#event-7113152351
https://github.com/cspotcode
cspotcodehttps://github.com/cspotcode
Aug 2, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1059396195
View reviewed changes https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f
cspotcodehttps://github.com/cspotcode
https://github.com/nodejs/node/pull/44109#pullrequestreview-1059396195
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/44109
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/cspotcode
cspotcodehttps://github.com/cspotcode
Aug 2, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1203192690
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Aug 2, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1059432935
View reviewed changes https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 2, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1059458911
View reviewed changes https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1059598743
View reviewed changes https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f
https://github.com/JakobJingleheimer
fixup! esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/pull/44109/commits/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3
e14ce33https://github.com/nodejs/node/pull/44109/commits/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1059959351
View reviewed changes https://github.com/nodejs/node/pull/44109/files/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1060130722
View reviewed changes https://github.com/nodejs/node/pull/44109/files/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f..e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f..e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
JakobJingleheimerhttps://github.com/JakobJingleheimer
August 3, 2022 20:45https://github.com/nodejs/node/pull/44109#commits-pushed-b3d1461
https://github.com/JakobJingleheimer
fixup! fixup! esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/pull/44109/commits/b3d1461a28e441328295a243a0f5bf3363f63b66
b3d1461https://github.com/nodejs/node/pull/44109/commits/b3d1461a28e441328295a243a0f5bf3363f63b66
https://github.com/JakobJingleheimer
fixup! fixup! fixup! esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/pull/44109/commits/380c9a543e6625196c7ecd7c623e53111c0766b6
380c9a5https://github.com/nodejs/node/pull/44109/commits/380c9a543e6625196c7ecd7c623e53111c0766b6
https://github.com/JakobJingleheimer
fixup! fixup! fixup! fixup! esm: fix loader hooks accepting too many …https://github.com/nodejs/node/pull/44109/commits/2254fb8b6909c5a3a7473494503bc8538d376f31
2254fb8https://github.com/nodejs/node/pull/44109/commits/2254fb8b6909c5a3a7473494503bc8538d376f31
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1060875707
View reviewed changes https://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31
test/es-module/test-esm-loader-chaining.mjshttps://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31#diff-9e2a80ada59a554d360836efd39c1d7183138f658ede118c2f6c18516200aded
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1060877752
View reviewed changes https://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31
test/es-module/test-esm-loader-chaining.mjshttps://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31#diff-9e2a80ada59a554d360836efd39c1d7183138f658ede118c2f6c18516200aded
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/JakobJingleheimer
improve substring matchhttps://github.com/nodejs/node/pull/44109/commits/1eff09180d476796e66fbf54dcdf6b452f7f1823
1eff091https://github.com/nodejs/node/pull/44109/commits/1eff09180d476796e66fbf54dcdf6b452f7f1823
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1060885869
View reviewed changes https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Aug 3, 2022https://github.com/nodejs/node/pull/44109#event-7121829187
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 3, 2022https://github.com/nodejs/node/pull/44109#event-7121890523
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 3, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1204395238
https://ci.nodejs.org/job/node-test-pull-request/45823/https://ci.nodejs.org/job/node-test-pull-request/45823/
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1061004701
View reviewed changes https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823
lib/internal/modules/esm/loader.jshttps://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 3, 2022https://github.com/nodejs/node/pull/44109#event-7122678384
https://github.com/JakobJingleheimer
correct context arg passed to nextHook fnhttps://github.com/nodejs/node/pull/44109/commits/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5
fad4ccfhttps://github.com/nodejs/node/pull/44109/commits/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 3, 2022https://github.com/nodejs/node/pull/44109#event-7123200900
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 3, 2022https://github.com/nodejs/node/pull/44109#event-7123232061
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 3, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1204557907
https://ci.nodejs.org/job/node-test-pull-request/45827/https://ci.nodejs.org/job/node-test-pull-request/45827/
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Aug 3, 2022 https://github.com/nodejs/node/pull/44109#pullrequestreview-1061107695
View reviewed changes https://github.com/nodejs/node/pull/44109/files/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1204777890
https://ci.nodejs.org/job/node-test-pull-request/45830/https://ci.nodejs.org/job/node-test-pull-request/45830/
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 4, 2022https://github.com/nodejs/node/pull/44109#event-7125658391
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 4, 2022https://github.com/nodejs/node/pull/44109#event-7125723674
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1204946605
https://github.com/nodejs/node/actions/runs/2795302869https://github.com/nodejs/node/actions/runs/2795302869
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Aug 4, 2022https://github.com/nodejs/node/pull/44109#event-7125724229
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Aug 4, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1204950172
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/MoLow
MoLowhttps://github.com/MoLow
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Aug 4, 2022https://github.com/nodejs/node/pull/44109#event-7131711235
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 4, 2022https://github.com/nodejs/node/pull/44109#event-7131723893
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
e0b440ahttps://github.com/nodejs/node/commit/e0b440ae32e81024dca3a79a9d7e1d6f01bbcc52
Aug 4, 2022https://github.com/nodejs/node/pull/44109#event-7131724180
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2022https://github.com/nodejs/node/pull/44109#issuecomment-1205818570
e0b440ahttps://github.com/nodejs/node/commit/e0b440ae32e81024dca3a79a9d7e1d6f01bbcc52
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 5, 2022 https://github.com/nodejs/node/pull/44109#ref-issue-1329299382
CI Reliability 2022-08-05 nodejs/reliability#337 https://github.com/nodejs/reliability/issues/337
https://github.com/cspotcode
cspotcodehttps://github.com/cspotcode
Aug 5, 2022 https://github.com/nodejs/node/pull/44109#ref-pullrequest-1318474076
when calling default* functions, you should not recursively pass default* function TypeStrong/ts-node#1849 https://github.com/TypeStrong/ts-node/pull/1849
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 6, 2022 https://github.com/nodejs/node/pull/44109#ref-issue-1330585504
CI Reliability 2022-08-06 nodejs/reliability#338 https://github.com/nodejs/reliability/issues/338
https://github.com/alichry
alichryhttps://github.com/alichry
Aug 6, 2022 https://github.com/nodejs/node/pull/44109#ref-issue-1312019877
Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0) testdouble/testdouble.js#496 https://github.com/testdouble/testdouble.js/issues/496
targoshttps://github.com/targos
Aug 6, 2022 https://github.com/nodejs/node/pull/44109#ref-commit-ae157d9
https://github.com/JakobJingleheimer
https://github.com/targos
esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/commit/ae157d9098fd8cb3b2c9d1bb941bbfa986c5f537
ae157d9https://github.com/nodejs/node/commit/ae157d9098fd8cb3b2c9d1bb941bbfa986c5f537
#44109https://github.com/nodejs/node/pull/44109
https://github.com/targos
targoshttps://github.com/targos
Aug 6, 2022 https://github.com/nodejs/node/pull/44109#ref-pullrequest-1325821229
v16.17.0 release proposal #44098 https://github.com/nodejs/node/pull/44098
CI Reliability 2022-08-07 nodejs/reliability#339 https://github.com/nodejs/reliability/issues/339
CI Reliability 2022-08-08 nodejs/reliability#340 https://github.com/nodejs/reliability/issues/340
danielleadamshttps://github.com/danielleadams
Aug 16, 2022 https://github.com/nodejs/node/pull/44109#ref-commit-c2ea22f
https://github.com/JakobJingleheimer
https://github.com/danielleadams
esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/commit/c2ea22f4276caee521b21a8cad1f8c5fa1bda729
c2ea22fhttps://github.com/nodejs/node/commit/c2ea22f4276caee521b21a8cad1f8c5fa1bda729
#44109https://github.com/nodejs/node/pull/44109
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 16, 2022 https://github.com/nodejs/node/pull/44109#ref-pullrequest-1339725975
v18.8.0 release proposal #44246 https://github.com/nodejs/node/pull/44246
ruyadornohttps://github.com/ruyadorno
Aug 23, 2022 https://github.com/nodejs/node/pull/44109#ref-commit-5e9c197
https://github.com/JakobJingleheimer
https://github.com/ruyadorno
esm: fix loader hooks accepting too many argumentshttps://github.com/nodejs/node/commit/5e9c197d85b79fc19425a5d26dbd09ecaf62e148
5e9c197https://github.com/nodejs/node/commit/5e9c197d85b79fc19425a5d26dbd09ecaf62e148
#44109https://github.com/nodejs/node/pull/44109
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Aug 23, 2022 https://github.com/nodejs/node/pull/44109#ref-pullrequest-1347304857
v18.8.0 release proposal #44353 https://github.com/nodejs/node/pull/44353
Fykohttps://github.com/Fyko
Sep 15, 2022 https://github.com/nodejs/node/pull/44109#ref-commit-c9b3809
https://github.com/JakobJingleheimer
https://github.com/Fyko
esm: fix loader hooks accepting too many argumentshttps://github.com/Fyko/node/commit/c9b380940330240c30603a4fc11675569b1019df
c9b3809https://github.com/Fyko/node/commit/c9b380940330240c30603a4fc11675569b1019df
nodejs#44109https://github.com/nodejs/node/pull/44109
guangwonghttps://github.com/guangwong
Oct 10, 2022 https://github.com/nodejs/node/pull/44109#ref-commit-e06f081
https://github.com/JakobJingleheimer
https://github.com/guangwong
esm: fix loader hooks accepting too many argumentshttps://github.com/noslate-project/node/commit/e06f0812bf7e46eb58f4657efb2899a28395caa1
e06f081https://github.com/noslate-project/node/commit/e06f0812bf7e46eb58f4657efb2899a28395caa1
nodejs/node#44109https://github.com/nodejs/node/pull/44109
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44109
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/44109/files/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f
https://github.com/cspotcode
cspotcode https://github.com/cspotcode
https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ESM Loaders: Stable (CJS parity) https://github.com/nodejs/node/milestone/33
Loader hooks' next functions behave unexpectedly when arguments.length is longer, even if documented named arguments are correct https://github.com/nodejs/node/issues/44108
Please reload this pagehttps://github.com/nodejs/node/pull/44109
https://github.com/JakobJingleheimer
https://github.com/nodejs-github-bot
https://github.com/cspotcode
https://github.com/GeoffreyBooth
https://github.com/guybedford
https://github.com/aduh95
https://github.com/MoLow
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.