| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3a685f1b-c0be-eb5e-724f-6bc20822b66f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1EC:2EC266:8A268A:BE8CE4:696A7719 |
| html-safe-nonce | f3299c7b529ef137350be1f53e93e07b30b8407a5d0ad84d10c9bd51e6bc2318 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUVDOjJFQzI2Njo4QTI2OEE6QkU4Q0U0OjY5NkE3NzE5IiwidmlzaXRvcl9pZCI6Ijc2MzA0MzQ0OTE5NDMxMzQ5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a9de94677d713b3983154d5cc3ad569e2dc18ff22211fca96d900c791c4bdaa |
| hovercard-subject-tag | pull_request:1015567181 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/44109/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/982b787827497a3b82fbdc052db26bcbe2ef77863445028af12c4c6c1f5a91e9/nodejs/node/pull/44109 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/982b787827497a3b82fbdc052db26bcbe2ef77863445028af12c4c6c1f5a91e9/nodejs/node/pull/44109 |
| og:image:alt | When a user supplies too many arguments, those beyond the 2nd arg are currently blindly passed to the next<HookName> function. Now, those extra args are ignored. It assumes both resolve and l... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JakobJingleheimer |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/44109#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44109 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44109 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/44109 |
| Reload | https://github.com/nodejs/node/pull/44109 |
| Reload | https://github.com/nodejs/node/pull/44109 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/44109#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| JakobJingleheimer:fix/esm-loader-accepts-too-many-args | https://github.com/JakobJingleheimer/node/tree/fix/esm-loader-accepts-too-many-args |
|
esm: fix loader hooks accepting too many arguments
| https://github.com/nodejs/node/pull/44109#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| JakobJingleheimer:fix/esm-loader-accepts-too-many-args | https://github.com/JakobJingleheimer/node/tree/fix/esm-loader-accepts-too-many-args |
|
Conversation
47
| https://github.com/nodejs/node/pull/44109 |
|
Commits
7
| https://github.com/nodejs/node/pull/44109/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/44109/checks |
|
Files changed
| https://github.com/nodejs/node/pull/44109/files |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/44109#issue-1326364539 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| #44108 | https://github.com/nodejs/node/issues/44108 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
|
| https://github.com/JakobJingleheimer |
| esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/pull/44109/commits/2f1d595f240366bbd1900f78f2850fcb13711f9f |
| 2f1d595 | https://github.com/nodejs/node/pull/44109/commits/2f1d595f240366bbd1900f78f2850fcb13711f9f |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/44109#event-7113149754 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| ESM Loaders: Stable (CJS parity) | https://github.com/nodejs/node/milestone/33 |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/44109#event-7113149767 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| aduh95 | https://github.com/aduh95 |
| August 2, 2022 20:24 | https://github.com/nodejs/node/pull/44109#event-7113149776 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1203178864 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| @cspotcode | https://github.com/cspotcode |
| @targos | https://github.com/targos |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/44109#event-7113152351 |
| https://github.com/cspotcode |
| cspotcode | https://github.com/cspotcode |
|
Aug 2, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1059396195 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f |
| cspotcode | https://github.com/cspotcode |
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1059396195 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/cspotcode |
| cspotcode | https://github.com/cspotcode |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1203192690 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Aug 2, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1059432935 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 2, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1059458911 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1059598743 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f |
|
| https://github.com/JakobJingleheimer |
| fixup! esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/pull/44109/commits/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3 |
| e14ce33 | https://github.com/nodejs/node/pull/44109/commits/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1059959351 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1060130722 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f..e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f..e14ce33eb7c9836aeeaa1e7d167b8e72050c2bd3#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| August 3, 2022 20:45 | https://github.com/nodejs/node/pull/44109#commits-pushed-b3d1461 |
|
| https://github.com/JakobJingleheimer |
| fixup! fixup! esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/pull/44109/commits/b3d1461a28e441328295a243a0f5bf3363f63b66 |
| b3d1461 | https://github.com/nodejs/node/pull/44109/commits/b3d1461a28e441328295a243a0f5bf3363f63b66 |
|
| https://github.com/JakobJingleheimer |
| fixup! fixup! fixup! esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/pull/44109/commits/380c9a543e6625196c7ecd7c623e53111c0766b6 |
| 380c9a5 | https://github.com/nodejs/node/pull/44109/commits/380c9a543e6625196c7ecd7c623e53111c0766b6 |
|
| https://github.com/JakobJingleheimer |
| fixup! fixup! fixup! fixup! esm: fix loader hooks accepting too many … | https://github.com/nodejs/node/pull/44109/commits/2254fb8b6909c5a3a7473494503bc8538d376f31 |
| 2254fb8 | https://github.com/nodejs/node/pull/44109/commits/2254fb8b6909c5a3a7473494503bc8538d376f31 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1060875707 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31 |
| test/es-module/test-esm-loader-chaining.mjs | https://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31#diff-9e2a80ada59a554d360836efd39c1d7183138f658ede118c2f6c18516200aded |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1060877752 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31 |
| test/es-module/test-esm-loader-chaining.mjs | https://github.com/nodejs/node/pull/44109/files/2254fb8b6909c5a3a7473494503bc8538d376f31#diff-9e2a80ada59a554d360836efd39c1d7183138f658ede118c2f6c18516200aded |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
|
| https://github.com/JakobJingleheimer |
| improve substring match | https://github.com/nodejs/node/pull/44109/commits/1eff09180d476796e66fbf54dcdf6b452f7f1823 |
| 1eff091 | https://github.com/nodejs/node/pull/44109/commits/1eff09180d476796e66fbf54dcdf6b452f7f1823 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1060885869 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#event-7121829187 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#event-7121890523 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1204395238 |
| https://ci.nodejs.org/job/node-test-pull-request/45823/ | https://ci.nodejs.org/job/node-test-pull-request/45823/ |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1061004701 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823 |
| lib/internal/modules/esm/loader.js | https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823#diff-f6796082f599554ec3a29c47cf026cb24fc5104884f2632e472c05fe622d778b |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#event-7122678384 |
|
| https://github.com/JakobJingleheimer |
| correct context arg passed to nextHook fn | https://github.com/nodejs/node/pull/44109/commits/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5 |
| fad4ccf | https://github.com/nodejs/node/pull/44109/commits/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#event-7123200900 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#event-7123232061 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 3, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1204557907 |
| https://ci.nodejs.org/job/node-test-pull-request/45827/ | https://ci.nodejs.org/job/node-test-pull-request/45827/ |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/44109#pullrequestreview-1061107695 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/44109/files/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1204777890 |
| https://ci.nodejs.org/job/node-test-pull-request/45830/ | https://ci.nodejs.org/job/node-test-pull-request/45830/ |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#event-7125658391 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#event-7125723674 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1204946605 |
| https://github.com/nodejs/node/actions/runs/2795302869 | https://github.com/nodejs/node/actions/runs/2795302869 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#event-7125724229 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1204950172 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#event-7131711235 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#event-7131723893 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| e0b440a | https://github.com/nodejs/node/commit/e0b440ae32e81024dca3a79a9d7e1d6f01bbcc52 |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#event-7131724180 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 4, 2022 | https://github.com/nodejs/node/pull/44109#issuecomment-1205818570 |
| e0b440a | https://github.com/nodejs/node/commit/e0b440ae32e81024dca3a79a9d7e1d6f01bbcc52 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 5, 2022
| https://github.com/nodejs/node/pull/44109#ref-issue-1329299382 |
|
CI Reliability 2022-08-05
nodejs/reliability#337
| https://github.com/nodejs/reliability/issues/337 |
| https://github.com/cspotcode |
| cspotcode | https://github.com/cspotcode |
|
Aug 5, 2022
| https://github.com/nodejs/node/pull/44109#ref-pullrequest-1318474076 |
|
when calling default* functions, you should not recursively pass default* function
TypeStrong/ts-node#1849
| https://github.com/TypeStrong/ts-node/pull/1849 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 6, 2022
| https://github.com/nodejs/node/pull/44109#ref-issue-1330585504 |
|
CI Reliability 2022-08-06
nodejs/reliability#338
| https://github.com/nodejs/reliability/issues/338 |
| https://github.com/alichry |
| alichry | https://github.com/alichry |
|
Aug 6, 2022
| https://github.com/nodejs/node/pull/44109#ref-issue-1312019877 |
|
Using testdouble esm loader with ts-node/esm loader on mocha leads to errors (Node 18.6.0)
testdouble/testdouble.js#496
| https://github.com/testdouble/testdouble.js/issues/496 |
| targos | https://github.com/targos |
|
Aug 6, 2022
| https://github.com/nodejs/node/pull/44109#ref-commit-ae157d9 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/targos |
| esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/commit/ae157d9098fd8cb3b2c9d1bb941bbfa986c5f537 |
| ae157d9 | https://github.com/nodejs/node/commit/ae157d9098fd8cb3b2c9d1bb941bbfa986c5f537 |
| #44109 | https://github.com/nodejs/node/pull/44109 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 6, 2022
| https://github.com/nodejs/node/pull/44109#ref-pullrequest-1325821229 |
|
v16.17.0 release proposal
#44098
| https://github.com/nodejs/node/pull/44098 |
|
CI Reliability 2022-08-07
nodejs/reliability#339
| https://github.com/nodejs/reliability/issues/339 |
|
CI Reliability 2022-08-08
nodejs/reliability#340
| https://github.com/nodejs/reliability/issues/340 |
| danielleadams | https://github.com/danielleadams |
|
Aug 16, 2022
| https://github.com/nodejs/node/pull/44109#ref-commit-c2ea22f |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/danielleadams |
| esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/commit/c2ea22f4276caee521b21a8cad1f8c5fa1bda729 |
| c2ea22f | https://github.com/nodejs/node/commit/c2ea22f4276caee521b21a8cad1f8c5fa1bda729 |
| #44109 | https://github.com/nodejs/node/pull/44109 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 16, 2022
| https://github.com/nodejs/node/pull/44109#ref-pullrequest-1339725975 |
|
v18.8.0 release proposal
#44246
| https://github.com/nodejs/node/pull/44246 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/44109#ref-commit-5e9c197 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/ruyadorno |
| esm: fix loader hooks accepting too many arguments | https://github.com/nodejs/node/commit/5e9c197d85b79fc19425a5d26dbd09ecaf62e148 |
| 5e9c197 | https://github.com/nodejs/node/commit/5e9c197d85b79fc19425a5d26dbd09ecaf62e148 |
| #44109 | https://github.com/nodejs/node/pull/44109 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/44109#ref-pullrequest-1347304857 |
|
v18.8.0 release proposal
#44353
| https://github.com/nodejs/node/pull/44353 |
| Fyko | https://github.com/Fyko |
|
Sep 15, 2022
| https://github.com/nodejs/node/pull/44109#ref-commit-c9b3809 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/Fyko |
| esm: fix loader hooks accepting too many arguments | https://github.com/Fyko/node/commit/c9b380940330240c30603a4fc11675569b1019df |
| c9b3809 | https://github.com/Fyko/node/commit/c9b380940330240c30603a4fc11675569b1019df |
| nodejs#44109 | https://github.com/nodejs/node/pull/44109 |
| guangwong | https://github.com/guangwong |
|
Oct 10, 2022
| https://github.com/nodejs/node/pull/44109#ref-commit-e06f081 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/guangwong |
| esm: fix loader hooks accepting too many arguments | https://github.com/noslate-project/node/commit/e06f0812bf7e46eb58f4657efb2899a28395caa1 |
| e06f081 | https://github.com/noslate-project/node/commit/e06f0812bf7e46eb58f4657efb2899a28395caa1 |
| nodejs/node#44109 | https://github.com/nodejs/node/pull/44109 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F44109 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823 |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/44109/files/fad4ccfb29a17a1591a5a4b9a3a9add33a5252f5 |
|
| https://github.com/guybedford |
|
guybedford
| https://github.com/guybedford |
|
| https://github.com/nodejs/node/pull/44109/files/2f1d595f240366bbd1900f78f2850fcb13711f9f |
|
| https://github.com/cspotcode |
|
cspotcode
| https://github.com/cspotcode |
|
| https://github.com/nodejs/node/pull/44109/files/1eff09180d476796e66fbf54dcdf6b452f7f1823 |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
ESM Loaders: Stable (CJS parity)
| https://github.com/nodejs/node/milestone/33 |
|
Loader hooks' next functions behave unexpectedly when arguments.length is longer, even if documented named arguments are correct
| https://github.com/nodejs/node/issues/44108 |
| Please reload this page | https://github.com/nodejs/node/pull/44109 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/cspotcode |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/guybedford |
|
| https://github.com/aduh95 |
|
| https://github.com/MoLow |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |