René's URL Explorer Experiment


Title: esm: improve performance & tidy tests by JakobJingleheimer · Pull Request #43784 · nodejs/node · GitHub

Open Graph Title: esm: improve performance & tidy tests by JakobJingleheimer · Pull Request #43784 · nodejs/node

X Title: esm: improve performance & tidy tests by JakobJingleheimer · Pull Request #43784 · nodejs/node

Description: This standardises the setup of ESM tests and improves performance by parallelising case runs using a promise wrapper around async spawn. I originally started out using chaining for parallelisation,...

Open Graph Description: This standardises the setup of ESM tests and improves performance by parallelising case runs using a promise wrapper around async spawn. I originally started out using chaining for parallelisation,...

X Description: This standardises the setup of ESM tests and improves performance by parallelising case runs using a promise wrapper around async spawn. I originally started out using chaining for parallelisation,...

Opengraph URL: https://github.com/nodejs/node/pull/43784

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76f49688-13ab-13f9-4a25-f4fe0daa4b7c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8E6:2BBCB0:91AA02:C806B7:696AB6C1
html-safe-noncead6fb5dfa30bb7cb754ea30db15f87c26336387e7cfa9d2829b19abf1355048f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEU2OjJCQkNCMDo5MUFBMDI6QzgwNkI3OjY5NkFCNkMxIiwidmlzaXRvcl9pZCI6Ijk3MTk1MTY0MjAxOTI4MDU3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a9cd1ebaca7be9c838b1a8f8f6cd0c4b03d62893a91c6f66350a62da0e871f7
hovercard-subject-tagpull_request:993454265
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/43784/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/318a5c95d1b7763e5a4d7f4fc2c007750e6554cd3b824a9e80dfa55ca4caee18/nodejs/node/pull/43784
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/318a5c95d1b7763e5a4d7f4fc2c007750e6554cd3b824a9e80dfa55ca4caee18/nodejs/node/pull/43784
og:image:altThis standardises the setup of ESM tests and improves performance by parallelising case runs using a promise wrapper around async spawn. I originally started out using chaining for parallelisation,...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJakobJingleheimer
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/43784#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43784
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43784
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/43784
Reloadhttps://github.com/nodejs/node/pull/43784
Reloadhttps://github.com/nodejs/node/pull/43784
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/43784
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/43784
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/43784#issue-comment-box
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
JakobJingleheimer:esm/tidy-esm-testshttps://github.com/JakobJingleheimer/node/tree/esm/tidy-esm-tests
esm: improve performance & tidy tests https://github.com/nodejs/node/pull/43784#top
aduh95https://github.com/aduh95
nodejs:mainhttps://github.com/nodejs/node/tree/main
JakobJingleheimer:esm/tidy-esm-testshttps://github.com/JakobJingleheimer/node/tree/esm/tidy-esm-tests
Conversation 97 https://github.com/nodejs/node/pull/43784
Commits 15 https://github.com/nodejs/node/pull/43784/commits
Checks 0 https://github.com/nodejs/node/pull/43784/checks
Files changed https://github.com/nodejs/node/pull/43784/files
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 11, 2022https://github.com/nodejs/node/pull/43784#issue-1301107855
Please reload this pagehttps://github.com/nodejs/node/pull/43784
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
Jul 11, 2022https://github.com/nodejs/node/pull/43784#event-6972052774
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jul 11, 2022https://github.com/nodejs/node/pull/43784#event-6972054384
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 11, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1034904859
View reviewed changes https://github.com/nodejs/node/pull/43784/files
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/43784#pullrequestreview-1034904859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-cjs-esm-warn.mjshttps://github.com/nodejs/node/pull/43784/files#diff-d4998945f93a68cd1226502c4aa024cd4ffcf37cb4b2ffc7ae90595821e0e19c
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 11, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1180889117
Please reload this pagehttps://github.com/nodejs/node/pull/43784
@aduh95https://github.com/aduh95
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 14, 2022 https://github.com/nodejs/node/pull/43784#ref-pullrequest-1299894464
test_runner: fix it concurrency #43757 https://github.com/nodejs/node/pull/43757
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 24, 2022 https://github.com/nodejs/node/pull/43784#ref-pullrequest-1314497944
esm: add --import flag #43942 https://github.com/nodejs/node/pull/43942
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
force-pushedhttps://github.com/nodejs/node/compare/efb8000dc5f9a76f613f8d362e6347b788728683..f3a2e1ca8edf60280f5ddbb19f7eb613e1c4646f
efb8000https://github.com/nodejs/node/commit/efb8000dc5f9a76f613f8d362e6347b788728683
f3a2e1chttps://github.com/nodejs/node/commit/f3a2e1ca8edf60280f5ddbb19f7eb613e1c4646f
Compare https://github.com/nodejs/node/compare/efb8000dc5f9a76f613f8d362e6347b788728683..f3a2e1ca8edf60280f5ddbb19f7eb613e1c4646f
July 24, 2022 22:22https://github.com/nodejs/node/pull/43784#event-7051943667
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
July 24, 2022 22:22https://github.com/nodejs/node/pull/43784#event-7051944074
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 24, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1193406283
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 24, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1193409503
Please reload this pagehttps://github.com/nodejs/node/pull/43784
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
GeoffreyBoothhttps://github.com/GeoffreyBooth
July 25, 2022 07:56https://github.com/nodejs/node/pull/43784#event-7054054420
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 25, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1049020517
View reviewed changes https://github.com/nodejs/node/pull/43784/files
test/es-module/test-cjs-esm-warn.jshttps://github.com/nodejs/node/pull/43784/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 25, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1049020193
View reviewed changes https://github.com/nodejs/node/pull/43784/files
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-invalid-extension.jshttps://github.com/nodejs/node/pull/43784/files#diff-993e2be28ff2eb2c915d3b73429d0b3808a5e87ea3badb4d60dfd75cc95f3f8a
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 25, 2022https://github.com/nodejs/node/pull/43784#discussion_r928581315
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
aduh95https://github.com/aduh95
July 25, 2022 21:57https://github.com/nodejs/node/pull/43784#event-7060025644
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 25, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1050125013
View reviewed changes https://github.com/nodejs/node/pull/43784/files
test/es-module/test-cjs-esm-warn.jshttps://github.com/nodejs/node/pull/43784/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547
aduh95https://github.com/aduh95
Jul 25, 2022https://github.com/nodejs/node/pull/43784#discussion_r929342660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 25, 2022https://github.com/nodejs/node/pull/43784#discussion_r929360274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
aduh95https://github.com/aduh95
Jul 25, 2022https://github.com/nodejs/node/pull/43784#discussion_r929365840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jul 26, 2022https://github.com/nodejs/node/pull/43784#discussion_r929507133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://stackoverflow.com/a/37145215/223225https://stackoverflow.com/a/37145215/223225
Please reload this pagehttps://github.com/nodejs/node/pull/43784
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 26, 2022https://github.com/nodejs/node/pull/43784#discussion_r929682610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/3012099/180961313-2960aa33-e1aa-4669-9087-e85ca64a8d64.png
Please reload this pagehttps://github.com/nodejs/node/pull/43784
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jul 26, 2022https://github.com/nodejs/node/pull/43784#discussion_r929684130
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/3012099/180962173-941f48c4-04b7-4d8a-a05a-dd6e626d1142.png
Please reload this pagehttps://github.com/nodejs/node/pull/43784
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jul 26, 2022https://github.com/nodejs/node/pull/43784#discussion_r930296336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-experimental-warnings.mjshttps://github.com/nodejs/node/pull/43784/files#diff-f9e424042265082861450494bae6c98756ee069e65dcd7d73fde0737b8b26b55
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-invalid-pjson.jshttps://github.com/nodejs/node/pull/43784/files#diff-af415fd1b964ba5516cf56b3cc42381cfc2a14f65d7803f6c33e13dd02f57ee0
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-repl-imports.jshttps://github.com/nodejs/node/pull/43784/files#diff-64d61e3f2be769df6abde84e8528c5abaffc80425407eab5ddb0e7a10aca08ec
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-repl-imports.jshttps://github.com/nodejs/node/pull/43784/files#diff-64d61e3f2be769df6abde84e8528c5abaffc80425407eab5ddb0e7a10aca08ec
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jul 26, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1050335024
View reviewed changes https://github.com/nodejs/node/pull/43784/files
GeoffreyBoothhttps://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/43784#pullrequestreview-1050335024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/helper.spawnAsPromised.mjshttps://github.com/nodejs/node/pull/43784/files#diff-4d42e70929fb28e8c8c402f880fe505511d0025772188180e1de6caaff8608ed
Please reload this pagehttps://github.com/nodejs/node/pull/43784
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Please reload this pagehttps://github.com/nodejs/node/pull/43784
JakobJingleheimerhttps://github.com/JakobJingleheimer
July 26, 2022 20:22https://github.com/nodejs/node/pull/43784#commits-pushed-03d1f1d
https://github.com/JakobJingleheimer
esm: tidy testshttps://github.com/nodejs/node/pull/43784/commits/03d1f1d12ad698f4c2d9173ca9c31f844bdd96de
03d1f1dhttps://github.com/nodejs/node/pull/43784/commits/03d1f1d12ad698f4c2d9173ca9c31f844bdd96de
https://github.com/JakobJingleheimer
switch to node:testhttps://github.com/nodejs/node/pull/43784/commits/24157ab6fe230b6cffb1bdb3646422f01f850f74
24157abhttps://github.com/nodejs/node/pull/43784/commits/24157ab6fe230b6cffb1bdb3646422f01f850f74
https://github.com/JakobJingleheimer
move spawnAsPromised to test/common as spawnPromisifiedhttps://github.com/nodejs/node/pull/43784/commits/a53214b193343597ae88f7bb5e9d79c44dbbf8fc
a53214bhttps://github.com/nodejs/node/pull/43784/commits/a53214b193343597ae88f7bb5e9d79c44dbbf8fc
https://github.com/JakobJingleheimer
tidy shouldIncludeNotehttps://github.com/nodejs/node/pull/43784/commits/e9fcef035fc9d2051202fb816e22fbfe5098c435
e9fcef0https://github.com/nodejs/node/pull/43784/commits/e9fcef035fc9d2051202fb816e22fbfe5098c435
https://github.com/JakobJingleheimer
replaceAll regex → stringhttps://github.com/nodejs/node/pull/43784/commits/41980ee7b2d1232dd2160bcb5d7d6378deed8de3
41980eehttps://github.com/nodejs/node/pull/43784/commits/41980ee7b2d1232dd2160bcb5d7d6378deed8de3
https://github.com/JakobJingleheimer
REPL done()https://github.com/nodejs/node/pull/43784/commits/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
d7a2541https://github.com/nodejs/node/pull/43784/commits/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
force-pushedhttps://github.com/nodejs/node/compare/98aebc9f3bd81d57668b3c3e033461fc421fa672..d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
98aebc9https://github.com/nodejs/node/commit/98aebc9f3bd81d57668b3c3e033461fc421fa672
d7a2541https://github.com/nodejs/node/commit/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
Compare https://github.com/nodejs/node/compare/98aebc9f3bd81d57668b3c3e033461fc421fa672..d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
July 26, 2022 18:32https://github.com/nodejs/node/pull/43784#event-7067283253
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 26, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1051488540
View reviewed changes https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
test/es-module/test-esm-cjs-load-error-note.mjshttps://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 26, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1051491323
View reviewed changes https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
test/common/index.jshttps://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jul 26, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1051491926
View reviewed changes https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
test/common/index.jshttps://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jul 27, 2022 https://github.com/nodejs/node/pull/43784#pullrequestreview-1051749499
View reviewed changes https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6
test/common/index.jshttps://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
July 31, 2022 18:36https://github.com/nodejs/node/pull/43784#event-7096687922
https://github.com/aduh95
aduh95https://github.com/aduh95
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Jul 31, 2022https://github.com/nodejs/node/pull/43784#event-7096966249
CI Reliability 2022-08-01 nodejs/reliability#334 https://github.com/nodejs/reliability/issues/334
CI Reliability 2022-08-02 nodejs/reliability#335 https://github.com/nodejs/reliability/issues/335
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
backport-requested-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v16.x
Aug 2, 2022https://github.com/nodejs/node/pull/43784#event-7111876843
https://github.com/targos
targoshttps://github.com/targos
lts-watch-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v16.x
backport-requested-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v16.x
Aug 2, 2022https://github.com/nodejs/node/pull/43784#event-7111931559
https://github.com/targos
targoshttps://github.com/targos
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203018272
Please reload this pagehttps://github.com/nodejs/node/pull/43784
@GeoffreyBoothhttps://github.com/GeoffreyBooth
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203020336
@targoshttps://github.com/targos
https://openjs-foundation.slack.com/archives/C01810KG1EF/p1659460515402819?thread_ts=1658853609.909249&cid=C01810KG1EFhttps://openjs-foundation.slack.com/archives/C01810KG1EF/p1659460515402819?thread_ts=1658853609.909249&cid=C01810KG1EF
@cspotcodehttps://github.com/cspotcode
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/targos
targoshttps://github.com/targos
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203023648
@GeoffreyBoothhttps://github.com/GeoffreyBooth
#44098https://github.com/nodejs/node/pull/44098
#44098https://github.com/nodejs/node/pull/44098
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203027023
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203030635
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/cspotcode
cspotcodehttps://github.com/cspotcode
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203032455
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Aug 2, 2022https://github.com/nodejs/node/pull/43784#issuecomment-1203034337
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 3, 2022 https://github.com/nodejs/node/pull/43784#ref-issue-1326529756
CI Reliability 2022-08-03 nodejs/reliability#336 https://github.com/nodejs/reliability/issues/336
https://github.com/targos
targoshttps://github.com/targos
lts-watch-v16.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v16.x
Aug 6, 2022https://github.com/nodejs/node/pull/43784#event-7140657592
targoshttps://github.com/targos
Aug 6, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-e6db809
https://github.com/JakobJingleheimer
https://github.com/targos
test: refactor ESM tests to improve performancehttps://github.com/nodejs/node/commit/e6db8099f8df90f7b8644f90a777670833bedd06
e6db809https://github.com/nodejs/node/commit/e6db8099f8df90f7b8644f90a777670833bedd06
#43784https://github.com/nodejs/node/pull/43784
https://github.com/targos
targoshttps://github.com/targos
Aug 6, 2022 https://github.com/nodejs/node/pull/43784#ref-pullrequest-1325821229
v16.17.0 release proposal #44098 https://github.com/nodejs/node/pull/44098
danielleadamshttps://github.com/danielleadams
Aug 16, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-cbc1189
https://github.com/JakobJingleheimer
https://github.com/danielleadams
test: refactor ESM tests to improve performancehttps://github.com/nodejs/node/commit/cbc118998ac22d425e76d2365c1079df7433564c
cbc1189https://github.com/nodejs/node/commit/cbc118998ac22d425e76d2365c1079df7433564c
#43784https://github.com/nodejs/node/pull/43784
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 16, 2022 https://github.com/nodejs/node/pull/43784#ref-pullrequest-1339725975
v18.8.0 release proposal #44246 https://github.com/nodejs/node/pull/44246
ruyadornohttps://github.com/ruyadorno
Aug 23, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-b19564b
https://github.com/JakobJingleheimer
https://github.com/ruyadorno
test: refactor ESM tests to improve performancehttps://github.com/nodejs/node/commit/b19564b9d2eae50468d2d714676eb58df25c93b4
b19564bhttps://github.com/nodejs/node/commit/b19564b9d2eae50468d2d714676eb58df25c93b4
#43784https://github.com/nodejs/node/pull/43784
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Aug 23, 2022 https://github.com/nodejs/node/pull/43784#ref-pullrequest-1347304857
v18.8.0 release proposal #44353 https://github.com/nodejs/node/pull/44353
codebyterehttps://github.com/codebytere
Aug 23, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-8b3177b
https://github.com/codebytere
esm: improve performance & tidy testshttps://github.com/electron/electron/commit/8b3177b09b95ea4836ed69e1c068a5e70ab606d8
8b3177bhttps://github.com/electron/electron/commit/8b3177b09b95ea4836ed69e1c068a5e70ab606d8
nodejs/node#43784https://github.com/nodejs/node/pull/43784
codebyterehttps://github.com/codebytere
Aug 23, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-16f2d2f
https://github.com/codebytere
esm: improve performance & tidy testshttps://github.com/electron/electron/commit/16f2d2f687cdcb4b2c303bb80e0624d427b452b7
16f2d2fhttps://github.com/electron/electron/commit/16f2d2f687cdcb4b2c303bb80e0624d427b452b7
nodejs/node#43784https://github.com/nodejs/node/pull/43784
codebyterehttps://github.com/codebytere
Aug 24, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-4d7a56e
https://github.com/codebytere
esm: improve performance & tidy testshttps://github.com/electron/electron/commit/4d7a56ef1fd64ef0c20aa6aa7e883a06af48d344
4d7a56ehttps://github.com/electron/electron/commit/4d7a56ef1fd64ef0c20aa6aa7e883a06af48d344
nodejs/node#43784https://github.com/nodejs/node/pull/43784
codebyterehttps://github.com/codebytere
Aug 25, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-e1bbdd2
https://github.com/codebytere
esm: improve performance & tidy testshttps://github.com/electron/electron/commit/e1bbdd2af365623b0e99df947757fb23c3c2e69e
e1bbdd2https://github.com/electron/electron/commit/e1bbdd2af365623b0e99df947757fb23c3c2e69e
nodejs/node#43784https://github.com/nodejs/node/pull/43784
jkleinschttps://github.com/jkleinsc
Aug 29, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-d0e220c
https://github.com/apps/electron-roller
https://github.com/codebytere
chore: bump node to v16.17.0 (main) (https://github.com/electron/electron/commit/d0e220cbcecb6fcca6b6e8acf161dd51864718f2
#35350https://github.com/electron/electron/pull/35350
)https://github.com/electron/electron/commit/d0e220cbcecb6fcca6b6e8acf161dd51864718f2
d0e220chttps://github.com/electron/electron/commit/d0e220cbcecb6fcca6b6e8acf161dd51864718f2
nodejs/node#43270https://github.com/nodejs/node/pull/43270
nodejs/node#43173https://github.com/nodejs/node/pull/43173
nodejs/node#43310https://github.com/nodejs/node/pull/43310
nodejs/node#43500https://github.com/nodejs/node/pull/43500
nodejs/node#43950https://github.com/nodejs/node/pull/43950
nodejs/node#43745https://github.com/nodejs/node/pull/43745
nodejs/node#43646https://github.com/nodejs/node/pull/43646
nodejs/node#43784https://github.com/nodejs/node/pull/43784
nodejs/node#43594https://github.com/nodejs/node/pull/43594
nodejs/node#42368https://github.com/nodejs/node/pull/42368
nodejs/node#40478https://github.com/nodejs/node/pull/40478
nodejs/node#43428https://github.com/nodejs/node/pull/43428
nodejs/node#43903https://github.com/nodejs/node/pull/43903
nodejs/node#42655https://github.com/nodejs/node/pull/42655
https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
nodejs/node#43218https://github.com/nodejs/node/pull/43218
nodejs/node#42507https://github.com/nodejs/node/pull/42507
nodejs/node#42695https://github.com/nodejs/node/pull/42695
nodejs/node#42539https://github.com/nodejs/node/pull/42539
nodejs/node#44393https://github.com/nodejs/node/pull/44393
Fykohttps://github.com/Fyko
Sep 15, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-a008632
https://github.com/JakobJingleheimer
https://github.com/Fyko
test: refactor ESM tests to improve performancehttps://github.com/Fyko/node/commit/a008632986c25e7ff50691f88e55b4d43b31246f
a008632https://github.com/Fyko/node/commit/a008632986c25e7ff50691f88e55b4d43b31246f
nodejs#43784https://github.com/nodejs/node/pull/43784
guangwonghttps://github.com/guangwong
Oct 10, 2022 https://github.com/nodejs/node/pull/43784#ref-commit-7ed24ae
https://github.com/JakobJingleheimer
https://github.com/guangwong
test: refactor ESM tests to improve performancehttps://github.com/noslate-project/node/commit/7ed24aec38e621c55b9ba13aa0536c02b3b4d406
7ed24aehttps://github.com/noslate-project/node/commit/7ed24aec38e621c55b9ba13aa0536c02b3b4d406
nodejs/node#43784https://github.com/nodejs/node/pull/43784
khalwahttps://github.com/khalwa
Feb 22, 2023 https://github.com/nodejs/node/pull/43784#ref-commit-a2ca4b7
https://github.com/apps/electron-roller
https://github.com/codebytere
https://github.com/khalwa
chore: bump node to v16.17.0 (main) (https://github.com/solarwindscloud/electron/commit/a2ca4b73333d628e7eef1599e79aeffa06f1c084
electron#35350https://github.com/electron/electron/pull/35350
)https://github.com/solarwindscloud/electron/commit/a2ca4b73333d628e7eef1599e79aeffa06f1c084
a2ca4b7https://github.com/solarwindscloud/electron/commit/a2ca4b73333d628e7eef1599e79aeffa06f1c084
nodejs/node#43270https://github.com/nodejs/node/pull/43270
nodejs/node#43173https://github.com/nodejs/node/pull/43173
nodejs/node#43310https://github.com/nodejs/node/pull/43310
nodejs/node#43500https://github.com/nodejs/node/pull/43500
nodejs/node#43950https://github.com/nodejs/node/pull/43950
nodejs/node#43745https://github.com/nodejs/node/pull/43745
nodejs/node#43646https://github.com/nodejs/node/pull/43646
nodejs/node#43784https://github.com/nodejs/node/pull/43784
nodejs/node#43594https://github.com/nodejs/node/pull/43594
nodejs/node#42368https://github.com/nodejs/node/pull/42368
nodejs/node#40478https://github.com/nodejs/node/pull/40478
nodejs/node#43428https://github.com/nodejs/node/pull/43428
nodejs/node#43903https://github.com/nodejs/node/pull/43903
nodejs/node#42655https://github.com/nodejs/node/pull/42655
https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093
nodejs/node#43218https://github.com/nodejs/node/pull/43218
nodejs/node#42507https://github.com/nodejs/node/pull/42507
nodejs/node#42695https://github.com/nodejs/node/pull/42695
nodejs/node#42539https://github.com/nodejs/node/pull/42539
nodejs/node#44393https://github.com/nodejs/node/pull/44393
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43784
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/43784/files/aa67d37f948d8704b339bd4baaf43bba61eb7d68
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/43784/files/aa67d37f948d8704b339bd4baaf43bba61eb7d68
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/43784/files/64bf3336e9196944bd6b24018864df39e51905dd
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
loaders https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/43784
https://github.com/JakobJingleheimer
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/MoLow
https://github.com/GeoffreyBooth
https://github.com/targos
https://github.com/cspotcode
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.