| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:76f49688-13ab-13f9-4a25-f4fe0daa4b7c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E8E6:2BBCB0:91AA02:C806B7:696AB6C1 |
| html-safe-nonce | ad6fb5dfa30bb7cb754ea30db15f87c26336387e7cfa9d2829b19abf1355048f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEU2OjJCQkNCMDo5MUFBMDI6QzgwNkI3OjY5NkFCNkMxIiwidmlzaXRvcl9pZCI6Ijk3MTk1MTY0MjAxOTI4MDU3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7a9cd1ebaca7be9c838b1a8f8f6cd0c4b03d62893a91c6f66350a62da0e871f7 |
| hovercard-subject-tag | pull_request:993454265 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/43784/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/318a5c95d1b7763e5a4d7f4fc2c007750e6554cd3b824a9e80dfa55ca4caee18/nodejs/node/pull/43784 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/318a5c95d1b7763e5a4d7f4fc2c007750e6554cd3b824a9e80dfa55ca4caee18/nodejs/node/pull/43784 |
| og:image:alt | This standardises the setup of ESM tests and improves performance by parallelising case runs using a promise wrapper around async spawn.
I originally started out using chaining for parallelisation,... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JakobJingleheimer |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 41f276818bd204c4a30a0281fb3c576298d9474c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/43784#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43784 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43784 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/43784 |
| Reload | https://github.com/nodejs/node/pull/43784 |
| Reload | https://github.com/nodejs/node/pull/43784 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/43784#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| JakobJingleheimer:esm/tidy-esm-tests | https://github.com/JakobJingleheimer/node/tree/esm/tidy-esm-tests |
|
esm: improve performance & tidy tests
| https://github.com/nodejs/node/pull/43784#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| JakobJingleheimer:esm/tidy-esm-tests | https://github.com/JakobJingleheimer/node/tree/esm/tidy-esm-tests |
|
Conversation
97
| https://github.com/nodejs/node/pull/43784 |
|
Commits
15
| https://github.com/nodejs/node/pull/43784/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/43784/checks |
|
Files changed
| https://github.com/nodejs/node/pull/43784/files |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 11, 2022 | https://github.com/nodejs/node/pull/43784#issue-1301107855 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
| Jul 11, 2022 | https://github.com/nodejs/node/pull/43784#event-6972052774 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jul 11, 2022 | https://github.com/nodejs/node/pull/43784#event-6972054384 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 11, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1034904859 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1034904859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-cjs-esm-warn.mjs | https://github.com/nodejs/node/pull/43784/files#diff-d4998945f93a68cd1226502c4aa024cd4ffcf37cb4b2ffc7ae90595821e0e19c |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 11, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1180889117 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Jul 14, 2022
| https://github.com/nodejs/node/pull/43784#ref-pullrequest-1299894464 |
|
test_runner: fix it concurrency
#43757
| https://github.com/nodejs/node/pull/43757 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Jul 24, 2022
| https://github.com/nodejs/node/pull/43784#ref-pullrequest-1314497944 |
|
esm: add --import flag
#43942
| https://github.com/nodejs/node/pull/43942 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| force-pushed | https://github.com/nodejs/node/compare/efb8000dc5f9a76f613f8d362e6347b788728683..f3a2e1ca8edf60280f5ddbb19f7eb613e1c4646f |
| efb8000 | https://github.com/nodejs/node/commit/efb8000dc5f9a76f613f8d362e6347b788728683 |
| f3a2e1c | https://github.com/nodejs/node/commit/f3a2e1ca8edf60280f5ddbb19f7eb613e1c4646f |
|
Compare
| https://github.com/nodejs/node/compare/efb8000dc5f9a76f613f8d362e6347b788728683..f3a2e1ca8edf60280f5ddbb19f7eb613e1c4646f |
| July 24, 2022 22:22 | https://github.com/nodejs/node/pull/43784#event-7051943667 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| July 24, 2022 22:22 | https://github.com/nodejs/node/pull/43784#event-7051944074 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 24, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1193406283 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jul 24, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1193409503 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| July 25, 2022 07:56 | https://github.com/nodejs/node/pull/43784#event-7054054420 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 25, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1049020517 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files |
| test/es-module/test-cjs-esm-warn.js | https://github.com/nodejs/node/pull/43784/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
|
Jul 25, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1049020193 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files |
| test/es-module/test-esm-cjs-load-error-note.mjs | https://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-invalid-extension.js | https://github.com/nodejs/node/pull/43784/files#diff-993e2be28ff2eb2c915d3b73429d0b3808a5e87ea3badb4d60dfd75cc95f3f8a |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 25, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r928581315 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| aduh95 | https://github.com/aduh95 |
| July 25, 2022 21:57 | https://github.com/nodejs/node/pull/43784#event-7060025644 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jul 25, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1050125013 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files |
| test/es-module/test-cjs-esm-warn.js | https://github.com/nodejs/node/pull/43784/files#diff-2ce8479190aa7c61723996ee6df6d2656c2ba1657da54999622791e1e4a57547 |
| aduh95 | https://github.com/aduh95 |
| Jul 25, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r929342660 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 25, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r929360274 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| aduh95 | https://github.com/aduh95 |
| Jul 25, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r929365840 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jul 26, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r929507133 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://stackoverflow.com/a/37145215/223225 | https://stackoverflow.com/a/37145215/223225 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 26, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r929682610 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/3012099/180961313-2960aa33-e1aa-4669-9087-e85ca64a8d64.png |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Jul 26, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r929684130 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/3012099/180962173-941f48c4-04b7-4d8a-a05a-dd6e626d1142.png |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Jul 26, 2022 | https://github.com/nodejs/node/pull/43784#discussion_r930296336 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-cjs-load-error-note.mjs | https://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-cjs-load-error-note.mjs | https://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-experimental-warnings.mjs | https://github.com/nodejs/node/pull/43784/files#diff-f9e424042265082861450494bae6c98756ee069e65dcd7d73fde0737b8b26b55 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-invalid-pjson.js | https://github.com/nodejs/node/pull/43784/files#diff-af415fd1b964ba5516cf56b3cc42381cfc2a14f65d7803f6c33e13dd02f57ee0 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-repl-imports.js | https://github.com/nodejs/node/pull/43784/files#diff-64d61e3f2be769df6abde84e8528c5abaffc80425407eab5ddb0e7a10aca08ec |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-repl-imports.js | https://github.com/nodejs/node/pull/43784/files#diff-64d61e3f2be769df6abde84e8528c5abaffc80425407eab5ddb0e7a10aca08ec |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Jul 26, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1050335024 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1050335024 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/helper.spawnAsPromised.mjs | https://github.com/nodejs/node/pull/43784/files#diff-4d42e70929fb28e8c8c402f880fe505511d0025772188180e1de6caaff8608ed |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| test/es-module/test-esm-cjs-load-error-note.mjs | https://github.com/nodejs/node/pull/43784/files#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| July 26, 2022 20:22 | https://github.com/nodejs/node/pull/43784#commits-pushed-03d1f1d |
|
| https://github.com/JakobJingleheimer |
| esm: tidy tests | https://github.com/nodejs/node/pull/43784/commits/03d1f1d12ad698f4c2d9173ca9c31f844bdd96de |
| 03d1f1d | https://github.com/nodejs/node/pull/43784/commits/03d1f1d12ad698f4c2d9173ca9c31f844bdd96de |
|
| https://github.com/JakobJingleheimer |
| switch to node:test | https://github.com/nodejs/node/pull/43784/commits/24157ab6fe230b6cffb1bdb3646422f01f850f74 |
| 24157ab | https://github.com/nodejs/node/pull/43784/commits/24157ab6fe230b6cffb1bdb3646422f01f850f74 |
|
| https://github.com/JakobJingleheimer |
| move spawnAsPromised to test/common as spawnPromisified | https://github.com/nodejs/node/pull/43784/commits/a53214b193343597ae88f7bb5e9d79c44dbbf8fc |
| a53214b | https://github.com/nodejs/node/pull/43784/commits/a53214b193343597ae88f7bb5e9d79c44dbbf8fc |
|
| https://github.com/JakobJingleheimer |
| tidy shouldIncludeNote | https://github.com/nodejs/node/pull/43784/commits/e9fcef035fc9d2051202fb816e22fbfe5098c435 |
| e9fcef0 | https://github.com/nodejs/node/pull/43784/commits/e9fcef035fc9d2051202fb816e22fbfe5098c435 |
|
| https://github.com/JakobJingleheimer |
| replaceAll regex → string | https://github.com/nodejs/node/pull/43784/commits/41980ee7b2d1232dd2160bcb5d7d6378deed8de3 |
| 41980ee | https://github.com/nodejs/node/pull/43784/commits/41980ee7b2d1232dd2160bcb5d7d6378deed8de3 |
|
| https://github.com/JakobJingleheimer |
| REPL done() | https://github.com/nodejs/node/pull/43784/commits/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| d7a2541 | https://github.com/nodejs/node/pull/43784/commits/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| force-pushed | https://github.com/nodejs/node/compare/98aebc9f3bd81d57668b3c3e033461fc421fa672..d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| 98aebc9 | https://github.com/nodejs/node/commit/98aebc9f3bd81d57668b3c3e033461fc421fa672 |
| d7a2541 | https://github.com/nodejs/node/commit/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
|
Compare
| https://github.com/nodejs/node/compare/98aebc9f3bd81d57668b3c3e033461fc421fa672..d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| July 26, 2022 18:32 | https://github.com/nodejs/node/pull/43784#event-7067283253 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
|
Jul 26, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1051488540 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| test/es-module/test-esm-cjs-load-error-note.mjs | https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-5292d6fe472b136e0740267b60638f6cbe582148e7b777d2a6dc0e29283fe875 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
|
Jul 26, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1051491323 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| test/common/index.js | https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/MoLow |
| MoLow | https://github.com/MoLow |
|
Jul 26, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1051491926 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| test/common/index.js | https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
Jul 27, 2022
| https://github.com/nodejs/node/pull/43784#pullrequestreview-1051749499 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6 |
| test/common/index.js | https://github.com/nodejs/node/pull/43784/files/d7a25417c506959f0a2dcdc21d82a16c2b09ddf6#diff-f75d7f53e0dbb5033126f9e985a67109aecee73364c6f41e6e2c125178ab48bb |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| July 31, 2022 18:36 | https://github.com/nodejs/node/pull/43784#event-7096687922 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
test_runner
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner |
| Jul 31, 2022 | https://github.com/nodejs/node/pull/43784#event-7096966249 |
|
CI Reliability 2022-08-01
nodejs/reliability#334
| https://github.com/nodejs/reliability/issues/334 |
|
CI Reliability 2022-08-02
nodejs/reliability#335
| https://github.com/nodejs/reliability/issues/335 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
|
backport-requested-v16.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v16.x |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#event-7111876843 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
lts-watch-v16.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v16.x |
|
backport-requested-v16.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v16.x |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#event-7111931559 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203018272 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203020336 |
| @targos | https://github.com/targos |
| https://openjs-foundation.slack.com/archives/C01810KG1EF/p1659460515402819?thread_ts=1658853609.909249&cid=C01810KG1EF | https://openjs-foundation.slack.com/archives/C01810KG1EF/p1659460515402819?thread_ts=1658853609.909249&cid=C01810KG1EF |
| @cspotcode | https://github.com/cspotcode |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/targos |
| targos | https://github.com/targos |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203023648 |
| @GeoffreyBooth | https://github.com/GeoffreyBooth |
| #44098 | https://github.com/nodejs/node/pull/44098 |
| #44098 | https://github.com/nodejs/node/pull/44098 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/GeoffreyBooth |
| GeoffreyBooth | https://github.com/GeoffreyBooth |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203027023 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203030635 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/cspotcode |
| cspotcode | https://github.com/cspotcode |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203032455 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/JakobJingleheimer |
| JakobJingleheimer | https://github.com/JakobJingleheimer |
| Aug 2, 2022 | https://github.com/nodejs/node/pull/43784#issuecomment-1203034337 |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 3, 2022
| https://github.com/nodejs/node/pull/43784#ref-issue-1326529756 |
|
CI Reliability 2022-08-03
nodejs/reliability#336
| https://github.com/nodejs/reliability/issues/336 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
lts-watch-v16.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v16.x |
| Aug 6, 2022 | https://github.com/nodejs/node/pull/43784#event-7140657592 |
| targos | https://github.com/targos |
|
Aug 6, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-e6db809 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/targos |
| test: refactor ESM tests to improve performance | https://github.com/nodejs/node/commit/e6db8099f8df90f7b8644f90a777670833bedd06 |
| e6db809 | https://github.com/nodejs/node/commit/e6db8099f8df90f7b8644f90a777670833bedd06 |
| #43784 | https://github.com/nodejs/node/pull/43784 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 6, 2022
| https://github.com/nodejs/node/pull/43784#ref-pullrequest-1325821229 |
|
v16.17.0 release proposal
#44098
| https://github.com/nodejs/node/pull/44098 |
| danielleadams | https://github.com/danielleadams |
|
Aug 16, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-cbc1189 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/danielleadams |
| test: refactor ESM tests to improve performance | https://github.com/nodejs/node/commit/cbc118998ac22d425e76d2365c1079df7433564c |
| cbc1189 | https://github.com/nodejs/node/commit/cbc118998ac22d425e76d2365c1079df7433564c |
| #43784 | https://github.com/nodejs/node/pull/43784 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 16, 2022
| https://github.com/nodejs/node/pull/43784#ref-pullrequest-1339725975 |
|
v18.8.0 release proposal
#44246
| https://github.com/nodejs/node/pull/44246 |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-b19564b |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/ruyadorno |
| test: refactor ESM tests to improve performance | https://github.com/nodejs/node/commit/b19564b9d2eae50468d2d714676eb58df25c93b4 |
| b19564b | https://github.com/nodejs/node/commit/b19564b9d2eae50468d2d714676eb58df25c93b4 |
| #43784 | https://github.com/nodejs/node/pull/43784 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/43784#ref-pullrequest-1347304857 |
|
v18.8.0 release proposal
#44353
| https://github.com/nodejs/node/pull/44353 |
| codebytere | https://github.com/codebytere |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-8b3177b |
|
| https://github.com/codebytere |
| esm: improve performance & tidy tests | https://github.com/electron/electron/commit/8b3177b09b95ea4836ed69e1c068a5e70ab606d8 |
| 8b3177b | https://github.com/electron/electron/commit/8b3177b09b95ea4836ed69e1c068a5e70ab606d8 |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| codebytere | https://github.com/codebytere |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-16f2d2f |
|
| https://github.com/codebytere |
| esm: improve performance & tidy tests | https://github.com/electron/electron/commit/16f2d2f687cdcb4b2c303bb80e0624d427b452b7 |
| 16f2d2f | https://github.com/electron/electron/commit/16f2d2f687cdcb4b2c303bb80e0624d427b452b7 |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| codebytere | https://github.com/codebytere |
|
Aug 24, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-4d7a56e |
|
| https://github.com/codebytere |
| esm: improve performance & tidy tests | https://github.com/electron/electron/commit/4d7a56ef1fd64ef0c20aa6aa7e883a06af48d344 |
| 4d7a56e | https://github.com/electron/electron/commit/4d7a56ef1fd64ef0c20aa6aa7e883a06af48d344 |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| codebytere | https://github.com/codebytere |
|
Aug 25, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-e1bbdd2 |
|
| https://github.com/codebytere |
| esm: improve performance & tidy tests | https://github.com/electron/electron/commit/e1bbdd2af365623b0e99df947757fb23c3c2e69e |
| e1bbdd2 | https://github.com/electron/electron/commit/e1bbdd2af365623b0e99df947757fb23c3c2e69e |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| jkleinsc | https://github.com/jkleinsc |
|
Aug 29, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-d0e220c |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
| chore: bump node to v16.17.0 (main) ( | https://github.com/electron/electron/commit/d0e220cbcecb6fcca6b6e8acf161dd51864718f2 |
| #35350 | https://github.com/electron/electron/pull/35350 |
| ) | https://github.com/electron/electron/commit/d0e220cbcecb6fcca6b6e8acf161dd51864718f2 |
| d0e220c | https://github.com/electron/electron/commit/d0e220cbcecb6fcca6b6e8acf161dd51864718f2 |
| nodejs/node#43270 | https://github.com/nodejs/node/pull/43270 |
| nodejs/node#43173 | https://github.com/nodejs/node/pull/43173 |
| nodejs/node#43310 | https://github.com/nodejs/node/pull/43310 |
| nodejs/node#43500 | https://github.com/nodejs/node/pull/43500 |
| nodejs/node#43950 | https://github.com/nodejs/node/pull/43950 |
| nodejs/node#43745 | https://github.com/nodejs/node/pull/43745 |
| nodejs/node#43646 | https://github.com/nodejs/node/pull/43646 |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| nodejs/node#43594 | https://github.com/nodejs/node/pull/43594 |
| nodejs/node#42368 | https://github.com/nodejs/node/pull/42368 |
| nodejs/node#40478 | https://github.com/nodejs/node/pull/40478 |
| nodejs/node#43428 | https://github.com/nodejs/node/pull/43428 |
| nodejs/node#43903 | https://github.com/nodejs/node/pull/43903 |
| nodejs/node#42655 | https://github.com/nodejs/node/pull/42655 |
| https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 | https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 |
| nodejs/node#43218 | https://github.com/nodejs/node/pull/43218 |
| nodejs/node#42507 | https://github.com/nodejs/node/pull/42507 |
| nodejs/node#42695 | https://github.com/nodejs/node/pull/42695 |
| nodejs/node#42539 | https://github.com/nodejs/node/pull/42539 |
| nodejs/node#44393 | https://github.com/nodejs/node/pull/44393 |
| Fyko | https://github.com/Fyko |
|
Sep 15, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-a008632 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/Fyko |
| test: refactor ESM tests to improve performance | https://github.com/Fyko/node/commit/a008632986c25e7ff50691f88e55b4d43b31246f |
| a008632 | https://github.com/Fyko/node/commit/a008632986c25e7ff50691f88e55b4d43b31246f |
| nodejs#43784 | https://github.com/nodejs/node/pull/43784 |
| guangwong | https://github.com/guangwong |
|
Oct 10, 2022
| https://github.com/nodejs/node/pull/43784#ref-commit-7ed24ae |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/guangwong |
| test: refactor ESM tests to improve performance | https://github.com/noslate-project/node/commit/7ed24aec38e621c55b9ba13aa0536c02b3b4d406 |
| 7ed24ae | https://github.com/noslate-project/node/commit/7ed24aec38e621c55b9ba13aa0536c02b3b4d406 |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| khalwa | https://github.com/khalwa |
|
Feb 22, 2023
| https://github.com/nodejs/node/pull/43784#ref-commit-a2ca4b7 |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
|
| https://github.com/khalwa |
| chore: bump node to v16.17.0 (main) ( | https://github.com/solarwindscloud/electron/commit/a2ca4b73333d628e7eef1599e79aeffa06f1c084 |
| electron#35350 | https://github.com/electron/electron/pull/35350 |
| ) | https://github.com/solarwindscloud/electron/commit/a2ca4b73333d628e7eef1599e79aeffa06f1c084 |
| a2ca4b7 | https://github.com/solarwindscloud/electron/commit/a2ca4b73333d628e7eef1599e79aeffa06f1c084 |
| nodejs/node#43270 | https://github.com/nodejs/node/pull/43270 |
| nodejs/node#43173 | https://github.com/nodejs/node/pull/43173 |
| nodejs/node#43310 | https://github.com/nodejs/node/pull/43310 |
| nodejs/node#43500 | https://github.com/nodejs/node/pull/43500 |
| nodejs/node#43950 | https://github.com/nodejs/node/pull/43950 |
| nodejs/node#43745 | https://github.com/nodejs/node/pull/43745 |
| nodejs/node#43646 | https://github.com/nodejs/node/pull/43646 |
| nodejs/node#43784 | https://github.com/nodejs/node/pull/43784 |
| nodejs/node#43594 | https://github.com/nodejs/node/pull/43594 |
| nodejs/node#42368 | https://github.com/nodejs/node/pull/42368 |
| nodejs/node#40478 | https://github.com/nodejs/node/pull/40478 |
| nodejs/node#43428 | https://github.com/nodejs/node/pull/43428 |
| nodejs/node#43903 | https://github.com/nodejs/node/pull/43903 |
| nodejs/node#42655 | https://github.com/nodejs/node/pull/42655 |
| https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 | https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 |
| nodejs/node#43218 | https://github.com/nodejs/node/pull/43218 |
| nodejs/node#42507 | https://github.com/nodejs/node/pull/42507 |
| nodejs/node#42695 | https://github.com/nodejs/node/pull/42695 |
| nodejs/node#42539 | https://github.com/nodejs/node/pull/42539 |
| nodejs/node#44393 | https://github.com/nodejs/node/pull/44393 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43784 |
|
| https://github.com/GeoffreyBooth |
|
GeoffreyBooth
| https://github.com/GeoffreyBooth |
|
| https://github.com/nodejs/node/pull/43784/files/aa67d37f948d8704b339bd4baaf43bba61eb7d68 |
|
| https://github.com/MoLow |
|
MoLow
| https://github.com/MoLow |
|
| https://github.com/nodejs/node/pull/43784/files/aa67d37f948d8704b339bd4baaf43bba61eb7d68 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/43784/files/64bf3336e9196944bd6b24018864df39e51905dd |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
loaders
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aloaders |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/43784 |
|
| https://github.com/JakobJingleheimer |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/MoLow |
|
| https://github.com/GeoffreyBooth |
|
| https://github.com/targos |
|
| https://github.com/cspotcode |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |