| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3a77a573-4f92-0127-2407-cc818a221399 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CAA:B6892:C2EA92:1088013:6969EACA |
| html-safe-nonce | bfda60743c12118112bbb865c2bc903e83647964d570518d77115db9a743d3f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0FBOkI2ODkyOkMyRUE5MjoxMDg4MDEzOjY5NjlFQUNBIiwidmlzaXRvcl9pZCI6IjQ4OTMwMTE0MTYwODA1NzUxNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 66303b0d4262a48e5b3e41d1ac03997030f3ede2a843f3b7e7594f7830db7a83 |
| hovercard-subject-tag | pull_request:979902207 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/43587/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/475a278ea455d44d8fe9d13f20784e371dca9f10f70e9c2c64be2c42cdeec6a7/nodejs/node/pull/43587 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/475a278ea455d44d8fe9d13f20784e371dca9f10f70e9c2c64be2c42cdeec6a7/nodejs/node/pull/43587 |
| og:image:alt | This PR prevents addition of a listener if not absolutely necessary, preventing a memory leak.
Fixes: #43548 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ShogunPanda |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/43587#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/43587 |
| Reload | https://github.com/nodejs/node/pull/43587 |
| Reload | https://github.com/nodejs/node/pull/43587 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/43587#issue-comment-box |
| ShogunPanda | https://github.com/ShogunPanda |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| ShogunPanda:socket-memory-leak | https://github.com/ShogunPanda/node/tree/socket-memory-leak |
|
http: do not leak error listeners
| https://github.com/nodejs/node/pull/43587#top |
| ShogunPanda | https://github.com/ShogunPanda |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| ShogunPanda:socket-memory-leak | https://github.com/ShogunPanda/node/tree/socket-memory-leak |
|
Conversation
50
| https://github.com/nodejs/node/pull/43587 |
|
Commits
1
| https://github.com/nodejs/node/pull/43587/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/43587/checks |
|
Files changed
| https://github.com/nodejs/node/pull/43587/files |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jun 27, 2022 | https://github.com/nodejs/node/pull/43587#issue-1285623892 |
| #43548 | https://github.com/nodejs/node/issues/43548 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 27, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1167203068 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Jun 27, 2022 | https://github.com/nodejs/node/pull/43587#event-6884243024 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 27, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1020000654 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1020000654 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/b7f34dfad2fba8ae1b4ba72527c5cb43595b9a81..56ba9abf6d62b55dfa5f4c253aaf6be7ed1f3da9 |
| b7f34df | https://github.com/nodejs/node/commit/b7f34dfad2fba8ae1b4ba72527c5cb43595b9a81 |
| 56ba9ab | https://github.com/nodejs/node/commit/56ba9abf6d62b55dfa5f4c253aaf6be7ed1f3da9 |
|
Compare
| https://github.com/nodejs/node/compare/b7f34dfad2fba8ae1b4ba72527c5cb43595b9a81..56ba9abf6d62b55dfa5f4c253aaf6be7ed1f3da9 |
| June 27, 2022 12:30 | https://github.com/nodejs/node/pull/43587#event-6884910523 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Jun 27, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1167322824 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 27, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1020213380 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| test/parallel/test-http-socket-listeners.js | https://github.com/nodejs/node/pull/43587/files#diff-7395b861577b9198102fe3da5ce532bf60c5482c8bbace3047f36227ddd60179 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| test/parallel/test-http-socket-listeners.js | https://github.com/nodejs/node/pull/43587/files#diff-7395b861577b9198102fe3da5ce532bf60c5482c8bbace3047f36227ddd60179 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| test/parallel/test-http-socket-listeners.js | https://github.com/nodejs/node/pull/43587/files#diff-7395b861577b9198102fe3da5ce532bf60c5482c8bbace3047f36227ddd60179 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/56ba9abf6d62b55dfa5f4c253aaf6be7ed1f3da9..275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0 |
| 56ba9ab | https://github.com/nodejs/node/commit/56ba9abf6d62b55dfa5f4c253aaf6be7ed1f3da9 |
| 275bb10 | https://github.com/nodejs/node/commit/275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0 |
|
Compare
| https://github.com/nodejs/node/compare/56ba9abf6d62b55dfa5f4c253aaf6be7ed1f3da9..275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0 |
| June 27, 2022 14:27 | https://github.com/nodejs/node/pull/43587#event-6885867321 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jun 27, 2022 | https://github.com/nodejs/node/pull/43587#event-6885886032 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 27, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1020505156 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| lib/_http_server.js | https://github.com/nodejs/node/pull/43587/files#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jun 27, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1020679560 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| test/parallel/test-http-socket-listeners.js | https://github.com/nodejs/node/pull/43587/files#diff-7395b861577b9198102fe3da5ce532bf60c5482c8bbace3047f36227ddd60179 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Jun 28, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1020947023 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| test/parallel/test-http-socket-listeners.js | https://github.com/nodejs/node/pull/43587/files#diff-7395b861577b9198102fe3da5ce532bf60c5482c8bbace3047f36227ddd60179 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
|
Jun 28, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1021106966 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0..f8244c0fa5485608c71d5de9ba2e3739dd3b1b6b |
| 275bb10 | https://github.com/nodejs/node/commit/275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0 |
| f8244c0 | https://github.com/nodejs/node/commit/f8244c0fa5485608c71d5de9ba2e3739dd3b1b6b |
|
Compare
| https://github.com/nodejs/node/compare/275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0..f8244c0fa5485608c71d5de9ba2e3739dd3b1b6b |
| June 28, 2022 10:35 | https://github.com/nodejs/node/pull/43587#event-6892784609 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jun 28, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1021753544 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1021753544 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Jun 28, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1021777956 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| https://github.com/tonivj5 |
| tonivj5 | https://github.com/tonivj5 |
|
Jun 28, 2022
| https://github.com/nodejs/node/pull/43587#pullrequestreview-1022372142 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/43587/files |
| lib/_http_server.js | https://github.com/nodejs/node/pull/43587/files#diff-2464899ab38c61dd42654fdb9658c75989cb6883b9c9d76613872a12d3fe2780 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/Slayer95 |
| Slayer95 | https://github.com/Slayer95 |
| Jun 29, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1169527621 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jun 29, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1169553295 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/d3d04fd6ba29b73cf59bc343e14c934de2624bae..c4df0b5d12a3672a186ab6b5ac80efa545743d9f |
| d3d04fd | https://github.com/nodejs/node/commit/d3d04fd6ba29b73cf59bc343e14c934de2624bae |
| c4df0b5 | https://github.com/nodejs/node/commit/c4df0b5d12a3672a186ab6b5ac80efa545743d9f |
|
Compare
| https://github.com/nodejs/node/compare/d3d04fd6ba29b73cf59bc343e14c934de2624bae..c4df0b5d12a3672a186ab6b5ac80efa545743d9f |
| June 30, 2022 07:58 | https://github.com/nodejs/node/pull/43587#event-6908468489 |
|
| https://github.com/ShogunPanda |
| http: do not leak error listeners | https://github.com/nodejs/node/pull/43587/commits/3bfee398c9a76be8b097dbb53269bcb02e65779c |
| 3bfee39 | https://github.com/nodejs/node/pull/43587/commits/3bfee398c9a76be8b097dbb53269bcb02e65779c |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| force-pushed | https://github.com/nodejs/node/compare/c4df0b5d12a3672a186ab6b5ac80efa545743d9f..3bfee398c9a76be8b097dbb53269bcb02e65779c |
| c4df0b5 | https://github.com/nodejs/node/commit/c4df0b5d12a3672a186ab6b5ac80efa545743d9f |
| 3bfee39 | https://github.com/nodejs/node/commit/3bfee398c9a76be8b097dbb53269bcb02e65779c |
|
Compare
| https://github.com/nodejs/node/compare/c4df0b5d12a3672a186ab6b5ac80efa545743d9f..3bfee398c9a76be8b097dbb53269bcb02e65779c |
| June 30, 2022 08:00 | https://github.com/nodejs/node/pull/43587#event-6908484232 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 30, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1171040243 |
| https://ci.nodejs.org/job/node-test-pull-request/45000/ | https://ci.nodejs.org/job/node-test-pull-request/45000/ |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 30, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1171495685 |
| https://ci.nodejs.org/job/node-test-pull-request/45010/ | https://ci.nodejs.org/job/node-test-pull-request/45010/ |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 30, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1171601285 |
| https://ci.nodejs.org/job/node-test-pull-request/45013/ | https://ci.nodejs.org/job/node-test-pull-request/45013/ |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Aug 23, 2022
| https://github.com/nodejs/node/pull/43587#ref-pullrequest-1347304857 |
|
v18.8.0 release proposal
#44353
| https://github.com/nodejs/node/pull/44353 |
| targos | https://github.com/targos |
|
Sep 5, 2022
| https://github.com/nodejs/node/pull/43587#ref-commit-cda1287 |
|
| https://github.com/ShogunPanda |
|
| https://github.com/targos |
| http: do not leak error listeners | https://github.com/nodejs/node/commit/cda1287cde3f92a595e8a873baf1adfefc9085fe |
| cda1287 | https://github.com/nodejs/node/commit/cda1287cde3f92a595e8a873baf1adfefc9085fe |
| #43587 | https://github.com/nodejs/node/pull/43587 |
| #43548 | https://github.com/nodejs/node/issues/43548 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| Oct 7, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1272092166 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1180784093 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1181161474 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/dougwilson |
| dougwilson | https://github.com/dougwilson |
| Oct 7, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1272094883 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| lpinca | https://github.com/lpinca |
|
Oct 8, 2022
| https://github.com/nodejs/node/pull/43587#ref-commit-03232eb |
|
| https://github.com/lpinca |
| Revert "http: do not leak error listeners" | https://github.com/lpinca/node/commit/03232eb65811347b513236e8e7e833f4b4790374 |
| 03232eb | https://github.com/lpinca/node/commit/03232eb65811347b513236e8e7e833f4b4790374 |
| 736a7d8 | https://github.com/lpinca/node/commit/736a7d8d60acdcf3274ae160fadefbbbbe4e4311 |
| nodejs#43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272092166 |
| nodejs#43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272094883 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Oct 8, 2022
| https://github.com/nodejs/node/pull/43587#ref-pullrequest-1401833846 |
|
Revert "http: do not leak error listeners"
#44921
| https://github.com/nodejs/node/pull/44921 |
| juanarbol | https://github.com/juanarbol |
|
Oct 10, 2022
| https://github.com/nodejs/node/pull/43587#ref-commit-25339ab |
|
| https://github.com/ShogunPanda |
|
| https://github.com/juanarbol |
| http: do not leak error listeners | https://github.com/nodejs/node/commit/25339ab3cf5bf14e2c66435c222ffa166253b050 |
| 25339ab | https://github.com/nodejs/node/commit/25339ab3cf5bf14e2c66435c222ffa166253b050 |
| #43587 | https://github.com/nodejs/node/pull/43587 |
| #43548 | https://github.com/nodejs/node/issues/43548 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Oct 11, 2022
| https://github.com/nodejs/node/pull/43587#ref-pullrequest-1395630632 |
|
V16.18.0 proposal
#44886
| https://github.com/nodejs/node/pull/44886 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 11, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1275165344 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| @dougwilson | https://github.com/dougwilson |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
dont-land-on-v16.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v16.x |
| Oct 11, 2022 | https://github.com/nodejs/node/pull/43587#event-7565766545 |
| https://github.com/dougwilson |
| dougwilson | https://github.com/dougwilson |
| Oct 11, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1275195708 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Oct 11, 2022
| https://github.com/nodejs/node/pull/43587#ref-commit-532f440 |
|
| https://github.com/ShogunPanda |
|
| https://github.com/RafaelGSS |
| http: do not leak error listeners | https://github.com/RafaelGSS/node/commit/532f4408921578d17b27b3882365cbc9fffce202 |
| 532f440 | https://github.com/RafaelGSS/node/commit/532f4408921578d17b27b3882365cbc9fffce202 |
| nodejs#43587 | https://github.com/nodejs/node/pull/43587 |
| nodejs#43548 | https://github.com/nodejs/node/issues/43548 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 11, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1275202065 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/dougwilson |
| dougwilson | https://github.com/dougwilson |
| Oct 11, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1275209036 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Oct 11, 2022 | https://github.com/nodejs/node/pull/43587#issuecomment-1275210784 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Oct 12, 2022
| https://github.com/nodejs/node/pull/43587#ref-commit-7c06eab |
|
| https://github.com/lpinca |
| Revert "http: do not leak error listeners" | https://github.com/nodejs/node/commit/7c06eab1dce3b8f05546b9dc13d3969a12d0ba2e |
| 7c06eab | https://github.com/nodejs/node/commit/7c06eab1dce3b8f05546b9dc13d3969a12d0ba2e |
| 736a7d8 | https://github.com/nodejs/node/commit/736a7d8d60acdcf3274ae160fadefbbbbe4e4311 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272092166 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272094883 |
| #44921 | https://github.com/nodejs/node/pull/44921 |
| danielleadams | https://github.com/danielleadams |
|
Dec 30, 2022
| https://github.com/nodejs/node/pull/43587#ref-commit-943e172 |
|
| https://github.com/lpinca |
|
| https://github.com/danielleadams |
| Revert "http: do not leak error listeners" | https://github.com/nodejs/node/commit/943e172c442ab1be67da72c31d778a40a3cb6052 |
| 943e172 | https://github.com/nodejs/node/commit/943e172c442ab1be67da72c31d778a40a3cb6052 |
| 736a7d8 | https://github.com/nodejs/node/commit/736a7d8d60acdcf3274ae160fadefbbbbe4e4311 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272092166 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272094883 |
| #44921 | https://github.com/nodejs/node/pull/44921 |
| danielleadams | https://github.com/danielleadams |
|
Jan 3, 2023
| https://github.com/nodejs/node/pull/43587#ref-commit-2882e60 |
|
| https://github.com/lpinca |
|
| https://github.com/danielleadams |
| Revert "http: do not leak error listeners" | https://github.com/nodejs/node/commit/2882e6042e67eebf848e79a29f61d16646c01a51 |
| 2882e60 | https://github.com/nodejs/node/commit/2882e6042e67eebf848e79a29f61d16646c01a51 |
| 736a7d8 | https://github.com/nodejs/node/commit/736a7d8d60acdcf3274ae160fadefbbbbe4e4311 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272092166 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1272094883 |
| #44921 | https://github.com/nodejs/node/pull/44921 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1396504318 |
| @dougwilson | https://github.com/dougwilson |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1397150850 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/jonathanong/ee-first/blob/master/index.js#L45 | https://github.com/jonathanong/ee-first/blob/master/index.js#L45 |
| https://github.com/jshttp/on-finished/blob/master/index.js#L96 | https://github.com/jshttp/on-finished/blob/master/index.js#L96 |
| @mcollina | https://github.com/mcollina |
| @mhdawson | https://github.com/mhdawson |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1397326763 |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1275165344 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1397410410 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 19, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1397522567 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jan 20, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1399046567 |
| @ShogunPanda | https://github.com/ShogunPanda |
| #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1397150850 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Jan 24, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1402001838 |
| @mcollina | https://github.com/mcollina |
| @lpinca | https://github.com/lpinca |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jan 24, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1402042926 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| http: do not leak error listeners #43587 (comment) | https://github.com/nodejs/node/pull/43587#issuecomment-1275195708 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/ShogunPanda |
| ShogunPanda | https://github.com/ShogunPanda |
| Feb 6, 2023 | https://github.com/nodejs/node/pull/43587#issuecomment-1419245039 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| @lpinca | https://github.com/lpinca |
| #46523 | https://github.com/nodejs/node/pull/46523 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Feb 6, 2023
| https://github.com/nodejs/node/pull/43587#ref-pullrequest-1572758666 |
|
events: add listener argument to listenerCount
#46523
| https://github.com/nodejs/node/pull/46523 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Feb 23, 2023
| https://github.com/nodejs/node/pull/43587#ref-pullrequest-1595247376 |
|
http: use listenerCount when adding noop event
#46769
| https://github.com/nodejs/node/pull/46769 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F43587 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/43587/files/f8244c0fa5485608c71d5de9ba2e3739dd3b1b6b |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/43587/files/275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0 |
|
| https://github.com/VoltrexKeyva |
|
VoltrexKeyva
| https://github.com/VoltrexKeyva |
|
| https://github.com/nodejs/node/pull/43587/files/f8244c0fa5485608c71d5de9ba2e3739dd3b1b6b |
|
| https://github.com/tonivj5 |
|
tonivj5
| https://github.com/tonivj5 |
|
| https://github.com/nodejs/node/pull/43587/files/f8244c0fa5485608c71d5de9ba2e3739dd3b1b6b |
|
| https://github.com/rickyes |
|
rickyes
| https://github.com/rickyes |
|
| https://github.com/nodejs/node/pull/43587/files/275bb101a23d9a47fc7ca4e85b9dfb5d2ab316d0 |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
Flooding requests results in memory leak
| https://github.com/nodejs/node/issues/43548 |
| Please reload this page | https://github.com/nodejs/node/pull/43587 |
|
| https://github.com/ShogunPanda |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mscdex |
|
| https://github.com/Slayer95 |
|
| https://github.com/BethGriggs |
|
| https://github.com/lpinca |
|
| https://github.com/dougwilson |
|
| https://github.com/mcollina |
|
| https://github.com/tonivj5 |
|
| https://github.com/rickyes |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |