René's URL Explorer Experiment


Title: url: revert "validate ipv4 part length" by aduh95 · Pull Request #42940 · nodejs/node · GitHub

Open Graph Title: url: revert "validate ipv4 part length" by aduh95 · Pull Request #42940 · nodejs/node

X Title: url: revert "validate ipv4 part length" by aduh95 · Pull Request #42940 · nodejs/node

Description: This reverts commit 87d0d7a. Refs: #42915 (comment)

Open Graph Description: This reverts commit 87d0d7a. Refs: #42915 (comment)

X Description: This reverts commit 87d0d7a. Refs: #42915 (comment)

Opengraph URL: https://github.com/nodejs/node/pull/42940

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c42b31b7-9570-40ce-0eec-fd516a97245d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7F2:34E8DF:A613C7:E86E84:696A1CBA
html-safe-nonce523b5dc2220e92d7563aca8d95b1f9961645726af5084c1604605ea58626d29d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0YyOjM0RThERjpBNjEzQzc6RTg2RTg0OjY5NkExQ0JBIiwidmlzaXRvcl9pZCI6Ijg0MTY1MjQ2ODM2MDIxNzMxMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0c213d1433da89cb2eafbaaec75fee69a2904efcc4e631bb71a24f2e43231112
hovercard-subject-tagpull_request:925304649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/42940/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/169b8967bdfd69714dbc88ed942f318e47118ad5b27ce036014e8abd2fd27b79/nodejs/node/pull/42940
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/169b8967bdfd69714dbc88ed942f318e47118ad5b27ce036014e8abd2fd27b79/nodejs/node/pull/42940
og:image:altThis reverts commit 87d0d7a. Refs: #42915 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/42940#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42940
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42940
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/42940
Reloadhttps://github.com/nodejs/node/pull/42940
Reloadhttps://github.com/nodejs/node/pull/42940
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/42940
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/42940
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/42940#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:revert-url-ipv4-fixhttps://github.com/aduh95/node/tree/revert-url-ipv4-fix
url: revert "validate ipv4 part length" https://github.com/nodejs/node/pull/42940#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:revert-url-ipv4-fixhttps://github.com/aduh95/node/tree/revert-url-ipv4-fix
Conversation 8 https://github.com/nodejs/node/pull/42940
Commits 2 https://github.com/nodejs/node/pull/42940/commits
Checks 0 https://github.com/nodejs/node/pull/42940/checks
Files changed https://github.com/nodejs/node/pull/42940/files
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
May 2, 2022https://github.com/nodejs/node/pull/42940#issue-1222595212
87d0d7ahttps://github.com/nodejs/node/commit/87d0d7a069b2a3ca1db1dd592a62db4645ba5d69
#42915 (comment)https://github.com/nodejs/node/pull/42915#issuecomment-1114585308
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
url: revert "validate ipv4 part length"https://github.com/nodejs/node/pull/42940/commits/05dcc02b1ef96f99f5c5c9d046fb97be7e4e3666
05dcc02https://github.com/nodejs/node/pull/42940/commits/05dcc02b1ef96f99f5c5c9d046fb97be7e4e3666
87d0d7ahttps://github.com/aduh95/node/commit/87d0d7a069b2a3ca1db1dd592a62db4645ba5d69
nodejs#42915https://github.com/nodejs/node/pull/42915
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
May 2, 2022https://github.com/nodejs/node/pull/42940#event-6531706116
https://github.com/targos
targoshttps://github.com/targos
May 2, 2022 https://github.com/nodejs/node/pull/42940#pullrequestreview-958825624
View reviewed changes https://github.com/nodejs/node/pull/42940/files/05dcc02b1ef96f99f5c5c9d046fb97be7e4e3666
targoshttps://github.com/targos
https://github.com/nodejs/node/pull/42940#pullrequestreview-958825624
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
aduh95https://github.com/aduh95
May 2, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1114622599
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
fixup! url: revert "validate ipv4 part length"https://github.com/nodejs/node/pull/42940/commits/7352d8b63207c07571a4139623867cae936e3808
7352d8bhttps://github.com/nodejs/node/pull/42940/commits/7352d8b63207c07571a4139623867cae936e3808
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
May 2, 2022 https://github.com/nodejs/node/pull/42940#pullrequestreview-958959484
View reviewed changes https://github.com/nodejs/node/pull/42940/files/7352d8b63207c07571a4139623867cae936e3808
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v18.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v18.x
May 2, 2022https://github.com/nodejs/node/pull/42940#event-6532895826
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 2, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1114764226
https://github.com/nodejs/node/blob/1d8a320a04d75b2143be0bc97b10dfcd9e64defa/doc/changelogs/CHANGELOG_V16.md#commits-3https://github.com/nodejs/node/blob/1d8a320a04d75b2143be0bc97b10dfcd9e64defa/doc/changelogs/CHANGELOG_V16.md#commits-3
6af3e34b6bhttps://github.com/nodejs/node/commit/6af3e34b6b
#40741https://github.com/nodejs/node/pull/40741
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/Trott
Trotthttps://github.com/Trott
May 2, 2022 https://github.com/nodejs/node/pull/42940#pullrequestreview-959026854
View reviewed changes https://github.com/nodejs/node/pull/42940/files/7352d8b63207c07571a4139623867cae936e3808
https://github.com/sepehrst
sepehrsthttps://github.com/sepehrst
May 2, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1114850591
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
aduh95https://github.com/aduh95
May 2, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1114887292
https://github.com/nodejs/node/labels/dont-land-on-v18.xhttps://github.com/nodejs/node/labels/dont-land-on-v18.x
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/nodejs
nodejshttps://github.com/nodejs
amusaber950https://github.com/amusaber950
May 2, 2022https://github.com/nodejs/node/pull/42940#event-6533851976
https://github.com/nodejs
nodejshttps://github.com/nodejs
amusaber950https://github.com/amusaber950
May 2, 2022https://github.com/nodejs/node/pull/42940#event-6533852559
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v14.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v14.x
May 3, 2022https://github.com/nodejs/node/pull/42940#event-6540265046
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 4, 2022https://github.com/nodejs/node/pull/42940#event-6552989953
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 4, 2022https://github.com/nodejs/node/pull/42940#event-6553017480
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 4, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1118028662
https://ci.nodejs.org/job/node-test-pull-request/43881/https://ci.nodejs.org/job/node-test-pull-request/43881/
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1118307018
https://ci.nodejs.org/job/node-test-pull-request/43885/https://ci.nodejs.org/job/node-test-pull-request/43885/
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 5, 2022https://github.com/nodejs/node/pull/42940#event-6555827730
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 5, 2022https://github.com/nodejs/node/pull/42940#event-6555847681
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
a3ff4bfhttps://github.com/nodejs/node/commit/a3ff4bfc667c864f3729b198e6ad1b0bfaa05683
May 5, 2022https://github.com/nodejs/node/pull/42940#event-6555848186
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2022https://github.com/nodejs/node/pull/42940#issuecomment-1118453048
a3ff4bfhttps://github.com/nodejs/node/commit/a3ff4bfc667c864f3729b198e6ad1b0bfaa05683
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
aduh95https://github.com/aduh95
May 5, 2022 11:49https://github.com/nodejs/node/pull/42940#event-6555890332
CI Reliability 2022-05-12 nodejs/reliability#273 https://github.com/nodejs/reliability/issues/273
CI Reliability 2022-05-12 nodejs/reliability#275 https://github.com/nodejs/reliability/issues/275
CI Reliability 2022-05-13 nodejs/reliability#276 https://github.com/nodejs/reliability/issues/276
https://github.com/F3n67u
F3n67uhttps://github.com/F3n67u
Jun 4, 2022 https://github.com/nodejs/node/pull/42940#ref-pullrequest-1245324680
test, url: update WHATWG URL parser to align with latest spec #43190 https://github.com/nodejs/node/pull/43190
danielleadamshttps://github.com/danielleadams
Jun 11, 2022 https://github.com/nodejs/node/pull/42940#ref-commit-8fc42d3
https://github.com/aduh95
https://github.com/danielleadams
url: revert "validate ipv4 part length"https://github.com/nodejs/node/commit/8fc42d31a5e0a9d1a0610744e2f39f66648e7a9d
8fc42d3https://github.com/nodejs/node/commit/8fc42d31a5e0a9d1a0610744e2f39f66648e7a9d
87d0d7ahttps://github.com/nodejs/node/commit/87d0d7a069b2a3ca1db1dd592a62db4645ba5d69
#42915https://github.com/nodejs/node/pull/42915
#42940https://github.com/nodejs/node/pull/42940
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Jun 11, 2022 https://github.com/nodejs/node/pull/42940#ref-pullrequest-1268367616
v18.4.0 proposal #43385 https://github.com/nodejs/node/pull/43385
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 14, 2022 https://github.com/nodejs/node/pull/42940#ref-pullrequest-1371690543
2022-10-18, Version 19.0.0 (Current) #44626 https://github.com/nodejs/node/pull/44626
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42940
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/42940/files/7352d8b63207c07571a4139623867cae936e3808
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/42940/files/05dcc02b1ef96f99f5c5c9d046fb97be7e4e3666
https://github.com/VoltrexKeyva
VoltrexKeyva https://github.com/VoltrexKeyva
https://github.com/nodejs/node/pull/42940/files/7352d8b63207c07571a4139623867cae936e3808
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
whatwg-url https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awhatwg-url
Please reload this pagehttps://github.com/nodejs/node/pull/42940
https://github.com/aduh95
https://github.com/addaleax
https://github.com/sepehrst
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/targos
https://github.com/VoltrexKeyva
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.