René's URL Explorer Experiment


Title: crypto: clean up parameter validation in HKDF by tniessen · Pull Request #42924 · nodejs/node · GitHub

Open Graph Title: crypto: clean up parameter validation in HKDF by tniessen · Pull Request #42924 · nodejs/node

X Title: crypto: clean up parameter validation in HKDF by tniessen · Pull Request #42924 · nodejs/node

Description: validateByteSource internally always calls toBuf, so reuse that value instead of calling toBuf both in validateParameters and in validateByteSource. Validate digest before key. This improves the er...

Open Graph Description: validateByteSource internally always calls toBuf, so reuse that value instead of calling toBuf both in validateParameters and in validateByteSource. Validate digest before key. This improves the er...

X Description: validateByteSource internally always calls toBuf, so reuse that value instead of calling toBuf both in validateParameters and in validateByteSource. Validate digest before key. This improves the er...

Opengraph URL: https://github.com/nodejs/node/pull/42924

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3e66bd3c-863e-6311-7aa4-b6159cf4e64c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2D8:2C2C4D:1DFED4D:2917E1F:696ABA7C
html-safe-nonce0e83a274353ab4640a7d746ea53b10a56c0debc013eca3d03c33fab6799a525d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkQ4OjJDMkM0RDoxREZFRDREOjI5MTdFMUY6Njk2QUJBN0MiLCJ2aXNpdG9yX2lkIjoiNTA4Nzg4OTk1OTUzMTc5MjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca65c45bfee6f1bfd0a2784b9e7b4724c9ce7479d79672a51847a15f1c2cfabc1
hovercard-subject-tagpull_request:924553273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/42924/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/11c8a0c1a2c3d521a97af1311815ca20c10f4c76ea8bddf09400a71c41330185/nodejs/node/pull/42924
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/11c8a0c1a2c3d521a97af1311815ca20c10f4c76ea8bddf09400a71c41330185/nodejs/node/pull/42924
og:image:altvalidateByteSource internally always calls toBuf, so reuse that value instead of calling toBuf both in validateParameters and in validateByteSource. Validate digest before key. This improves the er...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/42924#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/42924
Reloadhttps://github.com/nodejs/node/pull/42924
Reloadhttps://github.com/nodejs/node/pull/42924
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/42924
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/42924
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/42924#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-hkdf-validationhttps://github.com/tniessen/node/tree/crypto-hkdf-validation
crypto: clean up parameter validation in HKDF https://github.com/nodejs/node/pull/42924#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:crypto-hkdf-validationhttps://github.com/tniessen/node/tree/crypto-hkdf-validation
Conversation 9 https://github.com/nodejs/node/pull/42924
Commits 1 https://github.com/nodejs/node/pull/42924/commits
Checks 0 https://github.com/nodejs/node/pull/42924/checks
Files changed https://github.com/nodejs/node/pull/42924/files
Please reload this pagehttps://github.com/nodejs/node/pull/42924
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 30, 2022https://github.com/nodejs/node/pull/42924#issue-1221697617
Please reload this pagehttps://github.com/nodejs/node/pull/42924
https://github.com/tniessen
crypto: clean up parameter validation in HKDFhttps://github.com/nodejs/node/pull/42924/commits/852c0713287da658d47462c590d65597ed7bf754
852c071https://github.com/nodejs/node/pull/42924/commits/852c0713287da658d47462c590d65597ed7bf754
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
April 30, 2022 02:29https://github.com/nodejs/node/pull/42924#event-6527377341
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 30, 2022https://github.com/nodejs/node/pull/42924#issuecomment-1113895523
Please reload this pagehttps://github.com/nodejs/node/pull/42924
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 30, 2022https://github.com/nodejs/node/pull/42924#event-6527377630
https://github.com/tniessen
tniessenhttps://github.com/tniessen
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Apr 30, 2022https://github.com/nodejs/node/pull/42924#event-6527382821
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Apr 30, 2022https://github.com/nodejs/node/pull/42924#event-6527392476
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Apr 30, 2022https://github.com/nodejs/node/pull/42924#event-6527737233
https://github.com/panva
panvahttps://github.com/panva
Apr 30, 2022 https://github.com/nodejs/node/pull/42924#pullrequestreview-958466502
View reviewed changes https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
https://github.com/aduh95
aduh95https://github.com/aduh95
Apr 30, 2022 https://github.com/nodejs/node/pull/42924#pullrequestreview-958468164
View reviewed changes https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Apr 30, 2022 https://github.com/nodejs/node/pull/42924#pullrequestreview-958479554
View reviewed changes https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Apr 30, 2022https://github.com/nodejs/node/pull/42924#issuecomment-1113986777
#42741https://github.com/nodejs/node/issues/42741
Please reload this pagehttps://github.com/nodejs/node/pull/42924
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 30, 2022https://github.com/nodejs/node/pull/42924#issuecomment-1114008300
https://ci.nodejs.org/job/node-test-pull-request/43797/https://ci.nodejs.org/job/node-test-pull-request/43797/
Please reload this pagehttps://github.com/nodejs/node/pull/42924
https://github.com/lpinca
lpincahttps://github.com/lpinca
Apr 30, 2022 https://github.com/nodejs/node/pull/42924#pullrequestreview-958512627
View reviewed changes https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
CI Reliability 2022-05-01 nodejs/reliability#268 https://github.com/nodejs/reliability/issues/268
CI Reliability 2022-05-02 nodejs/reliability#269 https://github.com/nodejs/reliability/issues/269
https://github.com/himself65
himself65https://github.com/himself65
May 2, 2022 https://github.com/nodejs/node/pull/42924#pullrequestreview-958654733
View reviewed changes https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 2, 2022https://github.com/nodejs/node/pull/42924#event-6535147438
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 2, 2022https://github.com/nodejs/node/pull/42924#event-6535164494
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
75dbb86https://github.com/nodejs/node/commit/75dbb86c58d6abb1a0b1202381be019d8e8c5792
May 2, 2022https://github.com/nodejs/node/pull/42924#event-6535164921
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 2, 2022https://github.com/nodejs/node/pull/42924#issuecomment-1115168966
75dbb86https://github.com/nodejs/node/commit/75dbb86c58d6abb1a0b1202381be019d8e8c5792
Please reload this pagehttps://github.com/nodejs/node/pull/42924
CI Reliability 2022-05-03 nodejs/reliability#270 https://github.com/nodejs/reliability/issues/270
CI Reliability 2022-05-04 nodejs/reliability#271 https://github.com/nodejs/reliability/issues/271
CI Reliability 2022-05-05 nodejs/reliability#272 https://github.com/nodejs/reliability/issues/272
RafaelGSShttps://github.com/RafaelGSS
May 10, 2022 https://github.com/nodejs/node/pull/42924#ref-commit-183bcc0
https://github.com/tniessen
https://github.com/RafaelGSS
crypto: clean up parameter validation in HKDFhttps://github.com/nodejs/node/commit/183bcc069973dd2132fe844261ce051796bc9bea
183bcc0https://github.com/nodejs/node/commit/183bcc069973dd2132fe844261ce051796bc9bea
#42924https://github.com/nodejs/node/pull/42924
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
May 10, 2022 https://github.com/nodejs/node/pull/42924#ref-pullrequest-1231162812
v18.2.0 proposal #43036 https://github.com/nodejs/node/pull/43036
juanarbolhttps://github.com/juanarbol
May 31, 2022 https://github.com/nodejs/node/pull/42924#ref-commit-d2e6701
https://github.com/tniessen
https://github.com/juanarbol
crypto: clean up parameter validation in HKDFhttps://github.com/nodejs/node/commit/d2e67017263444ee4f4785ec7ae4a0d45f2c76bc
d2e6701https://github.com/nodejs/node/commit/d2e67017263444ee4f4785ec7ae4a0d45f2c76bc
#42924https://github.com/nodejs/node/pull/42924
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 31, 2022 https://github.com/nodejs/node/pull/42924#ref-pullrequest-1254411929
2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268 https://github.com/nodejs/node/pull/43268
danielleadamshttps://github.com/danielleadams
Jun 27, 2022 https://github.com/nodejs/node/pull/42924#ref-commit-59bac0a
https://github.com/tniessen
https://github.com/danielleadams
crypto: clean up parameter validation in HKDFhttps://github.com/nodejs/node/commit/59bac0a319fcaf8485422035bacbc895a89a01e9
59bac0ahttps://github.com/nodejs/node/commit/59bac0a319fcaf8485422035bacbc895a89a01e9
#42924https://github.com/nodejs/node/pull/42924
targoshttps://github.com/targos
Jul 12, 2022 https://github.com/nodejs/node/pull/42924#ref-commit-0038348
https://github.com/tniessen
https://github.com/targos
crypto: clean up parameter validation in HKDFhttps://github.com/nodejs/node/commit/003834814ac4cb534d9a3181e57b0e310cc28dfa
0038348https://github.com/nodejs/node/commit/003834814ac4cb534d9a3181e57b0e310cc28dfa
#42924https://github.com/nodejs/node/pull/42924
targoshttps://github.com/targos
Jul 31, 2022 https://github.com/nodejs/node/pull/42924#ref-commit-baaf778
https://github.com/tniessen
https://github.com/targos
crypto: clean up parameter validation in HKDFhttps://github.com/nodejs/node/commit/baaf77898bbecae65a41437c445db3e5b1ad4e36
baaf778https://github.com/nodejs/node/commit/baaf77898bbecae65a41437c445db3e5b1ad4e36
#42924https://github.com/nodejs/node/pull/42924
https://github.com/targos
targoshttps://github.com/targos
Aug 3, 2022 https://github.com/nodejs/node/pull/42924#ref-pullrequest-1325821229
v16.17.0 release proposal #44098 https://github.com/nodejs/node/pull/44098
guangwonghttps://github.com/guangwong
Oct 10, 2022 https://github.com/nodejs/node/pull/42924#ref-commit-f785a83
https://github.com/tniessen
https://github.com/guangwong
crypto: clean up parameter validation in HKDFhttps://github.com/noslate-project/node/commit/f785a83f02e45ace139b4c284a17e53bcf2a44a3
f785a83https://github.com/noslate-project/node/commit/f785a83f02e45ace139b4c284a17e53bcf2a44a3
nodejs/node#42924https://github.com/nodejs/node/pull/42924
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42924
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/VoltrexKeyva
VoltrexKeyva https://github.com/VoltrexKeyva
https://github.com/nodejs/node/pull/42924/files/852c0713287da658d47462c590d65597ed7bf754
https://github.com/jasnell
jasnell https://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/42924
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/lpinca
https://github.com/himself65
https://github.com/aduh95
https://github.com/VoltrexKeyva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.