René's URL Explorer Experiment


Title: worker: fix stream & termination race bug by airtable-keyhanvakil · Pull Request #42874 · nodejs/node · GitHub

Open Graph Title: worker: fix stream & termination race bug by airtable-keyhanvakil · Pull Request #42874 · nodejs/node

X Title: worker: fix stream & termination race bug by airtable-keyhanvakil · Pull Request #42874 · nodejs/node

Description: OnStreamAfterReqFinished uses v8::Object::Has to check if it needs to call oncomplete. v8::Object::Has needs to execute Javascript. However when worker threads are involved, OnStreamAfterReqFinishe...

Open Graph Description: OnStreamAfterReqFinished uses v8::Object::Has to check if it needs to call oncomplete. v8::Object::Has needs to execute Javascript. However when worker threads are involved, OnStreamAfterReqFinishe...

X Description: OnStreamAfterReqFinished uses v8::Object::Has to check if it needs to call oncomplete. v8::Object::Has needs to execute Javascript. However when worker threads are involved, OnStreamAfterReqFinishe...

Opengraph URL: https://github.com/nodejs/node/pull/42874

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b4d9ad79-142e-0714-73b0-411aa8b63b97
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1A0:164E7F:8C1A12:BD4A4A:696AB63F
html-safe-nonce449c26a2b5ab71360cc6c93e8bc24d313ee5dae3670174bb2fc04e7f77bc9730
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUEwOjE2NEU3Rjo4QzFBMTI6QkQ0QTRBOjY5NkFCNjNGIiwidmlzaXRvcl9pZCI6IjkxMDAzNjY2MTQ4MDczNjEwODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0c034c2dded8b4a7c39e186e124480da26b7428940d2e3566b1d185cbf9a721b
hovercard-subject-tagpull_request:918896746
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/42874/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d9b022ae88bcae02e40fb183d529c6c342fc947577148348ef784bf125e9f455/nodejs/node/pull/42874
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d9b022ae88bcae02e40fb183d529c6c342fc947577148348ef784bf125e9f455/nodejs/node/pull/42874
og:image:altOnStreamAfterReqFinished uses v8::Object::Has to check if it needs to call oncomplete. v8::Object::Has needs to execute Javascript. However when worker threads are involved, OnStreamAfterReqFinishe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameairtable-keyhanvakil
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/42874#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42874
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42874
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/42874
Reloadhttps://github.com/nodejs/node/pull/42874
Reloadhttps://github.com/nodejs/node/pull/42874
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/42874
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/42874
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/42874#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
airtable-keyhanvakil:fix-stream-worker-terminatehttps://github.com/airtable-keyhanvakil/node/tree/fix-stream-worker-terminate
worker: fix stream & termination race bug https://github.com/nodejs/node/pull/42874#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
airtable-keyhanvakil:fix-stream-worker-terminatehttps://github.com/airtable-keyhanvakil/node/tree/fix-stream-worker-terminate
Conversation 26 https://github.com/nodejs/node/pull/42874
Commits 5 https://github.com/nodejs/node/pull/42874/commits
Checks 0 https://github.com/nodejs/node/pull/42874/checks
Files changed https://github.com/nodejs/node/pull/42874/files
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
Apr 26, 2022https://github.com/nodejs/node/pull/42874#issue-1215352455
Please reload this pagehttps://github.com/nodejs/node/pull/42874
#38418https://github.com/nodejs/node/issues/38418
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
worker: fix stream racing with terminatehttps://github.com/nodejs/node/pull/42874/commits/d55ddfce3be534964817d766ea59588835d3b386
d55ddfchttps://github.com/nodejs/node/pull/42874/commits/d55ddfce3be534964817d766ea59588835d3b386
nodejs#38418https://github.com/nodejs/node/issues/38418
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 26, 2022https://github.com/nodejs/node/pull/42874#event-6495230829
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
Apr 26, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1109302797
https://github.com/Prinzhorn/electron-sigabrthttps://github.com/Prinzhorn/electron-sigabrt
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 26, 2022 https://github.com/nodejs/node/pull/42874#pullrequestreview-953626597
View reviewed changes https://github.com/nodejs/node/pull/42874/files
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/42874#pullrequestreview-953626597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/42874
src/stream_base.cchttps://github.com/nodejs/node/pull/42874/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
Apr 26, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1110034175
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
add testhttps://github.com/nodejs/node/pull/42874/commits/cf200b528142797d9e8c70bd510fdb40743ae50f
cf200b5https://github.com/nodejs/node/pull/42874/commits/cf200b528142797d9e8c70bd510fdb40743ae50f
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
force-pushedhttps://github.com/nodejs/node/compare/ce6ca470347566064500cbfe37b5f51b42721bf4..cf200b528142797d9e8c70bd510fdb40743ae50f
ce6ca47https://github.com/nodejs/node/commit/ce6ca470347566064500cbfe37b5f51b42721bf4
cf200b5https://github.com/nodejs/node/commit/cf200b528142797d9e8c70bd510fdb40743ae50f
Compare https://github.com/nodejs/node/compare/ce6ca470347566064500cbfe37b5f51b42721bf4..cf200b528142797d9e8c70bd510fdb40743ae50f
April 28, 2022 07:01https://github.com/nodejs/node/pull/42874#event-6512514359
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
Apr 28, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1111824534
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
linthttps://github.com/nodejs/node/pull/42874/commits/c57dd41f9980b888ae60f404915ea5a2a1a7ec16
c57dd41https://github.com/nodejs/node/pull/42874/commits/c57dd41f9980b888ae60f404915ea5a2a1a7ec16
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 30, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1114001032
node/deps/v8/src/api/api-inl.hhttps://github.com/nodejs/node/blob/02e0c174a485093c663201c2fd35c2ba481fa1ba/deps/v8/src/api/api-inl.h#L236-L242
02e0c17https://github.com/nodejs/node/commit/02e0c174a485093c663201c2fd35c2ba481fa1ba
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
May 2, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1115391552
node/lib/internal/worker.jshttps://github.com/nodejs/node/blob/ce29d2847b9996602e3b49523d2325aad206543c/lib/internal/worker.js#L360
ce29d28https://github.com/nodejs/node/commit/ce29d2847b9996602e3b49523d2325aad206543c
node/deps/v8/src/api/api.cchttps://github.com/nodejs/node/blob/ce29d2847b9996602e3b49523d2325aad206543c/deps/v8/src/api/api.cc#L8499
ce29d28https://github.com/nodejs/node/commit/ce29d2847b9996602e3b49523d2325aad206543c
node/deps/v8/src/execution/stack-guard.cchttps://github.com/nodejs/node/blob/ce29d2847b9996602e3b49523d2325aad206543c/deps/v8/src/execution/stack-guard.cc#L288
ce29d28https://github.com/nodejs/node/commit/ce29d2847b9996602e3b49523d2325aad206543c
node/deps/v8/src/execution/isolate.cchttps://github.com/nodejs/node/blob/ce29d2847b9996602e3b49523d2325aad206543c/deps/v8/src/execution/isolate.cc#L1611
ce29d28https://github.com/nodejs/node/commit/ce29d2847b9996602e3b49523d2325aad206543c
https://github.com/nodejs/node/blob/master/src/README.md#calling-into-javascripthttps://github.com/nodejs/node/blob/master/src/README.md#calling-into-javascript
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 3, 2022 https://github.com/nodejs/node/pull/42874#pullrequestreview-960253407
View reviewed changes https://github.com/nodejs/node/pull/42874/files/c57dd41f9980b888ae60f404915ea5a2a1a7ec16
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/42874#pullrequestreview-960253407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#42910https://github.com/nodejs/node/pull/42910
Please reload this pagehttps://github.com/nodejs/node/pull/42874
src/stream_base.cchttps://github.com/nodejs/node/pull/42874/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19
Please reload this pagehttps://github.com/nodejs/node/pull/42874
test/parallel/test-worker-http2-stream-terminate.jshttps://github.com/nodejs/node/pull/42874/files/c57dd41f9980b888ae60f404915ea5a2a1a7ec16#diff-eb6102dc46b7d17dda14cb1fb4e8358861fdd6cba1aab0553c3773773edd3b15
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 3, 2022 https://github.com/nodejs/node/pull/42874#ref-pullrequest-1220910417
fs: don't end fs promises on Isolate termination #42910 https://github.com/nodejs/node/pull/42910
https://github.com/airtable-keyhanvakil
follow RaisinTen's suggestionshttps://github.com/nodejs/node/pull/42874/commits/b17b64f816c70d49cc7c063345a617c1622d0b90
b17b64fhttps://github.com/nodejs/node/pull/42874/commits/b17b64f816c70d49cc7c063345a617c1622d0b90
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
May 3, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1116332096
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 4, 2022 https://github.com/nodejs/node/pull/42874#pullrequestreview-961322569
View reviewed changes https://github.com/nodejs/node/pull/42874/files/b17b64f816c70d49cc7c063345a617c1622d0b90
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/42874#pullrequestreview-961322569
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42874
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 4, 2022https://github.com/nodejs/node/pull/42874#event-6545708361
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 4, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1117252880
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 4, 2022 https://github.com/nodejs/node/pull/42874#pullrequestreview-962001575
View reviewed changes https://github.com/nodejs/node/pull/42874/files/b17b64f816c70d49cc7c063345a617c1622d0b90
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 4, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1117421647
https://ci.nodejs.org/job/node-test-pull-request/43878/https://ci.nodejs.org/job/node-test-pull-request/43878/
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
May 5, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1118060099
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25122/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25122/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25114/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25114/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1118456366
https://ci.nodejs.org/job/node-test-pull-request/43891/https://ci.nodejs.org/job/node-test-pull-request/43891/
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
May 5, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1118767105
common.platformTimeout()https://github.com/nodejs/node/tree/master/test/common#platformtimeoutms
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/richardlau
richardlauhttps://github.com/richardlau
May 5, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1118779427
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25122/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25122/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25114/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25114/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
fix node-test-commit-custom-suites-freestyle failurehttps://github.com/nodejs/node/pull/42874/commits/a7bdb8e036960a85aa4f1a64a472db06ff80128c
a7bdb8ehttps://github.com/nodejs/node/pull/42874/commits/a7bdb8e036960a85aa4f1a64a472db06ff80128c
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
May 5, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1119135530
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25122/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25122/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25114/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/25114/testReport/junit/(root)/test/parallel_test_worker_http2_stream_terminate/
https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/
#42910https://github.com/nodejs/node/pull/42910
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1119583738
https://ci.nodejs.org/job/node-test-pull-request/43900/https://ci.nodejs.org/job/node-test-pull-request/43900/
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1119754770
https://ci.nodejs.org/job/node-test-pull-request/43904/https://ci.nodejs.org/job/node-test-pull-request/43904/
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
May 6, 2022https://github.com/nodejs/node/pull/42874#event-6566440289
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2022https://github.com/nodejs/node/pull/42874#event-6566468268
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
0fc1cf4https://github.com/nodejs/node/commit/0fc1cf478f7a448241791f5cf2c25f2d45bfd5b5
May 6, 2022https://github.com/nodejs/node/pull/42874#event-6566468513
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1120041287
0fc1cf4https://github.com/nodejs/node/commit/0fc1cf478f7a448241791f5cf2c25f2d45bfd5b5
Please reload this pagehttps://github.com/nodejs/node/pull/42874
RafaelGSShttps://github.com/RafaelGSS
May 10, 2022 https://github.com/nodejs/node/pull/42874#ref-commit-5470578
https://github.com/airtable-keyhanvakil
https://github.com/RafaelGSS
worker: fix stream racing with terminatehttps://github.com/nodejs/node/commit/5470578008023f426f0ace07a192c81256c889d9
5470578https://github.com/nodejs/node/commit/5470578008023f426f0ace07a192c81256c889d9
#38418https://github.com/nodejs/node/issues/38418
#42874https://github.com/nodejs/node/pull/42874
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
May 10, 2022 https://github.com/nodejs/node/pull/42874#ref-pullrequest-1231162812
v18.2.0 proposal #43036 https://github.com/nodejs/node/pull/43036
CI Reliability 2022-05-12 nodejs/reliability#273 https://github.com/nodejs/reliability/issues/273
CI Reliability 2022-05-12 nodejs/reliability#275 https://github.com/nodejs/reliability/issues/275
CI Reliability 2022-05-13 nodejs/reliability#276 https://github.com/nodejs/reliability/issues/276
CI Reliability 2022-05-14 nodejs/reliability#277 https://github.com/nodejs/reliability/issues/277
juanarbolhttps://github.com/juanarbol
May 31, 2022 https://github.com/nodejs/node/pull/42874#ref-commit-e62d8e6
https://github.com/airtable-keyhanvakil
https://github.com/juanarbol
worker: fix stream racing with terminatehttps://github.com/nodejs/node/commit/e62d8e6f3150dd5a8d9e2b9b56e62365eb0d73e3
e62d8e6https://github.com/nodejs/node/commit/e62d8e6f3150dd5a8d9e2b9b56e62365eb0d73e3
#38418https://github.com/nodejs/node/issues/38418
#42874https://github.com/nodejs/node/pull/42874
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 31, 2022 https://github.com/nodejs/node/pull/42874#ref-pullrequest-1254411929
2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268 https://github.com/nodejs/node/pull/43268
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
Jun 4, 2022 https://github.com/nodejs/node/pull/42874#ref-issue-1259225467
FATAL ERROR: v8::FromJust Maybe value is Nothing #43304 https://github.com/nodejs/node/issues/43304
danielleadamshttps://github.com/danielleadams
Jun 27, 2022 https://github.com/nodejs/node/pull/42874#ref-commit-6fe149f
https://github.com/airtable-keyhanvakil
https://github.com/danielleadams
worker: fix stream racing with terminatehttps://github.com/nodejs/node/commit/6fe149f8f0c3a26ae5a36845c469f4d7316016e9
6fe149fhttps://github.com/nodejs/node/commit/6fe149f8f0c3a26ae5a36845c469f4d7316016e9
#38418https://github.com/nodejs/node/issues/38418
#42874https://github.com/nodejs/node/pull/42874
https://github.com/dapplion
dapplionhttps://github.com/dapplion
Jun 29, 2022 https://github.com/nodejs/node/pull/42874#ref-issue-1267665754
FATAL ERROR: v8::FromJust Maybe value is Nothing. ChainSafe/lodestar#4145 https://github.com/ChainSafe/lodestar/issues/4145
https://github.com/ashishchandr70
ashishchandr70https://github.com/ashishchandr70
Jul 6, 2022 https://github.com/nodejs/node/pull/42874#ref-issue-1296115945
FATAL ERROR: v8::FromJust Maybe value is Nothing. andywer/threads.js#436 https://github.com/andywer/threads.js/issues/436
https://github.com/airtable-keyhanvakil
airtable-keyhanvakilhttps://github.com/airtable-keyhanvakil
Jul 6, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1176519636
#43304https://github.com/nodejs/node/issues/43304
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 6, 2022https://github.com/nodejs/node/pull/42874#issuecomment-1176581788
node/doc/contributing/backporting-to-release-lines.mdhttps://github.com/nodejs/node/blob/a0440c9174dd5510f24011c325bf5c169380e1a2/doc/contributing/backporting-to-release-lines.md#L19-L25
a0440c9https://github.com/nodejs/node/commit/a0440c9174dd5510f24011c325bf5c169380e1a2
https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-requesthttps://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-request
Please reload this pagehttps://github.com/nodejs/node/pull/42874
targoshttps://github.com/targos
Jul 12, 2022 https://github.com/nodejs/node/pull/42874#ref-commit-172cffb
https://github.com/airtable-keyhanvakil
https://github.com/targos
worker: fix stream racing with terminatehttps://github.com/nodejs/node/commit/172cffb341f5e6a9160aa2e9329598bec7dced13
172cffbhttps://github.com/nodejs/node/commit/172cffb341f5e6a9160aa2e9329598bec7dced13
#38418https://github.com/nodejs/node/issues/38418
#42874https://github.com/nodejs/node/pull/42874
targoshttps://github.com/targos
Jul 31, 2022 https://github.com/nodejs/node/pull/42874#ref-commit-c583508
https://github.com/airtable-keyhanvakil
https://github.com/targos
worker: fix stream racing with terminatehttps://github.com/nodejs/node/commit/c58350832490dd502f0107f6d5b590129519094c
c583508https://github.com/nodejs/node/commit/c58350832490dd502f0107f6d5b590129519094c
#38418https://github.com/nodejs/node/issues/38418
#42874https://github.com/nodejs/node/pull/42874
https://github.com/targos
targoshttps://github.com/targos
Aug 3, 2022 https://github.com/nodejs/node/pull/42874#ref-pullrequest-1325821229
v16.17.0 release proposal #44098 https://github.com/nodejs/node/pull/44098
feat: use child_process for --no-threads vitest-dev/vitest#1790 https://github.com/vitest-dev/vitest/pull/1790
Node Error FATAL ERROR: v8::FromJust Maybe value is Nothing, on Windows (local) and CI build (Linux) vitest-dev/vitest#1191 https://github.com/vitest-dev/vitest/issues/1191
https://github.com/tony19
tony19https://github.com/tony19
Aug 9, 2022 https://github.com/nodejs/node/pull/42874#ref-issue-1288552332
Check failed: result.second #43617 https://github.com/nodejs/node/issues/43617
https://github.com/edwardstumpf
edwardstumpfhttps://github.com/edwardstumpf
Aug 16, 2022 https://github.com/nodejs/node/pull/42874#ref-issue-1209035360
Running tests crashes node w/ JSDOM and vue 2 vite plugin vitest-dev/vitest#1171 https://github.com/vitest-dev/vitest/issues/1171
https://github.com/tony19
tony19https://github.com/tony19
Aug 17, 2022 https://github.com/nodejs/node/pull/42874#ref-pullrequest-1326703162
ci: retry flaky tests vitejs/vite#9508 https://github.com/vitejs/vite/pull/9508
guangwonghttps://github.com/guangwong
Oct 10, 2022 https://github.com/nodejs/node/pull/42874#ref-commit-f4e18cb
https://github.com/airtable-keyhanvakil
https://github.com/guangwong
worker: fix stream racing with terminatehttps://github.com/noslate-project/node/commit/f4e18cb31c99934403c4d28b02f3422cd7e2fc9f
f4e18cbhttps://github.com/noslate-project/node/commit/f4e18cb31c99934403c4d28b02f3422cd7e2fc9f
nodejs/node#38418https://github.com/nodejs/node/issues/38418
nodejs/node#42874https://github.com/nodejs/node/pull/42874
https://github.com/Cherry
Cherryhttps://github.com/Cherry
Oct 23, 2023 https://github.com/nodejs/node/pull/42874#ref-pullrequest-1957877118
bump min node version to 16.18 to improve tests flakiness cloudflare/workers-sdk#4266 https://github.com/cloudflare/workers-sdk/pull/4266
https://github.com/polamjag
polamjaghttps://github.com/polamjag
Jan 6, 2025 https://github.com/nodejs/node/pull/42874#ref-issue-2769491788
Node.js 14 x MacOS CI failure prettier/prettier#16964 https://github.com/prettier/prettier/issues/16964
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42874
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/42874/files/b17b64f816c70d49cc7c063345a617c1622d0b90
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/42874/files/a7bdb8e036960a85aa4f1a64a472db06ff80128c
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/42874/files/b17b64f816c70d49cc7c063345a617c1622d0b90
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Calling worker.terminate() while http/2 reads on a stream crashes the whole process with FATAL ERROR / SIGABRT https://github.com/nodejs/node/issues/38418
Please reload this pagehttps://github.com/nodejs/node/pull/42874
https://github.com/airtable-keyhanvakil
https://github.com/RaisinTen
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/aduh95
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.