René's URL Explorer Experiment


Title: doc: suggest checkHost in checkServerIdentity docs by tniessen · Pull Request #42495 · nodejs/node · GitHub

Open Graph Title: doc: suggest checkHost in checkServerIdentity docs by tniessen · Pull Request #42495 · nodejs/node

X Title: doc: suggest checkHost in checkServerIdentity docs by tniessen · Pull Request #42495 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: checkServerIdentity is incompatible with X509Certificate. Applications that already use X509Certificate should use x509.checkHost instead. Refs: #42470

X Description: checkServerIdentity is incompatible with X509Certificate. Applications that already use X509Certificate should use x509.checkHost instead. Refs: #42470

Opengraph URL: https://github.com/nodejs/node/pull/42495

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8a47dcf3-1fe1-56f5-0284-b9d626085279
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8198:C8434:B522A4:EBF81E:6AED4634
html-safe-nonce3f926aa1185d518e3a62187f07fb9effc53926225bd790a07e7d11009f655466
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTk4OkM4NDM0OkI1MjJBNDpFQkY4MUU6NkFFRDQ2MzQiLCJ2aXNpdG9yX2lkIjoiNzQyMjk5NTEwNjIwNjkyNjM4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5244354a4c430d36f79a517f2c514b80563555a7fba68f32412708f73f017463
hovercard-subject-tagpull_request:891072880
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/42495/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/55581e9e060b56735e57fcac2bc5aa1398fa5cde5587e6d1d417bfd8d6e4c3c1/nodejs/node/pull/42495
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55581e9e060b56735e57fcac2bc5aa1398fa5cde5587e6d1d417bfd8d6e4c3c1/nodejs/node/pull/42495
og:image:altcheckServerIdentity is incompatible with X509Certificate. Applications that already use X509Certificate should use x509.checkHost instead. Refs: #42470
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/42495#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42495
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42495
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/42495
Reloadhttps://github.com/nodejs/node/pull/42495
Reloadhttps://github.com/nodejs/node/pull/42495
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:doc-tls-checkserveridentity-recommend-checkhosthttps://github.com/tniessen/node/tree/doc-tls-checkserveridentity-recommend-checkhost
Conversationhttps://github.com/nodejs/node/pull/42495
Commits1 (1)https://github.com/nodejs/node/pull/42495/commits
Checkshttps://github.com/nodejs/node/pull/42495/checks
Files changedhttps://github.com/nodejs/node/pull/42495/files
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/pull/42495#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:doc-tls-checkserveridentity-recommend-checkhosthttps://github.com/tniessen/node/tree/doc-tls-checkserveridentity-recommend-checkhost
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 27, 2022https://github.com/nodejs/node/pull/42495#issue-1182577821
#42470https://github.com/nodejs/node/pull/42470
Please reload this pagehttps://github.com/nodejs/node/pull/42495
https://github.com/tniessen
tniessenhttps://github.com/tniessen
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Mar 27, 2022https://github.com/nodejs/node/pull/42495#event-6313909877
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Mar 27, 2022 https://github.com/nodejs/node/pull/42495#ref-pullrequest-1181317330
tls: fix reference to certificate object subjectAltName in checkServerIdentity function #42470 https://github.com/nodejs/node/pull/42470
https://github.com/tniessen
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/pull/42495/commits/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
1766dd4https://github.com/nodejs/node/pull/42495/commits/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
nodejs#42470https://github.com/nodejs/node/pull/42470
https://github.com/tniessen
tniessenhttps://github.com/tniessen
force-pushedhttps://github.com/nodejs/node/compare/d85dd8da3558852aaed051cf83a4970222b4b6dd..1766dd4f5c84d8aa5dd973c49d1455630957d4e0
d85dd8dhttps://github.com/nodejs/node/commit/d85dd8da3558852aaed051cf83a4970222b4b6dd
1766dd4https://github.com/nodejs/node/commit/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
Compare https://github.com/nodejs/node/compare/d85dd8da3558852aaed051cf83a4970222b4b6dd..1766dd4f5c84d8aa5dd973c49d1455630957d4e0
March 27, 2022 16:17https://github.com/nodejs/node/pull/42495#event-6313927596
https://github.com/lpinca
lpincahttps://github.com/lpinca
Mar 27, 2022 https://github.com/nodejs/node/pull/42495#pullrequestreview-922485191
View reviewed changes https://github.com/nodejs/node/pull/42495/files/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Mar 27, 2022https://github.com/nodejs/node/pull/42495#event-6314181562
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
March 27, 2022 20:06https://github.com/nodejs/node/pull/42495#event-6314181750
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 28, 2022 https://github.com/nodejs/node/pull/42495#pullrequestreview-922601595
View reviewed changes https://github.com/nodejs/node/pull/42495/files/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
https://github.com/tniessen
tniessenhttps://github.com/tniessen
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 29, 2022https://github.com/nodejs/node/pull/42495#event-6328368906
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 29, 2022https://github.com/nodejs/node/pull/42495#event-6328398746
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 29, 2022https://github.com/nodejs/node/pull/42495#issuecomment-1082136797
https://github.com/nodejs/node/actions/runs/2059960893https://github.com/nodejs/node/actions/runs/2059960893
Please reload this pagehttps://github.com/nodejs/node/pull/42495
https://github.com/tniessen
tniessenhttps://github.com/tniessen
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Mar 29, 2022https://github.com/nodejs/node/pull/42495#event-6328685764
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Mar 29, 2022https://github.com/nodejs/node/pull/42495#event-6328739276
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
1000eb1https://github.com/nodejs/node/commit/1000eb168a06cc4403454c48dd1a2f8bdfd60275
Mar 29, 2022https://github.com/nodejs/node/pull/42495#event-6328739807
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 29, 2022https://github.com/nodejs/node/pull/42495#issuecomment-1082200628
1000eb1https://github.com/nodejs/node/commit/1000eb168a06cc4403454c48dd1a2f8bdfd60275
Please reload this pagehttps://github.com/nodejs/node/pull/42495
juanarbolhttps://github.com/juanarbol
Apr 4, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-369cc06
https://github.com/tniessen
https://github.com/juanarbol
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/369cc0660eab99fbff05359a4933741f34af4e58
369cc06https://github.com/nodejs/node/commit/369cc0660eab99fbff05359a4933741f34af4e58
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
juanarbolhttps://github.com/juanarbol
Apr 5, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-9e14b0e
https://github.com/tniessen
https://github.com/juanarbol
doc: suggest checkHost in checkServerIdentity docshttps://github.com/juanarbol/node/commit/9e14b0efc25e63cfe5d4e346bee1463156901c00
9e14b0ehttps://github.com/juanarbol/node/commit/9e14b0efc25e63cfe5d4e346bee1463156901c00
nodejs#42470https://github.com/nodejs/node/pull/42470
nodejs#42495https://github.com/nodejs/node/pull/42495
V17.8.1 proposal #42612 https://github.com/nodejs/node/pull/42612
v17.9.0 proposal #42613 https://github.com/nodejs/node/pull/42613
juanarbolhttps://github.com/juanarbol
Apr 6, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-6c13988
https://github.com/tniessen
https://github.com/juanarbol
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/6c13988d534a213bd7f40f97301018e324c67e1d
6c13988https://github.com/nodejs/node/commit/6c13988d534a213bd7f40f97301018e324c67e1d
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
xtx1130https://github.com/xtx1130
Apr 25, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-e42f4a0
https://github.com/tniessen
https://github.com/xtx1130
doc: suggest checkHost in checkServerIdentity docshttps://github.com/xtx1130/node/commit/e42f4a0d96a0adc2d2aad1c7612c96a3625e9cf5
e42f4a0https://github.com/xtx1130/node/commit/e42f4a0d96a0adc2d2aad1c7612c96a3625e9cf5
nodejs#42470https://github.com/nodejs/node/pull/42470
nodejs#42495https://github.com/nodejs/node/pull/42495
juanarbolhttps://github.com/juanarbol
May 31, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-54fc810
https://github.com/tniessen
https://github.com/juanarbol
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/54fc810af2edc805dcfddc3fe7493f86036c7832
54fc810https://github.com/nodejs/node/commit/54fc810af2edc805dcfddc3fe7493f86036c7832
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
May 31, 2022 https://github.com/nodejs/node/pull/42495#ref-pullrequest-1254411929
2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268 https://github.com/nodejs/node/pull/43268
danielleadamshttps://github.com/danielleadams
Jun 27, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-18814d4
https://github.com/tniessen
https://github.com/danielleadams
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/18814d485f455b9d1072448ae425eea4f19c1304
18814d4https://github.com/nodejs/node/commit/18814d485f455b9d1072448ae425eea4f19c1304
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
targoshttps://github.com/targos
Jul 11, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-278e0d0
https://github.com/tniessen
https://github.com/targos
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/278e0d0b3deac27e9ea5d6d10400324946d7dd8b
278e0d0https://github.com/nodejs/node/commit/278e0d0b3deac27e9ea5d6d10400324946d7dd8b
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
targoshttps://github.com/targos
Jul 11, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-0868510
https://github.com/tniessen
https://github.com/targos
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/0868510faf61c08106c35b0293ac612e129bccd4
0868510https://github.com/nodejs/node/commit/0868510faf61c08106c35b0293ac612e129bccd4
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
targoshttps://github.com/targos
Jul 31, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-37366d4
https://github.com/tniessen
https://github.com/targos
doc: suggest checkHost in checkServerIdentity docshttps://github.com/nodejs/node/commit/37366d4ec44b2bfd91914712f0bce34da6fb1afe
37366d4https://github.com/nodejs/node/commit/37366d4ec44b2bfd91914712f0bce34da6fb1afe
#42470https://github.com/nodejs/node/pull/42470
#42495https://github.com/nodejs/node/pull/42495
https://github.com/targos
targoshttps://github.com/targos
Aug 3, 2022 https://github.com/nodejs/node/pull/42495#ref-pullrequest-1325821229
v16.17.0 release proposal #44098 https://github.com/nodejs/node/pull/44098
guangwonghttps://github.com/guangwong
Oct 10, 2022 https://github.com/nodejs/node/pull/42495#ref-commit-8348499
https://github.com/tniessen
https://github.com/guangwong
doc: suggest checkHost in checkServerIdentity docshttps://github.com/noslate-project/node/commit/83484993f6decce59dbe3b2070f02ebbcc3f9229
8348499https://github.com/noslate-project/node/commit/83484993f6decce59dbe3b2070f02ebbcc3f9229
nodejs/node#42470https://github.com/nodejs/node/pull/42470
nodejs/node#42495https://github.com/nodejs/node/pull/42495
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42495
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/42495/files/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/42495/files/1766dd4f5c84d8aa5dd973c49d1455630957d4e0
https://github.com/jasnell
jasnell https://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/42495
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/42495
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.