René's URL Explorer Experiment


Title: tls: fix reference to certificate object subjectAltName in checkServerIdentity function by bnielsen1965 · Pull Request #42470 · nodejs/node · GitHub

Open Graph Title: tls: fix reference to certificate object subjectAltName in checkServerIdentity function by bnielsen1965 · Pull Request #42470 · nodejs/node

X Title: tls: fix reference to certificate object subjectAltName in checkServerIdentity function by bnielsen1965 · Pull Request #42470 · nodejs/node

Description: tls: fix reference to certificate object subjectAltName in checkServerIdentity function The checkServerIdentify() function always fails with ERR_TLS_CERT_ALTNAME_INVALID error due to a bad reference to the certificate object's subjectAltName property. Changed the property reference from all lowercase to camelcase.

Open Graph Description: tls: fix reference to certificate object subjectAltName in checkServerIdentity function The checkServerIdentify() function always fails with ERR_TLS_CERT_ALTNAME_INVALID error due to a bad referenc...

X Description: tls: fix reference to certificate object subjectAltName in checkServerIdentity function The checkServerIdentify() function always fails with ERR_TLS_CERT_ALTNAME_INVALID error due to a bad referenc...

Opengraph URL: https://github.com/nodejs/node/pull/42470

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40c4002d-1399-26b8-872d-2e38d304a187
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA5C:1258EF:FC0BB2:149CF0C:6AED5E93
html-safe-nonce2d418b9168c5341661f29d9f017c501323e92bae2594e8a88ceccd7fca7428e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTVDOjEyNThFRjpGQzBCQjI6MTQ5Q0YwQzo2QUVENUU5MyIsInZpc2l0b3JfaWQiOiIyNTkzNTk1ODM0MDQwNjcxODkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1d84f85573f38db012433dae629ba4a96f8be68dead8efd0203f16e5a7c0a386
hovercard-subject-tagpull_request:889946639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/42470/files
twitter:imagehttps://avatars.githubusercontent.com/u/486139?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/486139?s=400&v=4
og:image:alttls: fix reference to certificate object subjectAltName in checkServerIdentity function The checkServerIdentify() function always fails with ERR_TLS_CERT_ALTNAME_INVALID error due to a bad referenc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/42470/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42470%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F42470%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/42470/files
Reloadhttps://github.com/nodejs/node/pull/42470/files
Reloadhttps://github.com/nodejs/node/pull/42470/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
bnielsen1965https://github.com/bnielsen1965
nodejs:mainhttps://github.com/nodejs/node/tree/main
bnielsen1965:masterhttps://github.com/bnielsen1965/node/tree/master
Conversation 15 https://github.com/nodejs/node/pull/42470
Commits 2 https://github.com/nodejs/node/pull/42470/commits
Checks 6 https://github.com/nodejs/node/pull/42470/checks
Files changed https://github.com/nodejs/node/pull/42470/files
Please reload this pagehttps://github.com/nodejs/node/pull/42470/files
tls: fix reference to certificate object subjectAltName in checkServerIdentity function https://github.com/nodejs/node/pull/42470/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/42470/files
fb9607f tls: fix reference to certificate object subjectAltName in checkServe… bnielsen1965 Mar 25, 2022 https://github.com/nodejs/node/pull/42470/commits/fb9607f866e64927555e133f9624da2f5c89c8fd
8329b8b tls: fix reference to certificate object subjectAltName bnielsen1965 Mar 25, 2022 https://github.com/nodejs/node/pull/42470/commits/8329b8b2827de8f256301fdaf0f843d169642fc0
Clear filters https://github.com/nodejs/node/pull/42470/files
Please reload this pagehttps://github.com/nodejs/node/pull/42470/files
Please reload this pagehttps://github.com/nodejs/node/pull/42470/files
errors.md https://github.com/nodejs/node/pull/42470/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
tls.md https://github.com/nodejs/node/pull/42470/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
tls.js https://github.com/nodejs/node/pull/42470/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
env.h https://github.com/nodejs/node/pull/42470/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
test-https-foafssl.js https://github.com/nodejs/node/pull/42470/files#diff-3ad4e7a359fa02a4f8faf05963f9b3660f3c9adcbc44ffe6c6dc3bcaba6cb7c9
test-tls-0-dns-altname.js https://github.com/nodejs/node/pull/42470/files#diff-e4d596f1c4bdac3c468eae162174ddb314b2710881fcd36a60223dbd1caa4738
test-tls-check-server-identity.js https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
test-x509-escaping.js https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
doc/api/errors.mdhttps://github.com/nodejs/node/pull/42470/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/doc/api/errors.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
https://github.com/nodejs/node/pull/42470/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
doc/api/tls.mdhttps://github.com/nodejs/node/pull/42470/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/doc/api/tls.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/42470/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/42470/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
https://github.com/nodejs/node/pull/42470/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7de
lib/tls.jshttps://github.com/nodejs/node/pull/42470/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/lib/tls.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
https://github.com/nodejs/node/pull/42470/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
src/env.hhttps://github.com/nodejs/node/pull/42470/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/src/env.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
https://github.com/nodejs/node/pull/42470/files#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
test/parallel/test-https-foafssl.jshttps://github.com/nodejs/node/pull/42470/files#diff-3ad4e7a359fa02a4f8faf05963f9b3660f3c9adcbc44ffe6c6dc3bcaba6cb7c9
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/test/parallel/test-https-foafssl.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-3ad4e7a359fa02a4f8faf05963f9b3660f3c9adcbc44ffe6c6dc3bcaba6cb7c9
https://github.com/nodejs/node/pull/42470/files#diff-3ad4e7a359fa02a4f8faf05963f9b3660f3c9adcbc44ffe6c6dc3bcaba6cb7c9
test/parallel/test-tls-0-dns-altname.jshttps://github.com/nodejs/node/pull/42470/files#diff-e4d596f1c4bdac3c468eae162174ddb314b2710881fcd36a60223dbd1caa4738
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/test/parallel/test-tls-0-dns-altname.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-e4d596f1c4bdac3c468eae162174ddb314b2710881fcd36a60223dbd1caa4738
https://github.com/nodejs/node/pull/42470/files#diff-e4d596f1c4bdac3c468eae162174ddb314b2710881fcd36a60223dbd1caa4738
test/parallel/test-tls-check-server-identity.jshttps://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/test/parallel/test-tls-check-server-identity.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
https://github.com/nodejs/node/pull/42470/files#diff-0770727273fc8b3d8183927eea4c96efcbf94a61852d8d242c28f0261cd49db2
test/parallel/test-x509-escaping.jshttps://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
View file https://github.com/bnielsen1965/node/blob/8329b8b2827de8f256301fdaf0f843d169642fc0/test/parallel/test-x509-escaping.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/42470/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com/nodejs/node/pull/42470/files#diff-5870fefa1338cab298bbb00fa19f2b7d47ba1f712b4ee3160aa09177e5a59da5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.