| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8fe98bcf-66fc-5ad7-d0a1-a4a6e8b08c9b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B00:35267D:7C3A0F:A9C0D4:6A4DB592 |
| html-safe-nonce | f5babdbcd4c7c172bf0e6bdf2e3a21881f41cd87b27aec4cef4785ca78286675 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjAwOjM1MjY3RDo3QzNBMEY6QTlDMEQ0OjZBNERCNTkyIiwidmlzaXRvcl9pZCI6IjYyMDI3ODA2MDgwNDY2NzUzNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c7b06752d45e9ead5f3ff3aad6b086b866cf0032e7111fec3336904f8aa35a62 |
| hovercard-subject-tag | pull_request:826691931 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41596/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b4e4d5eb4e2e787aeb998ebbc87c49bf96677c71d5681d94e56dff067655a8a/nodejs/node/pull/41596 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b4e4d5eb4e2e787aeb998ebbc87c49bf96677c71d5681d94e56dff067655a8a/nodejs/node/pull/41596 |
| og:image:alt | Opening a PR to have the discussion about this particular idea (doc-deprecating buffer.slice).
References: #41588
For the why - buffer.slice() returns a mutable slice whereas typedArray.slice() and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benjamingr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 32f7b614aca06e6bbd89842b1370df1328264f68 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/41596#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41596 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41596 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/41596 |
| Reload | https://github.com/nodejs/node/pull/41596 |
| Reload | https://github.com/nodejs/node/pull/41596 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:doc-deprecate-buffer-slice | https://github.com/benjamingr/io.js/tree/doc-deprecate-buffer-slice |
| Conversation | https://github.com/nodejs/node/pull/41596 |
| Commits4 (4) | https://github.com/nodejs/node/pull/41596/commits |
| Checks | https://github.com/nodejs/node/pull/41596/checks |
| Files changed | https://github.com/nodejs/node/pull/41596/files |
| doc: deprecate buffer.slice | https://github.com/nodejs/node/pull/41596#top |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:doc-deprecate-buffer-slice | https://github.com/benjamingr/io.js/tree/doc-deprecate-buffer-slice |
|
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issue-1108313312 |
| #41588 | https://github.com/nodejs/node/issues/41588 |
| @addaleax | https://github.com/addaleax |
| @jasnell | https://github.com/jasnell |
| @sindresorhus | https://github.com/sindresorhus |
| @Trott | https://github.com/Trott |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#event-5919008851 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#event-5919010907 |
| https://github.com/VoltrexKeyva |
| VoltrexKeyva | https://github.com/VoltrexKeyva |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857058912 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/41596/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/41596/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/Mesteery |
| Mesteery | https://github.com/Mesteery |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016649639 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/nodejs/node/blob/master/doc/api/deprecations.md | https://github.com/nodejs/node/blob/master/doc/api/deprecations.md |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| force-pushed | https://github.com/nodejs/node/compare/482b28b341f4bb1070f69c937b85ba89f4921ec3..d1f48574e9f6c220bcd06784eab4323151a48f27 |
| 482b28b | https://github.com/nodejs/node/commit/482b28b341f4bb1070f69c937b85ba89f4921ec3 |
| d1f4857 | https://github.com/nodejs/node/commit/d1f48574e9f6c220bcd06784eab4323151a48f27 |
|
Compare
| https://github.com/nodejs/node/compare/482b28b341f4bb1070f69c937b85ba89f4921ec3..d1f48574e9f6c220bcd06784eab4323151a48f27 |
| January 19, 2022 16:44 | https://github.com/nodejs/node/pull/41596#event-5919090362 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016656969 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/vweevers |
| vweevers | https://github.com/vweevers |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016662388 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#event-5919139532 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857082557 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| doc/api/buffer.md | https://github.com/nodejs/node/pull/41596/files#diff-2aeb90ba4258a1154f8558dc18c7ad46778ac0bb479f564fe96853d35303bca0 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857088084 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857088084 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016670661 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| @aduh95 | https://github.com/aduh95 |
| @vweevers | https://github.com/vweevers |
| https://source.chromium.org/chromium/chromium/src/+/main:v8/src/builtins/typed-array-subarray.tq?q=subarray&ss=chromium%2Fchromium%2Fsrc | https://source.chromium.org/chromium/chromium/src/+/main:v8/src/builtins/typed-array-subarray.tq?q=subarray&ss=chromium%2Fchromium%2Fsrc |
| https://source.chromium.org/chromium/chromium/src/+/main:v8/src/builtins/typed-array-subarray.tq?q=subarray&ss=chromium%2Fchromium%2Fsrc | https://source.chromium.org/chromium/chromium/src/+/main:v8/src/builtins/typed-array-subarray.tq?q=subarray&ss=chromium%2Fchromium%2Fsrc |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016671738 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857100767 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857100767 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| force-pushed | https://github.com/nodejs/node/compare/7365c66e5353998dba7c27893722115e465329b1..79621a597fac6d79d9ef32d90a4c8efc21d3e37e |
| 7365c66 | https://github.com/nodejs/node/commit/7365c66e5353998dba7c27893722115e465329b1 |
| 79621a5 | https://github.com/nodejs/node/commit/79621a597fac6d79d9ef32d90a4c8efc21d3e37e |
|
Compare
| https://github.com/nodejs/node/compare/7365c66e5353998dba7c27893722115e465329b1..79621a597fac6d79d9ef32d90a4c8efc21d3e37e |
| January 19, 2022 17:08 | https://github.com/nodejs/node/pull/41596#event-5919244543 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016686627 |
| proposal-rm-builtin-subclassing | https://github.com/tc39/proposal-rm-builtin-subclassing |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857115146 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/41596/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016689727 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016693014 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857121953 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857123362 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857123362 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016696287 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#event-5919418469 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016704828 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/Mesteery |
| Mesteery | https://github.com/Mesteery |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857138305 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/41596/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/Mesteery |
| Mesteery | https://github.com/Mesteery |
|
Jan 19, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-857140211 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files |
| doc/api/deprecations.md | https://github.com/nodejs/node/pull/41596/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
|
| https://github.com/benjamingr |
| buffer: deprecate buffer.slice | https://github.com/nodejs/node/pull/41596/commits/a99e537bbe4454e93e81870c9de75a093d42da52 |
| a99e537 | https://github.com/nodejs/node/pull/41596/commits/a99e537bbe4454e93e81870c9de75a093d42da52 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| force-pushed | https://github.com/nodejs/node/compare/9bfde1f8f61f4ec02a1372dc6fffc5806c7e09f0..a99e537bbe4454e93e81870c9de75a093d42da52 |
| 9bfde1f | https://github.com/nodejs/node/commit/9bfde1f8f61f4ec02a1372dc6fffc5806c7e09f0 |
| a99e537 | https://github.com/nodejs/node/commit/a99e537bbe4454e93e81870c9de75a093d42da52 |
|
Compare
| https://github.com/nodejs/node/compare/9bfde1f8f61f4ec02a1372dc6fffc5806c7e09f0..a99e537bbe4454e93e81870c9de75a093d42da52 |
| January 19, 2022 17:46 | https://github.com/nodejs/node/pull/41596#event-5919483507 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016716955 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Jan 19, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1016719133 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Jan 21, 2022
| https://github.com/nodejs/node/pull/41596#pullrequestreview-858932417 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/41596/files/d4376e2bcd8d5659d644a6780d7e0889eff7cfa2 |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/41596#pullrequestreview-858932417 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Jan 21, 2022 | https://github.com/nodejs/node/pull/41596#event-5928780519 |
|
doc: demonstrate the dangers of buffer.slice()
#41627
| https://github.com/nodejs/node/pull/41627 |
|
doc: demonstrate dangers of buffer.slice()
#41628
| https://github.com/nodejs/node/pull/41628 |
| https://github.com/shalvah |
| shalvah | https://github.com/shalvah |
| Jan 21, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1018494643 |
| @benjamingr | https://github.com/benjamingr |
| #41628 | https://github.com/nodejs/node/pull/41628 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 21, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1018956227 |
| 290911b...3d23d62 | https://github.com/nodejs/node/compare/290911b99a13f6ecb0a6d8c33ba9d110c7059287...3d23d62373c0136428739893cc3c11d55dcd1490 |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jan 21, 2022 | https://github.com/nodejs/node/pull/41596#event-5935374269 |
| aduh95 | https://github.com/aduh95 |
|
Jan 21, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-830cbca |
|
| https://github.com/benjamingr |
|
| https://github.com/aduh95 |
| doc: deprecate buffer.slice | https://github.com/nodejs/node/commit/830cbca8107bbddf5601384e257de6ba618fe5df |
| 830cbca | https://github.com/nodejs/node/commit/830cbca8107bbddf5601384e257de6ba618fe5df |
| #41596 | https://github.com/nodejs/node/pull/41596 |
| aduh95 | https://github.com/aduh95 |
|
Jan 21, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-6bf769e |
|
| https://github.com/benjamingr |
|
| https://github.com/aduh95 |
| benchmark: add subarray to buffer-slice | https://github.com/nodejs/node/commit/6bf769e4e6e6c451197dfd11d5a0d74c0b958a48 |
| 6bf769e | https://github.com/nodejs/node/commit/6bf769e4e6e6c451197dfd11d5a0d74c0b958a48 |
| #41596 | https://github.com/nodejs/node/pull/41596 |
| aduh95 | https://github.com/aduh95 |
|
Jan 21, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-3d23d62 |
|
| https://github.com/benjamingr |
|
| https://github.com/aduh95 |
| buffer: alias subarray and slice | https://github.com/nodejs/node/commit/3d23d62373c0136428739893cc3c11d55dcd1490 |
| 3d23d62 | https://github.com/nodejs/node/commit/3d23d62373c0136428739893cc3c11d55dcd1490 |
| #41596 | https://github.com/nodejs/node/pull/41596 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 22, 2022
| https://github.com/nodejs/node/pull/41596#ref-issue-1111104046 |
|
CI Reliability 2022-01-22
nodejs/reliability#179
| https://github.com/nodejs/reliability/issues/179 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
|
notable-change
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anotable-change |
| Jan 22, 2022 | https://github.com/nodejs/node/pull/41596#event-5936158727 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Jan 22, 2022 | https://github.com/nodejs/node/pull/41596#issuecomment-1019087559 |
| @bricss | https://github.com/bricss |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
|
CI Reliability 2022-01-23
nodejs/reliability#180
| https://github.com/nodejs/reliability/issues/180 |
|
CI Reliability 2022-01-24
nodejs/reliability#181
| https://github.com/nodejs/reliability/issues/181 |
|
CI Reliability 2022-01-25
nodejs/reliability#182
| https://github.com/nodejs/reliability/issues/182 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 25, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-2e7bf00 |
|
| https://github.com/benjamingr |
|
| https://github.com/BethGriggs |
| doc: deprecate buffer.slice | https://github.com/nodejs/node/commit/2e7bf003599a43507677c103779c730818ed8a28 |
| 2e7bf00 | https://github.com/nodejs/node/commit/2e7bf003599a43507677c103779c730818ed8a28 |
| #41596 | https://github.com/nodejs/node/pull/41596 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 25, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-6fefd51 |
|
| https://github.com/benjamingr |
|
| https://github.com/BethGriggs |
| benchmark: add subarray to buffer-slice | https://github.com/nodejs/node/commit/6fefd5112a5e56733be2a1b58811405c9489c54c |
| 6fefd51 | https://github.com/nodejs/node/commit/6fefd5112a5e56733be2a1b58811405c9489c54c |
| #41596 | https://github.com/nodejs/node/pull/41596 |
| BethGriggs | https://github.com/BethGriggs |
|
Jan 25, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-89c3273 |
|
| https://github.com/benjamingr |
|
| https://github.com/BethGriggs |
| buffer: alias subarray and slice | https://github.com/nodejs/node/commit/89c327387b14b9da15d4e06a18c6f1fd5485dcc4 |
| 89c3273 | https://github.com/nodejs/node/commit/89c327387b14b9da15d4e06a18c6f1fd5485dcc4 |
| #41596 | https://github.com/nodejs/node/pull/41596 |
| Linkgoron | https://github.com/Linkgoron |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-fe6aa80 |
|
| https://github.com/benjamingr |
|
| https://github.com/Linkgoron |
| doc: deprecate buffer.slice | https://github.com/Linkgoron/node/commit/fe6aa80dd8212b3bf25183b14aa9526c6e69e953 |
| fe6aa80 | https://github.com/Linkgoron/node/commit/fe6aa80dd8212b3bf25183b14aa9526c6e69e953 |
| nodejs#41596 | https://github.com/nodejs/node/pull/41596 |
| Linkgoron | https://github.com/Linkgoron |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-093ecfa |
|
| https://github.com/benjamingr |
|
| https://github.com/Linkgoron |
| benchmark: add subarray to buffer-slice | https://github.com/Linkgoron/node/commit/093ecfa8dced3900a93cce16b30ea43c69667bc4 |
| 093ecfa | https://github.com/Linkgoron/node/commit/093ecfa8dced3900a93cce16b30ea43c69667bc4 |
| nodejs#41596 | https://github.com/nodejs/node/pull/41596 |
| Linkgoron | https://github.com/Linkgoron |
|
Jan 31, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-a31e11b |
|
| https://github.com/benjamingr |
|
| https://github.com/Linkgoron |
| buffer: alias subarray and slice | https://github.com/Linkgoron/node/commit/a31e11bd9929c510f6700d7e10c4645388c6495c |
| a31e11b | https://github.com/Linkgoron/node/commit/a31e11bd9929c510f6700d7e10c4645388c6495c |
| nodejs#41596 | https://github.com/nodejs/node/pull/41596 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Feb 8, 2022
| https://github.com/nodejs/node/pull/41596#ref-pullrequest-1127570672 |
|
v17.5.0 release proposal
#41897
| https://github.com/nodejs/node/pull/41897 |
| danielleadams | https://github.com/danielleadams |
|
Apr 21, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-e46c7d6 |
|
| https://github.com/benjamingr |
|
| https://github.com/danielleadams |
| doc: deprecate buffer.slice | https://github.com/danielleadams/node/commit/e46c7d6f695427af4f3b7f06213b8c3deb679b68 |
| e46c7d6 | https://github.com/danielleadams/node/commit/e46c7d6f695427af4f3b7f06213b8c3deb679b68 |
| nodejs#41596 | https://github.com/nodejs/node/pull/41596 |
| danielleadams | https://github.com/danielleadams |
|
Apr 21, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-3d4df9c |
|
| https://github.com/benjamingr |
|
| https://github.com/danielleadams |
| benchmark: add subarray to buffer-slice | https://github.com/danielleadams/node/commit/3d4df9cd7075658a36eab143fb0fb740e4f88ea2 |
| 3d4df9c | https://github.com/danielleadams/node/commit/3d4df9cd7075658a36eab143fb0fb740e4f88ea2 |
| nodejs#41596 | https://github.com/nodejs/node/pull/41596 |
| danielleadams | https://github.com/danielleadams |
|
Apr 21, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-84752a4 |
|
| https://github.com/benjamingr |
|
| https://github.com/danielleadams |
| buffer: alias subarray and slice | https://github.com/danielleadams/node/commit/84752a495f93d766c7f7c08b812ea6c2e53df09d |
| 84752a4 | https://github.com/danielleadams/node/commit/84752a495f93d766c7f7c08b812ea6c2e53df09d |
| nodejs#41596 | https://github.com/nodejs/node/pull/41596 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Apr 24, 2022
| https://github.com/nodejs/node/pull/41596#ref-pullrequest-1213493475 |
|
v16.15.0 release proposal
#42847
| https://github.com/nodejs/node/pull/42847 |
| mwalbeck | https://github.com/mwalbeck |
|
May 2, 2022
| https://github.com/nodejs/node/pull/41596#ref-commit-bf20861 |
|
| https://github.com/mwalbeck |
| Update Node.js to v16.15.0 (#62) | https://github.com/mwalbeck/docker-cyberchef/commit/bf2086165de875842d0eaab5df37c94a67520a0d |
| bf20861 | https://github.com/mwalbeck/docker-cyberchef/commit/bf2086165de875842d0eaab5df37c94a67520a0d |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41596 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/41596/files/79621a597fac6d79d9ef32d90a4c8efc21d3e37e |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/41596/files/d1f48574e9f6c220bcd06784eab4323151a48f27 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/41596/files/79621a597fac6d79d9ef32d90a4c8efc21d3e37e |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/41596/files/d4376e2bcd8d5659d644a6780d7e0889eff7cfa2 |
|
| https://github.com/Mesteery |
|
Mesteery
| https://github.com/Mesteery |
|
| https://github.com/nodejs/node/pull/41596/files/91dcbc1151ecd50909a78f9ee28d6820bf3942de |
|
| https://github.com/VoltrexKeyva |
|
VoltrexKeyva
| https://github.com/VoltrexKeyva |
|
| https://github.com/nodejs/node/pull/41596/files/f77e93e12b4468dce11a2449cd11db6f095eb890 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
semver-minor
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-minor |
| Please reload this page | https://github.com/nodejs/node/pull/41596 |
|
| https://github.com/benjamingr |
|
| https://github.com/Mesteery |
|
| https://github.com/vweevers |
|
| https://github.com/aduh95 |
|
| https://github.com/mcollina |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/merceyz |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bricss |
|
| https://github.com/shalvah |
|
| https://github.com/VoltrexKeyva |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |