| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7a0287d0-7c6e-a436-f165-f17fb2510c4b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA50:26BEF2:C66A08:1021B10:696B288C |
| html-safe-nonce | 22924e0674baa6b3c63c38ba254a1964ffab2edd3b1fc381ed15132a37943024 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTUwOjI2QkVGMjpDNjZBMDg6MTAyMUIxMDo2OTZCMjg4QyIsInZpc2l0b3JfaWQiOiI0NDA4MTMzNjAzMDgyMzQzODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 42237a3a76a932ca217fbc668c6014c99da2ae7d9447e322317a5d583e80e3f9 |
| hovercard-subject-tag | pull_request:52617497 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4146/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ccd06710ca99e662b2a2c3008391a6fcd1a2b59e0952429e2f088ab23278ce28/nodejs/node/pull/4146 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ccd06710ca99e662b2a2c3008391a6fcd1a2b59e0952429e2f088ab23278ce28/nodejs/node/pull/4146 |
| og:image:alt | 94b9948 added unistd.h to src/env.cc in order to use getpid(). However, this doesn't exist on Windows. This commit conditionally defines getpid() based on the OS.
Closes #4145
R=@mscdex |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/4146#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4146 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4146 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/4146 |
| Reload | https://github.com/nodejs/node/pull/4146 |
| Reload | https://github.com/nodejs/node/pull/4146 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/4146#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:4145 | https://github.com/cjihrig/node/tree/4145 |
|
src: define getpid() based on OS
| https://github.com/nodejs/node/pull/4146#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:4145 | https://github.com/cjihrig/node/tree/4145 |
|
Conversation
9
| https://github.com/nodejs/node/pull/4146 |
|
Commits
0
| https://github.com/nodejs/node/pull/4146/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/4146/checks |
|
Files changed
| https://github.com/nodejs/node/pull/4146/files |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issue-120309963 |
| #4145 | https://github.com/nodejs/node/issues/4145 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161845019 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161846427 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/3aed55fd088bccbd028a1831a733179b2383818a..67199ce218a521f2a51c12b5b35a2b645afe2e55 |
| 3aed55f | https://github.com/nodejs/node/commit/3aed55fd088bccbd028a1831a733179b2383818a |
| 67199ce | https://github.com/nodejs/node/commit/67199ce218a521f2a51c12b5b35a2b645afe2e55 |
|
Compare
| https://github.com/nodejs/node/compare/3aed55fd088bccbd028a1831a733179b2383818a..67199ce218a521f2a51c12b5b35a2b645afe2e55 |
| December 4, 2015 01:39 | https://github.com/nodejs/node/pull/4146#event-482186359 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/67199ce218a521f2a51c12b5b35a2b645afe2e55..f532b0aa913838bd8441b05ed1f778d54e0e3d85 |
| 67199ce | https://github.com/nodejs/node/commit/67199ce218a521f2a51c12b5b35a2b645afe2e55 |
| f532b0a | https://github.com/nodejs/node/commit/f532b0aa913838bd8441b05ed1f778d54e0e3d85 |
|
Compare
| https://github.com/nodejs/node/compare/67199ce218a521f2a51c12b5b35a2b645afe2e55..f532b0aa913838bd8441b05ed1f778d54e0e3d85 |
| December 4, 2015 01:40 | https://github.com/nodejs/node/pull/4146#event-482186797 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161847108 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161849077 |
| https://ci.nodejs.org/job/node-test-pull-request/919/ | https://ci.nodejs.org/job/node-test-pull-request/919/ |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161852115 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161852542 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#event-482213465 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| force-pushed | https://github.com/nodejs/node/compare/f532b0aa913838bd8441b05ed1f778d54e0e3d85..a9c0c65f9eca5593a775b2b7cb03e35806f24683 |
| f532b0a | https://github.com/nodejs/node/commit/f532b0aa913838bd8441b05ed1f778d54e0e3d85 |
| a9c0c65 | https://github.com/nodejs/node/commit/a9c0c65f9eca5593a775b2b7cb03e35806f24683 |
|
Compare
| https://github.com/nodejs/node/compare/f532b0aa913838bd8441b05ed1f778d54e0e3d85..a9c0c65f9eca5593a775b2b7cb03e35806f24683 |
| December 4, 2015 02:25 | https://github.com/nodejs/node/pull/4146#event-482213466 |
| cjihrig | https://github.com/cjihrig |
|
Dec 4, 2015
| https://github.com/nodejs/node/pull/4146#ref-commit-a9c0c65 |
|
| https://github.com/cjihrig |
| src: define getpid() based on OS | https://github.com/cjihrig/node/commit/a9c0c65f9eca5593a775b2b7cb03e35806f24683 |
| a9c0c65 | https://github.com/cjihrig/node/commit/a9c0c65f9eca5593a775b2b7cb03e35806f24683 |
| nodejs#4145 | https://github.com/nodejs/node/issues/4145 |
| nodejs#4146 | https://github.com/nodejs/node/pull/4146 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| December 4, 2015 02:25 | https://github.com/nodejs/node/pull/4146#event-482213517 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| a9c0c65 | https://github.com/nodejs/node/commit/a9c0c65f9eca5593a775b2b7cb03e35806f24683 |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#event-482213541 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Dec 4, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-161852840 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Dec 5, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-162141645 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| cjihrig | https://github.com/cjihrig |
|
Dec 5, 2015
| https://github.com/nodejs/node/pull/4146#ref-commit-458facd |
|
| https://github.com/cjihrig |
|
| https://github.com/rvagg |
| src: define getpid() based on OS | https://github.com/nodejs/node/commit/458facdf66395c38cfb6104109cf39d2938c9709 |
| 458facd | https://github.com/nodejs/node/commit/458facdf66395c38cfb6104109cf39d2938c9709 |
| #4145 | https://github.com/nodejs/node/issues/4145 |
| #4146 | https://github.com/nodejs/node/pull/4146 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Dec 5, 2015
| https://github.com/nodejs/node/pull/4146#ref-pullrequest-120544984 |
|
src: use GetCurrentProcessId() for process.pid
#4163
| https://github.com/nodejs/node/pull/4163 |
|
Release proposal: v5.2.0
#4180
| https://github.com/nodejs/node/pull/4180 |
|
Release proposal: v5.2.0 (Stable)
#4181
| https://github.com/nodejs/node/pull/4181 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Dec 17, 2015
| https://github.com/nodejs/node/pull/4146#ref-issue-122642707 |
|
Release 4.2.4 Planning
#4321
| https://github.com/nodejs/node/issues/4321 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
os
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
|
os
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aos |
| Dec 17, 2015 | https://github.com/nodejs/node/pull/4146#event-495084036 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 29, 2015 | https://github.com/nodejs/node/pull/4146#issuecomment-167900847 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Dec 29, 2015 | https://github.com/nodejs/node/pull/4146#event-502479560 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 14, 2016
| https://github.com/nodejs/node/pull/4146#ref-issue-126730245 |
|
Audit commits not found on v4.x-staging
#4698
| https://github.com/nodejs/node/issues/4698 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Jan 15, 2016 | https://github.com/nodejs/node/pull/4146#event-515898343 |
| scovetta | https://github.com/scovetta |
|
Apr 2, 2016
| https://github.com/nodejs/node/pull/4146#ref-commit-8018a25 |
|
| https://github.com/cjihrig |
| src: define getpid() based on OS | https://github.com/scovetta/node/commit/8018a251011a02c9ddab5fdbadba25bb09f58761 |
| 8018a25 | https://github.com/scovetta/node/commit/8018a251011a02c9ddab5fdbadba25bb09f58761 |
| nodejs#4145 | https://github.com/nodejs/node/issues/4145 |
| nodejs#4146 | https://github.com/nodejs/node/pull/4146 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4146 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/4146 |
|
| https://github.com/cjihrig |
|
| https://github.com/mscdex |
|
| https://github.com/rvagg |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |