René's URL Explorer Experiment


Title: stream: be less eager with readable flag by mscdex · Pull Request #4141 · nodejs/node · GitHub

Open Graph Title: stream: be less eager with readable flag by mscdex · Pull Request #4141 · nodejs/node

X Title: stream: be less eager with readable flag by mscdex · Pull Request #4141 · nodejs/node

Description: As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in child_process. This commit fixes those failures by making readable ...

Open Graph Description: As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in child_process. This commit fixes those failures by making readable ...

X Description: As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in child_process. This commit fixes those failures by making readable ...

Opengraph URL: https://github.com/nodejs/node/pull/4141

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d1313d5-35e7-d799-ff2f-bd46734ccb0f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD31E:154180:18A1D46:2055CEC:696B2C36
html-safe-nonceb752b2021a64ea7950974d2dde63e2e4ef5fbbb4d5b527b9e0967a8698a19593
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzFFOjE1NDE4MDoxOEExRDQ2OjIwNTVDRUM6Njk2QjJDMzYiLCJ2aXNpdG9yX2lkIjoiODAxNTQ1MTc4MTI3OTE5ODI2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac72d1078f2e4432aa83ee8e3c61c3f7a74e04f7acdb11526678e87e60262c8011
hovercard-subject-tagpull_request:52610302
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/4141/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/59bfcd30b8ac24b55b292944badc841b853bab96a66b98ce8244662309b99724/nodejs/node/pull/4141
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/59bfcd30b8ac24b55b292944badc841b853bab96a66b98ce8244662309b99724/nodejs/node/pull/4141
og:image:altAs of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in child_process. This commit fixes those failures by making readable ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemscdex
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/4141#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4141
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4141
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/4141
Reloadhttps://github.com/nodejs/node/pull/4141
Reloadhttps://github.com/nodejs/node/pull/4141
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/4141
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/4141
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/4141#issue-comment-box
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-readable-writable-regresshttps://github.com/mscdex/io.js/tree/fix-readable-writable-regress
stream: be less eager with readable flag https://github.com/nodejs/node/pull/4141#top
mscdexhttps://github.com/mscdex
nodejs:masterhttps://github.com/nodejs/node/tree/master
mscdex:fix-readable-writable-regresshttps://github.com/mscdex/io.js/tree/fix-readable-writable-regress
Conversation 10 https://github.com/nodejs/node/pull/4141
Commits 1 https://github.com/nodejs/node/pull/4141/commits
Checks 0 https://github.com/nodejs/node/pull/4141/checks
Files changed https://github.com/nodejs/node/pull/4141/files
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 3, 2015https://github.com/nodejs/node/pull/4141#issue-120298268
34b535fhttps://github.com/nodejs/node/commit/34b535f4caba366789d949211e4369b1e1d01152
#4125https://github.com/nodejs/node/issues/4125
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/mscdex
stream: be less eager with readable flaghttps://github.com/nodejs/node/pull/4141/commits/3560dae590037de73ef015008f5076adae97c359
3560daehttps://github.com/nodejs/node/pull/4141/commits/3560dae590037de73ef015008f5076adae97c359
34b535fhttps://github.com/mscdex/io.js/commit/34b535f4caba366789d949211e4369b1e1d01152
nodejs#4125https://github.com/nodejs/node/issues/4125
https://github.com/mscdex
mscdexhttps://github.com/mscdex
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Dec 3, 2015https://github.com/nodejs/node/pull/4141#event-482104456
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 3, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161827719
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161828870
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161829347
@jasnellhttps://github.com/jasnell
#4083https://github.com/nodejs/node/pull/4083
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161829617
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161830833
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161853480
https://ci.nodejs.org/job/node-test-pull-request/920/https://ci.nodejs.org/job/node-test-pull-request/920/
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161857294
Please reload this pagehttps://github.com/nodejs/node/pull/4141
mscdexhttps://github.com/mscdex
Dec 4, 2015 https://github.com/nodejs/node/pull/4141#ref-commit-2922188
https://github.com/mscdex
stream: be less eager with readable flaghttps://github.com/nodejs/node/commit/292218828eea50861680ac9276b1b764e7342134
2922188https://github.com/nodejs/node/commit/292218828eea50861680ac9276b1b764e7342134
34b535fhttps://github.com/nodejs/node/commit/34b535f4caba366789d949211e4369b1e1d01152
#4125https://github.com/nodejs/node/issues/4125
#4141https://github.com/nodejs/node/pull/4141
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 4, 2015https://github.com/nodejs/node/pull/4141#issuecomment-161858402
2922188https://github.com/nodejs/node/commit/292218828eea50861680ac9276b1b764e7342134
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Dec 4, 2015https://github.com/nodejs/node/pull/4141#event-482233528
mscdexhttps://github.com/mscdex
Dec 5, 2015 https://github.com/nodejs/node/pull/4141#ref-commit-756ab9c
https://github.com/mscdex
https://github.com/rvagg
stream: be less eager with readable flaghttps://github.com/nodejs/node/commit/756ab9caadcba43d59149584accdd204ac173e40
756ab9chttps://github.com/nodejs/node/commit/756ab9caadcba43d59149584accdd204ac173e40
34b535fhttps://github.com/nodejs/node/commit/34b535f4caba366789d949211e4369b1e1d01152
#4125https://github.com/nodejs/node/issues/4125
#4141https://github.com/nodejs/node/pull/4141
Release proposal: v5.2.0 #4180 https://github.com/nodejs/node/pull/4180
Release proposal: v5.2.0 (Stable) #4181 https://github.com/nodejs/node/pull/4181
https://github.com/rvagg
rvagghttps://github.com/rvagg
Dec 17, 2015 https://github.com/nodejs/node/pull/4141#ref-issue-122642707
Release 4.2.4 Planning #4321 https://github.com/nodejs/node/issues/4321
https://github.com/mscdex
mscdexhttps://github.com/mscdex
December 17, 2015 17:58https://github.com/nodejs/node/pull/4141#event-494977606
https://github.com/jasnell
jasnellhttps://github.com/jasnell
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Dec 17, 2015https://github.com/nodejs/node/pull/4141#event-495078778
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Dec 17, 2015https://github.com/nodejs/node/pull/4141#issuecomment-165558128
#4083https://github.com/nodejs/node/pull/4083
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 29, 2015https://github.com/nodejs/node/pull/4141#issuecomment-167900346
#4083https://github.com/nodejs/node/pull/4083
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Dec 29, 2015https://github.com/nodejs/node/pull/4141#event-502477599
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Dec 29, 2015 https://github.com/nodejs/node/pull/4141#ref-pullrequest-119639532
streams: update .readable/.writable to false #4083 https://github.com/nodejs/node/pull/4083
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jan 14, 2016 https://github.com/nodejs/node/pull/4141#ref-issue-126730245
Audit commits not found on v4.x-staging #4698 https://github.com/nodejs/node/issues/4698
https://github.com/rvagg
rvagghttps://github.com/rvagg
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Jan 15, 2016https://github.com/nodejs/node/pull/4141#event-515898705
scovettahttps://github.com/scovetta
Apr 2, 2016 https://github.com/nodejs/node/pull/4141#ref-commit-7c77290
https://github.com/mscdex
stream: be less eager with readable flaghttps://github.com/scovetta/node/commit/7c77290caf414f160bfbafbbbd1ede8ce3fc132f
7c77290https://github.com/scovetta/node/commit/7c77290caf414f160bfbafbbbd1ede8ce3fc132f
34b535fhttps://github.com/scovetta/node/commit/34b535f4caba366789d949211e4369b1e1d01152
nodejs#4125https://github.com/nodejs/node/issues/4125
nodejs#4141https://github.com/nodejs/node/pull/4141
[Snyk] Upgrade rollup from 2.32.1 to 2.52.2 Zintexiss/node-22#23 https://github.com/Zintexiss/node-22/pull/23
[Snyk] Upgrade rollup from 2.32.1 to 2.52.3 Zintexiss/node-22#34 https://github.com/Zintexiss/node-22/pull/34
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Jul 21, 2021 https://github.com/nodejs/node/pull/4141#ref-pullrequest-950164516
[Snyk] Upgrade rollup from 2.32.1 to 2.52.4 Zintexiss/node-22#38 https://github.com/Zintexiss/node-22/pull/38
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F4141
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
flaky test: test-child-process-flush-stdio https://github.com/nodejs/node/issues/4125
Please reload this pagehttps://github.com/nodejs/node/pull/4141
https://github.com/mscdex
https://github.com/cjihrig
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com/rvagg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.