René's URL Explorer Experiment


Title: fix,v8: make `v8.writeHeapSnapshot` throw if `fopen`/`fclose` fail by kyranet · Pull Request #41373 · nodejs/node · GitHub

Open Graph Title: fix,v8: make `v8.writeHeapSnapshot` throw if `fopen`/`fclose` fail by kyranet · Pull Request #41373 · nodejs/node

X Title: fix,v8: make `v8.writeHeapSnapshot` throw if `fopen`/`fclose` fail by kyranet · Pull Request #41373 · nodejs/node

Description: Fixes: #41346 Alternative to #41365, this PR makes v8.writeHeapSnapshot throw if the file could not be written, which can happen inside read-only directories (such as those from Docker containers)....

Open Graph Description: Fixes: #41346 Alternative to #41365, this PR makes v8.writeHeapSnapshot throw if the file could not be written, which can happen inside read-only directories (such as those from Docker containers)....

X Description: Fixes: #41346 Alternative to #41365, this PR makes v8.writeHeapSnapshot throw if the file could not be written, which can happen inside read-only directories (such as those from Docker containers)....

Opengraph URL: https://github.com/nodejs/node/pull/41373

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a9a0db59-b76d-c918-5d25-4415a28cc2d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAAC:1BA21A:4124BB:5CC21D:696A4634
html-safe-nonce893ead2975360c80f88701e8dee748212161a7fc786b7b428300e41115ddd4e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUFDOjFCQTIxQTo0MTI0QkI6NUNDMjFEOjY5NkE0NjM0IiwidmlzaXRvcl9pZCI6IjEzNDQ4NDk0NjQzOTEyNTU2MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfe1fd0811ac725112b3c16e4c864ecb3508c518555f098c6bf2998cdd6bdc812
hovercard-subject-tagpull_request:812653061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41373/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b7bc5079926062654f6d884b0ee88f3b40d96aaf164cef98d785963bcd73160a/nodejs/node/pull/41373
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b7bc5079926062654f6d884b0ee88f3b40d96aaf164cef98d785963bcd73160a/nodejs/node/pull/41373
og:image:altFixes: #41346 Alternative to #41365, this PR makes v8.writeHeapSnapshot throw if the file could not be written, which can happen inside read-only directories (such as those from Docker containers)....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekyranet
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/41373#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41373
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41373
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/41373
Reloadhttps://github.com/nodejs/node/pull/41373
Reloadhttps://github.com/nodejs/node/pull/41373
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/41373
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/41373
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/41373#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
kyranet:fix-v8/make-write-heap-snapshot-throwhttps://github.com/kyranet/node/tree/fix-v8/make-write-heap-snapshot-throw
fix,v8: make v8.writeHeapSnapshot throw if fopen/fclose fail https://github.com/nodejs/node/pull/41373#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:masterhttps://github.com/nodejs/node/tree/master
kyranet:fix-v8/make-write-heap-snapshot-throwhttps://github.com/kyranet/node/tree/fix-v8/make-write-heap-snapshot-throw
Conversation 11 https://github.com/nodejs/node/pull/41373
Commits 1 https://github.com/nodejs/node/pull/41373/commits
Checks 0 https://github.com/nodejs/node/pull/41373/checks
Files changed https://github.com/nodejs/node/pull/41373/files
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/kyranet
kyranethttps://github.com/kyranet
Jan 1, 2022https://github.com/nodejs/node/pull/41373#issue-1091913013
#41346https://github.com/nodejs/node/issues/41346
#41365https://github.com/nodejs/node/pull/41365
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 1, 2022https://github.com/nodejs/node/pull/41373#event-5832132604
https://github.com/kyranet
kyranethttps://github.com/kyranet
force-pushedhttps://github.com/nodejs/node/compare/1a3db37035d30bf4fb897dc7a80c9c5efba855cf..a6944414b24472cd1a18de85294170d8ff0b5033
1a3db37https://github.com/nodejs/node/commit/1a3db37035d30bf4fb897dc7a80c9c5efba855cf
a694441https://github.com/nodejs/node/commit/a6944414b24472cd1a18de85294170d8ff0b5033
Compare https://github.com/nodejs/node/compare/1a3db37035d30bf4fb897dc7a80c9c5efba855cf..a6944414b24472cd1a18de85294170d8ff0b5033
January 1, 2022 23:52https://github.com/nodejs/node/pull/41373#event-5832153415
https://github.com/kyranet
kyranethttps://github.com/kyranet
Jan 1, 2022 https://github.com/nodejs/node/pull/41373#ref-pullrequest-1091506846
doc,v8: clarify v8.writeHeapSnapshot may return undefined #41365 https://github.com/nodejs/node/pull/41365
https://github.com/kyranet
kyranethttps://github.com/kyranet
Jan 2, 2022https://github.com/nodejs/node/pull/41373#event-5832157850
https://github.com/mscdex
mscdexhttps://github.com/mscdex
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Jan 2, 2022https://github.com/nodejs/node/pull/41373#event-5832191827
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jan 2, 2022 https://github.com/nodejs/node/pull/41373#pullrequestreview-842404427
View reviewed changes https://github.com/nodejs/node/pull/41373/files
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
Jan 2, 2022 https://github.com/nodejs/node/pull/41373#pullrequestreview-842410995
View reviewed changes https://github.com/nodejs/node/pull/41373/files
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 2, 2022https://github.com/nodejs/node/pull/41373#event-5832631752
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jan 2, 2022 https://github.com/nodejs/node/pull/41373#pullrequestreview-842409402
View reviewed changes https://github.com/nodejs/node/pull/41373/files
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/41373#pullrequestreview-842409402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/doc/api/v8.mdhttps://github.com/nodejs/node/blob/55c5120b07964501a475b4ae1fdbb86e9306f153/doc/api/v8.md#L268-L270
55c5120https://github.com/nodejs/node/commit/55c5120b07964501a475b4ae1fdbb86e9306f153
node/doc/api/v8.mdhttps://github.com/nodejs/node/blob/55c5120b07964501a475b4ae1fdbb86e9306f153/doc/api/v8.md#L85-L88
55c5120https://github.com/nodejs/node/commit/55c5120b07964501a475b4ae1fdbb86e9306f153
Please reload this pagehttps://github.com/nodejs/node/pull/41373
src/heap_utils.cchttps://github.com/nodejs/node/pull/41373/files#diff-124f51f6a9986b18bfc73bc152dc0655344c40cba234e26b698aed1f84767088
Please reload this pagehttps://github.com/nodejs/node/pull/41373
src/heap_utils.cchttps://github.com/nodejs/node/pull/41373/files#diff-124f51f6a9986b18bfc73bc152dc0655344c40cba234e26b698aed1f84767088
Please reload this pagehttps://github.com/nodejs/node/pull/41373
src/heap_utils.cchttps://github.com/nodejs/node/pull/41373/files#diff-124f51f6a9986b18bfc73bc152dc0655344c40cba234e26b698aed1f84767088
Please reload this pagehttps://github.com/nodejs/node/pull/41373
test/sequential/test-heapdump.jshttps://github.com/nodejs/node/pull/41373/files#diff-5ee0ac76e909dc30c09d4010281a0aab4d0b5d1b91053e52cf21a8ca327c202a
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/VoltrexKeyva
VoltrexKeyvahttps://github.com/VoltrexKeyva
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 2, 2022https://github.com/nodejs/node/pull/41373#event-5832635827
https://github.com/faresalalimi
faresalalimihttps://github.com/faresalalimi
Jan 2, 2022 https://github.com/nodejs/node/pull/41373#pullrequestreview-842417814
View reviewed changes https://github.com/nodejs/node/pull/41373/files
faresalalimihttps://github.com/faresalalimi
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/nodejs/node/pull/41373#pullrequestreview-842417814
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Jan 2, 2022 https://github.com/nodejs/node/pull/41373#pullrequestreview-842433704
View reviewed changes https://github.com/nodejs/node/pull/41373/files
https://github.com/kyranet
v8: make writeHeapSnapshot throw if fopen failshttps://github.com/nodejs/node/pull/41373/commits/c954247354fa701c0c6c92ffe525bbe43cd07cc0
c954247https://github.com/nodejs/node/pull/41373/commits/c954247354fa701c0c6c92ffe525bbe43cd07cc0
nodejs#41346https://github.com/nodejs/node/issues/41346
https://github.com/kyranet
kyranethttps://github.com/kyranet
force-pushedhttps://github.com/nodejs/node/compare/a6944414b24472cd1a18de85294170d8ff0b5033..c954247354fa701c0c6c92ffe525bbe43cd07cc0
a694441https://github.com/nodejs/node/commit/a6944414b24472cd1a18de85294170d8ff0b5033
c954247https://github.com/nodejs/node/commit/c954247354fa701c0c6c92ffe525bbe43cd07cc0
Compare https://github.com/nodejs/node/compare/a6944414b24472cd1a18de85294170d8ff0b5033..c954247354fa701c0c6c92ffe525bbe43cd07cc0
January 2, 2022 18:16https://github.com/nodejs/node/pull/41373#event-5832918524
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jan 3, 2022 https://github.com/nodejs/node/pull/41373#pullrequestreview-842483047
View reviewed changes https://github.com/nodejs/node/pull/41373/files/c954247354fa701c0c6c92ffe525bbe43cd07cc0
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41373
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 3, 2022https://github.com/nodejs/node/pull/41373#event-5833648013
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 4, 2022 https://github.com/nodejs/node/pull/41373#ref-issue-1092905266
CI Reliability 2022-01-04 nodejs/reliability#165 https://github.com/nodejs/reliability/issues/165
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41373
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 5, 2022 https://github.com/nodejs/node/pull/41373#ref-issue-1093850695
CI Reliability 2022-01-05 nodejs/reliability#166 https://github.com/nodejs/reliability/issues/166
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 5, 2022https://github.com/nodejs/node/pull/41373#issuecomment-1006142383
https://ci.nodejs.org/job/node-test-pull-request/41768/https://ci.nodejs.org/job/node-test-pull-request/41768/
Please reload this pagehttps://github.com/nodejs/node/pull/41373
CI Reliability 2022-01-06 nodejs/reliability#167 https://github.com/nodejs/reliability/issues/167
CI Reliability 2022-01-07 nodejs/reliability#168 https://github.com/nodejs/reliability/issues/168
CI Reliability 2022-01-08 nodejs/reliability#169 https://github.com/nodejs/reliability/issues/169
CI Reliability 2022-01-09 nodejs/reliability#170 https://github.com/nodejs/reliability/issues/170
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 12, 2022 https://github.com/nodejs/node/pull/41373#ref-issue-1099731476
CI Reliability 2022-01-12 nodejs/reliability#171 https://github.com/nodejs/reliability/issues/171
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jan 12, 2022https://github.com/nodejs/node/pull/41373#event-5878542228
https://github.com/Ayase-252
Ayase-252https://github.com/Ayase-252
Jan 12, 2022https://github.com/nodejs/node/pull/41373#issuecomment-1010774955
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jan 12, 2022https://github.com/nodejs/node/pull/41373#event-5878563876
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
74b9baahttps://github.com/nodejs/node/commit/74b9baa4265a8f0d112dabc3efc63c2e13276488
Jan 12, 2022https://github.com/nodejs/node/pull/41373#event-5878564232
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 12, 2022https://github.com/nodejs/node/pull/41373#issuecomment-1010777851
74b9baahttps://github.com/nodejs/node/commit/74b9baa4265a8f0d112dabc3efc63c2e13276488
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/kyranet
kyranethttps://github.com/kyranet
January 12, 2022 18:56https://github.com/nodejs/node/pull/41373#event-5882378133
thedullhttps://github.com/thedull
Jan 18, 2022 https://github.com/nodejs/node/pull/41373#ref-commit-7a828ff
https://github.com/kyranet
https://github.com/thedull
v8: make writeHeapSnapshot throw if fopen failshttps://github.com/thedull/node/commit/7a828fff88f66465ba88938451be76c1d3ae9563
7a828ffhttps://github.com/thedull/node/commit/7a828fff88f66465ba88938451be76c1d3ae9563
nodejs#41346https://github.com/nodejs/node/issues/41346
nodejs#41373https://github.com/nodejs/node/pull/41373
Linkgoronhttps://github.com/Linkgoron
Jan 31, 2022 https://github.com/nodejs/node/pull/41373#ref-commit-bc626c2
https://github.com/kyranet
https://github.com/Linkgoron
v8: make writeHeapSnapshot throw if fopen failshttps://github.com/Linkgoron/node/commit/bc626c237be17352a12ca2ca0ad194c70fe613a0
bc626c2https://github.com/Linkgoron/node/commit/bc626c237be17352a12ca2ca0ad194c70fe613a0
nodejs#41346https://github.com/nodejs/node/issues/41346
nodejs#41373https://github.com/nodejs/node/pull/41373
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Feb 1, 2022 https://github.com/nodejs/node/pull/41373#ref-pullrequest-1118571236
test: fix failure in test/sequential/test-heapdump.js #41772 https://github.com/nodejs/node/pull/41772
https://github.com/BethGriggs
BethGriggshttps://github.com/BethGriggs
Mar 9, 2022 https://github.com/nodejs/node/pull/41373#ref-pullrequest-1163413250
2022-04-19, Version 18.0.0 (Current) #42262 https://github.com/nodejs/node/pull/42262
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Apr 2, 2022 https://github.com/nodejs/node/pull/41373#ref-pullrequest-1190646194
v8: make v8.writeHeapSnapshot() error codes consistent #42577 https://github.com/nodejs/node/pull/42577
BethGriggshttps://github.com/BethGriggs
Apr 18, 2022 https://github.com/nodejs/node/pull/41373#ref-commit-49a77a5
https://github.com/BethGriggs
2022-04-19, Version 18.0.0 (Current)https://github.com/nodejs/node/commit/49a77a5a996a49e8cb728eed42e55a7c1a9eef6e
49a77a5https://github.com/nodejs/node/commit/49a77a5a996a49e8cb728eed42e55a7c1a9eef6e
#42607https://github.com/nodejs/node/pull/42607
#41431https://github.com/nodejs/node/pull/41431
#41896https://github.com/nodejs/node/pull/41896
#40773https://github.com/nodejs/node/pull/40773
#41479https://github.com/nodejs/node/pull/41479
https://undici.nodejs.org/#/https://undici.nodejs.org/#/
#41811https://github.com/nodejs/node/pull/41811
#41263https://github.com/nodejs/node/pull/41263
#42325https://github.com/nodejs/node/pull/42325
#42292https://github.com/nodejs/node/pull/42292
#42604https://github.com/nodejs/node/pull/42604
#42659https://github.com/nodejs/node/pull/42659
#42105https://github.com/nodejs/node/pull/42105
#42666https://github.com/nodejs/node/pull/42666
#42657https://github.com/nodejs/node/pull/42657
#39062https://github.com/nodejs/node/pull/39062
#42225https://github.com/nodejs/node/pull/42225
#41270https://github.com/nodejs/node/pull/41270
#41305https://github.com/nodejs/node/pull/41305
#42718https://github.com/nodejs/node/pull/42718
#42163https://github.com/nodejs/node/pull/42163
#41431https://github.com/nodejs/node/pull/41431
#41271https://github.com/nodejs/node/pull/41271
#41271https://github.com/nodejs/node/pull/41271
#41020https://github.com/nodejs/node/pull/41020
#38545https://github.com/nodejs/node/pull/38545
#41270https://github.com/nodejs/node/pull/41270
#41270https://github.com/nodejs/node/pull/41270
#42666https://github.com/nodejs/node/pull/42666
#42292https://github.com/nodejs/node/pull/42292
#42105https://github.com/nodejs/node/pull/42105
#41305https://github.com/nodejs/node/pull/41305
#34312https://github.com/nodejs/node/pull/34312
#39841https://github.com/nodejs/node/pull/39841
#42123https://github.com/nodejs/node/pull/42123
#42124https://github.com/nodejs/node/pull/42124
#42002https://github.com/nodejs/node/pull/42002
#41600https://github.com/nodejs/node/pull/41600
#42657https://github.com/nodejs/node/pull/42657
#42657https://github.com/nodejs/node/pull/42657
#41610https://github.com/nodejs/node/pull/41610
#40907https://github.com/nodejs/node/pull/40907
#41431https://github.com/nodejs/node/pull/41431
#42659https://github.com/nodejs/node/pull/42659
#42604https://github.com/nodejs/node/pull/42604
#42607https://github.com/nodejs/node/pull/42607
#41263https://github.com/nodejs/node/pull/41263
#42163https://github.com/nodejs/node/pull/42163
#41811https://github.com/nodejs/node/pull/41811
#41678https://github.com/nodejs/node/pull/41678
#42325https://github.com/nodejs/node/pull/42325
#41431https://github.com/nodejs/node/pull/41431
#28006https://github.com/nodejs/node/pull/28006
#41896https://github.com/nodejs/node/pull/41896
#42464https://github.com/nodejs/node/pull/42464
#40773https://github.com/nodejs/node/pull/40773
#42225https://github.com/nodejs/node/pull/42225
#41954https://github.com/nodejs/node/pull/41954
#41933https://github.com/nodejs/node/pull/41933
#41766https://github.com/nodejs/node/pull/41766
#40852https://github.com/nodejs/node/pull/40852
#40696https://github.com/nodejs/node/pull/40696
#42325https://github.com/nodejs/node/pull/42325
#37408https://github.com/nodejs/node/pull/37408
#41561https://github.com/nodejs/node/pull/41561
#41479https://github.com/nodejs/node/pull/41479
#42313https://github.com/nodejs/node/pull/42313
#42577https://github.com/nodejs/node/pull/42577
#41373https://github.com/nodejs/node/pull/41373
#41271https://github.com/nodejs/node/pull/41271
#41271https://github.com/nodejs/node/pull/41271
#42262https://github.com/nodejs/node/pull/42262
BethGriggshttps://github.com/BethGriggs
Apr 19, 2022 https://github.com/nodejs/node/pull/41373#ref-commit-77373aa
https://github.com/BethGriggs
2022-04-19, Version 18.0.0 (Current)https://github.com/nodejs/node/commit/77373aa5d69a64f4bd9842163043dce260c30c49
77373aahttps://github.com/nodejs/node/commit/77373aa5d69a64f4bd9842163043dce260c30c49
#42607https://github.com/nodejs/node/pull/42607
#41431https://github.com/nodejs/node/pull/41431
#41896https://github.com/nodejs/node/pull/41896
#40773https://github.com/nodejs/node/pull/40773
#41479https://github.com/nodejs/node/pull/41479
https://undici.nodejs.org/#/https://undici.nodejs.org/#/
#41811https://github.com/nodejs/node/pull/41811
#41263https://github.com/nodejs/node/pull/41263
#42325https://github.com/nodejs/node/pull/42325
#42292https://github.com/nodejs/node/pull/42292
#42604https://github.com/nodejs/node/pull/42604
#42659https://github.com/nodejs/node/pull/42659
#42105https://github.com/nodejs/node/pull/42105
#42666https://github.com/nodejs/node/pull/42666
#42657https://github.com/nodejs/node/pull/42657
#39062https://github.com/nodejs/node/pull/39062
#42225https://github.com/nodejs/node/pull/42225
#41270https://github.com/nodejs/node/pull/41270
#41305https://github.com/nodejs/node/pull/41305
#42718https://github.com/nodejs/node/pull/42718
#42163https://github.com/nodejs/node/pull/42163
#41431https://github.com/nodejs/node/pull/41431
#41271https://github.com/nodejs/node/pull/41271
#41271https://github.com/nodejs/node/pull/41271
#41020https://github.com/nodejs/node/pull/41020
#38545https://github.com/nodejs/node/pull/38545
#41270https://github.com/nodejs/node/pull/41270
#41270https://github.com/nodejs/node/pull/41270
#42666https://github.com/nodejs/node/pull/42666
#42292https://github.com/nodejs/node/pull/42292
#42105https://github.com/nodejs/node/pull/42105
#41305https://github.com/nodejs/node/pull/41305
#34312https://github.com/nodejs/node/pull/34312
#39841https://github.com/nodejs/node/pull/39841
#42123https://github.com/nodejs/node/pull/42123
#42124https://github.com/nodejs/node/pull/42124
#42002https://github.com/nodejs/node/pull/42002
#41600https://github.com/nodejs/node/pull/41600
#42657https://github.com/nodejs/node/pull/42657
#42657https://github.com/nodejs/node/pull/42657
#41610https://github.com/nodejs/node/pull/41610
#40907https://github.com/nodejs/node/pull/40907
#41431https://github.com/nodejs/node/pull/41431
#42659https://github.com/nodejs/node/pull/42659
#42604https://github.com/nodejs/node/pull/42604
#42607https://github.com/nodejs/node/pull/42607
#41263https://github.com/nodejs/node/pull/41263
#42163https://github.com/nodejs/node/pull/42163
#41811https://github.com/nodejs/node/pull/41811
#41678https://github.com/nodejs/node/pull/41678
#42325https://github.com/nodejs/node/pull/42325
#41431https://github.com/nodejs/node/pull/41431
#28006https://github.com/nodejs/node/pull/28006
#41896https://github.com/nodejs/node/pull/41896
#42464https://github.com/nodejs/node/pull/42464
#40773https://github.com/nodejs/node/pull/40773
#42225https://github.com/nodejs/node/pull/42225
#41954https://github.com/nodejs/node/pull/41954
#41933https://github.com/nodejs/node/pull/41933
#41766https://github.com/nodejs/node/pull/41766
#40852https://github.com/nodejs/node/pull/40852
#40696https://github.com/nodejs/node/pull/40696
#42325https://github.com/nodejs/node/pull/42325
#37408https://github.com/nodejs/node/pull/37408
#41561https://github.com/nodejs/node/pull/41561
#41479https://github.com/nodejs/node/pull/41479
#42313https://github.com/nodejs/node/pull/42313
#42577https://github.com/nodejs/node/pull/42577
#41373https://github.com/nodejs/node/pull/41373
#41271https://github.com/nodejs/node/pull/41271
#41271https://github.com/nodejs/node/pull/41271
#42262https://github.com/nodejs/node/pull/42262
xtx1130https://github.com/xtx1130
Apr 25, 2022 https://github.com/nodejs/node/pull/41373#ref-commit-8d97f65
https://github.com/BethGriggs
https://github.com/xtx1130
2022-04-19, Version 18.0.0 (Current)https://github.com/xtx1130/node/commit/8d97f65f72e41390be5c199559f24ade38e76947
8d97f65https://github.com/xtx1130/node/commit/8d97f65f72e41390be5c199559f24ade38e76947
nodejs#42607https://github.com/nodejs/node/pull/42607
nodejs#41431https://github.com/nodejs/node/pull/41431
nodejs#41896https://github.com/nodejs/node/pull/41896
nodejs#40773https://github.com/nodejs/node/pull/40773
nodejs#41479https://github.com/nodejs/node/pull/41479
https://undici.nodejs.org/#/https://undici.nodejs.org/#/
nodejs#41811https://github.com/nodejs/node/pull/41811
nodejs#41263https://github.com/nodejs/node/pull/41263
nodejs#42325https://github.com/nodejs/node/pull/42325
nodejs#42292https://github.com/nodejs/node/pull/42292
nodejs#42604https://github.com/nodejs/node/pull/42604
nodejs#42659https://github.com/nodejs/node/pull/42659
nodejs#42105https://github.com/nodejs/node/pull/42105
nodejs#42666https://github.com/nodejs/node/pull/42666
nodejs#42657https://github.com/nodejs/node/pull/42657
nodejs#39062https://github.com/nodejs/node/pull/39062
nodejs#42225https://github.com/nodejs/node/pull/42225
nodejs#41270https://github.com/nodejs/node/pull/41270
nodejs#41305https://github.com/nodejs/node/pull/41305
nodejs#42718https://github.com/nodejs/node/pull/42718
nodejs#42163https://github.com/nodejs/node/pull/42163
nodejs#41431https://github.com/nodejs/node/pull/41431
nodejs#41271https://github.com/nodejs/node/pull/41271
nodejs#41271https://github.com/nodejs/node/pull/41271
nodejs#41020https://github.com/nodejs/node/pull/41020
nodejs#38545https://github.com/nodejs/node/pull/38545
nodejs#41270https://github.com/nodejs/node/pull/41270
nodejs#41270https://github.com/nodejs/node/pull/41270
nodejs#42666https://github.com/nodejs/node/pull/42666
nodejs#42292https://github.com/nodejs/node/pull/42292
nodejs#42105https://github.com/nodejs/node/pull/42105
nodejs#41305https://github.com/nodejs/node/pull/41305
nodejs#34312https://github.com/nodejs/node/pull/34312
nodejs#39841https://github.com/nodejs/node/pull/39841
nodejs#42123https://github.com/nodejs/node/pull/42123
nodejs#42124https://github.com/nodejs/node/pull/42124
nodejs#42002https://github.com/nodejs/node/pull/42002
nodejs#41600https://github.com/nodejs/node/pull/41600
nodejs#42657https://github.com/nodejs/node/pull/42657
nodejs#42657https://github.com/nodejs/node/pull/42657
nodejs#41610https://github.com/nodejs/node/pull/41610
nodejs#40907https://github.com/nodejs/node/pull/40907
nodejs#41431https://github.com/nodejs/node/pull/41431
nodejs#42659https://github.com/nodejs/node/pull/42659
nodejs#42604https://github.com/nodejs/node/pull/42604
nodejs#42607https://github.com/nodejs/node/pull/42607
nodejs#41263https://github.com/nodejs/node/pull/41263
nodejs#42163https://github.com/nodejs/node/pull/42163
nodejs#41811https://github.com/nodejs/node/pull/41811
nodejs#41678https://github.com/nodejs/node/pull/41678
nodejs#42325https://github.com/nodejs/node/pull/42325
nodejs#41431https://github.com/nodejs/node/pull/41431
nodejs#28006https://github.com/nodejs/node/pull/28006
nodejs#41896https://github.com/nodejs/node/pull/41896
nodejs#42464https://github.com/nodejs/node/pull/42464
nodejs#40773https://github.com/nodejs/node/pull/40773
nodejs#42225https://github.com/nodejs/node/pull/42225
nodejs#41954https://github.com/nodejs/node/pull/41954
nodejs#41933https://github.com/nodejs/node/pull/41933
nodejs#41766https://github.com/nodejs/node/pull/41766
nodejs#40852https://github.com/nodejs/node/pull/40852
nodejs#40696https://github.com/nodejs/node/pull/40696
nodejs#42325https://github.com/nodejs/node/pull/42325
nodejs#37408https://github.com/nodejs/node/pull/37408
nodejs#41561https://github.com/nodejs/node/pull/41561
nodejs#41479https://github.com/nodejs/node/pull/41479
nodejs#42313https://github.com/nodejs/node/pull/42313
nodejs#42577https://github.com/nodejs/node/pull/42577
nodejs#41373https://github.com/nodejs/node/pull/41373
nodejs#41271https://github.com/nodejs/node/pull/41271
nodejs#41271https://github.com/nodejs/node/pull/41271
nodejs#42262https://github.com/nodejs/node/pull/42262
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41373
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/41373/files/a6944414b24472cd1a18de85294170d8ff0b5033
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/41373/files/a6944414b24472cd1a18de85294170d8ff0b5033
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/41373/files/c954247354fa701c0c6c92ffe525bbe43cd07cc0
https://github.com/VoltrexKeyva
VoltrexKeyva https://github.com/VoltrexKeyva
https://github.com/nodejs/node/pull/41373/files/a6944414b24472cd1a18de85294170d8ff0b5033
https://github.com/faresalalimi
faresalalimi https://github.com/faresalalimi
https://github.com/nodejs/node/pull/41373/files/a6944414b24472cd1a18de85294170d8ff0b5033
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
v8.writeHeapSnapshot may return undefined if the file fails to write https://github.com/nodejs/node/issues/41346
Please reload this pagehttps://github.com/nodejs/node/pull/41373
https://github.com/kyranet
https://github.com/nodejs-github-bot
https://github.com/Ayase-252
https://github.com/addaleax
https://github.com/cjihrig
https://github.com/RaisinTen
https://github.com/VoltrexKeyva
https://github.com/faresalalimi
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.