René's URL Explorer Experiment


Title: doc,v8: clarify `v8.writeHeapSnapshot` may return `undefined` by kyranet · Pull Request #41365 · nodejs/node · GitHub

Open Graph Title: doc,v8: clarify `v8.writeHeapSnapshot` may return `undefined` by kyranet · Pull Request #41365 · nodejs/node

X Title: doc,v8: clarify `v8.writeHeapSnapshot` may return `undefined` by kyranet · Pull Request #41365 · nodejs/node

Description: Fixes: #41346 Or at least, it's one of the possible approaches. There are two we can do: Keep current behavior, document as undefined. Throw an exception and document as such. v8.writeHeapSnapsho...

Open Graph Description: Fixes: #41346 Or at least, it's one of the possible approaches. There are two we can do: Keep current behavior, document as undefined. Throw an exception and document as such. v8.writeHeapSna...

X Description: Fixes: #41346 Or at least, it's one of the possible approaches. There are two we can do: Keep current behavior, document as undefined. Throw an exception and document as such. v8.writeHea...

Opengraph URL: https://github.com/nodejs/node/pull/41365

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9107bb04-782a-093e-d387-b30321b2fec8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC97C:1B1D69:19D488B:239A795:696AA5F3
html-safe-nonce38004e0fe5669317bbdbe5ecc8fd28032a06e477dee66c35a6bd2141397e039b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTdDOjFCMUQ2OToxOUQ0ODhCOjIzOUE3OTU6Njk2QUE1RjMiLCJ2aXNpdG9yX2lkIjoiOTk0MzEzMDAyNjk4ODQzNjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5c7440872b295bc88f7f3bc3fb70375944002bfc0fc52aa39b813d8feef9a676
hovercard-subject-tagpull_request:812316412
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41365/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bba9b1f9afb76ae88c75433919d7d7a60f1f883b05626a919505cca80f7d58c7/nodejs/node/pull/41365
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bba9b1f9afb76ae88c75433919d7d7a60f1f883b05626a919505cca80f7d58c7/nodejs/node/pull/41365
og:image:altFixes: #41346 Or at least, it's one of the possible approaches. There are two we can do: Keep current behavior, document as undefined. Throw an exception and document as such. v8.writeHeapSna...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekyranet
hostnamegithub.com
expected-hostnamegithub.com
Nonea51f97dbb9326f71c08ecb61577457d543c602124d1a2672871258ef37ac5261
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4bd0eac606c70914085176ef312ebdcd97a8cdf1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/41365#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41365
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41365
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/41365
Reloadhttps://github.com/nodejs/node/pull/41365
Reloadhttps://github.com/nodejs/node/pull/41365
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/41365
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/41365
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/41365#issue-comment-box
kyranethttps://github.com/kyranet
nodejs:masterhttps://github.com/nodejs/node/tree/master
kyranet:doc-v8/write-heap-snapshot-may-return-undefinedhttps://github.com/kyranet/node/tree/doc-v8/write-heap-snapshot-may-return-undefined
doc,v8: clarify v8.writeHeapSnapshot may return undefined https://github.com/nodejs/node/pull/41365#top
kyranethttps://github.com/kyranet
nodejs:masterhttps://github.com/nodejs/node/tree/master
kyranet:doc-v8/write-heap-snapshot-may-return-undefinedhttps://github.com/kyranet/node/tree/doc-v8/write-heap-snapshot-may-return-undefined
Conversation 7 https://github.com/nodejs/node/pull/41365
Commits 1 https://github.com/nodejs/node/pull/41365/commits
Checks 0 https://github.com/nodejs/node/pull/41365/checks
Files changed https://github.com/nodejs/node/pull/41365/files
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/kyranet
kyranethttps://github.com/kyranet
Dec 31, 2021https://github.com/nodejs/node/pull/41365#issue-1091506846
Please reload this pagehttps://github.com/nodejs/node/pull/41365
#41346https://github.com/nodejs/node/issues/41346
node/src/heap_utils.cchttps://github.com/nodejs/node/blob/0de6a6341a566f990d0058b28a0a3cb5b052c6b3/src/heap_utils.cc#L369-L390
0de6a63https://github.com/nodejs/node/commit/0de6a6341a566f990d0058b28a0a3cb5b052c6b3
https://github.com/bnoordhuis/node-heapdump/blob/3537b67cebdbd602d8572fcc533f223ed25e5cbc/src/heapdump.cc#L93-L96https://github.com/bnoordhuis/node-heapdump/blob/3537b67cebdbd602d8572fcc533f223ed25e5cbc/src/heapdump.cc#L93-L96
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/2aae4db6bbe2e078c0cbc84cc9cd43cb1e01d8fd/types/node/v14/test/v8.ts#L13https://github.com/DefinitelyTyped/DefinitelyTyped/blob/2aae4db6bbe2e078c0cbc84cc9cd43cb1e01d8fd/types/node/v14/test/v8.ts#L13
@RaisinTenhttps://github.com/RaisinTen
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/kyranet
doc,v8: clarify v8.writeHeapSnapshot may return undefinedhttps://github.com/nodejs/node/pull/41365/commits/2bdbaf6c1d27cf23bccb6a62b5b736e3ed13e381
2bdbaf6https://github.com/nodejs/node/pull/41365/commits/2bdbaf6c1d27cf23bccb6a62b5b736e3ed13e381
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
Dec 31, 2021https://github.com/nodejs/node/pull/41365#event-5830173602
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 31, 2021 https://github.com/nodejs/node/pull/41365#pullrequestreview-842237328
View reviewed changes https://github.com/nodejs/node/pull/41365/files/2bdbaf6c1d27cf23bccb6a62b5b736e3ed13e381
RaisinTenhttps://github.com/RaisinTen
https://github.com/nodejs/node/pull/41365#pullrequestreview-842237328
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/lib/v8.jshttps://github.com/nodejs/node/blob/0de6a6341a566f990d0058b28a0a3cb5b052c6b3/lib/v8.js#L66
0de6a63https://github.com/nodejs/node/commit/0de6a6341a566f990d0058b28a0a3cb5b052c6b3
https://github.com/nodejs/node/blob/HEAD/test/sequential/test-heapdump.jshttps://github.com/nodejs/node/blob/HEAD/test/sequential/test-heapdump.js
Please reload this pagehttps://github.com/nodejs/node/pull/41365
doc/api/v8.mdhttps://github.com/nodejs/node/pull/41365/files/2bdbaf6c1d27cf23bccb6a62b5b736e3ed13e381#diff-fc79b2d1ad702cfaf107d5880b73e8360b36273edda73f128c00641637435c3c
RaisinTenhttps://github.com/RaisinTen
Dec 31, 2021https://github.com/nodejs/node/pull/41365#discussion_r776992143
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 31, 2021https://github.com/nodejs/node/pull/41365#issuecomment-1003380365
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/kyranet
kyranethttps://github.com/kyranet
Dec 31, 2021https://github.com/nodejs/node/pull/41365#issuecomment-1003390992
Please reload this pagehttps://github.com/nodejs/node/pull/41365
#41346 (comment)https://github.com/nodejs/node/issues/41346#issuecomment-1003042797
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jan 1, 2022https://github.com/nodejs/node/pull/41365#issuecomment-1003556568
node/src/heap_utils.cchttps://github.com/nodejs/node/blob/d0c11765331edc457a3f5023c21cbe3f89fa6d17/src/heap_utils.cc#L319-L327
d0c1176https://github.com/nodejs/node/commit/d0c11765331edc457a3f5023c21cbe3f89fa6d17
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/kyranet
kyranethttps://github.com/kyranet
Jan 1, 2022 https://github.com/nodejs/node/pull/41365#ref-pullrequest-1091913013
fix,v8: make v8.writeHeapSnapshot throw if fopen/fclose fail #41373 https://github.com/nodejs/node/pull/41373
https://github.com/kyranet
kyranethttps://github.com/kyranet
Jan 1, 2022https://github.com/nodejs/node/pull/41365#issuecomment-1003637636
@RaisinTenhttps://github.com/RaisinTen
#41373https://github.com/nodejs/node/pull/41373
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jan 12, 2022https://github.com/nodejs/node/pull/41365#issuecomment-1011166492
#41373https://github.com/nodejs/node/pull/41373
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Jan 12, 2022https://github.com/nodejs/node/pull/41365#event-5881155864
https://github.com/kyranet
kyranethttps://github.com/kyranet
January 12, 2022 18:56https://github.com/nodejs/node/pull/41365#event-5882376866
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41365
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/41365/files/2bdbaf6c1d27cf23bccb6a62b5b736e3ed13e381
doc https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc
v8.writeHeapSnapshot may return undefined if the file fails to write https://github.com/nodejs/node/issues/41346
Please reload this pagehttps://github.com/nodejs/node/pull/41365
https://github.com/kyranet
https://github.com/addaleax
https://github.com/RaisinTen
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.