René's URL Explorer Experiment


Title: src: improve MakeCallback() performance by addaleax · Pull Request #41331 · nodejs/node · GitHub

Open Graph Title: src: improve MakeCallback() performance by addaleax · Pull Request #41331 · nodejs/node

X Title: src: improve MakeCallback() performance by addaleax · Pull Request #41331 · nodejs/node

Description: Opening this as a better alternative to #41279. I could have sworn that there was a MakeCallback() benchmark, but I am unable to find it. Local manual benchmarking gives a 16% boost for MakeCallbac...

Open Graph Description: Opening this as a better alternative to #41279. I could have sworn that there was a MakeCallback() benchmark, but I am unable to find it. Local manual benchmarking gives a 16% boost for MakeCallbac...

X Description: Opening this as a better alternative to #41279. I could have sworn that there was a MakeCallback() benchmark, but I am unable to find it. Local manual benchmarking gives a 16% boost for MakeCallbac...

Opengraph URL: https://github.com/nodejs/node/pull/41331

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:595637df-0eac-d874-4fb8-0c4e90ba6cd7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9872:367724:150BC6:1AE2D7:696B3613
html-safe-nonceb4261270af939b277602ba2f59ca5b34c2b128902de4b0115ae0840b503ed930
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODcyOjM2NzcyNDoxNTBCQzY6MUFFMkQ3OjY5NkIzNjEzIiwidmlzaXRvcl9pZCI6IjI4NTkwMDc0MzQ0NzE1Nzk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac439f8f52a4be80ac4336d5b6ee0fcccce5112173d44f22dc26f4eb8e3026659f
hovercard-subject-tagpull_request:810064433
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/41331/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b4d4a97b015bc2d6a93a4a72f35ed7917ab6edbb1a19744fcc7cd08c9952dffa/nodejs/node/pull/41331
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b4d4a97b015bc2d6a93a4a72f35ed7917ab6edbb1a19744fcc7cd08c9952dffa/nodejs/node/pull/41331
og:image:altOpening this as a better alternative to #41279. I could have sworn that there was a MakeCallback() benchmark, but I am unable to find it. Local manual benchmarking gives a 16% boost for MakeCallbac...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/41331#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/41331
Reloadhttps://github.com/nodejs/node/pull/41331
Reloadhttps://github.com/nodejs/node/pull/41331
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/41331
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 691 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/41331
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/41331#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:41279-responsehttps://github.com/addaleax/node/tree/41279-response
src: improve MakeCallback() performance https://github.com/nodejs/node/pull/41331#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:41279-responsehttps://github.com/addaleax/node/tree/41279-response
Conversation 35 https://github.com/nodejs/node/pull/41331
Commits 6 https://github.com/nodejs/node/pull/41331/commits
Checks 0 https://github.com/nodejs/node/pull/41331/checks
Files changed 4 https://github.com/nodejs/node/pull/41331/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 26, 2021https://github.com/nodejs/node/pull/41331#issue-1088835000
#41279https://github.com/nodejs/node/pull/41279
Please reload this pagehttps://github.com/nodejs/node/pull/41331
addaleaxhttps://github.com/addaleax
December 26, 2021 20:28https://github.com/nodejs/node/pull/41331#commits-pushed-bb0bd36
https://github.com/addaleax
src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/nodejs/node/pull/41331/commits/bb0bd36b6bc8d26122cb11a48cbadf6f1b982a13
bb0bd36https://github.com/nodejs/node/pull/41331/commits/bb0bd36b6bc8d26122cb11a48cbadf6f1b982a13
https://github.com/addaleax
src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/pull/41331/commits/f97d04eca40eaf0a47e24da0b995409c20880554
f97d04ehttps://github.com/nodejs/node/pull/41331/commits/f97d04eca40eaf0a47e24da0b995409c20880554
https://github.com/addaleax
src: split out async stack corruption detection from inline fnhttps://github.com/nodejs/node/pull/41331/commits/853853fc7c5aeae20654b758d3a874ce981ea11f
853853fhttps://github.com/nodejs/node/pull/41331/commits/853853fc7c5aeae20654b758d3a874ce981ea11f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Dec 26, 2021https://github.com/nodejs/node/pull/41331#event-5815876647
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 26, 2021https://github.com/nodejs/node/pull/41331#event-5815876991
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 26, 2021 https://github.com/nodejs/node/pull/41331#ref-pullrequest-1086576666
src: skip costly pushing/popping if we pass zeroes as async context #41279 https://github.com/nodejs/node/pull/41279
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 26, 2021 https://github.com/nodejs/node/pull/41331#pullrequestreview-840109123
View reviewed changes https://github.com/nodejs/node/pull/41331/files/853853fc7c5aeae20654b758d3a874ce981ea11f
src/env.cchttps://github.com/nodejs/node/pull/41331/files/853853fc7c5aeae20654b758d3a874ce981ea11f#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
addaleaxhttps://github.com/addaleax
Dec 26, 2021https://github.com/nodejs/node/pull/41331#discussion_r775279985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 26, 2021https://github.com/nodejs/node/pull/41331#event-5815879858
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 26, 2021https://github.com/nodejs/node/pull/41331#event-5815895535
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Dec 26, 2021 https://github.com/nodejs/node/pull/41331#pullrequestreview-840113986
View reviewed changes https://github.com/nodejs/node/pull/41331/files/853853fc7c5aeae20654b758d3a874ce981ea11f
src/env-inl.hhttps://github.com/nodejs/node/pull/41331/files/853853fc7c5aeae20654b758d3a874ce981ea11f#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
Please reload this pagehttps://github.com/nodejs/node/pull/41331
src/api/callback.cchttps://github.com/nodejs/node/pull/41331/files/853853fc7c5aeae20654b758d3a874ce981ea11f#diff-6f5066579791abb5154463a462bf370248ebb2bc501b85960caf8d4d8645526d
Please reload this pagehttps://github.com/nodejs/node/pull/41331
addaleaxhttps://github.com/addaleax
December 26, 2021 23:34https://github.com/nodejs/node/pull/41331#commits-pushed-b98e4bd
https://github.com/addaleax
fixup! src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/nodejs/node/pull/41331/commits/b98e4bd20d2f7d412bf61fae4b005a35bd710a06
b98e4bdhttps://github.com/nodejs/node/pull/41331/commits/b98e4bd20d2f7d412bf61fae4b005a35bd710a06
https://github.com/addaleax
fixup! src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/pull/41331/commits/069373eada54b8f168c50089d94f73f9cf0a66e3
069373ehttps://github.com/nodejs/node/pull/41331/commits/069373eada54b8f168c50089d94f73f9cf0a66e3
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 26, 2021https://github.com/nodejs/node/pull/41331#event-5815981541
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 26, 2021https://github.com/nodejs/node/pull/41331#event-5815983914
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
https://github.com/RaisinTen
RaisinTenhttps://github.com/RaisinTen
Dec 28, 2021 https://github.com/nodejs/node/pull/41331#pullrequestreview-840908446
View reviewed changes https://github.com/nodejs/node/pull/41331/files/069373eada54b8f168c50089d94f73f9cf0a66e3
src/env.hhttps://github.com/nodejs/node/pull/41331/files/069373eada54b8f168c50089d94f73f9cf0a66e3#diff-9eafb215360b21494c0aedebe24a2f319b68a1158f9803557251946824175854
Please reload this pagehttps://github.com/nodejs/node/pull/41331
src/env-inl.hhttps://github.com/nodejs/node/pull/41331/files/069373eada54b8f168c50089d94f73f9cf0a66e3#diff-a1a4dc1d535a4c36d255573ddb470b0291de15e9cc66667680190af1d01b1bd4
Please reload this pagehttps://github.com/nodejs/node/pull/41331
src/env.cchttps://github.com/nodejs/node/pull/41331/files/069373eada54b8f168c50089d94f73f9cf0a66e3#diff-c546570c652a65d182b5c452e071328cdc3599e39b4bc390879b5c15dd545d58
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Dec 28, 2021 https://github.com/nodejs/node/pull/41331#pullrequestreview-841008191
View reviewed changes https://github.com/nodejs/node/pull/41331/files/069373eada54b8f168c50089d94f73f9cf0a66e3
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Dec 28, 2021https://github.com/nodejs/node/pull/41331#issuecomment-1002203002
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/addaleax
fixup! src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/pull/41331/commits/a7787bbcabeeb8b63889c7baffdabb208ace999e
a7787bbhttps://github.com/nodejs/node/pull/41331/commits/a7787bbcabeeb8b63889c7baffdabb208ace999e
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
commit-queue-rebase https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 28, 2021https://github.com/nodejs/node/pull/41331#event-5822189252
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Dec 28, 2021https://github.com/nodejs/node/pull/41331#issuecomment-1002217595
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Dec 28, 2021https://github.com/nodejs/node/pull/41331#event-5822208548
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jan 1, 2022https://github.com/nodejs/node/pull/41331#event-5831925741
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 1, 2022https://github.com/nodejs/node/pull/41331#issuecomment-1003598672
5f07d00...a4795adhttps://github.com/nodejs/node/compare/5f07d00c60729d6b73b7f468d3094331c8708950...a4795ada8b0c725cafc6f5e0ffbc864cd09b9db7
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 1, 2022https://github.com/nodejs/node/pull/41331#event-5831925845
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 1, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-6932fb8
https://github.com/addaleax
https://github.com/nodejs-github-bot
src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/nodejs/node/commit/6932fb8bac3a4caf3f3fabee0a595a077f477f63
6932fb8https://github.com/nodejs/node/commit/6932fb8bac3a4caf3f3fabee0a595a077f477f63
#41331https://github.com/nodejs/node/pull/41331
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 1, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-69ea677
https://github.com/addaleax
https://github.com/nodejs-github-bot
src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/commit/69ea6775f456ce33032f3c1de01b07260679a88c
69ea677https://github.com/nodejs/node/commit/69ea6775f456ce33032f3c1de01b07260679a88c
#41331https://github.com/nodejs/node/pull/41331
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 1, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-a4795ad
https://github.com/addaleax
https://github.com/nodejs-github-bot
src: split out async stack corruption detection from inline fnhttps://github.com/nodejs/node/commit/a4795ada8b0c725cafc6f5e0ffbc864cd09b9db7
a4795adhttps://github.com/nodejs/node/commit/a4795ada8b0c725cafc6f5e0ffbc864cd09b9db7
#41331https://github.com/nodejs/node/pull/41331
CI Reliability 2022-01-02 nodejs/reliability#163 https://github.com/nodejs/reliability/issues/163
CI Reliability 2022-01-03 nodejs/reliability#164 https://github.com/nodejs/reliability/issues/164
CI Reliability 2022-01-04 nodejs/reliability#165 https://github.com/nodejs/reliability/issues/165
CI Reliability 2022-01-05 nodejs/reliability#166 https://github.com/nodejs/reliability/issues/166
CI Reliability 2022-01-06 nodejs/reliability#167 https://github.com/nodejs/reliability/issues/167
CI Reliability 2022-01-07 nodejs/reliability#168 https://github.com/nodejs/reliability/issues/168
CI Reliability 2022-01-08 nodejs/reliability#169 https://github.com/nodejs/reliability/issues/169
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
January 9, 2022 19:26https://github.com/nodejs/node/pull/41331#event-5862673432
targoshttps://github.com/targos
Jan 14, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-6187e81
https://github.com/addaleax
https://github.com/targos
src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/nodejs/node/commit/6187e81a8ecb5ba784e985ff47c1cd3c055dae57
6187e81https://github.com/nodejs/node/commit/6187e81a8ecb5ba784e985ff47c1cd3c055dae57
#41331https://github.com/nodejs/node/pull/41331
targoshttps://github.com/targos
Jan 14, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-250e197
https://github.com/addaleax
https://github.com/targos
src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/commit/250e197a62e5f3c5438cfbe4f9d6e26fc8823817
250e197https://github.com/nodejs/node/commit/250e197a62e5f3c5438cfbe4f9d6e26fc8823817
#41331https://github.com/nodejs/node/pull/41331
targoshttps://github.com/targos
Jan 14, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-337ebfc
https://github.com/addaleax
https://github.com/targos
src: split out async stack corruption detection from inline fnhttps://github.com/nodejs/node/commit/337ebfcd537dc1400da7bfa1d132c134bd4d4ea0
337ebfchttps://github.com/nodejs/node/commit/337ebfcd537dc1400da7bfa1d132c134bd4d4ea0
#41331https://github.com/nodejs/node/pull/41331
https://github.com/targos
targoshttps://github.com/targos
Jan 16, 2022 https://github.com/nodejs/node/pull/41331#ref-pullrequest-1105064450
v17.4.0 release proposal #41557 https://github.com/nodejs/node/pull/41557
danielleadamshttps://github.com/danielleadams
Jan 31, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-f809625
https://github.com/addaleax
https://github.com/danielleadams
src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/nodejs/node/commit/f809625e8e8fa01a57ce968e124e3745aec81f23
f809625https://github.com/nodejs/node/commit/f809625e8e8fa01a57ce968e124e3745aec81f23
#41331https://github.com/nodejs/node/pull/41331
danielleadamshttps://github.com/danielleadams
Jan 31, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-40db8e5
https://github.com/addaleax
https://github.com/danielleadams
src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/commit/40db8e55a3ff925ea47b55e0850ff306109b3d2a
40db8e5https://github.com/nodejs/node/commit/40db8e55a3ff925ea47b55e0850ff306109b3d2a
#41331https://github.com/nodejs/node/pull/41331
danielleadamshttps://github.com/danielleadams
Jan 31, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-cd40686
https://github.com/addaleax
https://github.com/danielleadams
src: split out async stack corruption detection from inline fnhttps://github.com/nodejs/node/commit/cd40686edbdc69f81e2eb7b909efc458204eb830
cd40686https://github.com/nodejs/node/commit/cd40686edbdc69f81e2eb7b909efc458204eb830
#41331https://github.com/nodejs/node/pull/41331
Linkgoronhttps://github.com/Linkgoron
Jan 31, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-070d73d
https://github.com/addaleax
https://github.com/Linkgoron
src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/Linkgoron/node/commit/070d73dd198b5a93e8927be51c1c6d1b415703f4
070d73dhttps://github.com/Linkgoron/node/commit/070d73dd198b5a93e8927be51c1c6d1b415703f4
nodejs#41331https://github.com/nodejs/node/pull/41331
Linkgoronhttps://github.com/Linkgoron
Jan 31, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-f07bb11
https://github.com/addaleax
https://github.com/Linkgoron
src: store native async execution resources as v8::Localhttps://github.com/Linkgoron/node/commit/f07bb112f3cd19d9bbd3fd14a6db5eaf3022f03c
f07bb11https://github.com/Linkgoron/node/commit/f07bb112f3cd19d9bbd3fd14a6db5eaf3022f03c
nodejs#41331https://github.com/nodejs/node/pull/41331
Linkgoronhttps://github.com/Linkgoron
Jan 31, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-448ea3d
https://github.com/addaleax
https://github.com/Linkgoron
src: split out async stack corruption detection from inline fnhttps://github.com/Linkgoron/node/commit/448ea3d051423b0026b6502daa8d5589389d9daa
448ea3dhttps://github.com/Linkgoron/node/commit/448ea3d051423b0026b6502daa8d5589389d9daa
nodejs#41331https://github.com/nodejs/node/pull/41331
danielleadamshttps://github.com/danielleadams
Feb 1, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-59625f7
https://github.com/addaleax
https://github.com/danielleadams
src: guard slightly costly check in MakeCallback more stronglyhttps://github.com/nodejs/node/commit/59625f70adbee5f6f88182e6bb58913e7fd78ca1
59625f7https://github.com/nodejs/node/commit/59625f70adbee5f6f88182e6bb58913e7fd78ca1
#41331https://github.com/nodejs/node/pull/41331
danielleadamshttps://github.com/danielleadams
Feb 1, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-72921f4
https://github.com/addaleax
https://github.com/danielleadams
src: store native async execution resources as v8::Localhttps://github.com/nodejs/node/commit/72921f4b3158988bca5f6369586e54560563462f
72921f4https://github.com/nodejs/node/commit/72921f4b3158988bca5f6369586e54560563462f
#41331https://github.com/nodejs/node/pull/41331
danielleadamshttps://github.com/danielleadams
Feb 1, 2022 https://github.com/nodejs/node/pull/41331#ref-commit-fe4158a
https://github.com/addaleax
https://github.com/danielleadams
src: split out async stack corruption detection from inline fnhttps://github.com/nodejs/node/commit/fe4158aa4e4af45bb8ffecef8f142622c668a380
fe4158ahttps://github.com/nodejs/node/commit/fe4158aa4e4af45bb8ffecef8f142622c668a380
#41331https://github.com/nodejs/node/pull/41331
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Feb 1, 2022 https://github.com/nodejs/node/pull/41331#ref-pullrequest-1120258873
v16.14.0 proposal #41804 https://github.com/nodejs/node/pull/41804
https://github.com/e3dio
e3diohttps://github.com/e3dio
Feb 1, 2022https://github.com/nodejs/node/pull/41331#issuecomment-1026979611
https://user-images.githubusercontent.com/85405955/151994418-0f042365-beab-44cf-a9ed-6c94f41ea9d7.jpg
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/abenhamdine
abenhamdinehttps://github.com/abenhamdine
Dec 1, 2022 https://github.com/nodejs/node/pull/41331#ref-issue-1457032793
MakeCallback is very slow nodejs/performance#24 https://github.com/nodejs/performance/issues/24
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F41331
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/41331/files/069373eada54b8f168c50089d94f73f9cf0a66e3
https://github.com/Flarna
Flarna https://github.com/Flarna
https://github.com/nodejs/node/pull/41331/files/853853fc7c5aeae20654b758d3a874ce981ea11f
https://github.com/RaisinTen
RaisinTen https://github.com/RaisinTen
https://github.com/nodejs/node/pull/41331/files/a7787bbcabeeb8b63889c7baffdabb208ace999e
addons https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aaddons
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-rebase https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase
performance https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aperformance
Please reload this pagehttps://github.com/nodejs/node/pull/41331
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/tniessen
https://github.com/e3dio
https://github.com/Flarna
https://github.com/RaisinTen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.